)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a947e58ed581d09ad625f1607e93eb01f5ff826d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9dbd72c5_71f462d0","updated":"2022-10-17 15:15:52.000000000","message":"Interesting, it\u0027s failing on applying a DaemonSet. Had this patch actually raised installed K8s version?","commit_id":"0b568dd42db9d4b29e3b5a5cb9e517481e26567a"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"5bd7c9adcf01e65b20f82d74bd6b8527dca6e9c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0345f86_728caa62","in_reply_to":"9dbd72c5_71f462d0","updated":"2022-10-18 13:43:35.000000000","message":"No, it\u0027s only taking care of repos. DaemonSet issue was with empty path for the volume.","commit_id":"0b568dd42db9d4b29e3b5a5cb9e517481e26567a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8d90dfd01584b1e7c9a4ce6fbffb7688e31c937d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68280388_0d56c671","updated":"2022-10-19 07:49:22.000000000","message":"Nice! We can either remove the Docker gate or reconfigure it to use K8s 1.23. At this point I\u0027d prefer the latter and remove the thing in the future.","commit_id":"14125015b93a23dfceda8d6cb2ea55da8ec6afce"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"12f1aa7ec6d57afb0d79b3a37fd6eb9016d10d03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f82471cc_eef87d72","updated":"2022-10-18 19:40:30.000000000","message":"recheck","commit_id":"14125015b93a23dfceda8d6cb2ea55da8ec6afce"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f2e21da1414842552116a7a86ddf8ffda04fb063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e83674f0_c5e57c1c","in_reply_to":"68280388_0d56c671","updated":"2022-10-19 12:15:29.000000000","message":"Next patchset should fix it. I\u0027ll do the docker removal and then bumping kubernetes to 1.25 in subsequent patches.","commit_id":"14125015b93a23dfceda8d6cb2ea55da8ec6afce"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ac0f6adbca1f921a2d513e293e0ee4f2989eb940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df167ce1_7ab20abe","updated":"2022-10-19 14:15:58.000000000","message":"Should we have a commit bumping version to 1.25 as a dependent one first?","commit_id":"45d8b5fbad6b5b22e90302adc392ffaa1a540158"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8aafc2bbfc5798f2b3bcae37905cef8f0e5d6a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"20496739_4bde2e26","in_reply_to":"310dd2e6_9243fd9e","updated":"2022-10-19 14:41:14.000000000","message":"Alright, works for me.","commit_id":"45d8b5fbad6b5b22e90302adc392ffaa1a540158"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c666294dcd534dbf19956a69900abdba349e2dfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"310dd2e6_9243fd9e","in_reply_to":"df167ce1_7ab20abe","updated":"2022-10-19 14:30:54.000000000","message":"There is no need. Current k8s version has not been change, I\u0027ve planned to do so in subsequent patch right after we pin docker gate to 1.23.","commit_id":"45d8b5fbad6b5b22e90302adc392ffaa1a540158"}],"devstack/lib/kuryr_kubernetes":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a947e58ed581d09ad625f1607e93eb01f5ff826d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"KURYR_DUAL_STACK\u003d$(trueorfalse False KURYR_DUAL_STACK)"},{"line_number":18,"context_line":"KURYR_USE_LC\u003d$(trueorfalse False KURYR_CONTAINERS_USE_LOWER_CONSTRAINTS)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(gryf): Starting from version 1.24 of Kubernetes, kubelet will no longer"},{"line_number":21,"context_line":"# accepts --cni-bin-dir and --cni-conf-dir commandline options anymore."},{"line_number":22,"context_line":"# Moved those from settings as it\u0027s no longer subject for change."},{"line_number":23,"context_line":"CNI_PLUGIN_DIR\u003d/opt/cni/bin"},{"line_number":24,"context_line":"CNI_CONF_DIR\u003d/etc/cni/net.d"},{"line_number":25,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"dabaf2c7_0be9483d","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":65},"updated":"2022-10-17 15:15:52.000000000","message":"Way, I bet it\u0027s not hardcoded, just moved to crio?","commit_id":"0b568dd42db9d4b29e3b5a5cb9e517481e26567a"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"8afe07205de4d7f231fb2c34e02ed9631af2b258","unresolved":false,"context_lines":[{"line_number":17,"context_line":"KURYR_DUAL_STACK\u003d$(trueorfalse False KURYR_DUAL_STACK)"},{"line_number":18,"context_line":"KURYR_USE_LC\u003d$(trueorfalse False KURYR_CONTAINERS_USE_LOWER_CONSTRAINTS)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(gryf): Starting from version 1.24 of Kubernetes, kubelet will no longer"},{"line_number":21,"context_line":"# accepts --cni-bin-dir and --cni-conf-dir commandline options anymore."},{"line_number":22,"context_line":"# Moved those from settings as it\u0027s no longer subject for change."},{"line_number":23,"context_line":"CNI_PLUGIN_DIR\u003d/opt/cni/bin"},{"line_number":24,"context_line":"CNI_CONF_DIR\u003d/etc/cni/net.d"},{"line_number":25,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3097ad66_f356e77a","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":65},"in_reply_to":"030a2b2a_b9c44926","updated":"2022-10-19 12:15:41.000000000","message":"Done","commit_id":"0b568dd42db9d4b29e3b5a5cb9e517481e26567a"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"5bd7c9adcf01e65b20f82d74bd6b8527dca6e9c7","unresolved":true,"context_lines":[{"line_number":17,"context_line":"KURYR_DUAL_STACK\u003d$(trueorfalse False KURYR_DUAL_STACK)"},{"line_number":18,"context_line":"KURYR_USE_LC\u003d$(trueorfalse False KURYR_CONTAINERS_USE_LOWER_CONSTRAINTS)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(gryf): Starting from version 1.24 of Kubernetes, kubelet will no longer"},{"line_number":21,"context_line":"# accepts --cni-bin-dir and --cni-conf-dir commandline options anymore."},{"line_number":22,"context_line":"# Moved those from settings as it\u0027s no longer subject for change."},{"line_number":23,"context_line":"CNI_PLUGIN_DIR\u003d/opt/cni/bin"},{"line_number":24,"context_line":"CNI_CONF_DIR\u003d/etc/cni/net.d"},{"line_number":25,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"030a2b2a_b9c44926","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":65},"in_reply_to":"dabaf2c7_0be9483d","updated":"2022-10-18 13:43:35.000000000","message":"Actually no. It\u0027s only set in case CNI_PLUGIN_DIR and/or CNI_CONF_DIR are set. So having them here works by accident, since we source libs in devstack plugin. I\u0027ll reverted the change to have them back in settings.","commit_id":"0b568dd42db9d4b29e3b5a5cb9e517481e26567a"}]}