)]}'
{"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e6098e95f41796c9a99a9e69224ee654f393ea94","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        if port_id:"},{"line_number":161,"context_line":"            host_ip \u003d utils.get_parent_port_ip(port_id)"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            # Looks like the subport is gone already or this is not a nested"},{"line_number":164,"context_line":"            # case. We will supress errors from release_vif anyway, so it"},{"line_number":165,"context_line":"            # should be safe to pass None here."},{"line_number":166,"context_line":"            host_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"6bf00672_6d5b09a8","line":163,"updated":"2023-04-20 12:12:35.000000000","message":"I wonder if a check should be add here[1] to skip the getting trunk id and removal of subport? I think this would allow the release of the port and vlan. Or is the release_vif of base pool the one that handles it[2]?\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/drivers/nested_vlan_vif.py#L162\n[2] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/drivers/vif_pool.py#L318-L334","commit_id":"c197c722c827721de5cd16d5b1ce051e5fe5d751"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a033efef731915b8b9a6f6644467d922adaaa117","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        if port_id:"},{"line_number":161,"context_line":"            host_ip \u003d utils.get_parent_port_ip(port_id)"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            # Looks like the subport is gone already or this is not a nested"},{"line_number":164,"context_line":"            # case. We will supress errors from release_vif anyway, so it"},{"line_number":165,"context_line":"            # should be safe to pass None here."},{"line_number":166,"context_line":"            host_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"8e1b245e_01111473","line":163,"in_reply_to":"6bf00672_6d5b09a8","updated":"2023-04-21 12:14:49.000000000","message":"Makes sense, only that way we can release VLAN ID. I\u0027ll take a look.","commit_id":"c197c722c827721de5cd16d5b1ce051e5fe5d751"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dac6bfe0b2a6482d04d648f4640870eb0e353412","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        if port_id:"},{"line_number":161,"context_line":"            host_ip \u003d utils.get_parent_port_ip(port_id)"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            # Looks like the subport is gone already or this is not a nested"},{"line_number":164,"context_line":"            # case. We will supress errors from release_vif anyway, so it"},{"line_number":165,"context_line":"            # should be safe to pass None here."},{"line_number":166,"context_line":"            host_ip \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"b2bc27a1_02ec48da","line":163,"in_reply_to":"8e1b245e_01111473","updated":"2023-04-25 10:49:47.000000000","message":"Alright, I changed that completely to query for the node first instead of trying OpenStack APIs. And this way only works with nested, so we had this broken for non-nested case.","commit_id":"c197c722c827721de5cd16d5b1ce051e5fe5d751"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e6098e95f41796c9a99a9e69224ee654f393ea94","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            # Looks like the subport is gone already or this is not a nested"},{"line_number":164,"context_line":"            # case. We will supress errors from release_vif anyway, so it"},{"line_number":165,"context_line":"            # should be safe to pass None here."},{"line_number":166,"context_line":"            host_ip \u003d None"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        pod[\u0027status\u0027] \u003d {\u0027hostIP\u0027: host_ip}"},{"line_number":169,"context_line":"        return pod"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd82d1ee_2714762c","line":166,"updated":"2023-04-20 12:12:35.000000000","message":"Nit: should this be empty string instead?","commit_id":"c197c722c827721de5cd16d5b1ce051e5fe5d751"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a033efef731915b8b9a6f6644467d922adaaa117","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            # Looks like the subport is gone already or this is not a nested"},{"line_number":164,"context_line":"            # case. We will supress errors from release_vif anyway, so it"},{"line_number":165,"context_line":"            # should be safe to pass None here."},{"line_number":166,"context_line":"            host_ip \u003d None"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        pod[\u0027status\u0027] \u003d {\u0027hostIP\u0027: host_ip}"},{"line_number":169,"context_line":"        return pod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b6ebb3b_157a6a8b","line":166,"in_reply_to":"cd82d1ee_2714762c","updated":"2023-04-21 12:14:49.000000000","message":"It shouldn\u0027t really matter too much.","commit_id":"c197c722c827721de5cd16d5b1ce051e5fe5d751"}]}