)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"33b5d4a8eb29c27bb6d52e711561ee262fa99d17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d5f36ea_af4b82f4","updated":"2023-07-17 09:33:14.000000000","message":"Looks like you need to do it differently if it\u0027s supposed to work in the gate:\n\n\u003e Failed to enable unit: Interactive authentication required.\n\nI\u0027m guessing it\u0027s missing a `sudo`?\n\nIn general DevStack is not designed to survive reboots and we give no guarantees here. I\u0027m fine with merging this though.","commit_id":"5421c25365654052b72260c2b9d10a286111fe90"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"0131dcc0f65c2367f10c4263995af26282fe6ef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"470c178f_890e0c85","updated":"2023-07-17 11:43:53.000000000","message":"Thank you for your contribution!\n\nAlthough I believe, this patch should be done against devstack plugin container[1]. There is crio library which kuryr use. After installation it might be enabled by default, so that other projects could also benefit from your patch.\n\n[1] https://review.opendev.org/q/project:openstack%252Fdevstack-plugin-container","commit_id":"5421c25365654052b72260c2b9d10a286111fe90"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a92540f836951452f5ecbbfe57bb5a2cadc369a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75f8d3fc_0e965394","in_reply_to":"170f841f_504801f1","updated":"2023-07-18 15:15:15.000000000","message":"DevStack sole purpose is testing and development. It shouldn\u0027t be used to e.g. run a production cloud, so there shouldn\u0027t be a need to reboot the host DevStack runs on. If need be ./unstack.sh, ./clean.sh and ./stack.sh should be run again after the reboot.\n\nThat\u0027s just a disclaimer, I\u0027m not opposed to fixing this if it\u0027s as simple as one systemd call. Roman makes a good point though that this is installed in the devstack-plugin-container and should be placed there.","commit_id":"5421c25365654052b72260c2b9d10a286111fe90"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1764cbb21bbc30240d89881b243129df4ce3628b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c843b71a_62196da9","in_reply_to":"470c178f_890e0c85","updated":"2023-07-18 14:43:35.000000000","message":"Ah, I\u0027ve misunderstood that it\u0027s installed together with k8s packages. I\u0027d like to check it. Thanks.","commit_id":"5421c25365654052b72260c2b9d10a286111fe90"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1764cbb21bbc30240d89881b243129df4ce3628b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"170f841f_504801f1","in_reply_to":"6d5f36ea_af4b82f4","updated":"2023-07-18 14:43:35.000000000","message":"\u003e I\u0027m guessing it\u0027s missing a sudo?\nSure.\n\nI think rebooting devstack VM is still required for some usecases and useful if it\u0027s not guaranteed well. Thanks for the comment.","commit_id":"5421c25365654052b72260c2b9d10a286111fe90"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"05936ffe2b98063b298f5c41b645626d4090cde3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3f71a80_858fc1ed","in_reply_to":"c843b71a_62196da9","updated":"2023-07-21 09:06:30.000000000","message":"Well, it is, since whatever CRI is needed for k8s whether it is cri-dockerd, containerd or cri-o.\n\nHere[1] is the function which installs crio. Adding line which enable crio should go there. For ubuntu it will be right after line 59.\n\n[1] https://opendev.org/openstack/devstack-plugin-container/src/commit/f2fd4303cfbc89f43a3b90dcc74cc5e9289b5e52/devstack/lib/crio#L37-L82","commit_id":"5421c25365654052b72260c2b9d10a286111fe90"}]}
