)]}'
{"kuryr_libnetwork/port_driver/drivers/sriov.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dca9b69dccb460a354894173eb38a27dd89d4aad","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    A VF is associated with an VF number, which ip link command uses to"},{"line_number":53,"context_line":"    configure it. This number can be obtained from the PCI device filesystem."},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":"    VIRTFN_RE \u003d re.compile(\"virtfn(\\\\d+)\")"},{"line_number":56,"context_line":"    virtfns_path \u003d \"/sys/bus/pci/devices/%s/physfn/virtfn*\" % (pci_addr)"},{"line_number":57,"context_line":"    vf_num \u003d None"},{"line_number":58,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_7d7f81df","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":39},"updated":"2020-05-19 00:13:33.000000000","message":"I think this is incorrect. The pattern \u0027\\d+\u0027 is for matching number. \u0027\\\\d+\u0027 is matching different things.\n\nNot sure why you make this change but this change is logically wrong.","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7f6fe122b3cb47c2c7efae2041405ee95ace124c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    A VF is associated with an VF number, which ip link command uses to"},{"line_number":53,"context_line":"    configure it. This number can be obtained from the PCI device filesystem."},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":"    VIRTFN_RE \u003d re.compile(\"virtfn(\\\\d+)\")"},{"line_number":56,"context_line":"    virtfns_path \u003d \"/sys/bus/pci/devices/%s/physfn/virtfn*\" % (pci_addr)"},{"line_number":57,"context_line":"    vf_num \u003d None"},{"line_number":58,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3d064522","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":39},"in_reply_to":"ff570b3c_7d7f81df","updated":"2020-05-23 00:05:49.000000000","message":"Done","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"}],"kuryr_libnetwork/tests/unit/base.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dca9b69dccb460a354894173eb38a27dd89d4aad","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                }],"},{"line_number":364,"context_line":"                \"id\": \"65c0ee9f-d634-4522-8954-51021b570b0d\","},{"line_number":365,"context_line":"                \"security_groups\": [],"},{"line_number":366,"context_line":"                \"device_id\": \"\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        }"},{"line_number":369,"context_line":"        return fake_port"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_dd804dc2","side":"PARENT","line":366,"range":{"start_line":366,"start_character":16,"end_line":366,"end_character":31},"updated":"2020-05-19 00:13:33.000000000","message":"Why this is removed?","commit_id":"afecf766f58067485bedd356d5ad986baf3dbe6c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9ed501638ca44498ef4a14e88171287e7799ce83","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                }],"},{"line_number":364,"context_line":"                \"id\": \"65c0ee9f-d634-4522-8954-51021b570b0d\","},{"line_number":365,"context_line":"                \"security_groups\": [],"},{"line_number":366,"context_line":"                \"device_id\": \"\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        }"},{"line_number":369,"context_line":"        return fake_port"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_ee3d6bbb","side":"PARENT","line":366,"range":{"start_line":366,"start_character":16,"end_line":366,"end_character":31},"in_reply_to":"ff570b3c_dd804dc2","updated":"2020-05-20 15:41:14.000000000","message":"It\u0027s already defined in line 355.","commit_id":"afecf766f58067485bedd356d5ad986baf3dbe6c"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7f6fe122b3cb47c2c7efae2041405ee95ace124c","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                }],"},{"line_number":364,"context_line":"                \"id\": \"65c0ee9f-d634-4522-8954-51021b570b0d\","},{"line_number":365,"context_line":"                \"security_groups\": [],"},{"line_number":366,"context_line":"                \"device_id\": \"\""},{"line_number":367,"context_line":"            }"},{"line_number":368,"context_line":"        }"},{"line_number":369,"context_line":"        return fake_port"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_ef07f017","side":"PARENT","line":366,"range":{"start_line":366,"start_character":16,"end_line":366,"end_character":31},"in_reply_to":"ff570b3c_ee3d6bbb","updated":"2020-05-23 00:05:49.000000000","message":"right..","commit_id":"afecf766f58067485bedd356d5ad986baf3dbe6c"}],"kuryr_libnetwork/tests/unit/port_driver/test_driver.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dca9b69dccb460a354894173eb38a27dd89d4aad","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test__verify_binding_driver_compatibility_not_compatible(self, m_conf):"},{"line_number":108,"context_line":"        m_conf.binding.enabled_drivers \u003d [\u0027macvlan\u0027]"},{"line_number":109,"context_line":"        message \u003d \"Configuration file error: port driver \u0027veth\u0027 is not \" \\"},{"line_number":110,"context_line":"                  \"compatible with binding driver \u0027\\\\[\u0027macvlan\u0027\\\\]\u0027\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        fake_driver \u003d mock.Mock(spec\u003ddriver.Driver)"},{"line_number":113,"context_line":"        fake_driver.get_supported_bindings.return_value \u003d (\u0027veth\u0027,)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3d71890d","line":110,"range":{"start_line":110,"start_character":18,"end_line":110,"end_character":68},"updated":"2020-05-19 00:13:33.000000000","message":"Simply remove the escape should be the right fix:\n\n        message \u003d \"Configuration file error: port driver \u0027veth\u0027 is not \" \\\n                  \"compatible with binding driver \u0027[\u0027macvlan\u0027]\u0027\"","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7f6fe122b3cb47c2c7efae2041405ee95ace124c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test__verify_binding_driver_compatibility_not_compatible(self, m_conf):"},{"line_number":108,"context_line":"        m_conf.binding.enabled_drivers \u003d [\u0027macvlan\u0027]"},{"line_number":109,"context_line":"        message \u003d \"Configuration file error: port driver \u0027veth\u0027 is not \" \\"},{"line_number":110,"context_line":"                  \"compatible with binding driver \u0027\\\\[\u0027macvlan\u0027\\\\]\u0027\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        fake_driver \u003d mock.Mock(spec\u003ddriver.Driver)"},{"line_number":113,"context_line":"        fake_driver.get_supported_bindings.return_value \u003d (\u0027veth\u0027,)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_1d038111","line":110,"range":{"start_line":110,"start_character":18,"end_line":110,"end_character":68},"in_reply_to":"ff570b3c_3d71890d","updated":"2020-05-23 00:05:49.000000000","message":"Done","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dca9b69dccb460a354894173eb38a27dd89d4aad","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self, m_conf):"},{"line_number":120,"context_line":"        m_conf.binding.enabled_drivers \u003d [\u0027macvlan\u0027, \u0027sriov\u0027]"},{"line_number":121,"context_line":"        message \u003d \"Configuration file error: port driver \u0027veth\u0027 is not \" \\"},{"line_number":122,"context_line":"                  \"compatible with binding driver \u0027\\\\[\u0027macvlan\u0027\\\\, \u0027sriov\u0027]\u0027\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        fake_driver \u003d mock.Mock(spec\u003ddriver.Driver)"},{"line_number":125,"context_line":"        fake_driver.get_supported_bindings.return_value \u003d (\u0027veth\u0027,)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_7d68211c","line":122,"range":{"start_line":122,"start_character":51,"end_line":122,"end_character":65},"updated":"2020-05-19 00:13:33.000000000","message":"Ditto. Simply remove the \u0027\\\\\u0027","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7f6fe122b3cb47c2c7efae2041405ee95ace124c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self, m_conf):"},{"line_number":120,"context_line":"        m_conf.binding.enabled_drivers \u003d [\u0027macvlan\u0027, \u0027sriov\u0027]"},{"line_number":121,"context_line":"        message \u003d \"Configuration file error: port driver \u0027veth\u0027 is not \" \\"},{"line_number":122,"context_line":"                  \"compatible with binding driver \u0027\\\\[\u0027macvlan\u0027\\\\, \u0027sriov\u0027]\u0027\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        fake_driver \u003d mock.Mock(spec\u003ddriver.Driver)"},{"line_number":125,"context_line":"        fake_driver.get_supported_bindings.return_value \u003d (\u0027veth\u0027,)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_affdf809","line":122,"range":{"start_line":122,"start_character":51,"end_line":122,"end_character":65},"in_reply_to":"ff570b3c_7d68211c","updated":"2020-05-23 00:05:49.000000000","message":"Done","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dca9b69dccb460a354894173eb38a27dd89d4aad","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def test__verify_binding_driver_compatibility_not_supported(self, m_conf):"},{"line_number":131,"context_line":"        m_conf.binding.enabled_drivers \u003d [\u0027ipvlan\u0027]"},{"line_number":132,"context_line":"        message \u003d \"Configuration file error: binding driver \" \\"},{"line_number":133,"context_line":"                  \"\u0027\\\\[\u0027ipvlan\u0027\\\\]\u0027 is currently not supported \" \\"},{"line_number":134,"context_line":"                  \"with \u0027nested\u0027 port driver\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        fake_driver \u003d mock.Mock(spec\u003ddriver.Driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_1d57655a","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":33},"updated":"2020-05-19 00:13:33.000000000","message":"Ditto. Simply remove the escape","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7f6fe122b3cb47c2c7efae2041405ee95ace124c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def test__verify_binding_driver_compatibility_not_supported(self, m_conf):"},{"line_number":131,"context_line":"        m_conf.binding.enabled_drivers \u003d [\u0027ipvlan\u0027]"},{"line_number":132,"context_line":"        message \u003d \"Configuration file error: binding driver \" \\"},{"line_number":133,"context_line":"                  \"\u0027\\\\[\u0027ipvlan\u0027\\\\]\u0027 is currently not supported \" \\"},{"line_number":134,"context_line":"                  \"with \u0027nested\u0027 port driver\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        fake_driver \u003d mock.Mock(spec\u003ddriver.Driver)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_8f02b408","line":133,"range":{"start_line":133,"start_character":20,"end_line":133,"end_character":33},"in_reply_to":"ff570b3c_1d57655a","updated":"2020-05-23 00:05:49.000000000","message":"Done","commit_id":"87d420be731865230f5d5bd084659f3bf01546e7"}]}