)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"16cf228427e8a5b2221d243ce2d00b4ecf894daf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-06-11 09:07:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance svc namespace isolation with LoadBalancer type svc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the current service isolation test with a service"},{"line_number":10,"context_line":"of LoadBalancer type, checking that it has connectivity across"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9fb8cfa7_3cdaa94a","line":7,"updated":"2019-06-11 09:48:01.000000000","message":"this should be:\n\n\"Enhance svc namespace isolation test for Loadbalance type svc\"\n\nOtherwise I was expecting it to do some magic with octavia, when it is a test improvement instead.","commit_id":"2f3e9cd4d1642ac75738a7f89f9ed30e286ecb5b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4270988dad47032780571b83eb1b9f899928a553","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-06-11 09:07:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance svc namespace isolation with LoadBalancer type svc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch extends the current service isolation test with a service"},{"line_number":10,"context_line":"of LoadBalancer type, checking that it has connectivity across"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9fb8cfa7_07751264","line":7,"in_reply_to":"9fb8cfa7_3cdaa94a","updated":"2019-06-11 10:26:00.000000000","message":"Done","commit_id":"2f3e9cd4d1642ac75738a7f89f9ed30e286ecb5b"}],"kuryr_tempest_plugin/tests/scenario/test_namespace.py":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3276bba510bee369474a40b394d666290a499e65","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.assertIn(consts.POD_OUTPUT,"},{"line_number":220,"context_line":"                      self.exec_command_in_pod(pod_nsdefault_name, cmd))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # check connectivity from NS1 pod to NS3 LoadBalancer type service"},{"line_number":223,"context_line":"        cmd \u003d [\"/bin/sh\", \"-c\", \"curl {dst_ip}\".format("},{"line_number":224,"context_line":"            dst_ip\u003dsvc_ns3_ip)]"},{"line_number":225,"context_line":"        self.assertIn(consts.POD_OUTPUT,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_658fdf2b","line":222,"range":{"start_line":222,"start_character":10,"end_line":222,"end_character":74},"updated":"2018-12-10 10:34:00.000000000","message":"Do we need to add default to NS3?\nAlso we need to check connectivity to the Cluseter IP and to the FIP,right?","commit_id":"468fb9ed0e2c82b129328798434ad9233e4269c7"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0e166a226fdbd8f3ee5aafef6210787c6c1f0fc7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.assertIn(consts.POD_OUTPUT,"},{"line_number":220,"context_line":"                      self.exec_command_in_pod(pod_nsdefault_name, cmd))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # check connectivity from NS1 pod to NS3 LoadBalancer type service"},{"line_number":223,"context_line":"        cmd \u003d [\"/bin/sh\", \"-c\", \"curl {dst_ip}\".format("},{"line_number":224,"context_line":"            dst_ip\u003dsvc_ns3_ip)]"},{"line_number":225,"context_line":"        self.assertIn(consts.POD_OUTPUT,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_883a52c2","line":222,"range":{"start_line":222,"start_character":10,"end_line":222,"end_character":74},"in_reply_to":"3f79a3b5_658fdf2b","updated":"2018-12-10 10:57:52.000000000","message":"Why checking default to NS3? we are already checking NS2.\nAs for the clusterIP/FIP, we can add clusterIP too, but it should be enough with the FIP","commit_id":"468fb9ed0e2c82b129328798434ad9233e4269c7"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"6d0d054d3499f09bd67708583a7a21e3fc2d0c9d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.assertIn(consts.POD_OUTPUT,"},{"line_number":220,"context_line":"                      self.exec_command_in_pod(pod_nsdefault_name, cmd))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # check connectivity from NS1 pod to NS3 LoadBalancer type service"},{"line_number":223,"context_line":"        cmd \u003d [\"/bin/sh\", \"-c\", \"curl {dst_ip}\".format("},{"line_number":224,"context_line":"            dst_ip\u003dsvc_ns3_ip)]"},{"line_number":225,"context_line":"        self.assertIn(consts.POD_OUTPUT,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_dbdfb207","line":222,"range":{"start_line":222,"start_character":10,"end_line":222,"end_character":74},"in_reply_to":"3f79a3b5_883a52c2","updated":"2018-12-10 12:18:17.000000000","message":"default -\u003e ns3 It\u0027s not the same service type as ns2","commit_id":"468fb9ed0e2c82b129328798434ad9233e4269c7"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"ca68aabfef8e991370134abf88d702560cf60d97","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.assertIn(consts.POD_OUTPUT,"},{"line_number":226,"context_line":"                      self.exec_command_in_pod(pod_ns1_name, cmd, ns1_name))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # Check resources are deleted"},{"line_number":229,"context_line":"        self._delete_namespace_resources(ns1_name, net_crd_ns1,"},{"line_number":230,"context_line":"                                         subnet_ns1_name)"},{"line_number":231,"context_line":"        self._delete_namespace_resources(ns2_name, net_crd_ns2,"},{"line_number":232,"context_line":"                                         subnet_ns2_name)"},{"line_number":233,"context_line":"        self._delete_namespace_resources(ns3_name, net_crd_ns3,"},{"line_number":234,"context_line":"                                         subnet_ns3_name)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _delete_namespace_resources(self, namespace, net_crd, subnet):"},{"line_number":237,"context_line":"        # Check resources are deleted"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_0584eb0c","line":234,"range":{"start_line":228,"start_character":0,"end_line":234,"end_character":57},"updated":"2018-12-10 10:34:14.000000000","message":"I think it\u0027s better to delete namespaces in cleanup, so if the test fails in the middle, all the namespaces will be deleted as well","commit_id":"468fb9ed0e2c82b129328798434ad9233e4269c7"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0e166a226fdbd8f3ee5aafef6210787c6c1f0fc7","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.assertIn(consts.POD_OUTPUT,"},{"line_number":226,"context_line":"                      self.exec_command_in_pod(pod_ns1_name, cmd, ns1_name))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # Check resources are deleted"},{"line_number":229,"context_line":"        self._delete_namespace_resources(ns1_name, net_crd_ns1,"},{"line_number":230,"context_line":"                                         subnet_ns1_name)"},{"line_number":231,"context_line":"        self._delete_namespace_resources(ns2_name, net_crd_ns2,"},{"line_number":232,"context_line":"                                         subnet_ns2_name)"},{"line_number":233,"context_line":"        self._delete_namespace_resources(ns3_name, net_crd_ns3,"},{"line_number":234,"context_line":"                                         subnet_ns3_name)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _delete_namespace_resources(self, namespace, net_crd, subnet):"},{"line_number":237,"context_line":"        # Check resources are deleted"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_651fdf6d","line":234,"range":{"start_line":228,"start_character":0,"end_line":234,"end_character":57},"in_reply_to":"3f79a3b5_0584eb0c","updated":"2018-12-10 10:57:52.000000000","message":"this is the way we are doing it for the other tests in this file. Better to change all or none. Anyway, note delete_namespace_resources is kind of part of the test, as it is checking the subnets, CRDs, namespaces are being deleted","commit_id":"468fb9ed0e2c82b129328798434ad9233e4269c7"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"ed213772da9e609c8fb2281d53058a80c2a5ac64","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.assertIn(consts.POD_OUTPUT,"},{"line_number":226,"context_line":"                      self.exec_command_in_pod(pod_ns1_name, cmd, ns1_name))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # Check resources are deleted"},{"line_number":229,"context_line":"        self._delete_namespace_resources(ns1_name, net_crd_ns1,"},{"line_number":230,"context_line":"                                         subnet_ns1_name)"},{"line_number":231,"context_line":"        self._delete_namespace_resources(ns2_name, net_crd_ns2,"},{"line_number":232,"context_line":"                                         subnet_ns2_name)"},{"line_number":233,"context_line":"        self._delete_namespace_resources(ns3_name, net_crd_ns3,"},{"line_number":234,"context_line":"                                         subnet_ns3_name)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _delete_namespace_resources(self, namespace, net_crd, subnet):"},{"line_number":237,"context_line":"        # Check resources are deleted"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_1b2bea31","line":234,"range":{"start_line":228,"start_character":0,"end_line":234,"end_character":57},"in_reply_to":"3f79a3b5_651fdf6d","updated":"2018-12-10 12:07:00.000000000","message":"Even if it\u0027s part of the test we want to make sure the test doesn\u0027t leave garbage if it fails in the middle\nOf course it could be done in other patch for all the tests","commit_id":"468fb9ed0e2c82b129328798434ad9233e4269c7"}]}