)]}'
{"kuryr_tempest_plugin/tests/scenario/test_network_policy.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"836401da1a0d91267443bbbc9e5b39dc8c17d4f8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    name\u003dkuryr_netpolicy_crd_name)"},{"line_number":146,"context_line":"                break"},{"line_number":147,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":148,"context_line":"                time.sleep(1)"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"        sg_id \u003d kuryrnetpolicies[\u0027spec\u0027][\u0027securityGroupId\u0027]"},{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_548aef1a","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":24},"updated":"2019-04-08 07:15:37.000000000","message":"perhaps good to add an specific number or retries, to not hang here forever is something is not working","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"0ad7c20826d195ca2736673a1ceeff1a205b929d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    name\u003dkuryr_netpolicy_crd_name)"},{"line_number":146,"context_line":"                break"},{"line_number":147,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":148,"context_line":"                time.sleep(1)"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"        sg_id \u003d kuryrnetpolicies[\u0027spec\u0027][\u0027securityGroupId\u0027]"},{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_b7da94e6","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":24},"in_reply_to":"3fce034c_7630dd08","updated":"2019-04-14 10:11:37.000000000","message":"Done","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"10d5909ecce41921c63943206e80d81f8db71d8a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    name\u003dkuryr_netpolicy_crd_name)"},{"line_number":146,"context_line":"                break"},{"line_number":147,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":148,"context_line":"                time.sleep(1)"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"        sg_id \u003d kuryrnetpolicies[\u0027spec\u0027][\u0027securityGroupId\u0027]"},{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_627e25e4","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":24},"in_reply_to":"5fc1f717_548aef1a","updated":"2019-04-09 15:26:19.000000000","message":"+1","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"846c5e8a4ba253ec276c69427223e2e8ebc34ece","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    name\u003dkuryr_netpolicy_crd_name)"},{"line_number":146,"context_line":"                break"},{"line_number":147,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":148,"context_line":"                time.sleep(1)"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"        sg_id \u003d kuryrnetpolicies[\u0027spec\u0027][\u0027securityGroupId\u0027]"},{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_e5568305","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":24},"in_reply_to":"5fc1f717_548aef1a","updated":"2019-04-10 14:39:11.000000000","message":"Actually it was a copy/paste of the test above :)\nAll 3 comments you gave are c/p, so do you want to fix all the network policy tests in this patch, leave it as is and fix it for all the tests later or change only here?","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c4fa250ffa1a17dec992191c384bb48c5d75e108","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    name\u003dkuryr_netpolicy_crd_name)"},{"line_number":146,"context_line":"                break"},{"line_number":147,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":148,"context_line":"                time.sleep(1)"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"        sg_id \u003d kuryrnetpolicies[\u0027spec\u0027][\u0027securityGroupId\u0027]"},{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_7630dd08","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":24},"in_reply_to":"5fc1f717_e5568305","updated":"2019-04-11 08:17:02.000000000","message":"better to copy the approach on the upgrate method  (lines 91-100) rather than the initial one. In fact, the initial one could be changed to reflect this too","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"10d5909ecce41921c63943206e80d81f8db71d8a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"},{"line_number":153,"context_line":"        self.assertIn(network_policy_name, network_policies)"},{"line_number":154,"context_line":"        self.assertEqual(kuryr_netpolicy_crd_name,"},{"line_number":155,"context_line":"                         str(kuryrnetpolicies[\u0027metadata\u0027][\u0027name\u0027]))"},{"line_number":156,"context_line":"        self.assertIn(sg_id, sg_ids)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_3d3da0ba","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":67},"updated":"2019-04-09 15:26:19.000000000","message":"Maybe when/if you add the specific number of retries, for getting the CRD, you could also check if kuryrnetpolicies was set, and if not raise lib_exc.TimeoutException.","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"846c5e8a4ba253ec276c69427223e2e8ebc34ece","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"},{"line_number":153,"context_line":"        self.assertIn(network_policy_name, network_policies)"},{"line_number":154,"context_line":"        self.assertEqual(kuryr_netpolicy_crd_name,"},{"line_number":155,"context_line":"                         str(kuryrnetpolicies[\u0027metadata\u0027][\u0027name\u0027]))"},{"line_number":156,"context_line":"        self.assertIn(sg_id, sg_ids)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_6542933d","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":67},"in_reply_to":"5fc1f717_3d3da0ba","updated":"2019-04-10 14:39:11.000000000","message":"As in the previous comment copy/paste from the code above","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"0ad7c20826d195ca2736673a1ceeff1a205b929d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        sgs \u003d self.list_security_groups(fields\u003d\u0027id\u0027)"},{"line_number":152,"context_line":"        sg_ids \u003d [sg[\u0027id\u0027] for sg in sgs]"},{"line_number":153,"context_line":"        self.assertIn(network_policy_name, network_policies)"},{"line_number":154,"context_line":"        self.assertEqual(kuryr_netpolicy_crd_name,"},{"line_number":155,"context_line":"                         str(kuryrnetpolicies[\u0027metadata\u0027][\u0027name\u0027]))"},{"line_number":156,"context_line":"        self.assertIn(sg_id, sg_ids)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_3763041d","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":67},"in_reply_to":"5fc1f717_3d3da0ba","updated":"2019-04-14 10:11:37.000000000","message":"I am not sure I understand what you propose, could you please elaborate a bit more?","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"836401da1a0d91267443bbbc9e5b39dc8c17d4f8","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"},{"line_number":159,"context_line":"        self.delete_namespace(ns)"},{"line_number":160,"context_line":"        self.assertNotIn(network_policy_name, self.list_network_policies())"},{"line_number":161,"context_line":"        while True:"},{"line_number":162,"context_line":"            time.sleep(1)"},{"line_number":163,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_349ac361","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":75},"updated":"2019-04-08 07:15:37.000000000","message":"this may fail as you didn\u0027t check the namespace was actually deleted. Perhaps you need to check that first, and once the namespace does not exits, check that associated resources has been deleted","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"0ad7c20826d195ca2736673a1ceeff1a205b929d","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"},{"line_number":159,"context_line":"        self.delete_namespace(ns)"},{"line_number":160,"context_line":"        self.assertNotIn(network_policy_name, self.list_network_policies())"},{"line_number":161,"context_line":"        while True:"},{"line_number":162,"context_line":"            time.sleep(1)"},{"line_number":163,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_5767b04e","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":75},"in_reply_to":"3fce034c_56184180","updated":"2019-04-14 10:11:37.000000000","message":"Done","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"846c5e8a4ba253ec276c69427223e2e8ebc34ece","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"},{"line_number":159,"context_line":"        self.delete_namespace(ns)"},{"line_number":160,"context_line":"        self.assertNotIn(network_policy_name, self.list_network_policies())"},{"line_number":161,"context_line":"        while True:"},{"line_number":162,"context_line":"            time.sleep(1)"},{"line_number":163,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_4560b7cf","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":75},"in_reply_to":"5fc1f717_026f2128","updated":"2019-04-10 14:39:11.000000000","message":"copy/paste from the merged code above as well","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"10d5909ecce41921c63943206e80d81f8db71d8a","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"},{"line_number":159,"context_line":"        self.delete_namespace(ns)"},{"line_number":160,"context_line":"        self.assertNotIn(network_policy_name, self.list_network_policies())"},{"line_number":161,"context_line":"        while True:"},{"line_number":162,"context_line":"            time.sleep(1)"},{"line_number":163,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_026f2128","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":75},"in_reply_to":"5fc1f717_349ac361","updated":"2019-04-09 15:26:19.000000000","message":"+1","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c4fa250ffa1a17dec992191c384bb48c5d75e108","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # delete namespace"},{"line_number":159,"context_line":"        self.delete_namespace(ns)"},{"line_number":160,"context_line":"        self.assertNotIn(network_policy_name, self.list_network_policies())"},{"line_number":161,"context_line":"        while True:"},{"line_number":162,"context_line":"            time.sleep(1)"},{"line_number":163,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_56184180","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":75},"in_reply_to":"5fc1f717_4560b7cf","updated":"2019-04-11 08:17:02.000000000","message":"this should be moved to after the next while true, same for the create_delete method","commit_id":"4465761fb27bef0d966aee869f993d97e6d2e69b"}]}