)]}'
{"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b6043b61e1a07fd66dd843ce312cce24caa01f44","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return name, pod"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @classmethod"},{"line_number":152,"context_line":"    def create_pod_without_readiness_wait(cls, name\u003dNone, labels\u003dNone,"},{"line_number":153,"context_line":"                                          image\u003d\u0027kuryr/demo\u0027,"},{"line_number":154,"context_line":"                                          namespace\u003d\"default\","},{"line_number":155,"context_line":"                                          annotations\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5f112604","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":41},"updated":"2019-07-03 06:29:22.000000000","message":"Can you modify the create_pod method instead creating a new method?","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"f06c8f894d7c8f5678f69fe39359230a0ba65660","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return name, pod"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @classmethod"},{"line_number":152,"context_line":"    def create_pod_without_readiness_wait(cls, name\u003dNone, labels\u003dNone,"},{"line_number":153,"context_line":"                                          image\u003d\u0027kuryr/demo\u0027,"},{"line_number":154,"context_line":"                                          namespace\u003d\"default\","},{"line_number":155,"context_line":"                                          annotations\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_75768b0f","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":41},"in_reply_to":"9fb8cfa7_1ff40e87","updated":"2019-07-03 09:25:30.000000000","message":"Done","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dbb223c0b7697515b31d5037377e71e49aeda0f6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        return name, pod"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @classmethod"},{"line_number":152,"context_line":"    def create_pod_without_readiness_wait(cls, name\u003dNone, labels\u003dNone,"},{"line_number":153,"context_line":"                                          image\u003d\u0027kuryr/demo\u0027,"},{"line_number":154,"context_line":"                                          namespace\u003d\"default\","},{"line_number":155,"context_line":"                                          annotations\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1ff40e87","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":41},"in_reply_to":"9fb8cfa7_5f112604","updated":"2019-07-03 06:46:51.000000000","message":"in fact, the above method (line 125) takes a parameter named wait_for_status, we should call that one instead with wait_for_status \u003d\u003d False","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dbb223c0b7697515b31d5037377e71e49aeda0f6","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        return name, namespace_obj"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    @classmethod"},{"line_number":576,"context_line":"    def create_namespace_without_crd_wait(cls, name\u003dNone):"},{"line_number":577,"context_line":"        if not name:"},{"line_number":578,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-namespace\u0027)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7f28aaed","line":576,"range":{"start_line":576,"start_character":8,"end_line":576,"end_character":41},"updated":"2019-07-03 06:46:51.000000000","message":"perhaps we should make function in 555 similar to the ones for pods and have a var to either wait or not for the CRD to be created","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"f06c8f894d7c8f5678f69fe39359230a0ba65660","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        return name, namespace_obj"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    @classmethod"},{"line_number":576,"context_line":"    def create_namespace_without_crd_wait(cls, name\u003dNone):"},{"line_number":577,"context_line":"        if not name:"},{"line_number":578,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-namespace\u0027)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d5de57d9","line":576,"range":{"start_line":576,"start_character":8,"end_line":576,"end_character":41},"in_reply_to":"9fb8cfa7_7f28aaed","updated":"2019-07-03 09:25:30.000000000","message":"Done","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f43c3688380fe87d8eab65b400fbe46056dbc2af","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        while True:"},{"line_number":544,"context_line":"            time.sleep(1)"},{"line_number":545,"context_line":"            ns \u003d cls.k8s_client.CoreV1Api().read_namespace_status(name)"},{"line_number":546,"context_line":"            if ns.metadata.annotations:"},{"line_number":547,"context_line":"                if (not wait_for_crd_annotation or"},{"line_number":548,"context_line":"                        ns.metadata.annotations.get(kuryr_crd_annotation)):"},{"line_number":549,"context_line":"                    break"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        return name, namespace_obj"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_269ad261","line":548,"range":{"start_line":546,"start_character":0,"end_line":548,"end_character":75},"updated":"2019-08-28 14:04:11.000000000","message":"Why not combine those if\u0027s? If it\u0027s just formatting, use parentheses.","commit_id":"b5c433950dd5b536e2472086815ab1312398014d"}],"kuryr_tempest_plugin/tests/scenario/test_namespace.py":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b6043b61e1a07fd66dd843ce312cce24caa01f44","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @decorators.idempotent_id(\u00279e3ddb2d-d765-4ac5-8ab0-6a404adddd49\u0027)"},{"line_number":338,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":339,"context_line":"        ns_name \u003d \u0027test\u0027"},{"line_number":340,"context_line":"        ns_name, ns \u003d self.create_namespace_without_crd_wait(name\u003dns_name)"},{"line_number":341,"context_line":"        pod_name, pod \u003d self.create_pod_without_readiness_wait("},{"line_number":342,"context_line":"            namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ff1eda0b","line":339,"range":{"start_line":339,"start_character":19,"end_line":339,"end_character":23},"updated":"2019-07-03 06:29:22.000000000","message":"I suggest to use some random name.","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"f06c8f894d7c8f5678f69fe39359230a0ba65660","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @decorators.idempotent_id(\u00279e3ddb2d-d765-4ac5-8ab0-6a404adddd49\u0027)"},{"line_number":338,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":339,"context_line":"        ns_name \u003d \u0027test\u0027"},{"line_number":340,"context_line":"        ns_name, ns \u003d self.create_namespace_without_crd_wait(name\u003dns_name)"},{"line_number":341,"context_line":"        pod_name, pod \u003d self.create_pod_without_readiness_wait("},{"line_number":342,"context_line":"            namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_55a10746","line":339,"range":{"start_line":339,"start_character":19,"end_line":339,"end_character":23},"in_reply_to":"9fb8cfa7_1fc64e4b","updated":"2019-07-03 09:25:30.000000000","message":"Done","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dbb223c0b7697515b31d5037377e71e49aeda0f6","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    @decorators.idempotent_id(\u00279e3ddb2d-d765-4ac5-8ab0-6a404adddd49\u0027)"},{"line_number":338,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":339,"context_line":"        ns_name \u003d \u0027test\u0027"},{"line_number":340,"context_line":"        ns_name, ns \u003d self.create_namespace_without_crd_wait(name\u003dns_name)"},{"line_number":341,"context_line":"        pod_name, pod \u003d self.create_pod_without_readiness_wait("},{"line_number":342,"context_line":"            namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1fc64e4b","line":339,"range":{"start_line":339,"start_character":19,"end_line":339,"end_character":23},"in_reply_to":"9fb8cfa7_ff1eda0b","updated":"2019-07-03 06:46:51.000000000","message":"+1","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b6043b61e1a07fd66dd843ce312cce24caa01f44","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            namespace\u003dns_name)"},{"line_number":343,"context_line":"        self.delete_namespace(ns_name)"},{"line_number":344,"context_line":"        # wait for namespace to be deleted"},{"line_number":345,"context_line":"        while True:"},{"line_number":346,"context_line":"            try:"},{"line_number":347,"context_line":"                self.k8s_client.CoreV1Api().read_namespace(ns_name)"},{"line_number":348,"context_line":"                time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_ffe33a05","line":345,"range":{"start_line":345,"start_character":8,"end_line":345,"end_character":18},"updated":"2019-07-03 06:29:22.000000000","message":"Can we add a timeout?","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"f06c8f894d7c8f5678f69fe39359230a0ba65660","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            namespace\u003dns_name)"},{"line_number":343,"context_line":"        self.delete_namespace(ns_name)"},{"line_number":344,"context_line":"        # wait for namespace to be deleted"},{"line_number":345,"context_line":"        while True:"},{"line_number":346,"context_line":"            try:"},{"line_number":347,"context_line":"                self.k8s_client.CoreV1Api().read_namespace(ns_name)"},{"line_number":348,"context_line":"                time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b92abd7b","line":345,"range":{"start_line":345,"start_character":8,"end_line":345,"end_character":18},"in_reply_to":"9fb8cfa7_ffe33a05","updated":"2019-07-03 09:25:30.000000000","message":"Done","commit_id":"77717c542210c45891e8c220a80d02852baaae25"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"23bd6ef5fb8e2ffd540e3fb2bb227c17614185e9","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":341,"context_line":"        ns_name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-ns\u0027)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        ns_name, ns \u003d self.create_namespace("},{"line_number":344,"context_line":"            name\u003dns_name, wait_for_status\u003dFalse)"},{"line_number":345,"context_line":"        pod_name, pod \u003d self.create_pod("},{"line_number":346,"context_line":"            namespace\u003dns_name, wait_for_status\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_c233fa12","line":343,"range":{"start_line":343,"start_character":27,"end_line":343,"end_character":43},"updated":"2019-07-03 13:00:17.000000000","message":"I suggest adding a cleanup.","commit_id":"79ca858523c9b56e5ba37b93af9e4a3dfbf296b7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"ba3d9c5f49a85e97304ef1690184967c2bc61f5a","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":341,"context_line":"        ns_name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-ns\u0027)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        ns_name, ns \u003d self.create_namespace("},{"line_number":344,"context_line":"            name\u003dns_name, wait_for_status\u003dFalse)"},{"line_number":345,"context_line":"        pod_name, pod \u003d self.create_pod("},{"line_number":346,"context_line":"            namespace\u003dns_name, wait_for_status\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_416f11c5","line":343,"range":{"start_line":343,"start_character":27,"end_line":343,"end_character":43},"in_reply_to":"7faddb67_a3f28d99","updated":"2019-07-04 08:10:26.000000000","message":"good point! thanks.","commit_id":"79ca858523c9b56e5ba37b93af9e4a3dfbf296b7"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"dc77c27174578f6935cc4bc1795483ff3bcb347e","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":341,"context_line":"        ns_name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-ns\u0027)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        ns_name, ns \u003d self.create_namespace("},{"line_number":344,"context_line":"            name\u003dns_name, wait_for_status\u003dFalse)"},{"line_number":345,"context_line":"        pod_name, pod \u003d self.create_pod("},{"line_number":346,"context_line":"            namespace\u003dns_name, wait_for_status\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a3f28d99","line":343,"range":{"start_line":343,"start_character":27,"end_line":343,"end_character":43},"in_reply_to":"9fb8cfa7_220bf62b","updated":"2019-07-04 06:30:43.000000000","message":"Yeah, but what happens if something go wrong by then?","commit_id":"79ca858523c9b56e5ba37b93af9e4a3dfbf296b7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"afd1431fe533ae20bc6b94496bc8675904ba46ba","unresolved":false,"context_lines":[{"line_number":340,"context_line":"    def test_recreate_pod_in_namespace(self):"},{"line_number":341,"context_line":"        ns_name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-ns\u0027)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        ns_name, ns \u003d self.create_namespace("},{"line_number":344,"context_line":"            name\u003dns_name, wait_for_status\u003dFalse)"},{"line_number":345,"context_line":"        pod_name, pod \u003d self.create_pod("},{"line_number":346,"context_line":"            namespace\u003dns_name, wait_for_status\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_220bf62b","line":343,"range":{"start_line":343,"start_character":27,"end_line":343,"end_character":43},"in_reply_to":"9fb8cfa7_c233fa12","updated":"2019-07-03 13:01:40.000000000","message":"This namespace is being deleted on line 348.","commit_id":"79ca858523c9b56e5ba37b93af9e4a3dfbf296b7"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f43c3688380fe87d8eab65b400fbe46056dbc2af","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                self.k8s_client.CoreV1Api().read_namespace(ns_name)"},{"line_number":355,"context_line":"                retries -\u003d 1"},{"line_number":356,"context_line":"                if retries \u003d\u003d 0:"},{"line_number":357,"context_line":"                    raise lib_exc.TimeoutException()"},{"line_number":358,"context_line":"                time.sleep(1)"},{"line_number":359,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":360,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_66de8a11","line":357,"range":{"start_line":357,"start_character":0,"end_line":357,"end_character":52},"updated":"2019-08-28 14:04:11.000000000","message":"Please just use\n\n self.assertNotEqual(0, retries, \"Timed out waiting for namespace %s to be deleted\" % ns_name)\n\nRaising that TimeoutException was a mistake from the beginning.","commit_id":"b5c433950dd5b536e2472086815ab1312398014d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f43c3688380fe87d8eab65b400fbe46056dbc2af","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                if retries \u003d\u003d 0:"},{"line_number":357,"context_line":"                    raise lib_exc.TimeoutException()"},{"line_number":358,"context_line":"                time.sleep(1)"},{"line_number":359,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":360,"context_line":"                break"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        ns_name, ns \u003d self.create_namespace("},{"line_number":363,"context_line":"            name\u003dns_name, wait_for_crd_annotation\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e6c91a51","line":360,"range":{"start_line":359,"start_character":0,"end_line":360,"end_character":21},"updated":"2019-08-28 14:04:11.000000000","message":"You could check if it\u0027s 404 and do continue otherwise.","commit_id":"b5c433950dd5b536e2472086815ab1312398014d"}]}