)]}'
{"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"f64479b39e7e58ae9be73249f8e2a3b676a60451","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            namespace\u003dnamespace, plural\u003dKURYR_NET_POLICY_CRD_PLURAL,"},{"line_number":604,"context_line":"            name\u003dname, **kwargs)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def get_pod_list(self, namespace\u003d\"default\", label_selector\u003d\u0027\u0027):"},{"line_number":607,"context_line":"        return self.k8s_client.CoreV1Api().list_namespaced_pod("},{"line_number":608,"context_line":"            namespace\u003dnamespace, label_selector\u003dlabel_selector).items"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5ba3b99e","line":606,"updated":"2019-08-20 14:21:54.000000000","message":"NIT: For consistency use \"\" or \u0027\u0027 on the same line, here and below","commit_id":"f545fe90ed928575e47c5d74c1a8897976680df2"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"cc99efe929cd936f0dfb12c7f7ed919ce84f703c","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            namespace\u003dnamespace, plural\u003dKURYR_NET_POLICY_CRD_PLURAL,"},{"line_number":604,"context_line":"            name\u003dname, **kwargs)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def get_pod_list(self, namespace\u003d\"default\", label_selector\u003d\u0027\u0027):"},{"line_number":607,"context_line":"        return self.k8s_client.CoreV1Api().list_namespaced_pod("},{"line_number":608,"context_line":"            namespace\u003dnamespace, label_selector\u003dlabel_selector).items"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_f64f0c8f","line":606,"in_reply_to":"7faddb67_5ba3b99e","updated":"2019-08-21 06:02:05.000000000","message":"Done","commit_id":"f545fe90ed928575e47c5d74c1a8897976680df2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"46975f2408c74803dc80f9d5e7f531994ef33142","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        # status parameter, so for example it should stay in Running state when"},{"line_number":782,"context_line":"        # the service with incorrect parameters was created"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        controller_pods \u003d ["},{"line_number":785,"context_line":"            pod.metadata.name for pod in"},{"line_number":786,"context_line":"            self.k8s_client.CoreV1Api().list_namespaced_pod("},{"line_number":787,"context_line":"                namespace\u003dCONF.kuryr_kubernetes.kube_system_namespace).items"},{"line_number":788,"context_line":"            if pod.metadata.name.startswith(KURYR_CONTROLLER)]"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        while retry_attempts !\u003d 0:"},{"line_number":791,"context_line":"            time.sleep(time_between_attempts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_69a7babd","line":788,"range":{"start_line":784,"start_character":0,"end_line":788,"end_character":62},"updated":"2019-08-21 09:38:27.000000000","message":"perhaps then you should use the label here too","commit_id":"381f65f3b8593b595030926cac4cdbe18dcd04fd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e97d5618add408ef34297e3463810ce446dbfd5e","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        # status parameter, so for example it should stay in Running state when"},{"line_number":782,"context_line":"        # the service with incorrect parameters was created"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        controller_pods \u003d ["},{"line_number":785,"context_line":"            pod.metadata.name for pod in"},{"line_number":786,"context_line":"            self.k8s_client.CoreV1Api().list_namespaced_pod("},{"line_number":787,"context_line":"                namespace\u003dCONF.kuryr_kubernetes.kube_system_namespace).items"},{"line_number":788,"context_line":"            if pod.metadata.name.startswith(KURYR_CONTROLLER)]"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        while retry_attempts !\u003d 0:"},{"line_number":791,"context_line":"            time.sleep(time_between_attempts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_42517361","line":788,"range":{"start_line":784,"start_character":0,"end_line":788,"end_character":62},"in_reply_to":"7faddb67_69a7babd","updated":"2019-08-21 12:43:55.000000000","message":"Done","commit_id":"381f65f3b8593b595030926cac4cdbe18dcd04fd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"46975f2408c74803dc80f9d5e7f531994ef33142","unresolved":false,"context_lines":[{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def restart_kuryr_controller(self):"},{"line_number":938,"context_line":"        system_namespace \u003d CONF.kuryr_kubernetes.kube_system_namespace"},{"line_number":939,"context_line":"        for kuryr_pod_name in self.get_controller_pod_names():"},{"line_number":940,"context_line":"            self.delete_pod("},{"line_number":941,"context_line":"                pod_name\u003dkuryr_pod_name,"},{"line_number":942,"context_line":"                body\u003d{\"kind\": \"DeleteOptions\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_89279663","line":939,"range":{"start_line":939,"start_character":59,"end_line":939,"end_character":61},"updated":"2019-08-21 09:38:27.000000000","message":"perhaps better to pass here the system_namespace (renamed as kuryr_namespace) and make the get_controller_pod_names accept that parameter","commit_id":"381f65f3b8593b595030926cac4cdbe18dcd04fd"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e97d5618add408ef34297e3463810ce446dbfd5e","unresolved":false,"context_lines":[{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def restart_kuryr_controller(self):"},{"line_number":938,"context_line":"        system_namespace \u003d CONF.kuryr_kubernetes.kube_system_namespace"},{"line_number":939,"context_line":"        for kuryr_pod_name in self.get_controller_pod_names():"},{"line_number":940,"context_line":"            self.delete_pod("},{"line_number":941,"context_line":"                pod_name\u003dkuryr_pod_name,"},{"line_number":942,"context_line":"                body\u003d{\"kind\": \"DeleteOptions\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e29adf6c","line":939,"range":{"start_line":939,"start_character":59,"end_line":939,"end_character":61},"in_reply_to":"7faddb67_89279663","updated":"2019-08-21 12:43:55.000000000","message":"I\u0027m not sure why it\u0027s needed. Is there a case where the controller will be in other namespace than the one in the configuration?","commit_id":"381f65f3b8593b595030926cac4cdbe18dcd04fd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"30a6254dd1b73bcc55e78e86d887323d3311eced","unresolved":false,"context_lines":[{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def restart_kuryr_controller(self):"},{"line_number":938,"context_line":"        system_namespace \u003d CONF.kuryr_kubernetes.kube_system_namespace"},{"line_number":939,"context_line":"        for kuryr_pod_name in self.get_controller_pod_names():"},{"line_number":940,"context_line":"            self.delete_pod("},{"line_number":941,"context_line":"                pod_name\u003dkuryr_pod_name,"},{"line_number":942,"context_line":"                body\u003d{\"kind\": \"DeleteOptions\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6631110b","line":939,"range":{"start_line":939,"start_character":59,"end_line":939,"end_character":61},"in_reply_to":"7faddb67_e29adf6c","updated":"2019-08-22 07:45:11.000000000","message":"That will depend on the installation process. And yes, with devstack kuryr pods are on kube-system namespace, while for instance with openshift-ansible they are in their own namespace (that by default is called kuryr, but it is configurable).","commit_id":"381f65f3b8593b595030926cac4cdbe18dcd04fd"}]}