)]}'
{"kuryr_tempest_plugin/config.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b5569c01d4114b94aeb148d3a34625330786c1ab","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                \"map can be changed\"),"},{"line_number":78,"context_line":"    cfg.StrOpt(\"controller_label\", default\u003d\"name\u003dkuryr-controller\","},{"line_number":79,"context_line":"               help\u003d\"The label is used to identify the Kuryr controller pods\"),"},{"line_number":80,"context_line":"    cfg.BoolOpt(\"prepopulation_enabled\", default\u003dTrue,"},{"line_number":81,"context_line":"                help\u003d\"Whether prepopulation of ports is enabled\"),"},{"line_number":82,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4a31130b","line":80,"range":{"start_line":80,"start_character":49,"end_line":80,"end_character":54},"updated":"2019-10-08 07:59:34.000000000","message":"should default to False","commit_id":"0fd3a5b1f9d208beb3725872e0e784b41ece5efb"}],"kuryr_tempest_plugin/tests/scenario/test_port_pool.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b5569c01d4114b94aeb148d3a34625330786c1ab","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        num_nodes \u003d len(self.k8s_client.CoreV1Api().list_node().items)"},{"line_number":71,"context_line":"        num_ports_initial \u003d num_nodes * (int(self.PORTS_POOL_DEFAULT_DICT["},{"line_number":72,"context_line":"            \u0027ports_pool_batch\u0027])/2) + 1"},{"line_number":73,"context_line":"        port_list_num \u003d len(self.os_admin.ports_client.list_ports("},{"line_number":74,"context_line":"            fixed_ips\u003d\u0027subnet_id\u003d%s\u0027 % subnet_id)[\u0027ports\u0027])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if CONF.kuryr_kubernetes.prepopulation_enabled:"},{"line_number":77,"context_line":"            retries \u003d PREPOPULAION_RETRIES"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_45ffc400","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":59},"updated":"2019-10-08 07:59:34.000000000","message":"could it happen that, for the non-prepopulating case, this is executed before the subnet is actually attached to the router and therefore not counting the gateway port? Perhaps worth to have a waiting function as you have for the prepopulation_enabled for both cases... and just change the expected num_ports_initial based on the prepopulation_enabled flag","commit_id":"0fd3a5b1f9d208beb3725872e0e784b41ece5efb"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"89b9b60f874cd4453c99e5c0688046b3b424bcbc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"PREPOPULAION_RETRIES \u003d 60"},{"line_number":30,"context_line":"NON_PREPOPULAION_RETRIES \u003d 2"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TestPortPoolScenario(base.BaseKuryrScenarioTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e6ffd364","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":28},"updated":"2019-10-08 13:58:14.000000000","message":"this may be too little... better to increase to 5 to be on the safe side","commit_id":"7ff8fc2909a3622fef85be51758494170bd20e85"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a2497ba446dd5aeb06659bcf018a003011ea4ecd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        while port_list_num !\u003d num_ports_initial:"},{"line_number":84,"context_line":"            retries -\u003d 1"},{"line_number":85,"context_line":"            if retries \u003d\u003d 0:"},{"line_number":86,"context_line":"                raise lib_exc.TimeoutException()"},{"line_number":87,"context_line":"            time.sleep(3)"},{"line_number":88,"context_line":"            port_list_num \u003d len(self.os_admin.ports_client.list_ports("},{"line_number":89,"context_line":"                fixed_ips\u003d\u0027subnet_id\u003d%s\u0027 % subnet_id)[\u0027ports\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_e940c637","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":48},"updated":"2019-10-11 14:31:31.000000000","message":"Please, no more raising meaningless exceptions. It makes debugging way harder. Instead we can do something like this:\n\n self.assertNotEqual(0, retries, \"Timed out waiting for port prepopulation for namespace %s to end. Expected %d ports, found %d\" % (namespace_name, num_ports_initial, port_list_num)\n\n(I know, port_list_num is set below, but Python doesn\u0027t have notion of scopes, I think it\u0027ll work.)","commit_id":"a3ba8ef53e630ce948f202650ee33c5a0d9537d3"}]}