)]}'
{"kuryr_tempest_plugin/tests/scenario/test_port_pool.py":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"6f49e709be9785eb299be45381acf84b00ebac13","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        ports_pool_batch \u003d int(self.PORTS_POOL_DEFAULT_DICT["},{"line_number":140,"context_line":"                               \u0027ports_pool_batch\u0027])"},{"line_number":141,"context_line":"        ports_pool_min \u003d int(self.PORTS_POOL_DEFAULT_DICT[\u0027ports_pool_min\u0027])"},{"line_number":142,"context_line":"        num_pods \u003d ports_pool_batch - ports_pool_min"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if num_pods \u003c 3:"},{"line_number":145,"context_line":"            num_ports_expected \u003d ports_pool_batch * 2 + 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_99d44beb","line":142,"range":{"start_line":142,"start_character":7,"end_line":142,"end_character":16},"updated":"2019-10-24 09:06:34.000000000","message":"don\u0027t like the name, it\u0027s free_ports_after_batch or something like this","commit_id":"625b44e896f4990977fa924462453e4e5ff099af"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2b7bda8e8e9603af3a5ce0b00129c4c8ad6e4618","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        ports_pool_min \u003d int(self.PORTS_POOL_DEFAULT_DICT[\u0027ports_pool_min\u0027])"},{"line_number":142,"context_line":"        num_pods \u003d ports_pool_batch - ports_pool_min"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if num_pods \u003c 3:"},{"line_number":145,"context_line":"            num_ports_expected \u003d ports_pool_batch * 2 + 1"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            num_ports_expected \u003d ports_pool_batch + 1"},{"line_number":148,"context_line":"        self.assertEqual(num_ports_expected, updated3_port_list_num)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # check connectivity between pods"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b70cab39","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":53},"updated":"2019-10-24 12:16:22.000000000","message":"I don\u0027t get this, this needs a comment","commit_id":"625b44e896f4990977fa924462453e4e5ff099af"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"c22470cb08c6919012ca066636b49cb7d59d94b8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        ports_pool_min \u003d int(self.PORTS_POOL_DEFAULT_DICT[\u0027ports_pool_min\u0027])"},{"line_number":142,"context_line":"        num_pods \u003d ports_pool_batch - ports_pool_min"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if num_pods \u003c 3:"},{"line_number":145,"context_line":"            num_ports_expected \u003d ports_pool_batch * 2 + 1"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            num_ports_expected \u003d ports_pool_batch + 1"},{"line_number":148,"context_line":"        self.assertEqual(num_ports_expected, updated3_port_list_num)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # check connectivity between pods"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5020ddf7","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":53},"in_reply_to":"3fa7e38b_30868167","updated":"2019-10-24 13:52:44.000000000","message":"Done. Hopefully it will be clear enough","commit_id":"625b44e896f4990977fa924462453e4e5ff099af"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ce317c22d0beab91113d869a144d34071916cdc7","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        ports_pool_min \u003d int(self.PORTS_POOL_DEFAULT_DICT[\u0027ports_pool_min\u0027])"},{"line_number":142,"context_line":"        num_pods \u003d ports_pool_batch - ports_pool_min"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if num_pods \u003c 3:"},{"line_number":145,"context_line":"            num_ports_expected \u003d ports_pool_batch * 2 + 1"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            num_ports_expected \u003d ports_pool_batch + 1"},{"line_number":148,"context_line":"        self.assertEqual(num_ports_expected, updated3_port_list_num)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # check connectivity between pods"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_30868167","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":53},"in_reply_to":"3fa7e38b_97dbaf7b","updated":"2019-10-24 13:43:02.000000000","message":"this must be stated on a comment, and perhaps num_pods should be renamed to anything more meaningful","commit_id":"625b44e896f4990977fa924462453e4e5ff099af"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"a82cdc2432e6790b4e779ceb45270bf9f43781e1","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        ports_pool_min \u003d int(self.PORTS_POOL_DEFAULT_DICT[\u0027ports_pool_min\u0027])"},{"line_number":142,"context_line":"        num_pods \u003d ports_pool_batch - ports_pool_min"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if num_pods \u003c 3:"},{"line_number":145,"context_line":"            num_ports_expected \u003d ports_pool_batch * 2 + 1"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            num_ports_expected \u003d ports_pool_batch + 1"},{"line_number":148,"context_line":"        self.assertEqual(num_ports_expected, updated3_port_list_num)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # check connectivity between pods"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_97dbaf7b","line":147,"range":{"start_line":144,"start_character":0,"end_line":147,"end_character":53},"in_reply_to":"3fa7e38b_b70cab39","updated":"2019-10-24 12:20:56.000000000","message":"The test as it is dones\u0027t work when batch\u003d3 and min\u003d1. The num ports is 7 where the test expects it to be 4. So I adjust it to the case where new ports are created because the min ports has been reached at this stage.","commit_id":"625b44e896f4990977fa924462453e4e5ff099af"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6bbf5ab2b7a87169872163a2c8f92485dcb73bf7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            namespace\u003dnamespace_name,"},{"line_number":133,"context_line":"            affinity\u003d{\u0027podAffinity\u0027: consts.POD_AFFINITY})"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Check the number of pods based on the values of the ports_pool_batch"},{"line_number":136,"context_line":"        # and ports_pool_min. If the difference between the values is greater"},{"line_number":137,"context_line":"        # than two it means that once we create another pod ports_pool_patch"},{"line_number":138,"context_line":"        # number of ports will be created, If the difference is more than two"},{"line_number":139,"context_line":"        # no new ports will be created once we create a new pod"},{"line_number":140,"context_line":"        updated3_port_list_num \u003d len(self.os_admin.ports_client.list_ports("},{"line_number":141,"context_line":"            fixed_ips\u003d\u0027subnet_id\u003d%s\u0027 % subnet_id)[\u0027ports\u0027])"},{"line_number":142,"context_line":"        ports_pool_batch \u003d int(self.PORTS_POOL_DEFAULT_DICT["}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7f1efa74","line":139,"range":{"start_line":135,"start_character":0,"end_line":139,"end_character":63},"updated":"2019-10-25 07:44:18.000000000","message":"Thanks! it is much clear now!","commit_id":"3e0c9f9a6fcbea9500f052581dc92061a3faba70"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6bbf5ab2b7a87169872163a2c8f92485dcb73bf7","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        ports_pool_batch \u003d int(self.PORTS_POOL_DEFAULT_DICT["},{"line_number":143,"context_line":"                               \u0027ports_pool_batch\u0027])"},{"line_number":144,"context_line":"        ports_pool_min \u003d int(self.PORTS_POOL_DEFAULT_DICT[\u0027ports_pool_min\u0027])"},{"line_number":145,"context_line":"        num_pods \u003d ports_pool_batch - ports_pool_min"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if num_pods \u003c 3:"},{"line_number":148,"context_line":"            num_ports_expected \u003d ports_pool_batch * 2 + 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e2fd7108","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":17},"updated":"2019-10-25 07:44:18.000000000","message":"perhaps can be renamed as \u0027population_threshold\u0027 or trigger or something in that line","commit_id":"3e0c9f9a6fcbea9500f052581dc92061a3faba70"}]}