)]}'
{"kuryr_tempest_plugin/tests/scenario/test_namespace.py":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"292a272ddd673d6f7e406d9fd56badff05ca8892","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def test_namespace_sg_isolation(self):"},{"line_number":94,"context_line":"        if CONF.kuryr_kubernetes.network_policy_enabled:"},{"line_number":95,"context_line":"            raise self.skipException(\u0027Network policy should not be enabled for\u0027"},{"line_number":96,"context_line":"                                     \u0027 Namespace isolation tests to run\u0027)"},{"line_number":97,"context_line":"        # Check security group resources are created"},{"line_number":98,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":99,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0703d443","line":96,"updated":"2019-10-29 09:39:34.000000000","message":"I would rephrase - something like, No need to run Namespace Isolation when NP is enabled","commit_id":"5f3a039eb1a6c7c9756464cb98da4099dd70925c"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"292a272ddd673d6f7e406d9fd56badff05ca8892","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def test_namespace_sg_svc_isolation(self):"},{"line_number":184,"context_line":"        if CONF.kuryr_kubernetes.network_policy_enabled:"},{"line_number":185,"context_line":"            raise self.skipException(\u0027Network policy should not be enabled for\u0027"},{"line_number":186,"context_line":"                                     \u0027 Namespace isolation tests to run\u0027)"},{"line_number":187,"context_line":"        # Check security group resources are created"},{"line_number":188,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":189,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_27005034","line":186,"updated":"2019-10-29 09:39:34.000000000","message":"same as before","commit_id":"5f3a039eb1a6c7c9756464cb98da4099dd70925c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"80576c45b843ff9f014689d374d7d08cec8c77aa","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u0027bdde5441-1b44-449d-a125-b5fdbfb1a2a9\u0027)"},{"line_number":93,"context_line":"    def test_namespace_sg_isolation(self):"},{"line_number":94,"context_line":"        if CONF.kuryr_kubernetes.network_policy_enabled:"},{"line_number":95,"context_line":"            raise self.skipException(\u0027No need to run Namespace Isolation when \u0027"},{"line_number":96,"context_line":"                                     \u0027NP is enabled\u0027)"},{"line_number":97,"context_line":"        # Check security group resources are created"},{"line_number":98,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":99,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2d0fd12e","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":53},"updated":"2019-10-29 11:14:57.000000000","message":"this is not needed, the complete test_namespace isolation must be skipt in case of NetworkPolicies being enabled. If this is executed, that means the skip checks are wrong","commit_id":"d9ec84f2a4b48b603e2a40af636c2044108fad99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5b778c543b16508811ae5fb7e2b3183991351d3f","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u0027bdde5441-1b44-449d-a125-b5fdbfb1a2a9\u0027)"},{"line_number":93,"context_line":"    def test_namespace_sg_isolation(self):"},{"line_number":94,"context_line":"        if CONF.kuryr_kubernetes.network_policy_enabled:"},{"line_number":95,"context_line":"            raise self.skipException(\u0027No need to run Namespace Isolation when \u0027"},{"line_number":96,"context_line":"                                     \u0027NP is enabled\u0027)"},{"line_number":97,"context_line":"        # Check security group resources are created"},{"line_number":98,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":99,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cde15d2d","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":53},"in_reply_to":"3fa7e38b_2d0fd12e","updated":"2019-10-29 11:27:23.000000000","message":"sorry, please dismiss. I see the test at line 46 can be executed with NPs","commit_id":"d9ec84f2a4b48b603e2a40af636c2044108fad99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"aee15beae94f0df6c0222d1d45f6e11a298a1a4a","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u0027bdde5441-1b44-449d-a125-b5fdbfb1a2a9\u0027)"},{"line_number":93,"context_line":"    def test_namespace_sg_isolation(self):"},{"line_number":94,"context_line":"        if CONF.kuryr_kubernetes.network_policy_enabled:"},{"line_number":95,"context_line":"            raise self.skipException(\u0027No need to run Namespace Isolation when \u0027"},{"line_number":96,"context_line":"                                     \u0027NP is enabled\u0027)"},{"line_number":97,"context_line":"        # Check security group resources are created"},{"line_number":98,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":99,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c6afdbe0","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":53},"updated":"2019-10-31 08:51:57.000000000","message":"I would do it the other way around... As this is about namespace isolation feature, I would raise the skipException if namespace_enabled is not set","commit_id":"03b1889aedeb30c6c76e1f452f3bcf23c343905a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"aee15beae94f0df6c0222d1d45f6e11a298a1a4a","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @decorators.idempotent_id(\u0027b43f5421-1244-449d-a125-b5fddfb1a2a9\u0027)"},{"line_number":183,"context_line":"    def test_namespace_sg_svc_isolation(self):"},{"line_number":184,"context_line":"        if CONF.kuryr_kubernetes.network_policy_enabled:"},{"line_number":185,"context_line":"            raise self.skipException(\u0027No need to run Namespace Isolation when \u0027"},{"line_number":186,"context_line":"                                     \u0027NP is enabled\u0027)"},{"line_number":187,"context_line":"        # Check security group resources are created"},{"line_number":188,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":189,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e6aa17d0","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":53},"updated":"2019-10-31 08:51:57.000000000","message":"ditto","commit_id":"03b1889aedeb30c6c76e1f452f3bcf23c343905a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a7e800dc522acf72d5579b8c91a90b51d21560ee","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(TestNamespaceScenario, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.kuryr_kubernetes.subnet_per_namespace:"},{"line_number":38,"context_line":"            raise cls.skipException(\u0027Namespace driver and handler must be \u0027"},{"line_number":39,"context_line":"                                    \u0027enabled to run this tests\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_39005001","line":39,"range":{"start_line":38,"start_character":37,"end_line":39,"end_character":63},"updated":"2019-10-31 09:58:48.000000000","message":"update the message. We need the namespace handler and the namespace subnet driver, regardless of the security group driver","commit_id":"6c74dbd4b3572c57598ad44aebf05d440d93315f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9435d36fa854b775124132fae66731395be730e3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def skip_checks(cls):"},{"line_number":36,"context_line":"        super(TestNamespaceScenario, cls).skip_checks()"},{"line_number":37,"context_line":"        if not CONF.kuryr_kubernetes.subnet_per_namespace:"},{"line_number":38,"context_line":"            raise cls.skipException(\u0027Namespace driver and handler must be \u0027"},{"line_number":39,"context_line":"                                    \u0027enabled to run this tests\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_3113635e","line":39,"range":{"start_line":38,"start_character":37,"end_line":39,"end_character":63},"in_reply_to":"3fa7e38b_39005001","updated":"2019-11-04 08:53:40.000000000","message":"Done","commit_id":"6c74dbd4b3572c57598ad44aebf05d440d93315f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a7e800dc522acf72d5579b8c91a90b51d21560ee","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def test_namespace_sg_isolation(self):"},{"line_number":94,"context_line":"        if not CONF.kuryr_kubernetes.namespace_enabled:"},{"line_number":95,"context_line":"            raise self.skipException(\u0027No need to run Namespace Isolation when \u0027"},{"line_number":96,"context_line":"                                     \u0027Namespace driver is not enabled\u0027)"},{"line_number":97,"context_line":"        # Check security group resources are created"},{"line_number":98,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":99,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_c6603b04","line":96,"range":{"start_line":96,"start_character":37,"end_line":96,"end_character":54},"updated":"2019-10-31 09:58:48.000000000","message":"perhaps worth to add information about what driver. No need to run then when security_group_driver is not namespace","commit_id":"6c74dbd4b3572c57598ad44aebf05d440d93315f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"9435d36fa854b775124132fae66731395be730e3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def test_namespace_sg_isolation(self):"},{"line_number":94,"context_line":"        if not CONF.kuryr_kubernetes.namespace_enabled:"},{"line_number":95,"context_line":"            raise self.skipException(\u0027No need to run Namespace Isolation when \u0027"},{"line_number":96,"context_line":"                                     \u0027Namespace driver is not enabled\u0027)"},{"line_number":97,"context_line":"        # Check security group resources are created"},{"line_number":98,"context_line":"        ns1_name, ns1 \u003d self.create_namespace()"},{"line_number":99,"context_line":"        ns2_name, ns2 \u003d self.create_namespace()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_510e1f32","line":96,"range":{"start_line":96,"start_character":37,"end_line":96,"end_character":54},"in_reply_to":"3fa7e38b_c6603b04","updated":"2019-11-04 08:53:40.000000000","message":"Done","commit_id":"6c74dbd4b3572c57598ad44aebf05d440d93315f"}]}