)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"1af882290b1e3096f8cf9414988b1307ecde082d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maysa de Macedo Souza \u003cmaysa.macedo95@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-04 15:35:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure correct failure message is checked on CRD validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The error message retuned when a CRD is not validated has changed"},{"line_number":10,"context_line":"on Kubernetes 1.16. We should also update the NP tempests tests"},{"line_number":11,"context_line":"to match it, as the gate is using Kubernetes 1.16."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4ed2bdbbc664579689763f2759741b0efced6db6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_3231175a","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":50},"updated":"2019-11-05 07:52:06.000000000","message":"The general remark: All crd_knp tests are not scenario tests, so they should not be under scenario.\nCould you please move them?","commit_id":"884b9b125dee025652d9b84005c2bf38bc06657e"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"11d41843e61450af3d482f2fbff888c28f25aecc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maysa de Macedo Souza \u003cmaysa.macedo95@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-04 15:35:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure correct failure message is checked on CRD validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The error message retuned when a CRD is not validated has changed"},{"line_number":10,"context_line":"on Kubernetes 1.16. We should also update the NP tempests tests"},{"line_number":11,"context_line":"to match it, as the gate is using Kubernetes 1.16."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4ed2bdbbc664579689763f2759741b0efced6db6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_ad312cef","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":50},"in_reply_to":"3fa7e38b_3231175a","updated":"2019-11-05 08:26:46.000000000","message":"Why they are not? We need to ensure they are created/updated/deleted accordingly to NP actions","commit_id":"884b9b125dee025652d9b84005c2bf38bc06657e"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"acaec02cc02ccc461ffaa5bd8f3cd23748064751","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maysa de Macedo Souza \u003cmaysa.macedo95@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-04 15:35:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure correct failure message is checked on CRD validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The error message retuned when a CRD is not validated has changed"},{"line_number":10,"context_line":"on Kubernetes 1.16. We should also update the NP tempests tests"},{"line_number":11,"context_line":"to match it, as the gate is using Kubernetes 1.16."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4ed2bdbbc664579689763f2759741b0efced6db6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_ad8dac7c","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":50},"in_reply_to":"3fa7e38b_ad312cef","updated":"2019-11-05 08:42:45.000000000","message":"In tempest the scenario tests are real scenarios, usually it\u0027s an environment creation and then testing the feature,\nlike we create NP apply it, test the connectivity and so on.\n\nThis specific test is not in this category","commit_id":"884b9b125dee025652d9b84005c2bf38bc06657e"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b8b4c55d1dcc17edbb4a7eb7c6a0a7a7f300fa8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maysa de Macedo Souza \u003cmaysa.macedo95@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-04 15:35:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure correct failure message is checked on CRD validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The error message retuned when a CRD is not validated has changed"},{"line_number":10,"context_line":"on Kubernetes 1.16. We should also update the NP tempests tests"},{"line_number":11,"context_line":"to match it, as the gate is using Kubernetes 1.16."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4ed2bdbbc664579689763f2759741b0efced6db6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_6d0574c1","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":50},"in_reply_to":"3fa7e38b_ad8dac7c","updated":"2019-11-05 08:50:19.000000000","message":"Please take a look on tempest example - tempest/api/network/test_floating_ips.py, looks similar but sits under api and not scenario section","commit_id":"884b9b125dee025652d9b84005c2bf38bc06657e"}],"kuryr_tempest_plugin/tests/scenario/test_namespace.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f6e612bd65a86347fd32d249b3e832ae8929a6cf","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            error_body \u003d json.loads(e.body)"},{"line_number":336,"context_line":"            error_causes \u003d error_body[\u0027details\u0027][\u0027causes\u0027]"},{"line_number":337,"context_line":"            err_msg_cause \u003d error_causes[0].get(\u0027message\u0027, \"\")"},{"line_number":338,"context_line":"            err_field_cause \u003d error_causes[0].get(\u0027field\u0027, \"\")"},{"line_number":339,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":340,"context_line":"                self.assertTrue(field in"},{"line_number":341,"context_line":"                                err_field_cause)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_80b0238d","line":338,"range":{"start_line":338,"start_character":59,"end_line":338,"end_character":61},"updated":"2019-11-18 10:00:50.000000000","message":"[]?","commit_id":"ca6398c1b727309b29e67c2ddc4724fd3f2a0fe7"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"bc9417d0b8ccbda5c27fa89faa47f0367614a8c6","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            error_body \u003d json.loads(e.body)"},{"line_number":336,"context_line":"            error_causes \u003d error_body[\u0027details\u0027][\u0027causes\u0027]"},{"line_number":337,"context_line":"            err_msg_cause \u003d error_causes[0].get(\u0027message\u0027, \"\")"},{"line_number":338,"context_line":"            err_field_cause \u003d error_causes[0].get(\u0027field\u0027, \"\")"},{"line_number":339,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":340,"context_line":"                self.assertTrue(field in"},{"line_number":341,"context_line":"                                err_field_cause)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_a6d9b8f4","line":338,"range":{"start_line":338,"start_character":59,"end_line":338,"end_character":61},"in_reply_to":"3fa7e38b_60ff2702","updated":"2019-11-18 10:34:47.000000000","message":"then you will need to do get(\u0027field\u0027, \"[]\"), right? otherwise the if at linke 339 won\u0027t work as expected, right?","commit_id":"ca6398c1b727309b29e67c2ddc4724fd3f2a0fe7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4f265ac22591c55623388228d25e5447ea3d7f3a","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            error_body \u003d json.loads(e.body)"},{"line_number":336,"context_line":"            error_causes \u003d error_body[\u0027details\u0027][\u0027causes\u0027]"},{"line_number":337,"context_line":"            err_msg_cause \u003d error_causes[0].get(\u0027message\u0027, \"\")"},{"line_number":338,"context_line":"            err_field_cause \u003d error_causes[0].get(\u0027field\u0027, \"\")"},{"line_number":339,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":340,"context_line":"                self.assertTrue(field in"},{"line_number":341,"context_line":"                                err_field_cause)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_60ff2702","line":338,"range":{"start_line":338,"start_character":59,"end_line":338,"end_character":61},"in_reply_to":"3fa7e38b_80b0238d","updated":"2019-11-18 10:06:16.000000000","message":"Nop. It\u0027s a string. \n\n\"field\":\"[]\"","commit_id":"ca6398c1b727309b29e67c2ddc4724fd3f2a0fe7"}],"kuryr_tempest_plugin/tests/scenario/test_network_policy.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"02a1f40c327f1cd7a2cb99f5a15a68a04de6882e","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        knp_obj \u003d self._get_knp_obj(np_name, sg_rule)"},{"line_number":256,"context_line":"        error_msg \u003d \u0027Required value\u0027"},{"line_number":257,"context_line":"        field \u003d \u0027security_group_rule.id\u0027"},{"line_number":258,"context_line":"        self._create_kuryr_net_policy_crd_obj(knp_obj, error_msg, field)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @decorators.idempotent_id(\u002747f0e412-3e13-40b2-93e5-503790df870b\u0027)"},{"line_number":261,"context_line":"    def test_create_knp_crd_with_networkpolicy_spec_wrong_type(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_12c73b47","line":258,"range":{"start_line":258,"start_character":66,"end_line":258,"end_character":71},"updated":"2019-11-05 07:39:51.000000000","message":"field\u003dfield? otherwise it may be taken as namespace value, right?","commit_id":"884b9b125dee025652d9b84005c2bf38bc06657e"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96108c1f2f14e86eaee958b6599b94cef410c3ec","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            error_body \u003d json.loads(e.body)"},{"line_number":360,"context_line":"            error_causes \u003d error_body[\u0027details\u0027][\u0027causes\u0027]"},{"line_number":361,"context_line":"            err_msg_cause \u003d error_causes[0][\u0027message\u0027]"},{"line_number":362,"context_line":"            err_field_cause \u003d error_causes[0][\u0027field\u0027]"},{"line_number":363,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":364,"context_line":"                self.assertTrue(field in"},{"line_number":365,"context_line":"                                err_field_cause)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_25f4e15a","line":362,"range":{"start_line":362,"start_character":12,"end_line":362,"end_character":54},"updated":"2019-11-18 08:50:11.000000000","message":"was there a \u0027field\u0027 before? not sure if better to rewrite it as:\nerr_field_cause \u003d error_causes[0].get(\u0027field\u0027, [])","commit_id":"4b8ae9e15fc1837ae696c632d690ab59c91e74fb"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e81d1a96de884e1e8dc6bc72c09f78b862fd0f0d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            error_body \u003d json.loads(e.body)"},{"line_number":360,"context_line":"            error_causes \u003d error_body[\u0027details\u0027][\u0027causes\u0027]"},{"line_number":361,"context_line":"            err_msg_cause \u003d error_causes[0][\u0027message\u0027]"},{"line_number":362,"context_line":"            err_field_cause \u003d error_causes[0][\u0027field\u0027]"},{"line_number":363,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":364,"context_line":"                self.assertTrue(field in"},{"line_number":365,"context_line":"                                err_field_cause)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_c0513b0f","line":362,"range":{"start_line":362,"start_character":12,"end_line":362,"end_character":54},"in_reply_to":"3fa7e38b_25f4e15a","updated":"2019-11-18 09:10:30.000000000","message":"Yes. There was a field before, but empty. This was probably was a bug in k8s and they fixed. But, it\u0027s safer as you proposed, gonna update that.","commit_id":"4b8ae9e15fc1837ae696c632d690ab59c91e74fb"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f6e612bd65a86347fd32d249b3e832ae8929a6cf","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            error_body \u003d json.loads(e.body)"},{"line_number":360,"context_line":"            error_causes \u003d error_body[\u0027details\u0027][\u0027causes\u0027]"},{"line_number":361,"context_line":"            err_msg_cause \u003d error_causes[0].get(\u0027message\u0027, \"\")"},{"line_number":362,"context_line":"            err_field_cause \u003d error_causes[0].get(\u0027field\u0027, \"\")"},{"line_number":363,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":364,"context_line":"                self.assertTrue(field in"},{"line_number":365,"context_line":"                                err_field_cause)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_60a3a744","line":362,"range":{"start_line":362,"start_character":59,"end_line":362,"end_character":61},"updated":"2019-11-18 10:00:50.000000000","message":"[]","commit_id":"ca6398c1b727309b29e67c2ddc4724fd3f2a0fe7"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0f895d2477056efe2b4473eb3b0cd12823d0854f","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            err_msg_cause \u003d error_causes[0].get(\u0027message\u0027, \"\")"},{"line_number":362,"context_line":"            err_field_cause \u003d error_causes[0].get(\u0027field\u0027, \"[]\")"},{"line_number":363,"context_line":"            if err_field_cause !\u003d \"[]\":"},{"line_number":364,"context_line":"                self.assertTrue(field in"},{"line_number":365,"context_line":"                                err_field_cause)"},{"line_number":366,"context_line":"            else:"},{"line_number":367,"context_line":"                self.assertTrue(error_msg in err_msg_cause)"},{"line_number":368,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_bb153fe8","line":365,"range":{"start_line":364,"start_character":0,"end_line":365,"end_character":48},"updated":"2019-11-19 09:45:38.000000000","message":"No need to wrap this, it seems.","commit_id":"b702a0697aedc5c06df1ed271fdf3bd13db55df9"}]}