)]}'
{"kuryr_tempest_plugin/tests/scenario/test_service.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5b9a5319cc813e23fa661a85a01689f3ae254619","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        # NOTE(ltomasbo): Using LoadBalancer type to avoid namespace isolation"},{"line_number":116,"context_line":"        # restrictions as this test targets svc udp testing and not the"},{"line_number":117,"context_line":"        # isolation"},{"line_number":118,"context_line":"        self.create_setup_for_service_test(spec_type\u003d\"LoadBalancer\","},{"line_number":119,"context_line":"                                           protocol\u003d\"UDP\", port\u003d90,"},{"line_number":120,"context_line":"                                           target_port\u003d9090)"},{"line_number":121,"context_line":"        # NOTE(ltomasbo): Ensure usage of svc clusterIP IP instead of the FIP"},{"line_number":122,"context_line":"        # as the focus of this test is not to check FIP connectivity."},{"line_number":123,"context_line":"        clusterip_svc_ip \u003d self.get_service_ip(self.service_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7afc08b5","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":60},"updated":"2019-11-11 13:11:26.000000000","message":"this also needs to wait, right?","commit_id":"dd6d99248fe25e2e27188eb7216d88c5b8a9f63d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"11c62db702a294b733b87f26c9a1472af5e36b79","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        # NOTE(ltomasbo): Using LoadBalancer type to avoid namespace isolation"},{"line_number":105,"context_line":"        # restrictions as this test targets svc udp testing and not the"},{"line_number":106,"context_line":"        # isolation"},{"line_number":107,"context_line":"        self.create_setup_for_service_test(spec_type\u003d\"LoadBalancer\","},{"line_number":108,"context_line":"                                           protocol\u003d\"UDP\", port\u003d90,"},{"line_number":109,"context_line":"                                           target_port\u003d9090)"},{"line_number":110,"context_line":"        # NOTE(ltomasbo): Ensure usage of svc clusterIP IP instead of the FIP"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_8b6491b4","line":107,"range":{"start_line":107,"start_character":54,"end_line":107,"end_character":67},"updated":"2019-11-21 11:46:33.000000000","message":"perhaps no need to make this one loadbalancer type. You can use the same as for the other cluster type here I suppose, similar to what there is on lines L40-46","commit_id":"0906a264a628e57484d2c9e55d20c75e583ce75a"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"293e56520c9cbbc676e5fc1b365bc3f571a003e3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        # NOTE(ltomasbo): Using LoadBalancer type to avoid namespace isolation"},{"line_number":105,"context_line":"        # restrictions as this test targets svc udp testing and not the"},{"line_number":106,"context_line":"        # isolation"},{"line_number":107,"context_line":"        self.create_setup_for_service_test(spec_type\u003d\"LoadBalancer\","},{"line_number":108,"context_line":"                                           protocol\u003d\"UDP\", port\u003d90,"},{"line_number":109,"context_line":"                                           target_port\u003d9090)"},{"line_number":110,"context_line":"        # NOTE(ltomasbo): Ensure usage of svc clusterIP IP instead of the FIP"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_2bbb08c4","line":107,"range":{"start_line":107,"start_character":54,"end_line":107,"end_character":67},"in_reply_to":"3fa7e38b_157989fa","updated":"2019-11-22 11:04:12.000000000","message":"Done","commit_id":"0906a264a628e57484d2c9e55d20c75e583ce75a"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"68a15db7936be041464203ca8c84a5a83b8d4e68","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        # NOTE(ltomasbo): Using LoadBalancer type to avoid namespace isolation"},{"line_number":105,"context_line":"        # restrictions as this test targets svc udp testing and not the"},{"line_number":106,"context_line":"        # isolation"},{"line_number":107,"context_line":"        self.create_setup_for_service_test(spec_type\u003d\"LoadBalancer\","},{"line_number":108,"context_line":"                                           protocol\u003d\"UDP\", port\u003d90,"},{"line_number":109,"context_line":"                                           target_port\u003d9090)"},{"line_number":110,"context_line":"        # NOTE(ltomasbo): Ensure usage of svc clusterIP IP instead of the FIP"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_f6796881","line":107,"range":{"start_line":107,"start_character":54,"end_line":107,"end_character":67},"in_reply_to":"3fa7e38b_8b6491b4","updated":"2019-11-21 13:46:16.000000000","message":"No need or must it changed?","commit_id":"0906a264a628e57484d2c9e55d20c75e583ce75a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"09f5d3a40a8db270a133033d7cdcc662089d4379","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        # NOTE(ltomasbo): Using LoadBalancer type to avoid namespace isolation"},{"line_number":105,"context_line":"        # restrictions as this test targets svc udp testing and not the"},{"line_number":106,"context_line":"        # isolation"},{"line_number":107,"context_line":"        self.create_setup_for_service_test(spec_type\u003d\"LoadBalancer\","},{"line_number":108,"context_line":"                                           protocol\u003d\"UDP\", port\u003d90,"},{"line_number":109,"context_line":"                                           target_port\u003d9090)"},{"line_number":110,"context_line":"        # NOTE(ltomasbo): Ensure usage of svc clusterIP IP instead of the FIP"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_157989fa","line":107,"range":{"start_line":107,"start_character":54,"end_line":107,"end_character":67},"in_reply_to":"3fa7e38b_f6796881","updated":"2019-11-22 08:56:33.000000000","message":"Well, no strong opinion, but why making it LoadBalancer type? if there is no reason for it(previously was due to checking connectivity from outside but now you are changing that to check it from a pod), I think it should be a clusterIP type.","commit_id":"0906a264a628e57484d2c9e55d20c75e583ce75a"}]}