)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"b2b148c85e3b0b2853a7adf4446b19b3ef6a57b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-20 13:50:59 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a sleep of 120 seconds after command of NP creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9b234386d861dfd35ed2062f7951dbe15538a034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_13c4685f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"updated":"2019-11-20 11:58:27.000000000","message":"Please explain why it\u0027s needed","commit_id":"8471647e99e9b9e175c56545b7a549559a895bcf"}],"kuryr_tempest_plugin/tests/scenario/test_network_policy.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"06e0f09f1db3e210a7d7ddeb228275f5f870ccca","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_100e8ce3","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"updated":"2019-11-21 10:52:43.000000000","message":"Actually, this test is not checking connectivity, just that the objects are created and there is a loop for that. If TIMEOUT_PERIOD is not enough, then that value is the one you need to increase so taht loop at lines 59-67 retries during more time","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"42ddb76be0f72516eeb47c1cb31a0e7d4b2b0136","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_106c4c05","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_100e8ce3","updated":"2019-11-21 11:15:02.000000000","message":"The timeout you mention is for getting CRDs.\nIn our case you get CRDs, but SG is still not updated, so you need some additional timeout","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ef541576374dc4a8a18a5c39ee9b1894d96b167e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_562b9c80","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_106c4c05","updated":"2019-11-21 12:19:43.000000000","message":"No, but that is needed to check the connectivity as you need to wait for the security groups to be enforced. Here you are just checking the crd object creating and its information. So the problem you have is that TIMEOUT_PERIOD is 20, and perhaps you need to increase that to 30 or 60","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5c0c2d9a9e9034d01998c947cbe2b2cec919d681","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d69765ea","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_2ab1b48f","updated":"2019-11-25 09:18:20.000000000","message":"if there is a problem with that... then it may be a bug. The kuryrnetpolicy CRD is created after the SG and SG rules. So, if the CRD is there, the SG/SG-rules should be there. This sleep should not be here. You just need to wait enough time at the whille loop at L59-L67. And if that loop finishes without finding the crd, then the assertIsNotNone should trigger the error","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ddbb82c9cba7ec250a3eb2ed054404336b953015","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_66a4e7b9","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_5166462b","updated":"2019-11-21 14:46:30.000000000","message":"No... The problem you hit it later, but the sg creation is trigger after creating the NP, and then, once the kuryrnetpolicy_crd is created, the SG should have been created (as that information is there -- the sg id). The only reason waiting 120 here helps is because by the time you execute the while at linkes 59-67 it is already created. So, if this is nit enforcing that the rule is applied, and it is just checking the SG being created... you should just ensure that the loop at 59-67 iterates enough times, perhaps 30 or 60 seconds, or maybe even the same 120 that you have there, but you should not wait once the kuryr-netpolicy crd is created, so just increasing the TIMEOUT_PERIOD for something bigger than 20 should do it","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"bb94bd253a215ae43aac4a5f50cf39198937a6e4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5166462b","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_562b9c80","updated":"2019-11-21 13:42:57.000000000","message":"@Luis, there seems to be no need to increase the TIMEOUT_PERIOD as the test passes this steps of crds.The problem is in Lines 72-80 (sg rules creation).","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"6a1eeb18e396a9c8a058d5a3b33318cc7b818581","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        egress_ipblock_cidr\u003degress_ipblock,"},{"line_number":50,"context_line":"                                        ingress_port\u003d2500)"},{"line_number":51,"context_line":"        LOG.debug(\"Creating network policy %s\", np)"},{"line_number":52,"context_line":"        time.sleep(120)"},{"line_number":53,"context_line":"        self.addCleanup(self.delete_network_policy, np.metadata.name,"},{"line_number":54,"context_line":"                        namespace_name)"},{"line_number":55,"context_line":"        network_policy_name \u003d np.metadata.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2ab1b48f","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":23},"in_reply_to":"3fa7e38b_66a4e7b9","updated":"2019-11-24 07:40:12.000000000","message":"@Luis, the failures we see are not in SG group creation, but in SG rules creation. From what we saw sometimes we are missing ingress and sometimes egress rules","commit_id":"7567f92ac6df236a0a2734fc6a7433ff6935830b"}]}