)]}'
{"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b18b46f82afec9d6f86e0d2fd2e5afe6889566c6","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd_annotation\u003dTrue):"},{"line_number":566,"context_line":"        if not name:"},{"line_number":567,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-namespace\u0027)"},{"line_number":568,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"},{"line_number":569,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-network-crd\""},{"line_number":570,"context_line":"        else:"},{"line_number":571,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-net-crd\""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_e72cfe4b","line":569,"range":{"start_line":568,"start_character":0,"end_line":569,"end_character":73},"updated":"2020-03-12 16:34:10.000000000","message":"Uhm, this strikes me as the fact we\u0027ll still need update RBAC rights on namespace objects which seems an overkill to me. Will discuss that on the main patch.","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bd4546cc1b75957d55e3ee2838eee099d90e74ec","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd_annotation\u003dTrue):"},{"line_number":566,"context_line":"        if not name:"},{"line_number":567,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-namespace\u0027)"},{"line_number":568,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"},{"line_number":569,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-network-crd\""},{"line_number":570,"context_line":"        else:"},{"line_number":571,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-net-crd\""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_6da1cd95","line":569,"range":{"start_line":568,"start_character":0,"end_line":569,"end_character":73},"in_reply_to":"1fa4df85_0a035f0f","updated":"2020-03-12 18:00:15.000000000","message":"It is the same as before, but I believe it\u0027s a mistake that we annotate namespaces, check out my comments on the main patch. :)","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f8cf0377f2251ee02b47049fdfc8679ad9b84868","unresolved":false,"context_lines":[{"line_number":565,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd_annotation\u003dTrue):"},{"line_number":566,"context_line":"        if not name:"},{"line_number":567,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-namespace\u0027)"},{"line_number":568,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"},{"line_number":569,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-network-crd\""},{"line_number":570,"context_line":"        else:"},{"line_number":571,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-net-crd\""},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_0a035f0f","line":569,"range":{"start_line":568,"start_character":0,"end_line":569,"end_character":73},"in_reply_to":"1fa4df85_e72cfe4b","updated":"2020-03-12 16:57:32.000000000","message":"how is it different from before? namespace objects are cluster scope. We just changed the prefix of the annotation","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0401e419a1d10b2b63d4dffec08ed6a48da60176","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        namespace_obj \u003d cls.k8s_client.CoreV1Api().create_namespace("},{"line_number":571,"context_line":"            body\u003dnamespace)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        if not wait_for_crd_annotation:"},{"line_number":574,"context_line":"            return name, namespace_obj"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_f1a81ddc","line":573,"range":{"start_line":573,"start_character":15,"end_line":573,"end_character":38},"updated":"2020-03-14 22:30:40.000000000","message":"As this now applies to both kuryrnets and kuryrnetworks, maybe wait_for_crd_population would fit better.","commit_id":"92f1409bb3d68e8ecf172d20db4026f100ff0636"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"10f6905c395f692fc05c0904362b7c06759fcedf","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        namespace_obj \u003d cls.k8s_client.CoreV1Api().create_namespace("},{"line_number":571,"context_line":"            body\u003dnamespace)"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        if not wait_for_crd_annotation:"},{"line_number":574,"context_line":"            return name, namespace_obj"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_7148a886","line":573,"range":{"start_line":573,"start_character":15,"end_line":573,"end_character":38},"in_reply_to":"1fa4df85_f1a81ddc","updated":"2020-03-16 08:13:03.000000000","message":"Done","commit_id":"92f1409bb3d68e8ecf172d20db4026f100ff0636"}],"kuryr_tempest_plugin/tests/scenario/test_namespace.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b18b46f82afec9d6f86e0d2fd2e5afe6889566c6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_namespace(self):"},{"line_number":48,"context_line":"        # Check resources are created"},{"line_number":49,"context_line":"        namespace_name, namespace \u003d self.create_namespace()"},{"line_number":50,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"},{"line_number":51,"context_line":"            # NOTE(ltomasbo): if kuryrnetwork CRD is used, the namespace gets"},{"line_number":52,"context_line":"            # the annotation before the subnets are created, so we need to add"},{"line_number":53,"context_line":"            # some extra delay to ensure the networks are created"},{"line_number":54,"context_line":"            time.sleep(20)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        existing_namespaces \u003d [ns.metadata.name"},{"line_number":57,"context_line":"                               for ns in self.list_namespaces().items]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_07327aa8","line":54,"range":{"start_line":50,"start_character":0,"end_line":54,"end_character":26},"updated":"2020-03-12 16:34:10.000000000","message":"Why can\u0027t we just poll the CRD in the method above?","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f8cf0377f2251ee02b47049fdfc8679ad9b84868","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_namespace(self):"},{"line_number":48,"context_line":"        # Check resources are created"},{"line_number":49,"context_line":"        namespace_name, namespace \u003d self.create_namespace()"},{"line_number":50,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"},{"line_number":51,"context_line":"            # NOTE(ltomasbo): if kuryrnetwork CRD is used, the namespace gets"},{"line_number":52,"context_line":"            # the annotation before the subnets are created, so we need to add"},{"line_number":53,"context_line":"            # some extra delay to ensure the networks are created"},{"line_number":54,"context_line":"            time.sleep(20)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        existing_namespaces \u003d [ns.metadata.name"},{"line_number":57,"context_line":"                               for ns in self.list_namespaces().items]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_27aa1619","line":54,"range":{"start_line":50,"start_character":0,"end_line":54,"end_character":26},"in_reply_to":"1fa4df85_07327aa8","updated":"2020-03-12 16:57:32.000000000","message":"we will need to get it until the network/subnet  info is there","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bd4546cc1b75957d55e3ee2838eee099d90e74ec","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def test_namespace(self):"},{"line_number":48,"context_line":"        # Check resources are created"},{"line_number":49,"context_line":"        namespace_name, namespace \u003d self.create_namespace()"},{"line_number":50,"context_line":"        if CONF.kuryr_kubernetes.kuryrnetworks:"},{"line_number":51,"context_line":"            # NOTE(ltomasbo): if kuryrnetwork CRD is used, the namespace gets"},{"line_number":52,"context_line":"            # the annotation before the subnets are created, so we need to add"},{"line_number":53,"context_line":"            # some extra delay to ensure the networks are created"},{"line_number":54,"context_line":"            time.sleep(20)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        existing_namespaces \u003d [ns.metadata.name"},{"line_number":57,"context_line":"                               for ns in self.list_namespaces().items]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_ad97c53a","line":54,"range":{"start_line":50,"start_character":0,"end_line":54,"end_character":26},"in_reply_to":"1fa4df85_27aa1619","updated":"2020-03-12 18:00:15.000000000","message":"True, but it doesn\u0027t really differ from polling for annotation.","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b18b46f82afec9d6f86e0d2fd2e5afe6889566c6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                else:"},{"line_number":291,"context_line":"                    self.get_kuryr_net_crds(net_crd[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":292,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":293,"context_line":"                # NOTE(ltomasbo): Due to the use of finalizers, it may"},{"line_number":294,"context_line":"                # take some time after the CRD removal to delete the"},{"line_number":295,"context_line":"                # namespace object"},{"line_number":296,"context_line":"                time.sleep(10)"},{"line_number":297,"context_line":"                break"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        existing_namespaces \u003d [ns.metadata.name"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_271a1617","line":296,"range":{"start_line":293,"start_character":0,"end_line":296,"end_character":30},"updated":"2020-03-12 16:34:10.000000000","message":"Why isn\u0027t it better to just bump the sleep in line 285?","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f8cf0377f2251ee02b47049fdfc8679ad9b84868","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                else:"},{"line_number":291,"context_line":"                    self.get_kuryr_net_crds(net_crd[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":292,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":293,"context_line":"                # NOTE(ltomasbo): Due to the use of finalizers, it may"},{"line_number":294,"context_line":"                # take some time after the CRD removal to delete the"},{"line_number":295,"context_line":"                # namespace object"},{"line_number":296,"context_line":"                time.sleep(10)"},{"line_number":297,"context_line":"                break"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        existing_namespaces \u003d [ns.metadata.name"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c749c28b","line":296,"range":{"start_line":293,"start_character":0,"end_line":296,"end_character":30},"in_reply_to":"1fa4df85_271a1617","updated":"2020-03-12 16:57:32.000000000","message":"due to the break... it may be that the kuryr_network_crd got just removed when the check at line 288 is done, and then we need to wait a bit to ensure the namespace is cleanup","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0401e419a1d10b2b63d4dffec08ed6a48da60176","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                else:"},{"line_number":284,"context_line":"                    self.get_kuryr_net_crds(net_crd[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":285,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":286,"context_line":"                # NOTE(ltomasbo): Due to the use of finalizers, it may"},{"line_number":287,"context_line":"                # take some time after the CRD removal to delete the"},{"line_number":288,"context_line":"                # namespace object"},{"line_number":289,"context_line":"                time.sleep(15)"},{"line_number":290,"context_line":"                break"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        existing_namespaces \u003d [ns.metadata.name"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_718d0d7a","line":289,"range":{"start_line":286,"start_character":0,"end_line":289,"end_character":30},"updated":"2020-03-14 22:30:40.000000000","message":"Perhaps we could also keep retrying to check the non existence of the namespace, and timeout if the limit of attempts is reached.","commit_id":"92f1409bb3d68e8ecf172d20db4026f100ff0636"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"10f6905c395f692fc05c0904362b7c06759fcedf","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                else:"},{"line_number":284,"context_line":"                    self.get_kuryr_net_crds(net_crd[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":285,"context_line":"            except kubernetes.client.rest.ApiException:"},{"line_number":286,"context_line":"                # NOTE(ltomasbo): Due to the use of finalizers, it may"},{"line_number":287,"context_line":"                # take some time after the CRD removal to delete the"},{"line_number":288,"context_line":"                # namespace object"},{"line_number":289,"context_line":"                time.sleep(15)"},{"line_number":290,"context_line":"                break"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        existing_namespaces \u003d [ns.metadata.name"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_115ff441","line":289,"range":{"start_line":286,"start_character":0,"end_line":289,"end_character":30},"in_reply_to":"1fa4df85_718d0d7a","updated":"2020-03-16 08:13:03.000000000","message":"good idea!","commit_id":"92f1409bb3d68e8ecf172d20db4026f100ff0636"}],"kuryr_tempest_plugin/tests/scenario/test_network_policy.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b18b46f82afec9d6f86e0d2fd2e5afe6889566c6","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    @decorators.idempotent_id(\u002724577a9b-1d46-419b-8b60-da3c49d777c3\u0027)"},{"line_number":329,"context_line":"    def test_create_delete_network_policy_non_default_ns(self):"},{"line_number":330,"context_line":"        ns_name, ns \u003d self.create_namespace()"},{"line_number":331,"context_line":"        self.addCleanup(self.delete_namespace, ns_name)"},{"line_number":332,"context_line":"        match_labels \u003d {\u0027role\u0027: \u0027db\u0027}"},{"line_number":333,"context_line":"        np \u003d self.create_network_policy(match_labels\u003dmatch_labels,"},{"line_number":334,"context_line":"                                        namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c7e0e2fd","line":331,"range":{"start_line":331,"start_character":0,"end_line":331,"end_character":55},"updated":"2020-03-12 16:34:10.000000000","message":"+1","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f8cf0377f2251ee02b47049fdfc8679ad9b84868","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    @decorators.idempotent_id(\u002724577a9b-1d46-419b-8b60-da3c49d777c3\u0027)"},{"line_number":329,"context_line":"    def test_create_delete_network_policy_non_default_ns(self):"},{"line_number":330,"context_line":"        ns_name, ns \u003d self.create_namespace()"},{"line_number":331,"context_line":"        self.addCleanup(self.delete_namespace, ns_name)"},{"line_number":332,"context_line":"        match_labels \u003d {\u0027role\u0027: \u0027db\u0027}"},{"line_number":333,"context_line":"        np \u003d self.create_network_policy(match_labels\u003dmatch_labels,"},{"line_number":334,"context_line":"                                        namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_c73ea2d9","line":331,"range":{"start_line":331,"start_character":0,"end_line":331,"end_character":55},"in_reply_to":"1fa4df85_c7e0e2fd","updated":"2020-03-12 16:57:32.000000000","message":"yep, this was missing and I saw some leaks on my local env","commit_id":"af0e4959bc22ed13a03470cd65ad9e4f537d6da9"}]}