)]}'
{"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"6b2419785bb49259b7aa2e76dc3641688ec46cd1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    @classmethod"},{"line_number":153,"context_line":"    def create_pod(cls, name\u003dNone, labels\u003dNone, image\u003d\u0027kuryr/demo\u0027,"},{"line_number":154,"context_line":"                   namespace\u003d\"default\", annotations\u003dNone, wait_for_status\u003dTrue,"},{"line_number":155,"context_line":"                   timeout\u003d60, affinity\u003dNone):"},{"line_number":156,"context_line":"        if not name:"},{"line_number":157,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-pod\u0027)"},{"line_number":158,"context_line":"        pod \u003d cls.k8s_client.V1Pod()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_8541c7ab","line":155,"updated":"2020-03-09 11:54:29.000000000","message":"Not sure 60 is enough, anyway even if it is, it\u0027s better not to use 60 here, but to use specific const.\nThere is const.py with several parameters, so you can use one of those or create a new one there","commit_id":"9e1ccefdcfd1eb0b9de5855ec5cbb4201dea5a48"},{"author":{"_account_id":31631,"name":"Ramón Lobillo","email":"rlobillo@redhat.com","username":"rlobillo"},"change_message_id":"b00aaf9e7fe281e11578f3bf8400cf828bc100ff","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    @classmethod"},{"line_number":153,"context_line":"    def create_pod(cls, name\u003dNone, labels\u003dNone, image\u003d\u0027kuryr/demo\u0027,"},{"line_number":154,"context_line":"                   namespace\u003d\"default\", annotations\u003dNone, wait_for_status\u003dTrue,"},{"line_number":155,"context_line":"                   timeout\u003d60, affinity\u003dNone):"},{"line_number":156,"context_line":"        if not name:"},{"line_number":157,"context_line":"            name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-pod\u0027)"},{"line_number":158,"context_line":"        pod \u003d cls.k8s_client.V1Pod()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_4258a086","line":155,"in_reply_to":"1fa4df85_8541c7ab","updated":"2020-03-09 15:36:48.000000000","message":"Gate shows 60 is not enough. I have created the constant and increased the timeout to 120 seconds, same value used in restart_kuryr_controller method.","commit_id":"9e1ccefdcfd1eb0b9de5855ec5cbb4201dea5a48"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"edb66b33927d5296b84d1891b425915c49e83948","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":35,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":36,"context_line":"from tempest.scenario import manager"},{"line_number":37,"context_line":"import consts"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"CONF \u003d config.CONF"},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_e1574125","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":13},"updated":"2020-03-10 06:51:38.000000000","message":"You mean:\n\n  from kuryr_tempest_plugin.tests.scenario import consts","commit_id":"0ce588645dce13ccfe0f4d9ac85cbdf4e7175119"},{"author":{"_account_id":31631,"name":"Ramón Lobillo","email":"rlobillo@redhat.com","username":"rlobillo"},"change_message_id":"b3f19b69bb19ee8b2fd5631d29dc5b710128b374","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from tempest.lib.common.utils import test_utils"},{"line_number":35,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":36,"context_line":"from tempest.scenario import manager"},{"line_number":37,"context_line":"import consts"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"CONF \u003d config.CONF"},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_3c4d7c3d","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":13},"in_reply_to":"1fa4df85_e1574125","updated":"2020-03-10 07:35:15.000000000","message":"Done","commit_id":"0ce588645dce13ccfe0f4d9ac85cbdf4e7175119"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4d9b847c978f56c9479790d95f7fcc3c40021358","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                name,"},{"line_number":175,"context_line":"                namespace\u003dnamespace,"},{"line_number":176,"context_line":"                pod_status\u003d\u0027Running\u0027,"},{"line_number":177,"context_line":"                retries\u003dconsts.TIMEOUT_CREATE_POD)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return name, pod"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_7c97743b","line":177,"range":{"start_line":177,"start_character":24,"end_line":177,"end_character":49},"updated":"2020-03-10 07:54:03.000000000","message":"just a tiny nit, this is the number of retries rather than a timeout","commit_id":"74d9b70eeddd9cf7497bcec164d5b08cde603d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a6288a34a27f711bf185f8ae4b54915b3e00a4b0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                name,"},{"line_number":175,"context_line":"                namespace\u003dnamespace,"},{"line_number":176,"context_line":"                pod_status\u003d\u0027Running\u0027,"},{"line_number":177,"context_line":"                retries\u003dconsts.TIMEOUT_CREATE_POD)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return name, pod"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_3c41fca9","line":177,"range":{"start_line":177,"start_character":24,"end_line":177,"end_character":49},"in_reply_to":"1fa4df85_3cd33c06","updated":"2020-03-10 08:11:36.000000000","message":"yep, no strong opinion here. Just noticed that it is not time based (even though now it is approx 1 sec). And if someone later change the time.sleep(1) at line 207 to 2 seconds, then this will be misleading. As for the name, perhaps POD_STATUS_RETRIES or something like that. But as I said, no strong opinion here","commit_id":"74d9b70eeddd9cf7497bcec164d5b08cde603d91"},{"author":{"_account_id":31631,"name":"Ramón Lobillo","email":"rlobillo@redhat.com","username":"rlobillo"},"change_message_id":"4e1847a4eab8d51050ec0c43d528ac8e41ff80db","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                name,"},{"line_number":175,"context_line":"                namespace\u003dnamespace,"},{"line_number":176,"context_line":"                pod_status\u003d\u0027Running\u0027,"},{"line_number":177,"context_line":"                retries\u003dconsts.TIMEOUT_CREATE_POD)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        return name, pod"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_3cd33c06","line":177,"range":{"start_line":177,"start_character":24,"end_line":177,"end_character":49},"in_reply_to":"1fa4df85_7c97743b","updated":"2020-03-10 08:02:32.000000000","message":"As wait_for_pod_status checks the state every second, this is the maximum time that create_pod will wait for getting the \u0027Running\u0027 status. Dont you think it is clearer to define it as a timeout in this case? If not, can you please suggest other name?","commit_id":"74d9b70eeddd9cf7497bcec164d5b08cde603d91"}]}