)]}'
{"kuryr_tempest_plugin/config.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2aff2423ff0f9549f651d1ea0a1ca0b16731d4af","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    cfg.BoolOpt(\"ipv6\", default\u003dFalse,"},{"line_number":92,"context_line":"                help\u003d\"True if Kuryr is configured to use IPv6 subnets as pod \""},{"line_number":93,"context_line":"                     \"and service subnets.\"),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\"test_services_without_selector\", default\u003dTrue,"},{"line_number":95,"context_line":"                help\u003d\"Whether or not service without selector tests will be\""},{"line_number":96,"context_line":"                \"running\"),"},{"line_number":97,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_1549228a","line":94,"updated":"2020-11-09 10:31:39.000000000","message":"The config with value True needs to be set on the DevStack plugin on the Kuryr-Kubernetes repo [1] and a Depends-on needs to be included in the Kuryr-Kubernetes patch to this patch on the tempest. Consequently, the default value here should be set to False.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/master/devstack/plugin.sh#L958-L962","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c645f87bbef924e2e4ca11bc09527a0c19b8d71f","unresolved":true,"context_lines":[{"line_number":92,"context_line":"                help\u003d\"True if Kuryr is configured to use IPv6 subnets as pod \""},{"line_number":93,"context_line":"                     \"and service subnets.\"),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\"test_services_without_selector\", default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\"Whether or not service without selector tests will be\""},{"line_number":96,"context_line":"                \"running\"),"},{"line_number":97,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"f6612ab2_0f85f240","line":95,"range":{"start_line":95,"start_character":73,"end_line":95,"end_character":76},"updated":"2020-11-24 13:02:26.000000000","message":"You\u0027re missing space here on newline.","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"9de68ce829df90e8df403e61d914ea5fe26c0dcb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                help\u003d\"True if Kuryr is configured to use IPv6 subnets as pod \""},{"line_number":93,"context_line":"                     \"and service subnets.\"),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\"test_services_without_selector\", default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\"Whether or not service without selector tests will be\""},{"line_number":96,"context_line":"                \"running\"),"},{"line_number":97,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"effc763a_974dab53","line":95,"range":{"start_line":95,"start_character":73,"end_line":95,"end_character":76},"in_reply_to":"f6612ab2_0f85f240","updated":"2020-11-27 14:19:16.000000000","message":"Done","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"}],"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"9319006ecf027924e802d9c71f81bb8b1785a3ad","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                                        namespace\u003dnamespace)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    @classmethod"},{"line_number":648,"context_line":"    def create_setup_for_svc_without_selectors_test(cls, pod_num\u003d2,"},{"line_number":649,"context_line":"                                                    spec_type\u003d\"ClusterIP\","},{"line_number":650,"context_line":"                                                    protocol\u003d\"TCP\","},{"line_number":651,"context_line":"                                                    port\u003d80,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f65232a_d1cc26be","line":648,"updated":"2020-10-27 06:27:03.000000000","message":"This method is pretty specific for single test. It\u0027s not as generic as create_pod or create_service for instance. Perhaps a better solution would be to move it to test_service.TestServiceWithoutSelectorScenario and change the name to something a little bit shorter :)","commit_id":"67b97b3226c65febb015f04b9052bcd6bde8375f"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"250773d61c8c077919088cc0edbea3a5437266e9","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                                        namespace\u003dnamespace)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    @classmethod"},{"line_number":648,"context_line":"    def create_setup_for_svc_without_selectors_test(cls, pod_num\u003d2,"},{"line_number":649,"context_line":"                                                    spec_type\u003d\"ClusterIP\","},{"line_number":650,"context_line":"                                                    protocol\u003d\"TCP\","},{"line_number":651,"context_line":"                                                    port\u003d80,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_84ca6f17","line":648,"in_reply_to":"3f65232a_d1cc26be","updated":"2020-11-02 21:59:16.000000000","message":"I think in future, we will be adding more test for service without selectors, but I am not against to move it.\n\nAbout the name, I will definitely change it to something shorter, but for now, I have no idea what to try to correspond with the clean code/ how we are naming functions.","commit_id":"67b97b3226c65febb015f04b9052bcd6bde8375f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"539b8ceadf208121891c67dd2bbb0b5d960d5756","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        endpoint.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dservice_name)"},{"line_number":679,"context_line":"        endpoint.subsets \u003d [cls.k8s_client.V1EndpointSubset("},{"line_number":680,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":681,"context_line":"                                ip\u003d\u002710.0.111.144\u0027"},{"line_number":682,"context_line":"                            )],"},{"line_number":683,"context_line":"                            not_ready_addresses\u003d["},{"line_number":684,"context_line":"                                cls.k8s_client.V1EndpointAddress("}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_30d62c29","line":681,"range":{"start_line":681,"start_character":36,"end_line":681,"end_character":49},"updated":"2020-11-03 12:08:54.000000000","message":"This IP should correspond to the pod IP of the Pod created to serve as an Endpoint.","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"15e69e0cecedf877623f3e357f95ab07b9da0c93","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        endpoint.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dservice_name)"},{"line_number":679,"context_line":"        endpoint.subsets \u003d [cls.k8s_client.V1EndpointSubset("},{"line_number":680,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":681,"context_line":"                                ip\u003d\u002710.0.111.144\u0027"},{"line_number":682,"context_line":"                            )],"},{"line_number":683,"context_line":"                            not_ready_addresses\u003d["},{"line_number":684,"context_line":"                                cls.k8s_client.V1EndpointAddress("}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_b24dee9b","line":681,"range":{"start_line":681,"start_character":36,"end_line":681,"end_character":49},"in_reply_to":"1f621f24_30d62c29","updated":"2020-11-06 18:50:29.000000000","message":"Done","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"539b8ceadf208121891c67dd2bbb0b5d960d5756","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":681,"context_line":"                                ip\u003d\u002710.0.111.144\u0027"},{"line_number":682,"context_line":"                            )],"},{"line_number":683,"context_line":"                            not_ready_addresses\u003d["},{"line_number":684,"context_line":"                                cls.k8s_client.V1EndpointAddress("},{"line_number":685,"context_line":"                                    ip\u003d\u002710.0.0.0\u0027"},{"line_number":686,"context_line":"                                )"},{"line_number":687,"context_line":"                            ],"},{"line_number":688,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":689,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":690,"context_line":"                                  port\u003dport,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_d0e6d816","line":687,"range":{"start_line":683,"start_character":0,"end_line":687,"end_character":30},"updated":"2020-11-03 12:08:54.000000000","message":"There shouldn\u0027t be a need to specify the not_ready_addresses as by default, when the Pod is created we\u0027re waiting for it to be Running.","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"15e69e0cecedf877623f3e357f95ab07b9da0c93","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":681,"context_line":"                                ip\u003d\u002710.0.111.144\u0027"},{"line_number":682,"context_line":"                            )],"},{"line_number":683,"context_line":"                            not_ready_addresses\u003d["},{"line_number":684,"context_line":"                                cls.k8s_client.V1EndpointAddress("},{"line_number":685,"context_line":"                                    ip\u003d\u002710.0.0.0\u0027"},{"line_number":686,"context_line":"                                )"},{"line_number":687,"context_line":"                            ],"},{"line_number":688,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":689,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":690,"context_line":"                                  port\u003dport,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_9252723a","line":687,"range":{"start_line":683,"start_character":0,"end_line":687,"end_character":30},"in_reply_to":"1f621f24_d0e6d816","updated":"2020-11-06 18:50:29.000000000","message":"Done","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"511e31fff675d2edf1e769c235234381f6dc85ea","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":689,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":690,"context_line":"                                  port\u003dport,"},{"line_number":691,"context_line":"                                  protocol\u003d protocol)])]"},{"line_number":692,"context_line":"        ep \u003d cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":693,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"},{"line_number":694,"context_line":"        if cleanup:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_87c1d1e7","line":691,"updated":"2020-11-03 00:30:34.000000000","message":"pep8: E251 unexpected spaces around keyword / parameter equals","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"15e69e0cecedf877623f3e357f95ab07b9da0c93","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":689,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":690,"context_line":"                                  port\u003dport,"},{"line_number":691,"context_line":"                                  protocol\u003d protocol)])]"},{"line_number":692,"context_line":"        ep \u003d cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":693,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"},{"line_number":694,"context_line":"        if cleanup:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_f243e66a","line":691,"in_reply_to":"1f621f24_87c1d1e7","updated":"2020-11-06 18:50:29.000000000","message":"Done","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"511e31fff675d2edf1e769c235234381f6dc85ea","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":690,"context_line":"                                  port\u003dport,"},{"line_number":691,"context_line":"                                  protocol\u003d protocol)])]"},{"line_number":692,"context_line":"        ep \u003d cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":693,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"},{"line_number":694,"context_line":"        if cleanup:"},{"line_number":695,"context_line":"            cls.addClassResourceCleanup(cls.delete_service, service_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_e7b88577","line":692,"updated":"2020-11-03 00:30:34.000000000","message":"pep8: F841 local variable \u0027ep\u0027 is assigned to but never used","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"15e69e0cecedf877623f3e357f95ab07b9da0c93","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":690,"context_line":"                                  port\u003dport,"},{"line_number":691,"context_line":"                                  protocol\u003d protocol)])]"},{"line_number":692,"context_line":"        ep \u003d cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":693,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"},{"line_number":694,"context_line":"        if cleanup:"},{"line_number":695,"context_line":"            cls.addClassResourceCleanup(cls.delete_service, service_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_d2486a88","line":692,"in_reply_to":"1f621f24_e7b88577","updated":"2020-11-06 18:50:29.000000000","message":"Done","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"511e31fff675d2edf1e769c235234381f6dc85ea","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        if cleanup:"},{"line_number":695,"context_line":"            cls.addClassResourceCleanup(cls.delete_service, service_name,"},{"line_number":696,"context_line":"                                        namespace\u003dnamespace)"},{"line_number":697,"context_line":"    @classmethod"},{"line_number":698,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd\u003dTrue,"},{"line_number":699,"context_line":"                         timeout_period\u003dconsts.NS_TIMEOUT):"},{"line_number":700,"context_line":"        if not name:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_c7bbc96f","line":697,"updated":"2020-11-03 00:30:34.000000000","message":"pep8: E301 expected 1 blank line, found 0","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"15e69e0cecedf877623f3e357f95ab07b9da0c93","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        if cleanup:"},{"line_number":695,"context_line":"            cls.addClassResourceCleanup(cls.delete_service, service_name,"},{"line_number":696,"context_line":"                                        namespace\u003dnamespace)"},{"line_number":697,"context_line":"    @classmethod"},{"line_number":698,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd\u003dTrue,"},{"line_number":699,"context_line":"                         timeout_period\u003dconsts.NS_TIMEOUT):"},{"line_number":700,"context_line":"        if not name:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_3261de06","line":697,"in_reply_to":"1f621f24_c7bbc96f","updated":"2020-11-06 18:50:29.000000000","message":"Done","commit_id":"03954fb6e39fe5642a6df68176c19b2d4c14d920"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2aff2423ff0f9549f651d1ea0a1ca0b16731d4af","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        endpoint \u003d cls.k8s_client.V1Endpoints()"},{"line_number":679,"context_line":"        endpoint.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dservice_name)"},{"line_number":680,"context_line":"        endpoint.subsets \u003d [cls.k8s_client.V1EndpointSubset("},{"line_number":681,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":682,"context_line":"                                ip\u003dip"},{"line_number":683,"context_line":"                            )],"},{"line_number":684,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":685,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":686,"context_line":"                                  port\u003dport,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_b505ce16","line":683,"range":{"start_line":681,"start_character":28,"end_line":683,"end_character":31},"updated":"2020-11-09 10:31:39.000000000","message":"As no targetRef field is specified here, a Depends-on needs to be included from your patch to https://review.opendev.org/#/c/761192/ otherwise this Endpoints is ignored.","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"d6e68242eeec3f919c140f71f24e5facf4036186","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        endpoint \u003d cls.k8s_client.V1Endpoints()"},{"line_number":679,"context_line":"        endpoint.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dservice_name)"},{"line_number":680,"context_line":"        endpoint.subsets \u003d [cls.k8s_client.V1EndpointSubset("},{"line_number":681,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":682,"context_line":"                                ip\u003dip"},{"line_number":683,"context_line":"                            )],"},{"line_number":684,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":685,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":686,"context_line":"                                  port\u003dport,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_20114805","line":683,"range":{"start_line":681,"start_character":28,"end_line":683,"end_character":31},"in_reply_to":"1f621f24_b505ce16","updated":"2020-11-12 16:36:47.000000000","message":"Done","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2aff2423ff0f9549f651d1ea0a1ca0b16731d4af","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":686,"context_line":"                                  port\u003dport,"},{"line_number":687,"context_line":"                                  protocol\u003dprotocol)])]"},{"line_number":688,"context_line":"        cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":689,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"},{"line_number":690,"context_line":"        if cleanup:"},{"line_number":691,"context_line":"            cls.addClassResourceCleanup(cls.delete_service, service_name,"},{"line_number":692,"context_line":"                                        namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_d5316a5c","line":689,"range":{"start_line":688,"start_character":0,"end_line":689,"end_character":47},"updated":"2020-11-09 10:31:39.000000000","message":"It\u0027s safer to verify_lbaas_endpoints_configured after Endpoints are created to ensure the KuryrLoadBalancer CRD is fully configured.","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"d6e68242eeec3f919c140f71f24e5facf4036186","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":686,"context_line":"                                  port\u003dport,"},{"line_number":687,"context_line":"                                  protocol\u003dprotocol)])]"},{"line_number":688,"context_line":"        cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":689,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"},{"line_number":690,"context_line":"        if cleanup:"},{"line_number":691,"context_line":"            cls.addClassResourceCleanup(cls.delete_service, service_name,"},{"line_number":692,"context_line":"                                        namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_400e04e5","line":689,"range":{"start_line":688,"start_character":0,"end_line":689,"end_character":47},"in_reply_to":"1f621f24_d5316a5c","updated":"2020-11-12 16:36:47.000000000","message":"Done","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"e90a5b8f0b713452e6e10a0d8fa41adcba9f72d1","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                                        namespace\u003dnamespace)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @classmethod"},{"line_number":658,"context_line":"    def create_setup_for_svc_without_selectors_test(cls, pod_num\u003d2,"},{"line_number":659,"context_line":"                                                    spec_type\u003d\"ClusterIP\","},{"line_number":660,"context_line":"                                                    protocol\u003d\"TCP\","},{"line_number":661,"context_line":"                                                    port\u003d80,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f621f24_521a3e16","line":658,"range":{"start_line":658,"start_character":8,"end_line":658,"end_character":51},"updated":"2020-11-16 04:54:22.000000000","message":"Is there a way to extend create_setup_for_service and not duplicate?","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"77a3e35da6e4efc9ae7b7b4ff2381e7bf883136d","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                                        namespace\u003dnamespace)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    @classmethod"},{"line_number":658,"context_line":"    def create_setup_for_svc_without_selectors_test(cls, pod_num\u003d2,"},{"line_number":659,"context_line":"                                                    spec_type\u003d\"ClusterIP\","},{"line_number":660,"context_line":"                                                    protocol\u003d\"TCP\","},{"line_number":661,"context_line":"                                                    port\u003d80,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f621f24_43bf12a9","line":658,"range":{"start_line":658,"start_character":8,"end_line":658,"end_character":51},"in_reply_to":"1f621f24_521a3e16","updated":"2020-11-16 10:10:02.000000000","message":"I think that of course, there is more possibilities to handle this. The same thing is, that we need to create pod, service, endpoint, verify the configuration.\n\nThe difference is that the service does not have a selector, and endpoint is created. \n\nSo it can be change to have a flag, that will be telling us if we need to have selector of not, after that, we can have if for this to option for creating service and than another one for creation of endpoint. I think this is one of the ways how to extended create_setup_for_service.","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"efedc071e26986cc8e7ab9fc257cded87d6039b1","unresolved":false,"context_lines":[{"line_number":684,"context_line":"        endpoint \u003d cls.k8s_client.V1Endpoints()"},{"line_number":685,"context_line":"        endpoint.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dservice_name)"},{"line_number":686,"context_line":"        endpoint.subsets \u003d [cls.k8s_client.V1EndpointSubset("},{"line_number":687,"context_line":"                            addresses\u003d[cls.k8s_client.V1EndpointAddress("},{"line_number":688,"context_line":"                                ip\u003dip"},{"line_number":689,"context_line":"                            )],"},{"line_number":690,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("}],"source_content_type":"text/x-python","patch_set":17,"id":"1f621f24_dd7ad221","line":687,"range":{"start_line":687,"start_character":28,"end_line":687,"end_character":37},"updated":"2020-11-17 00:16:25.000000000","message":"If two Pods were created to be endpoints, perhaps we can include the extra one here?","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0f34bb38cb96e6cd2786bfc44655a6446108f7b6","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                                ip\u003dip"},{"line_number":689,"context_line":"                            )],"},{"line_number":690,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":691,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":692,"context_line":"                                  port\u003dport,"},{"line_number":693,"context_line":"                                  protocol\u003dprotocol)])]"},{"line_number":694,"context_line":"        cls.k8s_client.CoreV1Api().create_namespaced_endpoints("}],"source_content_type":"text/x-python","patch_set":17,"id":"1f621f24_3def86e9","line":691,"range":{"start_line":691,"start_character":38,"end_line":691,"end_character":56},"updated":"2020-11-17 00:09:27.000000000","message":"The name of the Pod shouldn\u0027t be used here. Note that this port should have the same name defined on the Port of the Service object, if any name was defined there.","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0f34bb38cb96e6cd2786bfc44655a6446108f7b6","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                            )],"},{"line_number":690,"context_line":"                            ports\u003d[cls.k8s_client.V1EndpointPort("},{"line_number":691,"context_line":"                                  name\u003dpod.metadata.name,"},{"line_number":692,"context_line":"                                  port\u003dport,"},{"line_number":693,"context_line":"                                  protocol\u003dprotocol)])]"},{"line_number":694,"context_line":"        cls.k8s_client.CoreV1Api().create_namespaced_endpoints("},{"line_number":695,"context_line":"            namespace\u003dnamespace, body\u003dendpoint)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f621f24_9dde9a3b","line":692,"range":{"start_line":692,"start_character":39,"end_line":692,"end_character":43},"updated":"2020-11-17 00:09:27.000000000","message":"This port should be the target_port, which is the port expected on the Pod.","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3e0b6845ada5ac8cf27b958e76ed52bff69d0495","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        namespace.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dname)"},{"line_number":713,"context_line":"        namespace_obj \u003d cls.k8s_client.CoreV1Api().create_namespace("},{"line_number":714,"context_line":"            body\u003dnamespace)"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        if not wait_for_crd:"},{"line_number":717,"context_line":"            return name, namespace_obj"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1f621f24_bd6ef6c5","line":715,"updated":"2020-11-16 23:22:41.000000000","message":"After the namespace got create here, could you include the following check:\n\nif not CONF.kuryr_kubernetes.subnet_per_namespace:\n    return name, namespace_obj\n\nWe need to avoid the checking of the crd at line 725 because the handler won\u0027t be enabled in this scenario[1].\n[1] https://review.opendev.org/#/c/762893/","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0f7bb53c119733986e87e4309693ff6e65b9c69d","unresolved":true,"context_lines":[{"line_number":712,"context_line":"        namespace.metadata \u003d cls.k8s_client.V1ObjectMeta(name\u003dname)"},{"line_number":713,"context_line":"        namespace_obj \u003d cls.k8s_client.CoreV1Api().create_namespace("},{"line_number":714,"context_line":"            body\u003dnamespace)"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"        if not wait_for_crd:"},{"line_number":717,"context_line":"            return name, namespace_obj"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7f2a05af_559f6cc6","line":715,"in_reply_to":"1f621f24_bd6ef6c5","updated":"2020-11-30 14:31:04.000000000","message":"BTW, the comment on this patch should help with the namespace issue.","commit_id":"271ea301e495c25442ca7f76dc43cbc1759cbfe0"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d57cca4553c9c7cfcafdd0d8690d1a9fc615bbfb","unresolved":true,"context_lines":[{"line_number":674,"context_line":"            pod_name, pod \u003d cls.create_pod(namespace\u003dnamespace)"},{"line_number":675,"context_line":"            pod_name_list.append(pod_name)"},{"line_number":676,"context_line":"            if cleanup:"},{"line_number":677,"context_line":"                cls.addClassResourceCleanup(cls.delete_pod, pod_name,"},{"line_number":678,"context_line":"                                            namespace\u003dnamespace)"},{"line_number":679,"context_line":"        cls.pod_num \u003d pod_num"},{"line_number":680,"context_line":"        service_name, service_obj \u003d cls.create_service("}],"source_content_type":"text/x-python","patch_set":19,"id":"cc6f9193_2db92333","line":677,"updated":"2020-11-24 13:12:25.000000000","message":"No need to add that, you\u0027ll just cleanup whole namespace, right?","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c645f87bbef924e2e4ca11bc09527a0c19b8d71f","unresolved":true,"context_lines":[{"line_number":707,"context_line":"            cls.verify_lbaas_endpoints_configured(service_name, pod_num,"},{"line_number":708,"context_line":"                                                  namespace)"},{"line_number":709,"context_line":"            cls.service_name \u003d service_name"},{"line_number":710,"context_line":"        if cleanup:"},{"line_number":711,"context_line":"            cls.addClassResourceCleanup(cls.delete_namespace, namespace)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    @classmethod"},{"line_number":714,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":19,"id":"70b57ded_7c21d51f","line":711,"range":{"start_line":710,"start_character":0,"end_line":711,"end_character":72},"updated":"2020-11-24 13:02:26.000000000","message":"You should do it in the test, where you create the namespace. Also this should be added immediately after the namespace gets created, otherwise you risk it never being cleaned up (e.g. when creating the service fails).","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"9de68ce829df90e8df403e61d914ea5fe26c0dcb","unresolved":false,"context_lines":[{"line_number":707,"context_line":"            cls.verify_lbaas_endpoints_configured(service_name, pod_num,"},{"line_number":708,"context_line":"                                                  namespace)"},{"line_number":709,"context_line":"            cls.service_name \u003d service_name"},{"line_number":710,"context_line":"        if cleanup:"},{"line_number":711,"context_line":"            cls.addClassResourceCleanup(cls.delete_namespace, namespace)"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    @classmethod"},{"line_number":714,"context_line":"    def create_namespace(cls, name\u003dNone, wait_for_crd\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":19,"id":"baf32a48_95542fae","line":711,"range":{"start_line":710,"start_character":0,"end_line":711,"end_character":72},"in_reply_to":"70b57ded_7c21d51f","updated":"2020-11-27 14:19:16.000000000","message":"Done","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5cd5b163a37f40369b52d4cc8a72470870c9dce4","unresolved":true,"context_lines":[{"line_number":663,"context_line":"                                      namespace\u003d\"default\","},{"line_number":664,"context_line":"                                      get_ip\u003dTrue,"},{"line_number":665,"context_line":"                                      service_name\u003dNone,"},{"line_number":666,"context_line":"                                      cleanup\u003dTrue):"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"        \"\"\"Create a setup for services without selector"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"59f12351_3a6e93cb","line":666,"range":{"start_line":666,"start_character":38,"end_line":666,"end_character":50},"updated":"2020-11-30 11:11:58.000000000","message":"You don\u0027t use it anymore.","commit_id":"7dda6dba00c5d75099382fc715b0322e7441bab2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"106b4899c0f5f97fca5ca963db2219dba76a03c3","unresolved":true,"context_lines":[{"line_number":734,"context_line":"                    not kns_crd.get(\u0027status\u0027).get(\u0027routerId\u0027)):"},{"line_number":735,"context_line":"                msg \u003d \u0027Timed out waiting for kns crd %s creation\u0027 % name"},{"line_number":736,"context_line":"                raise lib_exc.TimeoutException(msg)"},{"line_number":737,"context_line":"        else:"},{"line_number":738,"context_line":"            kuryr_crd_annotation \u003d K8S_ANNOTATION_PREFIX + \"-net-crd\""},{"line_number":739,"context_line":"            # wait until namespace gets created"},{"line_number":740,"context_line":"            while True:"}],"source_content_type":"text/x-python","patch_set":23,"id":"0182647c_6517d454","line":737,"range":{"start_line":737,"start_character":1,"end_line":737,"end_character":13},"updated":"2020-11-30 14:46:10.000000000","message":"This needs to be:\n\n else if CONF.kuryr_kubernetes.subnet_per_namespace:\n\nThat\u0027s in order to make sure we don\u0027t wait for CRD to get created on the gates that do not have it configured.","commit_id":"d51e43701a809b55a5de8032e04aa2f8b2245640"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f1a04c40cbe0250662dfc50ee29aaf1c14dc08b9","unresolved":true,"context_lines":[{"line_number":716,"context_line":"            body\u003dnamespace)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        if not wait_for_crd or not CONF.kuryr_kubernetes.subnet_per_namespace:"},{"line_number":719,"context_line":"            time.sleep(30)  # Need to wait for SA token before using it."},{"line_number":720,"context_line":"            return name, namespace_obj"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        start \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":26,"id":"e0d5f166_0ee99236","line":719,"range":{"start_line":719,"start_character":12,"end_line":719,"end_character":72},"updated":"2020-12-01 15:04:19.000000000","message":"SA token? perhaps a bit more information could be handy here. And why 30 seconds?","commit_id":"8fc596fe2a3618797f4053c00bdb8fe3f27b8192"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"083834aac0168b7f0b6dd49144d520432f2933b9","unresolved":true,"context_lines":[{"line_number":716,"context_line":"            body\u003dnamespace)"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        if not wait_for_crd or not CONF.kuryr_kubernetes.subnet_per_namespace:"},{"line_number":719,"context_line":"            time.sleep(30)  # Need to wait for SA token before using it."},{"line_number":720,"context_line":"            return name, namespace_obj"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        start \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":26,"id":"20d418ad_962e942f","line":719,"range":{"start_line":719,"start_character":12,"end_line":719,"end_character":72},"in_reply_to":"e0d5f166_0ee99236","updated":"2020-12-01 16:50:30.000000000","message":"ServiceAccount. The value is totally a guess, but creating a pod immediately in the namespace just doesn\u0027t work. I can check if we can just wait for it to appear.","commit_id":"8fc596fe2a3618797f4053c00bdb8fe3f27b8192"}],"kuryr_tempest_plugin/tests/scenario/test_service.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"08504c67ba6007e971fcc59ef50da018c4acf80f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            raise cls.skipException(\"Service UDP tests are not enabled\")"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @decorators.idempotent_id(\u0027bddf5441-1244-449d-a125-b5fda1670781\u0027)"},{"line_number":110,"context_line":"    def test_service_without_selector(self):"},{"line_number":111,"context_line":"        # Create a servvice without selector"},{"line_number":112,"context_line":"        spec_type \u003d \u0027ClusterIP\u0027"},{"line_number":113,"context_line":"        ns_name, ns_obj \u003d self.create_namespace()"},{"line_number":114,"context_line":"        pod_name, pod \u003d self.create_pod(namespace\u003dns_name)"},{"line_number":115,"context_line":"        svc_name, svc_obj \u003d self.create_service(spec_type\u003dspec_type,"},{"line_number":116,"context_line":"                                                namespace\u003dns_name)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        svc_ip \u003d self.get_svc_ip_on_crd(svc_name, ns_name)"},{"line_number":119,"context_line":"        self.verify_lbaas_endpoints_configured(svc_name,"},{"line_number":120,"context_line":"                                               namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_db02fe0b","line":120,"range":{"start_line":110,"start_character":0,"end_line":120,"end_character":65},"updated":"2020-10-12 12:30:25.000000000","message":"Shouldn\u0027t a new test get created instead of modifying an existing test? The test_service_udp_ping is still valid.\n\nYou might be missing the creation of the Endpoints object.","commit_id":"59e08dadad7474d818573394e92624c01f69c616"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"01bc762eab06eeccce6ab90cead1954c8c9a9464","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.check_service_internal_connectivity(service_port\u003d\u002790\u0027,"},{"line_number":119,"context_line":"                                                 protocol\u003d\u0027UDP\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class TestServiceWithoutSelectorScenario(base.BaseKuryrScenarioTest):"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @classmethod"},{"line_number":124,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dd72ee49","line":121,"updated":"2020-10-12 17:15:28.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"33667b1c793fc84ba9fda36bda2bfdd765b381a1"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"01bc762eab06eeccce6ab90cead1954c8c9a9464","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def skip_checks(cls):"},{"line_number":125,"context_line":"        super(TestServiceWithoutSelectorScenario, cls).skip_checks()"},{"line_number":126,"context_line":"        if not CONF.kuryr_kubernetes.test_services_without_selector:"},{"line_number":127,"context_line":"            raise cls.skipException(\"Service without selectors tests\" "},{"line_number":128,"context_line":"                                    \"are not enabled\")   "},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_service_without_selector(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_bd6d7a68","line":127,"updated":"2020-10-12 17:15:28.000000000","message":"pep8: W291 trailing whitespace","commit_id":"33667b1c793fc84ba9fda36bda2bfdd765b381a1"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"01bc762eab06eeccce6ab90cead1954c8c9a9464","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        super(TestServiceWithoutSelectorScenario, cls).skip_checks()"},{"line_number":126,"context_line":"        if not CONF.kuryr_kubernetes.test_services_without_selector:"},{"line_number":127,"context_line":"            raise cls.skipException(\"Service without selectors tests\" "},{"line_number":128,"context_line":"                                    \"are not enabled\")   "},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_service_without_selector(self):"},{"line_number":131,"context_line":"        # Create a servvice without selector"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1d8e2626","line":128,"updated":"2020-10-12 17:15:28.000000000","message":"pep8: W291 trailing whitespace","commit_id":"33667b1c793fc84ba9fda36bda2bfdd765b381a1"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"01bc762eab06eeccce6ab90cead1954c8c9a9464","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        svc_name, svc_obj \u003d self.create_service(spec_type\u003dspec_type,"},{"line_number":136,"context_line":"                                                namespace\u003dns_name)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        svc_ip \u003d self.get_svc_ip_on_crd(svc_name, ns_name)"},{"line_number":139,"context_line":"        self.verify_lbaas_endpoints_configured(svc_name,"},{"line_number":140,"context_line":"                                               namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fd909244","line":138,"updated":"2020-10-12 17:15:28.000000000","message":"pep8: F841 local variable \u0027svc_ip\u0027 is assigned to but never used","commit_id":"33667b1c793fc84ba9fda36bda2bfdd765b381a1"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d937c1e194dee19315696eefa935c3d10e8f3fc4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.check_service_internal_connectivity(service_port\u003d\u002790\u0027,"},{"line_number":119,"context_line":"                                                 protocol\u003d\u0027UDP\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class TestServiceWithoutSelectorScenario(base.BaseKuryrScenarioTest):"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @classmethod"},{"line_number":124,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_44f8ca7a","line":121,"updated":"2020-10-12 19:46:15.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"f5f37f9e05c7171741ca46b96cb7763139b16010"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d937c1e194dee19315696eefa935c3d10e8f3fc4","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def skip_checks(cls):"},{"line_number":125,"context_line":"        super(TestServiceWithoutSelectorScenario, cls).skip_checks()"},{"line_number":126,"context_line":"        if not CONF.kuryr_kubernetes.test_services_without_selector:"},{"line_number":127,"context_line":"            raise cls.skipException(\"Service without selectors tests\" "},{"line_number":128,"context_line":"                                    \"are not enabled\")   "},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_service_without_selector(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_24f316a1","line":127,"updated":"2020-10-12 19:46:15.000000000","message":"pep8: W291 trailing whitespace","commit_id":"f5f37f9e05c7171741ca46b96cb7763139b16010"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d937c1e194dee19315696eefa935c3d10e8f3fc4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        super(TestServiceWithoutSelectorScenario, cls).skip_checks()"},{"line_number":126,"context_line":"        if not CONF.kuryr_kubernetes.test_services_without_selector:"},{"line_number":127,"context_line":"            raise cls.skipException(\"Service without selectors tests\" "},{"line_number":128,"context_line":"                                    \"are not enabled\")   "},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test_service_without_selector(self):"},{"line_number":131,"context_line":"        # Create a servvice without selector"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_84ee62b2","line":128,"updated":"2020-10-12 19:46:15.000000000","message":"pep8: W291 trailing whitespace","commit_id":"f5f37f9e05c7171741ca46b96cb7763139b16010"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d937c1e194dee19315696eefa935c3d10e8f3fc4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        svc_name, svc_obj \u003d self.create_service(spec_type\u003dspec_type,"},{"line_number":136,"context_line":"                                                namespace\u003dns_name)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        svc_ip \u003d self.get_svc_ip_on_crd(svc_name, ns_name)"},{"line_number":139,"context_line":"        self.verify_lbaas_endpoints_configured(svc_name,"},{"line_number":140,"context_line":"                                               namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_64e98ea9","line":138,"updated":"2020-10-12 19:46:15.000000000","message":"pep8: F841 local variable \u0027svc_ip\u0027 is assigned to but never used","commit_id":"f5f37f9e05c7171741ca46b96cb7763139b16010"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4baad45e10710ee57aa938c7b346f4dd04b34faf","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # Create a servvice without selector"},{"line_number":135,"context_line":"        ns_name, ns_obj \u003d self.create_namespace()"},{"line_number":136,"context_line":"        pod_name, pod \u003d self.create_pod(namespace\u003dns_name)"},{"line_number":137,"context_line":"        self.create_setup_for_service_test(namespace\u003dns_name,"},{"line_number":138,"context_line":"                                           cleanup\u003dTrue)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        service_name \u003d self.service_name"},{"line_number":141,"context_line":"        self.check_service_internal_connectivity(namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_036a0d7f","line":138,"range":{"start_line":137,"start_character":8,"end_line":138,"end_character":56},"updated":"2020-10-18 13:35:46.000000000","message":"Note that the service create here will end up having a Selector.","commit_id":"6ffde1dd3815e37591a1c6c0782396f0fb5f6ccb"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5cb97005c0d71b624b7320109d18d1edc6824632","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # Create a servvice without selector"},{"line_number":135,"context_line":"        ns_name, ns_obj \u003d self.create_namespace()"},{"line_number":136,"context_line":"        pod_name, pod \u003d self.create_pod(namespace\u003dns_name)"},{"line_number":137,"context_line":"        self.create_setup_for_service_test(namespace\u003dns_name,"},{"line_number":138,"context_line":"                                           cleanup\u003dTrue)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        service_name \u003d self.service_name"},{"line_number":141,"context_line":"        self.check_service_internal_connectivity(namespace\u003dns_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f65232a_1d7a7787","line":138,"range":{"start_line":137,"start_character":8,"end_line":138,"end_character":56},"in_reply_to":"5f681702_036a0d7f","updated":"2020-10-21 07:34:46.000000000","message":"yeah, you will need to modify the create_setup_for_service_test to ensure it allows you to create services without selectors","commit_id":"6ffde1dd3815e37591a1c6c0782396f0fb5f6ccb"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8805d93a023e2e182d3c4ca0e24209a3f8266338","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.create_setup_for_service_test(namespace\u003dns_name,"},{"line_number":138,"context_line":"                                           cleanup\u003dTrue)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        service_name \u003d self.service_name"},{"line_number":141,"context_line":"        self.check_service_internal_connectivity(namespace\u003dns_name)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b003dcbd","line":140,"updated":"2020-10-13 03:53:04.000000000","message":"pep8: F841 local variable \u0027service_name\u0027 is assigned to but never used","commit_id":"6ffde1dd3815e37591a1c6c0782396f0fb5f6ccb"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2aff2423ff0f9549f651d1ea0a1ca0b16731d4af","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            raise cls.skipException(\"Service tests are not enabled\")"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_service_without_selector(self):"},{"line_number":134,"context_line":"        # Create a servvice without selector"},{"line_number":135,"context_line":"        ns_name, ns_obj \u003d self.create_namespace()"},{"line_number":136,"context_line":"        self.addCleanup(self.delete_namespace, ns_name)"},{"line_number":137,"context_line":"        self.create_setup_for_svc_without_selectors_test(namespace\u003dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_f563c640","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":27},"updated":"2020-11-09 10:31:39.000000000","message":"typo","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"d6e68242eeec3f919c140f71f24e5facf4036186","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            raise cls.skipException(\"Service tests are not enabled\")"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_service_without_selector(self):"},{"line_number":134,"context_line":"        # Create a servvice without selector"},{"line_number":135,"context_line":"        ns_name, ns_obj \u003d self.create_namespace()"},{"line_number":136,"context_line":"        self.addCleanup(self.delete_namespace, ns_name)"},{"line_number":137,"context_line":"        self.create_setup_for_svc_without_selectors_test(namespace\u003dns_name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_00088cd7","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":27},"in_reply_to":"1f621f24_f563c640","updated":"2020-11-12 16:36:47.000000000","message":"Done","commit_id":"0fda654d91b9f7c1b97165f8c11ea9f3046cdd35"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c645f87bbef924e2e4ca11bc09527a0c19b8d71f","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    def skip_checks(cls):"},{"line_number":126,"context_line":"        super(TestServiceWithoutSelectorScenario, cls).skip_checks()"},{"line_number":127,"context_line":"        if not CONF.kuryr_kubernetes.test_services_without_selector:"},{"line_number":128,"context_line":"            raise cls.skipException(\"Service without selectors tests\""},{"line_number":129,"context_line":"                                    \"are not enabled\")"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_service_without_selector(self):"},{"line_number":132,"context_line":"        # Create a service without selector"}],"source_content_type":"text/x-python","patch_set":19,"id":"57286c84_87034ca1","line":129,"range":{"start_line":128,"start_character":36,"end_line":129,"end_character":53},"updated":"2020-11-24 13:02:26.000000000","message":"Missing space on newline.","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"9de68ce829df90e8df403e61d914ea5fe26c0dcb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def skip_checks(cls):"},{"line_number":126,"context_line":"        super(TestServiceWithoutSelectorScenario, cls).skip_checks()"},{"line_number":127,"context_line":"        if not CONF.kuryr_kubernetes.test_services_without_selector:"},{"line_number":128,"context_line":"            raise cls.skipException(\"Service without selectors tests\""},{"line_number":129,"context_line":"                                    \"are not enabled\")"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_service_without_selector(self):"},{"line_number":132,"context_line":"        # Create a service without selector"}],"source_content_type":"text/x-python","patch_set":19,"id":"76459dd9_e0b79512","line":129,"range":{"start_line":128,"start_character":36,"end_line":129,"end_character":53},"in_reply_to":"57286c84_87034ca1","updated":"2020-11-27 14:19:16.000000000","message":"Done","commit_id":"534de8e12c1f4eef1cdfc372f6ec9a4c887649ac"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5cd5b163a37f40369b52d4cc8a72470870c9dce4","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    def test_service_without_selector(self):"},{"line_number":132,"context_line":"        # Create a service without selector"},{"line_number":133,"context_line":"        ns_name, ns_obj \u003d self.create_namespace()"},{"line_number":134,"context_line":"        self.addClassResourceCleanup(self.delete_namespace, ns_name)"},{"line_number":135,"context_line":"        self.service_without_selector_base(namespace\u003dns_name,"},{"line_number":136,"context_line":"                                           cleanup\u003dTrue)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"03808c26_ab40581a","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":68},"updated":"2020-11-30 11:11:58.000000000","message":"Why not just addCleanup()? Other tests are using addCleanup().","commit_id":"7dda6dba00c5d75099382fc715b0322e7441bab2"}]}