)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f8a4270518783060354211d8fc9f461a501c1dce","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    else"},{"line_number":11,"context_line":"        docker build -t quay.io/kuryr/demo . -f Dockerfile"},{"line_number":12,"context_line":"        docker build -t quay.io/kuryr/sctp-demo . -f \\"},{"line_number":13,"context_line":"            kuryr_sctp_demo/Dockerfile"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"    popd"},{"line_number":16,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"c6e6532b_05450f81","line":13,"updated":"2021-01-22 06:53:38.000000000","message":"Don\u0027t we want to do the same for crio? (hint: line 9)","commit_id":"2dcb17e1814afdc88c1a0a7305f450080d374921"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3a46c3cd659bc9f4a125ce2d63347645346e3809","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    else"},{"line_number":11,"context_line":"        docker build -t quay.io/kuryr/demo . -f Dockerfile"},{"line_number":12,"context_line":"        docker build -t quay.io/kuryr/sctp-demo . -f \\"},{"line_number":13,"context_line":"            kuryr_sctp_demo/Dockerfile"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":"    popd"},{"line_number":16,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3b2ac43a_5847aca6","line":13,"in_reply_to":"c6e6532b_05450f81","updated":"2021-01-22 14:12:22.000000000","message":"Yep, if cri-o is used as a container runtime instead of Docker, we need to build it using buildah. It\u0027s broken at the moment, but definitely should be added above.","commit_id":"2dcb17e1814afdc88c1a0a7305f450080d374921"}],"test_container/kuryr_sctp_demo/Dockerfile":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e3ed5d59b49f3afdc8a5c5501bf859c0ce7daa9b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM alpine:3.12"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apk add --no-cache \\"},{"line_number":4,"context_line":"\t\tbash \\"},{"line_number":5,"context_line":"\t\tgcc \\"},{"line_number":6,"context_line":"\t\tg++ \\"},{"line_number":7,"context_line":"\t\tlibstdc++ \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"03c57bbc_f7129f1f","line":4,"range":{"start_line":4,"start_character":1,"end_line":4,"end_character":2},"updated":"2021-01-12 14:32:12.000000000","message":"You would need to use space instead of tabs on this file.","commit_id":"f23aa4e732edd40a0a1b80b8841aa64d300b6a18"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e3ed5d59b49f3afdc8a5c5501bf859c0ce7daa9b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM alpine:3.12"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apk add --no-cache \\"},{"line_number":4,"context_line":"\t\tbash \\"},{"line_number":5,"context_line":"\t\tgcc \\"},{"line_number":6,"context_line":"\t\tg++ \\"},{"line_number":7,"context_line":"\t\tlibstdc++ \\"},{"line_number":8,"context_line":"\t\tlinux-headers \\"},{"line_number":9,"context_line":"\t\tlksctp-tools \\"},{"line_number":10,"context_line":"\t\tlksctp-tools-dev \\"},{"line_number":11,"context_line":"\t\topenssh-client \\"},{"line_number":12,"context_line":"\t\tnet-tools \\"},{"line_number":13,"context_line":"\t\tpython3 \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"dfedc126_c51f8a3f","line":10,"range":{"start_line":4,"start_character":2,"end_line":10,"end_character":20},"updated":"2021-01-12 14:32:12.000000000","message":"Why these packages are needed?","commit_id":"f23aa4e732edd40a0a1b80b8841aa64d300b6a18"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"bd73756c6e4bbc030aedf733495973477876affc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM alpine:3.12"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apk add --no-cache \\"},{"line_number":4,"context_line":"\t\tbash \\"},{"line_number":5,"context_line":"\t\tgcc \\"},{"line_number":6,"context_line":"\t\tg++ \\"},{"line_number":7,"context_line":"\t\tlibstdc++ \\"},{"line_number":8,"context_line":"\t\tlinux-headers \\"},{"line_number":9,"context_line":"\t\tlksctp-tools \\"},{"line_number":10,"context_line":"\t\tlksctp-tools-dev \\"},{"line_number":11,"context_line":"\t\topenssh-client \\"},{"line_number":12,"context_line":"\t\tnet-tools \\"},{"line_number":13,"context_line":"\t\tpython3 \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"19543fb6_4cc23056","line":10,"range":{"start_line":4,"start_character":2,"end_line":10,"end_character":20},"in_reply_to":"155ecbf4_b0da3175","updated":"2021-01-12 14:49:30.000000000","message":"Yes, the ones documented are Ubuntu-based. These are the Alpine variant","commit_id":"f23aa4e732edd40a0a1b80b8841aa64d300b6a18"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"ce74dd4eacfde2bc833127ad25b2706e82797969","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM alpine:3.12"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apk add --no-cache \\"},{"line_number":4,"context_line":"\t\tbash \\"},{"line_number":5,"context_line":"\t\tgcc \\"},{"line_number":6,"context_line":"\t\tg++ \\"},{"line_number":7,"context_line":"\t\tlibstdc++ \\"},{"line_number":8,"context_line":"\t\tlinux-headers \\"},{"line_number":9,"context_line":"\t\tlksctp-tools \\"},{"line_number":10,"context_line":"\t\tlksctp-tools-dev \\"},{"line_number":11,"context_line":"\t\topenssh-client \\"},{"line_number":12,"context_line":"\t\tnet-tools \\"},{"line_number":13,"context_line":"\t\tpython3 \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"155ecbf4_b0da3175","line":10,"range":{"start_line":4,"start_character":2,"end_line":10,"end_character":20},"in_reply_to":"dfedc126_c51f8a3f","updated":"2021-01-12 14:46:27.000000000","message":"Hi, the server uses the python sctp (pysctp) module. The packages are needed for pysctp installation to work.","commit_id":"f23aa4e732edd40a0a1b80b8841aa64d300b6a18"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"5997b48af74be64fd56befe3ca1b46f9693fa7f0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM alpine:3.12"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apk add --no-cache \\"},{"line_number":4,"context_line":"\t\tbash \\"},{"line_number":5,"context_line":"\t\tgcc \\"},{"line_number":6,"context_line":"\t\tg++ \\"},{"line_number":7,"context_line":"\t\tlibstdc++ \\"},{"line_number":8,"context_line":"\t\tlinux-headers \\"},{"line_number":9,"context_line":"\t\tlksctp-tools \\"},{"line_number":10,"context_line":"\t\tlksctp-tools-dev \\"},{"line_number":11,"context_line":"\t\topenssh-client \\"},{"line_number":12,"context_line":"\t\tnet-tools \\"},{"line_number":13,"context_line":"\t\tpython3 \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"d1c760ce_af206200","line":10,"range":{"start_line":4,"start_character":2,"end_line":10,"end_character":20},"in_reply_to":"dfedc126_c51f8a3f","updated":"2021-01-12 14:44:23.000000000","message":"some of those are not specified at https://review.opendev.org/c/openstack/kuryr-kubernetes/+/770107/6/doc/source/installation/testing_sctp_services.rst#177, I assume it was because on the docs patch the docker image was based on ubuntu?","commit_id":"f23aa4e732edd40a0a1b80b8841aa64d300b6a18"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"221cd42a1eeb8d65fac4ae5cc5cf7a686a163126","unresolved":true,"context_lines":[{"line_number":18,"context_line":"USER kuryr"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"WORKDIR /home/kuryr"},{"line_number":21,"context_line":"COPY kuryr_sctp_demo/sctp_server.py /sctp_server.py"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN pip3 --no-cache-dir install -U pip \\"},{"line_number":24,"context_line":"        \u0026\u0026 python3 -m pip install pysctp"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"e34aea91_cf834304","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":51},"updated":"2021-01-13 13:42:54.000000000","message":"Shouldn\u0027t the client also be included in this image?\nOtherwise it wouldn\u0027t be possible to run the client to test client Pod -\u003e server Pod connectivity.","commit_id":"a6de1d74ffa5cb82c1b853db9c822da3d2dc6de2"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f8a4270518783060354211d8fc9f461a501c1dce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM alpine:3.13"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apk add --no-cache \\"},{"line_number":4,"context_line":"                bash \\"}],"source_content_type":"text/x-dockerfile","patch_set":7,"id":"399cc3e6_2a4a941b","line":1,"updated":"2021-01-22 06:53:38.000000000","message":"Let\u0027s not rely on docker.io anymore, since its quota policy cause us a lot of false negatives on running tests on gates. Please use quay.io/kuryr/alpine:3.12 instead. If there is a need for 3.13 for any reason, please let me know.","commit_id":"2dcb17e1814afdc88c1a0a7305f450080d374921"}],"test_container/kuryr_sctp_demo/sctp_client.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f8a4270518783060354211d8fc9f461a501c1dce","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":11,"context_line":"# limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import sctp"},{"line_number":14,"context_line":"import socket"},{"line_number":15,"context_line":"import sys"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"86b643b2_770b95d5","line":13,"updated":"2021-01-22 06:53:38.000000000","message":"Nit: sctp is a 3rd party import, so entire imports block should be grouped like that:\n\n  import socket\n  import sys\n\n  import sctp\n\nFor more information, please take a look at: https://www.python.org/dev/peps/pep-0008/#imports","commit_id":"2dcb17e1814afdc88c1a0a7305f450080d374921"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f8a4270518783060354211d8fc9f461a501c1dce","unresolved":true,"context_lines":[{"line_number":17,"context_line":"sk \u003d sctp.sctpsocket_tcp(socket.AF_INET)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def connect_plus_message(OUT_IP, OUT_PORT):"},{"line_number":21,"context_line":"    sk.connect((OUT_IP, OUT_PORT))"},{"line_number":22,"context_line":"    print(\"Sending Message\")"},{"line_number":23,"context_line":"    sk.sctp_send(msg\u003d\u0027HELLO, I AM ALIVE!!!\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a1db39e0_86632289","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":41},"updated":"2021-01-22 06:53:38.000000000","message":"Arguments should be lowercase.","commit_id":"2dcb17e1814afdc88c1a0a7305f450080d374921"}],"test_container/kuryr_sctp_demo/sctp_server.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e3ed5d59b49f3afdc8a5c5501bf859c0ce7daa9b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"f8f21baf_40f243b2","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2021-01-12 14:32:12.000000000","message":"You may want to remove the copyright from redhat on the new files created.","commit_id":"f23aa4e732edd40a0a1b80b8841aa64d300b6a18"}]}