)]}'
{"kuryr_tempest_plugin/config.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ec0760bfade651ca9e0acdf7993ddeda02735953","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    cfg.BoolOpt(\"test_services_without_selector\", default\u003dFalse,"},{"line_number":97,"context_line":"                help\u003d\"Whether or not service without selector tests will be \""},{"line_number":98,"context_line":"                \"running\"),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\"test_configurable_lb_timeouts\", default\u003dTrue,"},{"line_number":100,"context_line":"                help\u003d\"Whether or not listener timeout values are \""},{"line_number":101,"context_line":"                \"configurable\"),"},{"line_number":102,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"4894e8d6_8617286d","line":99,"range":{"start_line":99,"start_character":57,"end_line":99,"end_character":61},"updated":"2021-04-02 14:31:26.000000000","message":"It\u0027s easier if it\u0027ll default to False.\n\nThe kuryr_tempest_plugin is not branched, meaning that all the versions (stable/*) are tested against the latest master code. And those master versions doesn\u0027t have the LB timeouts feature, so those tests should be disabled there. Defaulting it to \"true\" here means that you\u0027d need to prepare patches setting the option to False in Kuryr\u0027s DevStack plugin for all the stable branches. That\u0027s unnecessary burden.","commit_id":"ae5eb1139cec7c910afed2dfaf652ebcb2d2b595"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"0590d2f8328ee4c6c814d45f4e828906b678c6ca","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    cfg.BoolOpt(\"test_services_without_selector\", default\u003dFalse,"},{"line_number":97,"context_line":"                help\u003d\"Whether or not service without selector tests will be \""},{"line_number":98,"context_line":"                \"running\"),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\"test_configurable_lb_timeouts\", default\u003dTrue,"},{"line_number":100,"context_line":"                help\u003d\"Whether or not listener timeout values are \""},{"line_number":101,"context_line":"                \"configurable\"),"},{"line_number":102,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d94c8d7_5b94aa4e","line":99,"range":{"start_line":99,"start_character":57,"end_line":99,"end_character":61},"in_reply_to":"4894e8d6_8617286d","updated":"2021-04-06 09:07:49.000000000","message":"Right, thanks ;) I just wanted to check that it works as expected.","commit_id":"ae5eb1139cec7c910afed2dfaf652ebcb2d2b595"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4f3cfe936764d71e0c8a0f3d2e78cdaf8084895c","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    cfg.BoolOpt(\"test_services_without_selector\", default\u003dFalse,"},{"line_number":97,"context_line":"                help\u003d\"Whether or not service without selector tests will be \""},{"line_number":98,"context_line":"                \"running\"),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\"test_configurable_lb_timeouts\", default\u003dFalse,"},{"line_number":100,"context_line":"                help\u003d\"Whether or not listener timeout values are \""},{"line_number":101,"context_line":"                \"configurable\"),"},{"line_number":102,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"96660a7a_a16c2f03","line":99,"range":{"start_line":99,"start_character":17,"end_line":99,"end_character":46},"updated":"2021-04-07 21:29:41.000000000","message":"The patch which enables this config is using \"test_updated_listener_timeouts\"[1]. The test won\u0027t run as they have different name. Might be good to rename it to: \u0027test_configurable_listener_timeouts\u0027.\n\n[1] https://review.opendev.org/c/openstack/kuryr-kubernetes/+/785140/1/devstack/plugin.sh#997","commit_id":"eb9a664a02aeaa3e3716c09f107feb890666a1da"}],"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ec0760bfade651ca9e0acdf7993ddeda02735953","unresolved":true,"context_lines":[{"line_number":1430,"context_line":"        updated_service \u003d self.update_service(service_name\u003dservice_name,"},{"line_number":1431,"context_line":"                                              annotation\u003dannotation,"},{"line_number":1432,"context_line":"                                              namespace\u003dnamespace)"},{"line_number":1433,"context_line":"        timeout_cli, timeout_mem \u003d self.get_lb_timeout_on_crd("},{"line_number":1434,"context_line":"            service_name\u003dupdated_service.metadata.name, namespace\u003dnamespace)"},{"line_number":1435,"context_line":""},{"line_number":1436,"context_line":"        annotated_values \u003d [value for i, value in annotation.items()]"},{"line_number":1437,"context_line":"        lb_status_values \u003d [str(timeout_cli), str(timeout_mem)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f4b49bb_8e0781d6","line":1434,"range":{"start_line":1433,"start_character":0,"end_line":1434,"end_character":76},"updated":"2021-04-02 14:31:26.000000000","message":"I think I\u0027d loop this with some timeout to make sure it won\u0027t fail if setting the timeouts took more than 60 seconds.","commit_id":"ae5eb1139cec7c910afed2dfaf652ebcb2d2b595"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"0590d2f8328ee4c6c814d45f4e828906b678c6ca","unresolved":true,"context_lines":[{"line_number":1430,"context_line":"        updated_service \u003d self.update_service(service_name\u003dservice_name,"},{"line_number":1431,"context_line":"                                              annotation\u003dannotation,"},{"line_number":1432,"context_line":"                                              namespace\u003dnamespace)"},{"line_number":1433,"context_line":"        timeout_cli, timeout_mem \u003d self.get_lb_timeout_on_crd("},{"line_number":1434,"context_line":"            service_name\u003dupdated_service.metadata.name, namespace\u003dnamespace)"},{"line_number":1435,"context_line":""},{"line_number":1436,"context_line":"        annotated_values \u003d [value for i, value in annotation.items()]"},{"line_number":1437,"context_line":"        lb_status_values \u003d [str(timeout_cli), str(timeout_mem)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4cfd22_ea1aedfe","line":1434,"range":{"start_line":1433,"start_character":0,"end_line":1434,"end_character":76},"in_reply_to":"7f4b49bb_8e0781d6","updated":"2021-04-06 09:07:49.000000000","message":"Okay, will do, thanks ;)","commit_id":"ae5eb1139cec7c910afed2dfaf652ebcb2d2b595"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4f3cfe936764d71e0c8a0f3d2e78cdaf8084895c","unresolved":true,"context_lines":[{"line_number":528,"context_line":"        raise lib_exc.TimeoutException(msg)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    @classmethod"},{"line_number":531,"context_line":"    def get_lb_timeout_on_crd(cls, service_name, namespace):"},{"line_number":532,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":533,"context_line":"        start \u003d time.time()"},{"line_number":534,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"}],"source_content_type":"text/x-python","patch_set":4,"id":"309e4313_516d963a","line":531,"range":{"start_line":531,"start_character":8,"end_line":531,"end_character":29},"updated":"2021-04-07 21:29:41.000000000","message":"Perhaps we could rename it to: get_listener_timeout_on_crd, as the listener is the one with the timeouts info","commit_id":"eb9a664a02aeaa3e3716c09f107feb890666a1da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4f3cfe936764d71e0c8a0f3d2e78cdaf8084895c","unresolved":true,"context_lines":[{"line_number":1439,"context_line":"                namespace\u003dnamespace)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"            lb_status_values \u003d [str(timeout_cli), str(timeout_mem)]"},{"line_number":1442,"context_line":"            if annotated_values \u003d\u003d lb_status_values:"},{"line_number":1443,"context_line":"                return self.assertEqual(annotated_values, lb_status_values)"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"        msg \u003d \"Timed out getting listener timeouts for %s\" % service_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"98190bc3_c43a3283","line":1442,"range":{"start_line":1442,"start_character":12,"end_line":1442,"end_character":52},"updated":"2021-04-07 21:29:41.000000000","message":"we should assertEqual in case they differ as well to have proof an error was hit.","commit_id":"eb9a664a02aeaa3e3716c09f107feb890666a1da"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a165b12af6086341fbc6817bc056827104651c1c","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                body\u003ddelete_options)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @classmethod"},{"line_number":430,"context_line":"    def update_service(cls, service_name, annotation,"},{"line_number":431,"context_line":"                       namespace\u003d\"default\"):"},{"line_number":432,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":433,"context_line":"        service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":434,"context_line":"        service.metadata \u003d cls.k8s_client.V1ObjectMeta("}],"source_content_type":"text/x-python","patch_set":5,"id":"1dc95d9d_1d55efd3","line":431,"range":{"start_line":430,"start_character":0,"end_line":431,"end_character":44},"updated":"2021-04-13 15:21:06.000000000","message":"Seems like this fits into a single line.","commit_id":"3e0f497b2a247247b55a01a470f4a9c88fae77c2"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2adbcdd3a0b7ac8d0501d027fdac9ae375898b27","unresolved":true,"context_lines":[{"line_number":532,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":533,"context_line":"        start \u003d time.time()"},{"line_number":534,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"},{"line_number":535,"context_line":"            time.sleep(60)"},{"line_number":536,"context_line":"            service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"            if service.metadata.annotations:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e9dc3c15_ff66a2ca","line":535,"updated":"2021-04-13 14:03:36.000000000","message":"why this sleep is needed?","commit_id":"3e0f497b2a247247b55a01a470f4a9c88fae77c2"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"0b4ae05c91b07405e456492e34271010f601c6c1","unresolved":true,"context_lines":[{"line_number":532,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":533,"context_line":"        start \u003d time.time()"},{"line_number":534,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"},{"line_number":535,"context_line":"            time.sleep(60)"},{"line_number":536,"context_line":"            service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"            if service.metadata.annotations:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a96f95c1_a6a931d3","line":535,"in_reply_to":"09fa4154_70b6e2a4","updated":"2021-04-13 15:09:37.000000000","message":"It was failing without earlier it when amphora provider is used. But let me try removing it again, thanks.","commit_id":"3e0f497b2a247247b55a01a470f4a9c88fae77c2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a165b12af6086341fbc6817bc056827104651c1c","unresolved":true,"context_lines":[{"line_number":532,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":533,"context_line":"        start \u003d time.time()"},{"line_number":534,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"},{"line_number":535,"context_line":"            time.sleep(60)"},{"line_number":536,"context_line":"            service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"            if service.metadata.annotations:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b59f2ab3_b38ff8e1","line":535,"in_reply_to":"a96f95c1_a6a931d3","updated":"2021-04-13 15:21:06.000000000","message":"Now that you\u0027re looping twice it should be okay.","commit_id":"3e0f497b2a247247b55a01a470f4a9c88fae77c2"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"64314edbde42e7028a8c974d16461e1dd67f05a5","unresolved":true,"context_lines":[{"line_number":532,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":533,"context_line":"        start \u003d time.time()"},{"line_number":534,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"},{"line_number":535,"context_line":"            time.sleep(60)"},{"line_number":536,"context_line":"            service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"            if service.metadata.annotations:"}],"source_content_type":"text/x-python","patch_set":5,"id":"09fa4154_70b6e2a4","line":535,"in_reply_to":"e9dc3c15_ff66a2ca","updated":"2021-04-13 14:17:00.000000000","message":"I just tried without it and it didn\u0027t fail. If there is no corner case being avoided with it, I believe we can remove.","commit_id":"3e0f497b2a247247b55a01a470f4a9c88fae77c2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a165b12af6086341fbc6817bc056827104651c1c","unresolved":true,"context_lines":[{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"            lb_status_values \u003d [str(timeout_cli), str(timeout_mem)]"},{"line_number":1442,"context_line":"            if annotated_values \u003d\u003d lb_status_values:"},{"line_number":1443,"context_line":"                return self.assertEqual(annotated_values, lb_status_values)"},{"line_number":1444,"context_line":""},{"line_number":1445,"context_line":"        self.assertEqual(annotated_values, lb_status_values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2fbc476d_ba49fb09","line":1443,"range":{"start_line":1443,"start_character":0,"end_line":1443,"end_character":75},"updated":"2021-04-13 15:21:06.000000000","message":"This should be \"break\", shouldn\u0027t it?","commit_id":"3e0f497b2a247247b55a01a470f4a9c88fae77c2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c475e15d6f18d7c14ba4deaf792c4a9d441abf85","unresolved":true,"context_lines":[{"line_number":530,"context_line":"    def get_listener_timeout_on_crd(cls, service_name, namespace):"},{"line_number":531,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":532,"context_line":"        start \u003d time.time()"},{"line_number":533,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"},{"line_number":534,"context_line":"            time.sleep(5)"},{"line_number":535,"context_line":"            service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":536,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"61e23943_8c7ee482","line":533,"updated":"2021-04-14 07:08:20.000000000","message":"why you need this loop if you are already looping/waiting on the check_updated_listener_timeout calling this?","commit_id":"6eaf2b1bbcaed59b44dd86f0034e20dd896b544a"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"0d0c22134d0d60b8ac3e8427b3e2df7a99dc9f7c","unresolved":true,"context_lines":[{"line_number":530,"context_line":"    def get_listener_timeout_on_crd(cls, service_name, namespace):"},{"line_number":531,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":532,"context_line":"        start \u003d time.time()"},{"line_number":533,"context_line":"        while time.time() - start \u003c consts.LB_TIMEOUT:"},{"line_number":534,"context_line":"            time.sleep(5)"},{"line_number":535,"context_line":"            service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":536,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a285c1d2_ab699979","line":533,"in_reply_to":"61e23943_8c7ee482","updated":"2021-04-14 13:43:40.000000000","message":"This loop just handles the case where the loadbalancer CRD status does not have any timeout values. And the other one loops until the status value is updated...","commit_id":"6eaf2b1bbcaed59b44dd86f0034e20dd896b544a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"21f0161da19f6ab5a323d91e8b68f6b50892b62d","unresolved":true,"context_lines":[{"line_number":529,"context_line":"    @classmethod"},{"line_number":530,"context_line":"    def get_listener_timeout_on_crd(cls, service_name, namespace):"},{"line_number":531,"context_line":"        api \u003d cls.k8s_client.CoreV1Api()"},{"line_number":532,"context_line":"        time.sleep(5)"},{"line_number":533,"context_line":"        service \u003d api.read_namespaced_service(service_name, namespace)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        if service.metadata.annotations:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2eef5a5b_f2dd6fd4","line":532,"range":{"start_line":532,"start_character":8,"end_line":532,"end_character":21},"updated":"2021-04-21 13:52:08.000000000","message":"is this needed?","commit_id":"aa845746026ed29f5d104e232fcab5fa1c4c522f"}]}