)]}'
{".stestr/next-stream":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4a94e38d3a6758560c65f951db8ebdcb1d26b33b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"0"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"7927e7b9_cd2579a5","line":1,"updated":"2022-06-27 10:58:42.000000000","message":"why is this file being included? and the same goes to .stestr/format","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"298b9bca9b90b6a57f4e54463581666e40bc237e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"0"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"b144ade8_abb91efa","line":1,"in_reply_to":"7927e7b9_cd2579a5","updated":"2022-06-27 11:06:12.000000000","message":"\u003e why is this file being included? and the same goes to .stestr/format\n\nHonestly, this got here by accident. Would remove both in my next patch. Thanks","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"7d2ef8172be17b41c6c14e16e82fb28effe55e6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"487922bb_a49a1379","updated":"2021-11-23 23:03:35.000000000","message":"Seems the ListenerClient does not accept `cascade` flag?","commit_id":"c8d396903a3c23a3e9969edf8b06344b4ab1e2ec"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"421518b17bbb6aac7d6d801b114aa93d88a7c453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9da2f3c6_606f5daf","updated":"2021-12-02 11:49:42.000000000","message":"I agree with Michal here. Creating a separate testing scenario for the Listeners is more ideal given that loadbalancer and listener deletion are two possible different operations/scenarios.","commit_id":"494acba7a9152e64c08096bd80a28500951ff0f1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2cf224ae7947ad67161cfb32f036b3811b9b2209","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cb902f91_cc1d67ef","updated":"2021-12-01 16:27:51.000000000","message":"Uhm, not sure if I get this. Shouldn\u0027t we put testing deleting listener in a separate test function, otherwise the test will just pass even if the code that checks for listeners isn\u0027t there?\n\nIn general I think the best way to run these tests is:\n1. These should only run when OVN Octavia is enabled (creating an LB is really fast there).\n2. Each test should create it\u0027s own simple service (with OVN Octavia we can do it), delete the resource and wait for LB to be recreated.\n3. For the upstream gates we tweak the period of reconciliations to be e.g. 60 seconds instead of 600 in order to save time on the tests execution. We\u0027d need to make that time configurable first.","commit_id":"494acba7a9152e64c08096bd80a28500951ff0f1"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"509d00ed74ca0eb044448a3c94c86e3cfbf14ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"495a0eb4_7a00ef75","updated":"2021-11-29 11:02:40.000000000","message":"recheck","commit_id":"494acba7a9152e64c08096bd80a28500951ff0f1"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"95ab72f75b32d8909d5ea42c9db2b65d67ab4be8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"96b39981_e9aa7f75","in_reply_to":"9da2f3c6_606f5daf","updated":"2021-12-02 12:18:05.000000000","message":"\u003e I agree with Michal here. Creating a separate testing scenario for the Listeners is more ideal given that loadbalancer and listener deletion are two possible different operations/scenarios.\n\nI agree. Let me split the tests then","commit_id":"494acba7a9152e64c08096bd80a28500951ff0f1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ce6a4f380fb678d7f827c88e60211e3ea7d4218b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b357a1a_b699cc0c","in_reply_to":"9da2f3c6_606f5daf","updated":"2021-12-24 10:36:46.000000000","message":"Just clarifying - I don\u0027t want a separate test scenario in the sense of a new class. Just a separate test in the same class.","commit_id":"494acba7a9152e64c08096bd80a28500951ff0f1"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"95ab72f75b32d8909d5ea42c9db2b65d67ab4be8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3683b80c_3fd65510","in_reply_to":"cb902f91_cc1d67ef","updated":"2021-12-02 12:18:05.000000000","message":"\u003e Uhm, not sure if I get this. Shouldn\u0027t we put testing deleting listener in a separate test function, otherwise the test will just pass even if the code that checks for listeners isn\u0027t there?\n\u003e \n\u003e In general I think the best way to run these tests is:\n\u003e 1. These should only run when OVN Octavia is enabled (creating an LB is really fast there).\n\u003e 2. Each test should create it\u0027s own simple service (with OVN Octavia we can do it), delete the resource and wait for LB to be recreated.\n\u003e 3. For the upstream gates we tweak the period of reconciliations to be e.g. 60 seconds instead of 600 in order to save time on the tests execution. We\u0027d need to make that time configurable first.\n\nPlease share more lights on num(1), how do I require this?","commit_id":"494acba7a9152e64c08096bd80a28500951ff0f1"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"748ee483190a5d308dfba2045148a2055464956d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2613e0b7_4cd2f22e","updated":"2021-12-20 17:19:03.000000000","message":"I think there is a policy against deleting the listeners associated with a loadbalancer sort of unless the loadbalancer is on PENDING_UPDATE? I am getting this on the gates \"Details: {\u0027faultcode\u0027: \u0027Client\u0027, \u0027faultstring\u0027: \u0027Policy does not allow this request to be performed.\u0027, \u0027debuginfo\u0027: None}\"","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8665108e701e790851f1b737087f799f8a650099","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"34f6dff8_68abeba9","updated":"2021-12-24 10:37:58.000000000","message":"Very preliminary review inline.","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"c11b1e2ff88cd29957d95a9b2cd683e67f585d6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"62303684_d3dece41","updated":"2021-12-20 15:02:10.000000000","message":"recheck","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ce6a4f380fb678d7f827c88e60211e3ea7d4218b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e62f2ebd_d2577515","updated":"2021-12-24 10:36:46.000000000","message":"recheck","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"f746ab6ddbedb97360ce6d91181ad5696d429136","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f6b1be18_43364de1","updated":"2021-12-20 10:17:04.000000000","message":"recheck","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ce6a4f380fb678d7f827c88e60211e3ea7d4218b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"334594c2_bf245c0d","in_reply_to":"2613e0b7_4cd2f22e","updated":"2021-12-24 10:36:46.000000000","message":"Hm, \"policy\" seems to say it\u0027s an RBAC issue, weird. Let\u0027s recheck this, we had a lot of gate troubles recently.","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"d006d0a48fa314b7e1a60a1f0389bdd6c608f9a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"95340980_3757f988","updated":"2022-02-01 06:56:14.000000000","message":"Rechecking will not work - it\u0027s an issue unrelated with your changes, see the logs from zuul - kuryr cni/controller images are failed to build due to some issue with centos mirrors.","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"da6e31a3808ad7a79352aed702c629122b94e807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2364bf38_f28e34ab","updated":"2022-02-07 08:10:16.000000000","message":"recheck","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"0efa726eb7a6aa2bd0a991f34228761a3e45cf22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7d81e9a5_39b52352","updated":"2022-01-31 20:09:56.000000000","message":"recheck","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"9679b254498fe25c294b3dbb75545fc92bcdb150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7fdee5da_6ae8c3f9","updated":"2022-02-03 11:49:10.000000000","message":"recheck","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"21bfe408f2261e1051dd79c6d5e1f49e571d133e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d3855371_6197dfba","in_reply_to":"95340980_3757f988","updated":"2022-02-01 07:47:32.000000000","message":"\u003e Rechecking will not work - it\u0027s an issue unrelated with your changes, see the logs from zuul - kuryr cni/controller images are failed to build due to some issue with centos mirrors.\n\nI just confirmed that and its failing all the builds. Any fix being planned?","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"cfc10576902a3636d6db560dddf8f9e5e516e513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fb6e843f_ca99a6f1","in_reply_to":"d3855371_6197dfba","updated":"2022-02-01 13:50:42.000000000","message":"yup, it\u0027s on the way: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/827283","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e8b05957ef319b9be5a33b2b7a0949a6425a143b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"54b22b8e_9c8103d2","updated":"2022-03-08 09:19:11.000000000","message":"recheck\n\nCI is semi-stable now, let\u0027s recheck this.","commit_id":"f4a282e513e1fc2e0d47c2eb454327d01b96c9e2"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"aa1dbb0f4feacfcf12e38b9414fce5f7bc2d3a60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"873356af_6fb695a8","in_reply_to":"54b22b8e_9c8103d2","updated":"2022-03-08 14:18:42.000000000","message":"I think it would need a rebase.","commit_id":"f4a282e513e1fc2e0d47c2eb454327d01b96c9e2"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"7e5513e3238bf267d7f4a849bda0301e19727800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"91b135a7_0656b2c7","updated":"2022-06-15 11:12:38.000000000","message":"recheck","commit_id":"5a7fa774dfe1da7c86b6a671fea6d31e0ea989e7"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"ac5b3885c25f38463fe9a4387d3cb43ee4593d98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"20366e69_61c8de13","updated":"2022-06-22 14:11:26.000000000","message":"Let\u0027s check again","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6532e1912f3e49f2024e8fd260062ab404053e66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"92080f5a_6144daed","updated":"2022-06-22 19:24:42.000000000","message":"Thanks for including this test cover!\nThe tempest test being added is failing. Looks like either we have a small timeout or there might be something wrong with the listener reconciliation.","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"6b1144751bbce0c178a3defa403fdfe9dc38ed25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"795c27d8_3ba28962","updated":"2022-06-22 14:11:10.000000000","message":"recheck","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"f5d9224680c978d948f0bba65978a6d344a49771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"8f25fe56_8a96bb3a","updated":"2022-06-21 06:06:34.000000000","message":"recheck","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"c09aeb86af6fcea816959cad1939378898f7114b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fcfddca7_6576120a","updated":"2022-06-20 19:53:00.000000000","message":"recheck","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"8ae28f0af9a714710c35a50ffd4739ea1f06aade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0abc6429_55379756","updated":"2022-06-25 22:52:25.000000000","message":"recheck","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"24f28123d8570b7f4c21f323cf47f069216b701b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c7e5607b_89d98906","updated":"2022-06-26 06:23:25.000000000","message":"recheck","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"f59e1d7ea6d095025b078cadfe45a02f4c091da2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"fc47d29b_a30a9535","updated":"2022-06-28 19:23:49.000000000","message":"I think there is an issue without adding the LB_TIMEOUT contant. I will try and rebase and see if this solves it","commit_id":"29c6521dcfbfcbbe016a12430c67614da1b71815"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"edc83378c37bab56d9690c7ab8108d15836ec045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"26e3722a_80383df6","in_reply_to":"fc47d29b_a30a9535","updated":"2022-06-28 19:32:12.000000000","message":"I rebased and could still not find the configurations. I doubt if the patchset containing the configuration is merged. 😕","commit_id":"29c6521dcfbfcbbe016a12430c67614da1b71815"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8c8d6a7dad2aee209a334f0c5cfdb852573c015a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"d34bfb66_aee88564","updated":"2022-06-30 21:09:23.000000000","message":"Can you add a depends-on to this patch https://review.opendev.org/c/openstack/kuryr-kubernetes/+/845683? it might help with the Yoga gate.\n\nAlso, as Michal previously mentioned, The listener reconciliation was not added in the Xena cycle and one prior to that, so you need to skip the tests for there releases.\nhttps://github.com/openstack/kuryr-kubernetes/blob/stable/xena/kuryr_kubernetes/controller/handlers/loadbalancer.py#L128-L153","commit_id":"e99de1a59c5c4a73def80abe2a434b3a57218f91"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"fb0194b691de14b823deb06d5e1ea38fffea97a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"7f7b2be7_0eda3d66","updated":"2022-07-07 16:31:24.000000000","message":"recheck","commit_id":"e99de1a59c5c4a73def80abe2a434b3a57218f91"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"d4acf8130ac8c68a52dbc51c7e93c8bf0b10563a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"972d55c1_410d943f","updated":"2022-06-29 09:02:37.000000000","message":"recheck","commit_id":"e99de1a59c5c4a73def80abe2a434b3a57218f91"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"423407fbc9377b79020ba1b3aa465f302c321f26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"e2075045_90b535b6","updated":"2022-06-30 10:51:29.000000000","message":"recheck","commit_id":"e99de1a59c5c4a73def80abe2a434b3a57218f91"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9de9261ab8e69393e31947148d521afb7ffbebf3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"d4707d7e_be72cd64","updated":"2022-08-19 15:31:42.000000000","message":"Tempest tests have to work with any stable version. I see that listener reconciliation is there in Yoga, but not in Xena. You got to add a new flag that enables the new test and default it to false. Then on master and stable/yoga you\u0027ll be able to turn it on, effectively turning on the test there. This should be very similar to [1]. Unfortunately I don\u0027t think there\u0027s another way around this.\n\n[1] https://github.com/openstack/kuryr-tempest-plugin/blob/49088c155a19552ac6f994ea90591c5aa181ea7f/kuryr_tempest_plugin/tests/scenario/test_service.py#L273-L274","commit_id":"da1a0746dec191742af0b2fe4de43ecc1e8236de"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"0f8a3e2d9457b81e84ee352054b6b8c34b02ff71","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"626c937b_a95878c9","in_reply_to":"d4707d7e_be72cd64","updated":"2022-08-20 10:38:58.000000000","message":"\u003e Tempest tests have to work with any stable version. I see that listener reconciliation is there in Yoga, but not in Xena. You got to add a new flag that enables the new test and default it to false. Then on master and stable/yoga you\u0027ll be able to turn it on, effectively turning on the test there. This should be very similar to [1]. Unfortunately I don\u0027t think there\u0027s another way around this.\n\u003e \n\u003e [1] https://github.com/openstack/kuryr-tempest-plugin/blob/49088c155a19552ac6f994ea90591c5aa181ea7f/kuryr_tempest_plugin/tests/scenario/test_service.py#L273-L274\n\nThanks. I have sent in patches for flipping the listener reconciliation for the stable branches. Please take a look. Thanks","commit_id":"da1a0746dec191742af0b2fe4de43ecc1e8236de"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1b7dd9a941221a3957421eae514de7c33c45bc00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"64cbb1fe_5009be22","updated":"2022-08-24 12:47:00.000000000","message":"This should work now, one code organization remark inline.\n\nSeems like CI is broken somehow though, I\u0027m pretty sure it\u0027s unrelated to this patch.","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5f18e049dc462c0897ecf73d1f71b4d9c5ebe020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"5d4a7302_05d2b660","updated":"2022-08-24 12:39:00.000000000","message":"recheck","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"9858145f781dc521ec32d3db4d8c4e17d8032f51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"288af846_76498ac8","in_reply_to":"168ab2bd_bf206906","updated":"2022-08-24 14:37:07.000000000","message":"\u003e Ah no, failures were genuine, so let\u0027s see how it works now.\n\nYou can take a deeper look now. I could see some success and failure for the Listener Reconciliation","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5f1dd7847f764abc226f8f4235fe06206a3e6031","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"168ab2bd_bf206906","in_reply_to":"64cbb1fe_5009be22","updated":"2022-08-24 12:48:51.000000000","message":"Ah no, failures were genuine, so let\u0027s see how it works now.","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"77782f177d22b00e149681a9e727f6ab7664e471","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"463c749a_63e13663","updated":"2022-08-25 07:50:17.000000000","message":"Looks good now, I\u0027d only like the code duplication to be addressed.","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"737b7632702175ffb2699070c8903f5284393a30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"227823c9_bd2fe644","updated":"2022-09-06 14:23:22.000000000","message":"I might need to remove the `Depends-On` patch but we still need it to go in to avoid zuul complaining on Xena","commit_id":"f1bae60126068a2e9c4b5a414fd063485e6d3e7b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c7b7b6f013bedb5428dfa51056013b923cced8d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"6a03d29c_641f7591","updated":"2022-08-31 12:50:35.000000000","message":"Okay, looks good now, let\u0027s see if it\u0027s passing.","commit_id":"f1bae60126068a2e9c4b5a414fd063485e6d3e7b"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"25c226fc8217a450390c407a8ed65af8807a759c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"011ed5b1_2bc73a19","updated":"2022-09-01 06:12:33.000000000","message":"recheck","commit_id":"f1bae60126068a2e9c4b5a414fd063485e6d3e7b"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"6d2a9dd281857396f33b26a7246b293d503dc6ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"357793c3_cff97857","updated":"2022-08-31 17:38:47.000000000","message":"recheck","commit_id":"f1bae60126068a2e9c4b5a414fd063485e6d3e7b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"261b31a3289dd8be1548e7606b77ff356b27d9b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"80cfb906_aa1e354a","updated":"2022-09-01 07:53:14.000000000","message":"recheck","commit_id":"f1bae60126068a2e9c4b5a414fd063485e6d3e7b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9459bac6a28f24818c9249896b4616f7eb6402ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"04b42448_7a3e2f98","updated":"2022-08-31 14:42:34.000000000","message":"recheck\n\nLooks like Amphora job is really faulty. :/","commit_id":"f1bae60126068a2e9c4b5a414fd063485e6d3e7b"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3c871759e34965c825bcd68a525f8bf6ba4c2fa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"80aa5bbb_de249431","updated":"2022-09-07 10:27:03.000000000","message":"let\u0027s see a run with the test green first","commit_id":"e5a94aef465264eb4fdc24174c8833ee674e7110"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"9514563b0930947f4e86015acd8650b2123f1378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"918b44b5_00ae78cb","updated":"2022-09-07 10:22:42.000000000","message":"recheck\n\nFailures look unrelated","commit_id":"e5a94aef465264eb4fdc24174c8833ee674e7110"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"88171a21053892c127fd0c1b695771e8144462a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"ec94c331_85e143f1","updated":"2022-09-09 16:00:47.000000000","message":"recheck\n\nRechecking again and hopefully we shall have a green","commit_id":"e5a94aef465264eb4fdc24174c8833ee674e7110"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"f1a48e3da095e55bbd04840e56334a1bda92c764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"e5861b8a_c807bc9d","updated":"2022-09-09 12:11:45.000000000","message":"recheck\n\nTest has passed","commit_id":"e5a94aef465264eb4fdc24174c8833ee674e7110"}],"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6532e1912f3e49f2024e8fd260062ab404053e66","unresolved":true,"context_lines":[{"line_number":1582,"context_line":"                status \u003d self.get_kuryr_loadbalancer_crds(service_name,"},{"line_number":1583,"context_line":"                                                          namespace).get("},{"line_number":1584,"context_line":"                                                          \u0027status\u0027, {})"},{"line_number":1585,"context_line":"                if resource in [\u0027listeners\u0027]:"},{"line_number":1586,"context_line":"                    new_resource_id \u003d status.get(resource, [])[0].get(\u0027id\u0027)"},{"line_number":1587,"context_line":"                else:"},{"line_number":1588,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"47b27f87_02cea91e","line":1585,"range":{"start_line":1585,"start_character":19,"end_line":1585,"end_character":44},"updated":"2022-06-22 19:24:42.000000000","message":"looks like we can directly check if the resource is the \u0027listener\u0027 constant","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"d9d1e61412be1d9f7bd8d595c06a7dab7f298d42","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"                status \u003d self.get_kuryr_loadbalancer_crds(service_name,"},{"line_number":1583,"context_line":"                                                          namespace).get("},{"line_number":1584,"context_line":"                                                          \u0027status\u0027, {})"},{"line_number":1585,"context_line":"                if resource in [\u0027listeners\u0027]:"},{"line_number":1586,"context_line":"                    new_resource_id \u003d status.get(resource, [])[0].get(\u0027id\u0027)"},{"line_number":1587,"context_line":"                else:"},{"line_number":1588,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"8ad2ee8b_f8e20be7","line":1585,"range":{"start_line":1585,"start_character":19,"end_line":1585,"end_character":44},"in_reply_to":"47b27f87_02cea91e","updated":"2022-06-24 10:53:37.000000000","message":"Done","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4a94e38d3a6758560c65f951db8ebdcb1d26b33b","unresolved":true,"context_lines":[{"line_number":1555,"context_line":"                containers[pod_name][container.name] \u003d container.restart_count"},{"line_number":1556,"context_line":"        return containers"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"    def check_for_resource_reconciliation(self, service_name, namespace,"},{"line_number":1559,"context_line":"                                          svc_pods, resource, resource_id,"},{"line_number":1560,"context_line":"                                          show_resource):"},{"line_number":1561,"context_line":"        LOG.debug(\"Waiting for %s to be completely gone\", resource)"}],"source_content_type":"text/x-python","patch_set":22,"id":"b85d594d_e828fb3b","line":1558,"range":{"start_line":1558,"start_character":62,"end_line":1558,"end_character":71},"updated":"2022-06-27 10:58:42.000000000","message":"this parameter could have a default value of \u0027default\u0027","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4a94e38d3a6758560c65f951db8ebdcb1d26b33b","unresolved":true,"context_lines":[{"line_number":1582,"context_line":"                status \u003d self.get_kuryr_loadbalancer_crds(service_name,"},{"line_number":1583,"context_line":"                                                          namespace).get("},{"line_number":1584,"context_line":"                                                          \u0027status\u0027, {})"},{"line_number":1585,"context_line":"                if resource \u003d\u003d \u0027listeners\u0027:"},{"line_number":1586,"context_line":"                    new_resource_id \u003d status.get(resource, [])[0].get(\u0027id\u0027)"},{"line_number":1587,"context_line":"                else:"},{"line_number":1588,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"2ec57acd_223796b4","line":1585,"range":{"start_line":1585,"start_character":31,"end_line":1585,"end_character":42},"updated":"2022-06-27 10:58:42.000000000","message":"the constant can be used here","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4a94e38d3a6758560c65f951db8ebdcb1d26b33b","unresolved":true,"context_lines":[{"line_number":1602,"context_line":"        LOG.info(\"%s successfully reconciled\", resource)"},{"line_number":1603,"context_line":"        # if there is a connectivity now, that means the KuryrLoadBalancer CRD"},{"line_number":1604,"context_line":"        # resource is reconciled"},{"line_number":1605,"context_line":"        self.check_service_internal_connectivity(service_name\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":22,"id":"84f9d5a8_5585c13f","line":1605,"range":{"start_line":1605,"start_character":48,"end_line":1605,"end_character":75},"updated":"2022-06-27 10:58:42.000000000","message":"perhaps the namespace could be passed as parameter as well?","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"93051e35577305fb91c36404d60d1566f7720c0a","unresolved":true,"context_lines":[{"line_number":1627,"context_line":"                                                          namespace).get("},{"line_number":1628,"context_line":"                                                          \u0027status\u0027, {})"},{"line_number":1629,"context_line":"                if resource \u003d\u003d consts.LISTENER:"},{"line_number":1630,"context_line":"                    new_resource_id \u003d status.get(resource, [])[0].get(\u0027id\u0027)"},{"line_number":1631,"context_line":"                else:"},{"line_number":1632,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"},{"line_number":1633,"context_line":"                new_lb_members \u003d status.get(\u0027members\u0027, [])"}],"source_content_type":"text/x-python","patch_set":31,"id":"fdf5f719_23019a23","line":1630,"range":{"start_line":1630,"start_character":0,"end_line":1630,"end_character":75},"updated":"2022-08-24 15:43:57.000000000","message":"Judging from the failure [1] it seems you can hit a moment when KLB is created, but listener not yet populated there. In such case you got to do continue. I\u0027d modify this line like:\n\n listeners \u003d status.get(resource, [])\n if not listeners:\n     continue\n new_resource_id \u003d listeners[0].get(\u0027id\u0027)\n\n[1] https://8d891edb8e5699635f27-9c76bcf6e457f3db23ca64bd2842f261.ssl.cf5.rackcdn.com/818701/31/check/kuryr-kubernetes-tempest-ipv6-ovs/fa941b7/testr_results.html","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"3d93564026c10d401571dc21231b09056fa7ba69","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"                                                          namespace).get("},{"line_number":1628,"context_line":"                                                          \u0027status\u0027, {})"},{"line_number":1629,"context_line":"                if resource \u003d\u003d consts.LISTENER:"},{"line_number":1630,"context_line":"                    new_resource_id \u003d status.get(resource, [])[0].get(\u0027id\u0027)"},{"line_number":1631,"context_line":"                else:"},{"line_number":1632,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"},{"line_number":1633,"context_line":"                new_lb_members \u003d status.get(\u0027members\u0027, [])"}],"source_content_type":"text/x-python","patch_set":31,"id":"826e15da_fd2a61de","line":1630,"range":{"start_line":1630,"start_character":0,"end_line":1630,"end_character":75},"in_reply_to":"fdf5f719_23019a23","updated":"2022-08-24 20:19:23.000000000","message":"Ack","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"77782f177d22b00e149681a9e727f6ab7664e471","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"                        continue"},{"line_number":1633,"context_line":"                    new_resource_id \u003d listeners[0].get(\u0027id\u0027)"},{"line_number":1634,"context_line":"                else:"},{"line_number":1635,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"},{"line_number":1636,"context_line":"                new_lb_members \u003d status.get(\u0027members\u0027, [])"},{"line_number":1637,"context_line":"                if (new_resource_id \u003d\u003d resource_id or new_resource_id is None"},{"line_number":1638,"context_line":"                        or len(svc_pods) !\u003d len(new_lb_members)):"}],"source_content_type":"text/x-python","patch_set":32,"id":"d211da48_9e2c729d","line":1635,"range":{"start_line":1635,"start_character":0,"end_line":1635,"end_character":72},"updated":"2022-08-25 07:50:17.000000000","message":"This might be unrelated to this particular patch, but I guess we can hit a moment there\u0027s no LB or pool ID yet too. Can you add a check for None in a separate patch? Something like:\n\n if new_resource_id is None:\n     continue","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"cfbe2241a125e0f19e9d0954a383a367640b1534","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"                        continue"},{"line_number":1633,"context_line":"                    new_resource_id \u003d listeners[0].get(\u0027id\u0027)"},{"line_number":1634,"context_line":"                else:"},{"line_number":1635,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"},{"line_number":1636,"context_line":"                new_lb_members \u003d status.get(\u0027members\u0027, [])"},{"line_number":1637,"context_line":"                if (new_resource_id \u003d\u003d resource_id or new_resource_id is None"},{"line_number":1638,"context_line":"                        or len(svc_pods) !\u003d len(new_lb_members)):"}],"source_content_type":"text/x-python","patch_set":32,"id":"5276de9b_7b727b59","line":1635,"range":{"start_line":1635,"start_character":0,"end_line":1635,"end_character":72},"in_reply_to":"4f351819_95af8bda","updated":"2022-08-30 15:04:45.000000000","message":"You can also create a separate tiny patch now, patches are cheap. ;)","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"2fd2c5e62ddd3380b0fcd6ee4edc4e81e695c09f","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"                        continue"},{"line_number":1633,"context_line":"                    new_resource_id \u003d listeners[0].get(\u0027id\u0027)"},{"line_number":1634,"context_line":"                else:"},{"line_number":1635,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"},{"line_number":1636,"context_line":"                new_lb_members \u003d status.get(\u0027members\u0027, [])"},{"line_number":1637,"context_line":"                if (new_resource_id \u003d\u003d resource_id or new_resource_id is None"},{"line_number":1638,"context_line":"                        or len(svc_pods) !\u003d len(new_lb_members)):"}],"source_content_type":"text/x-python","patch_set":32,"id":"d8b6a3d9_e2ef8585","line":1635,"range":{"start_line":1635,"start_character":0,"end_line":1635,"end_character":72},"in_reply_to":"5276de9b_7b727b59","updated":"2022-08-30 16:12:05.000000000","message":"Ack","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"4e8ccd25fde316ccb8f6e33dee4da33bee7b2b7c","unresolved":true,"context_lines":[{"line_number":1632,"context_line":"                        continue"},{"line_number":1633,"context_line":"                    new_resource_id \u003d listeners[0].get(\u0027id\u0027)"},{"line_number":1634,"context_line":"                else:"},{"line_number":1635,"context_line":"                    new_resource_id \u003d status.get(resource, {}).get(\u0027id\u0027)"},{"line_number":1636,"context_line":"                new_lb_members \u003d status.get(\u0027members\u0027, [])"},{"line_number":1637,"context_line":"                if (new_resource_id \u003d\u003d resource_id or new_resource_id is None"},{"line_number":1638,"context_line":"                        or len(svc_pods) !\u003d len(new_lb_members)):"}],"source_content_type":"text/x-python","patch_set":32,"id":"4f351819_95af8bda","line":1635,"range":{"start_line":1635,"start_character":0,"end_line":1635,"end_character":72},"in_reply_to":"d211da48_9e2c729d","updated":"2022-08-29 15:52:03.000000000","message":"\u003e This might be unrelated to this particular patch, but I guess we can hit a moment there\u0027s no LB or pool ID yet too. Can you add a check for None in a separate patch? Something like:\n\u003e \n\u003e  if new_resource_id is None:\n\u003e      continue\n\nOkay that would go into the next patch for pools reconciliations.","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"}],"kuryr_tempest_plugin/tests/scenario/consts.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4a94e38d3a6758560c65f951db8ebdcb1d26b33b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"POD_CHECK_SLEEP_TIME \u003d 5"},{"line_number":24,"context_line":"NP_CHECK_SLEEP_TIME \u003d 10"},{"line_number":25,"context_line":"NS_TIMEOUT \u003d 600"},{"line_number":26,"context_line":"LB_TIMEOUT \u003d 1200"},{"line_number":27,"context_line":"LB_RECONCILE_TIMEOUT \u003d 600"},{"line_number":28,"context_line":"REPETITIONS_PER_BACKEND \u003d 10"},{"line_number":29,"context_line":"LOADBALANCER \u003d \u0027loadbalancer\u0027"},{"line_number":30,"context_line":"LISTENER \u003d \u0027listeners\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"51b9e67e_72ea6c68","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"updated":"2022-06-27 10:58:42.000000000","message":"I don\u0027t think there is a need for this new constants since there are already configuration for these settings.","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"298b9bca9b90b6a57f4e54463581666e40bc237e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"POD_CHECK_SLEEP_TIME \u003d 5"},{"line_number":24,"context_line":"NP_CHECK_SLEEP_TIME \u003d 10"},{"line_number":25,"context_line":"NS_TIMEOUT \u003d 600"},{"line_number":26,"context_line":"LB_TIMEOUT \u003d 1200"},{"line_number":27,"context_line":"LB_RECONCILE_TIMEOUT \u003d 600"},{"line_number":28,"context_line":"REPETITIONS_PER_BACKEND \u003d 10"},{"line_number":29,"context_line":"LOADBALANCER \u003d \u0027loadbalancer\u0027"},{"line_number":30,"context_line":"LISTENER \u003d \u0027listeners\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"9017f5b1_14483734","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":26},"in_reply_to":"51b9e67e_72ea6c68","updated":"2022-06-27 11:06:12.000000000","message":"Sure, I think I used this to resolve a rebase. I would remove","commit_id":"a60e2b2370069cf9341fbabf7fd77c25b474d631"}],"kuryr_tempest_plugin/tests/scenario/test_service.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8665108e701e790851f1b737087f799f8a650099","unresolved":true,"context_lines":[{"line_number":300,"context_line":"                                                          \u0027loadbalancer\u0027,"},{"line_number":301,"context_line":"                                                          {}).get(\u0027id\u0027)"},{"line_number":302,"context_line":"        except kubernetes.client.rest.ApiException:"},{"line_number":303,"context_line":"            raise lib_exc.ServerFault"},{"line_number":304,"context_line":"        # NOTE(digitalsimboja): We need to await for DELETE to"},{"line_number":305,"context_line":"        # complete on Octavia"},{"line_number":306,"context_line":"        self.lbaas.delete_loadbalancer(klb_crd_id, cascade\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"d78954e0_def38aad","line":303,"range":{"start_line":303,"start_character":11,"end_line":303,"end_character":37},"updated":"2021-12-24 10:37:58.000000000","message":"Can we include the message from K8s?","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"46fd3546f8195dcd9ecead68ea87c10b706cbee8","unresolved":true,"context_lines":[{"line_number":300,"context_line":"                                                          \u0027loadbalancer\u0027,"},{"line_number":301,"context_line":"                                                          {}).get(\u0027id\u0027)"},{"line_number":302,"context_line":"        except kubernetes.client.rest.ApiException:"},{"line_number":303,"context_line":"            raise lib_exc.ServerFault"},{"line_number":304,"context_line":"        # NOTE(digitalsimboja): We need to await for DELETE to"},{"line_number":305,"context_line":"        # complete on Octavia"},{"line_number":306,"context_line":"        self.lbaas.delete_loadbalancer(klb_crd_id, cascade\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"b5af1745_5bd8d48b","line":303,"range":{"start_line":303,"start_character":11,"end_line":303,"end_character":37},"in_reply_to":"d78954e0_def38aad","updated":"2022-01-31 16:39:00.000000000","message":"\u003e Can we include the message from K8s?\n\nI suppose raising this exception returns status-code \"500\" and with message \"Got server fault\" directly from the tempest plugin. Do you think I still go ahead to include the message here or simply execute ` raise lib_exc.ServerFault()` which would rather return the message above?","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8665108e701e790851f1b737087f799f8a650099","unresolved":true,"context_lines":[{"line_number":327,"context_line":"                                                           \u0027listeners\u0027,"},{"line_number":328,"context_line":"                                                           [])[0].get(\u0027id\u0027)"},{"line_number":329,"context_line":"        except kubernetes.client.rest.ApiException:"},{"line_number":330,"context_line":"            raise lib_exc.ServerFault"},{"line_number":331,"context_line":"        self.lsnr_client.delete_listener(klb_lsnr_id)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        self.check_for_resource_reconciliation(service_name, namespace,"}],"source_content_type":"text/x-python","patch_set":14,"id":"a36dab65_c9a8cf37","line":330,"range":{"start_line":330,"start_character":12,"end_line":330,"end_character":37},"updated":"2021-12-24 10:37:58.000000000","message":"Could we include the message?","commit_id":"84fa2e9b516f0ddd46e16923b631d112341b8a6b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"76fc43445e8a951f8b2238ae9b7e949203f24440","unresolved":true,"context_lines":[{"line_number":277,"context_line":"    def setup_clients(cls):"},{"line_number":278,"context_line":"        super(TestLoadBalancerReconciliationScenario, cls).setup_clients()"},{"line_number":279,"context_line":"        cls.lbaas \u003d cls.os_roles_lb_admin.load_balancer_v2.LoadbalancerClient()"},{"line_number":280,"context_line":"        cls.lsnr_client \u003d cls.os_primary.load_balancer_v2.ListenerClient()"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-228c92a4da7f\u0027)"},{"line_number":283,"context_line":"    def test_loadbalancers_reconcilation(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"d62dd004_59fd4535","line":280,"range":{"start_line":280,"start_character":30,"end_line":280,"end_character":40},"updated":"2022-02-09 09:20:13.000000000","message":"I guess you got to use os_roles_lb_admin here too.","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"878fdc1d61c9e589e705035c8f97d0741618ccfe","unresolved":true,"context_lines":[{"line_number":277,"context_line":"    def setup_clients(cls):"},{"line_number":278,"context_line":"        super(TestLoadBalancerReconciliationScenario, cls).setup_clients()"},{"line_number":279,"context_line":"        cls.lbaas \u003d cls.os_roles_lb_admin.load_balancer_v2.LoadbalancerClient()"},{"line_number":280,"context_line":"        cls.lsnr_client \u003d cls.os_primary.load_balancer_v2.ListenerClient()"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-228c92a4da7f\u0027)"},{"line_number":283,"context_line":"    def test_loadbalancers_reconcilation(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ec128bdb_26affcdc","line":280,"range":{"start_line":280,"start_character":30,"end_line":280,"end_character":40},"in_reply_to":"d62dd004_59fd4535","updated":"2022-02-09 09:22:25.000000000","message":"\u003e I guess you got to use os_roles_lb_admin here too.\n\nThanks let me try that.","commit_id":"c211fb363fb1dae18f4775c226ef7bfee8e434a7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6532e1912f3e49f2024e8fd260062ab404053e66","unresolved":true,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":311,"context_line":"    def test_listeners_reconcilation(self):"},{"line_number":312,"context_line":"        service_name \u003d \"listener-reconciliation-demo\""},{"line_number":313,"context_line":"        namespace \u003d \"default\""},{"line_number":314,"context_line":"        resource \u003d \"listeners\""},{"line_number":315,"context_line":"        _, svc_pods \u003d self.create_setup_for_service_test("}],"source_content_type":"text/x-python","patch_set":20,"id":"87e7dbfb_f124c711","line":312,"updated":"2022-06-22 19:24:42.000000000","message":"let\u0027s add a random sufix to the name, same would apply for the load-balancer test","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6c6700f3c429c8b8ef640ef7ccf728460a26aada","unresolved":true,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":311,"context_line":"    def test_listeners_reconcilation(self):"},{"line_number":312,"context_line":"        service_name \u003d \"listener-reconciliation-demo\""},{"line_number":313,"context_line":"        namespace \u003d \"default\""},{"line_number":314,"context_line":"        resource \u003d \"listeners\""},{"line_number":315,"context_line":"        _, svc_pods \u003d self.create_setup_for_service_test("}],"source_content_type":"text/x-python","patch_set":20,"id":"d6daaef9_7ae1b9c2","line":312,"in_reply_to":"87e7dbfb_f124c711","updated":"2022-06-22 19:26:05.000000000","message":"example https://github.com/openstack/kuryr-tempest-plugin/blob/master/kuryr_tempest_plugin/tests/scenario/base.py#L99","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"d9d1e61412be1d9f7bd8d595c06a7dab7f298d42","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":311,"context_line":"    def test_listeners_reconcilation(self):"},{"line_number":312,"context_line":"        service_name \u003d \"listener-reconciliation-demo\""},{"line_number":313,"context_line":"        namespace \u003d \"default\""},{"line_number":314,"context_line":"        resource \u003d \"listeners\""},{"line_number":315,"context_line":"        _, svc_pods \u003d self.create_setup_for_service_test("}],"source_content_type":"text/x-python","patch_set":20,"id":"ff0773b6_d4b284d3","line":312,"in_reply_to":"d6daaef9_7ae1b9c2","updated":"2022-06-24 10:53:37.000000000","message":"Done","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6532e1912f3e49f2024e8fd260062ab404053e66","unresolved":true,"context_lines":[{"line_number":311,"context_line":"    def test_listeners_reconcilation(self):"},{"line_number":312,"context_line":"        service_name \u003d \"listener-reconciliation-demo\""},{"line_number":313,"context_line":"        namespace \u003d \"default\""},{"line_number":314,"context_line":"        resource \u003d \"listeners\""},{"line_number":315,"context_line":"        _, svc_pods \u003d self.create_setup_for_service_test("},{"line_number":316,"context_line":"                service_name\u003dservice_name)"},{"line_number":317,"context_line":"        self.check_service_internal_connectivity(service_name\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":20,"id":"48cdb1f6_6bcc8536","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":30},"updated":"2022-06-22 19:24:42.000000000","message":"might be better to specify it as a constant in the constant file","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"d9d1e61412be1d9f7bd8d595c06a7dab7f298d42","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_listeners_reconcilation(self):"},{"line_number":312,"context_line":"        service_name \u003d \"listener-reconciliation-demo\""},{"line_number":313,"context_line":"        namespace \u003d \"default\""},{"line_number":314,"context_line":"        resource \u003d \"listeners\""},{"line_number":315,"context_line":"        _, svc_pods \u003d self.create_setup_for_service_test("},{"line_number":316,"context_line":"                service_name\u003dservice_name)"},{"line_number":317,"context_line":"        self.check_service_internal_connectivity(service_name\u003dservice_name)"}],"source_content_type":"text/x-python","patch_set":20,"id":"6304d471_fe18851c","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":30},"in_reply_to":"48cdb1f6_6bcc8536","updated":"2022-06-24 10:53:37.000000000","message":"Ack","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6532e1912f3e49f2024e8fd260062ab404053e66","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            klb_lsnr_id \u003d self.get_kuryr_loadbalancer_crds(service_name,"},{"line_number":322,"context_line":"                                                           namespace).get("},{"line_number":323,"context_line":"                                                           \u0027status\u0027, {}).get("},{"line_number":324,"context_line":"                                                           \u0027listeners\u0027,"},{"line_number":325,"context_line":"                                                           [])[0].get(\u0027id\u0027)"},{"line_number":326,"context_line":"        except kubernetes.client.rest.ApiException:"},{"line_number":327,"context_line":"            raise lib_exc.ServerFault()"}],"source_content_type":"text/x-python","patch_set":20,"id":"58e88cd3_3b81caee","line":324,"range":{"start_line":324,"start_character":59,"end_line":324,"end_character":70},"updated":"2022-06-22 19:24:42.000000000","message":"resources constant can be used here.","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"d9d1e61412be1d9f7bd8d595c06a7dab7f298d42","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            klb_lsnr_id \u003d self.get_kuryr_loadbalancer_crds(service_name,"},{"line_number":322,"context_line":"                                                           namespace).get("},{"line_number":323,"context_line":"                                                           \u0027status\u0027, {}).get("},{"line_number":324,"context_line":"                                                           \u0027listeners\u0027,"},{"line_number":325,"context_line":"                                                           [])[0].get(\u0027id\u0027)"},{"line_number":326,"context_line":"        except kubernetes.client.rest.ApiException:"},{"line_number":327,"context_line":"            raise lib_exc.ServerFault()"}],"source_content_type":"text/x-python","patch_set":20,"id":"40d25524_dc6664eb","line":324,"range":{"start_line":324,"start_character":59,"end_line":324,"end_character":70},"in_reply_to":"58e88cd3_3b81caee","updated":"2022-06-24 10:53:37.000000000","message":"Ack","commit_id":"24b8e47ebaa42ddfd9c3236c20c1046ae185d3da"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"5cbe85a9c80a9dfa991838ee2ebd1e83a7529838","unresolved":true,"context_lines":[{"line_number":272,"context_line":"            raise cls.skipException(\"Service tests are not enabled\")"},{"line_number":273,"context_line":"        if not CONF.kuryr_kubernetes.enable_reconciliation:"},{"line_number":274,"context_line":"            raise cls.skipException(\"Reconciliation is not enabled\")"},{"line_number":275,"context_line":"        if not CONF.kuryr_kubernetes.listener_reconciliation:"},{"line_number":276,"context_line":"            raise cls.skipException(\"Listener reconciliation is not enabled\")"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":30,"id":"ffb53946_4d4f2d2b","line":275,"range":{"start_line":275,"start_character":37,"end_line":275,"end_character":60},"updated":"2022-08-24 10:27:45.000000000","message":"Is this configuration being defined anywhere?\n\nLet\u0027s include it in the configurations like you did for the \"enable_reconciliation\"\nhttps://github.com/openstack/kuryr-tempest-plugin/commit/ddef1710fb33463c2898d4011ed44d6441f55b78","commit_id":"27e056478f7ae9638c6209c28c6bbf5a7ee35ccd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1b7dd9a941221a3957421eae514de7c33c45bc00","unresolved":true,"context_lines":[{"line_number":318,"context_line":"            raise cls.skipException(\"Service tests are not enabled\")"},{"line_number":319,"context_line":"        if not CONF.kuryr_kubernetes.enable_listener_reconciliation:"},{"line_number":320,"context_line":"            raise cls.skipException(\"Listener reconciliation is not enabled\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @classmethod"},{"line_number":323,"context_line":"    def setup_clients(cls):"},{"line_number":324,"context_line":"        super(TestListenerReconciliationScenario, cls).setup_clients()"},{"line_number":325,"context_line":"        cls.lsnr \u003d cls.os_roles_lb_admin.load_balancer_v2.ListenerClient()"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":328,"context_line":"    def test_listeners_reconcilation(self):"},{"line_number":329,"context_line":"        service_name \u003d data_utils.rand_name("}],"source_content_type":"text/x-python","patch_set":31,"id":"0ab1e268_6d32031d","line":326,"range":{"start_line":321,"start_character":0,"end_line":326,"end_character":0},"updated":"2022-08-24 12:47:00.000000000","message":"Instead of duplicating this and `credentials` class property, you should create a base class for reconciliation tests and put that there.","commit_id":"74e1046192f901104e3602fcad235a8844dc34f6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"77782f177d22b00e149681a9e727f6ab7664e471","unresolved":true,"context_lines":[{"line_number":319,"context_line":"        if not CONF.kuryr_kubernetes.enable_listener_reconciliation:"},{"line_number":320,"context_line":"            raise cls.skipException(\"Listener reconciliation is not enabled\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @classmethod"},{"line_number":323,"context_line":"    def setup_clients(cls):"},{"line_number":324,"context_line":"        super(TestListenerReconciliationScenario, cls).setup_clients()"},{"line_number":325,"context_line":"        cls.lsnr \u003d cls.os_roles_lb_admin.load_balancer_v2.ListenerClient()"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":328,"context_line":"    def test_listeners_reconcilation(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"0ffaabe6_bc6595c5","line":325,"range":{"start_line":322,"start_character":0,"end_line":325,"end_character":74},"updated":"2022-08-25 07:50:17.000000000","message":"Repeating the comment from the previous patchset:\n\nInstead of duplicating this and `credentials` class property, you should create a base class for reconciliation tests and put that there.","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"4e8ccd25fde316ccb8f6e33dee4da33bee7b2b7c","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        if not CONF.kuryr_kubernetes.enable_listener_reconciliation:"},{"line_number":320,"context_line":"            raise cls.skipException(\"Listener reconciliation is not enabled\")"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @classmethod"},{"line_number":323,"context_line":"    def setup_clients(cls):"},{"line_number":324,"context_line":"        super(TestListenerReconciliationScenario, cls).setup_clients()"},{"line_number":325,"context_line":"        cls.lsnr \u003d cls.os_roles_lb_admin.load_balancer_v2.ListenerClient()"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":328,"context_line":"    def test_listeners_reconcilation(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"6db16022_59811c89","line":325,"range":{"start_line":322,"start_character":0,"end_line":325,"end_character":74},"in_reply_to":"0ffaabe6_bc6595c5","updated":"2022-08-29 15:52:03.000000000","message":"Ack","commit_id":"df58cf296bcf2d766320fddaf6c0bdd6c966f6f2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a48d83e7d31b700e4fba9f95cc8356e9c554209a","unresolved":true,"context_lines":[{"line_number":264,"context_line":"class TestLoadBalancerReconciliationScenario("},{"line_number":265,"context_line":"        base.BaseReconciliationScenarioTest):"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    @classmethod"},{"line_number":268,"context_line":"    def setup_clients(cls):"},{"line_number":269,"context_line":"        super(TestLoadBalancerReconciliationScenario, cls).setup_clients()"},{"line_number":270,"context_line":"        cls.lbaas \u003d cls.os_roles_lb_admin.load_balancer_v2.LoadbalancerClient()"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-228c92a4da7f\u0027)"},{"line_number":273,"context_line":"    def test_loadbalancers_reconcilation(self):"},{"line_number":274,"context_line":"        service_name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-loadbalancer\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"ec1bcf28_6ddce74c","line":271,"range":{"start_line":267,"start_character":0,"end_line":271,"end_character":0},"updated":"2022-08-31 10:38:40.000000000","message":"Is this necessary if already done on the base class?","commit_id":"25aae2dd00feb1136a39ad5f813c489284144191"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"771107bc5fb972cff9fe602873530528cfd7ba96","unresolved":false,"context_lines":[{"line_number":264,"context_line":"class TestLoadBalancerReconciliationScenario("},{"line_number":265,"context_line":"        base.BaseReconciliationScenarioTest):"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    @classmethod"},{"line_number":268,"context_line":"    def setup_clients(cls):"},{"line_number":269,"context_line":"        super(TestLoadBalancerReconciliationScenario, cls).setup_clients()"},{"line_number":270,"context_line":"        cls.lbaas \u003d cls.os_roles_lb_admin.load_balancer_v2.LoadbalancerClient()"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-228c92a4da7f\u0027)"},{"line_number":273,"context_line":"    def test_loadbalancers_reconcilation(self):"},{"line_number":274,"context_line":"        service_name \u003d data_utils.rand_name(prefix\u003d\u0027kuryr-loadbalancer\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"57a5a291_7945ec4c","line":271,"range":{"start_line":267,"start_character":0,"end_line":271,"end_character":0},"in_reply_to":"ec1bcf28_6ddce74c","updated":"2022-08-31 12:22:40.000000000","message":"Done","commit_id":"25aae2dd00feb1136a39ad5f813c489284144191"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a48d83e7d31b700e4fba9f95cc8356e9c554209a","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        if not CONF.kuryr_kubernetes.enable_listener_reconciliation:"},{"line_number":307,"context_line":"            raise cls.skipException(\"Listener reconciliation is not enabled\")"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @classmethod"},{"line_number":310,"context_line":"    def setup_clients(cls):"},{"line_number":311,"context_line":"        super(TestListenerReconciliationScenario, cls).setup_clients()"},{"line_number":312,"context_line":"        cls.lsnr \u003d cls.os_roles_lb_admin.load_balancer_v2.ListenerClient()"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":315,"context_line":"    def test_listeners_reconcilation(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"74c6a607_379c4013","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":74},"updated":"2022-08-31 10:38:40.000000000","message":"Same here.","commit_id":"25aae2dd00feb1136a39ad5f813c489284144191"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"771107bc5fb972cff9fe602873530528cfd7ba96","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        if not CONF.kuryr_kubernetes.enable_listener_reconciliation:"},{"line_number":307,"context_line":"            raise cls.skipException(\"Listener reconciliation is not enabled\")"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @classmethod"},{"line_number":310,"context_line":"    def setup_clients(cls):"},{"line_number":311,"context_line":"        super(TestListenerReconciliationScenario, cls).setup_clients()"},{"line_number":312,"context_line":"        cls.lsnr \u003d cls.os_roles_lb_admin.load_balancer_v2.ListenerClient()"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @decorators.idempotent_id(\u0027da9bd886-e895-4869-b356-230c92a5da8c\u0027)"},{"line_number":315,"context_line":"    def test_listeners_reconcilation(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"46c00115_497c91e2","line":312,"range":{"start_line":309,"start_character":0,"end_line":312,"end_character":74},"in_reply_to":"74c6a607_379c4013","updated":"2022-08-31 12:22:40.000000000","message":"Done","commit_id":"25aae2dd00feb1136a39ad5f813c489284144191"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"5c2432131b46e749144b2c6bd39a645706ad3924","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @classmethod"},{"line_number":269,"context_line":"    def skip_checks(cls):"},{"line_number":270,"context_line":"        super(TestLoadBalancerReconciliationScenario, cls).skip_checks()"},{"line_number":271,"context_line":"        if not CONF.kuryr_kubernetes.service_tests_enabled:"},{"line_number":272,"context_line":"            raise cls.skipException(\"Service tests are not enabled\")"},{"line_number":273,"context_line":"        if not CONF.kuryr_kubernetes.enable_reconciliation:"}],"source_content_type":"text/x-python","patch_set":36,"id":"48032cf2_5a424688","side":"PARENT","line":270,"updated":"2022-09-07 10:16:15.000000000","message":"Why are these skips being removed? Shouldn\u0027t they remain here to ensure this test only runs when those configs are enabled?","commit_id":"4b0fceea709fe9fb23764174444b88087d262490"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e594ac6ff3d50af82c1202d67bbc685c717985be","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @classmethod"},{"line_number":269,"context_line":"    def skip_checks(cls):"},{"line_number":270,"context_line":"        super(TestLoadBalancerReconciliationScenario, cls).skip_checks()"},{"line_number":271,"context_line":"        if not CONF.kuryr_kubernetes.service_tests_enabled:"},{"line_number":272,"context_line":"            raise cls.skipException(\"Service tests are not enabled\")"},{"line_number":273,"context_line":"        if not CONF.kuryr_kubernetes.enable_reconciliation:"}],"source_content_type":"text/x-python","patch_set":36,"id":"29e93cdd_f1b5e3b5","side":"PARENT","line":270,"in_reply_to":"48032cf2_5a424688","updated":"2022-09-07 10:17:27.000000000","message":"disregard it, I noticed this is being inherited now","commit_id":"4b0fceea709fe9fb23764174444b88087d262490"}]}