)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"5d7b6499c378b2711950862c168a104d3e26aca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"399494fa_36a4d91b","updated":"2022-03-22 14:21:40.000000000","message":"recheck","commit_id":"67e65f207a206621c072c298cbc66df5da8d7046"}],"kuryr_tempest_plugin/tests/scenario/base.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"abc130c53b93ef2f5c2a5cf202daa55ed4e7b684","unresolved":true,"context_lines":[{"line_number":224,"context_line":"            else:"},{"line_number":225,"context_line":"                raise"},{"line_number":226,"context_line":"        retries \u003d 6"},{"line_number":227,"context_line":"        while retries \u003e 0:"},{"line_number":228,"context_line":"            try:"},{"line_number":229,"context_line":"                pod \u003d cls.k8s_client.CoreV1Api().read_namespaced_pod("},{"line_number":230,"context_line":"                    pod_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b41764f_a90ff8ca","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":26},"updated":"2022-03-22 10:03:06.000000000","message":"Should we add an `else` to the `while` with a warning log that pod is not gone after 30 seconds? I can agree that such an error shouldn\u0027t be fatal.","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"919a03e14fcec7e81d123235ad144bbe109c2145","unresolved":true,"context_lines":[{"line_number":224,"context_line":"            else:"},{"line_number":225,"context_line":"                raise"},{"line_number":226,"context_line":"        retries \u003d 6"},{"line_number":227,"context_line":"        while retries \u003e 0:"},{"line_number":228,"context_line":"            try:"},{"line_number":229,"context_line":"                pod \u003d cls.k8s_client.CoreV1Api().read_namespaced_pod("},{"line_number":230,"context_line":"                    pod_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef24319d_86389f32","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":26},"in_reply_to":"5b41764f_a90ff8ca","updated":"2022-03-22 10:32:45.000000000","message":"yeah. Thanks!","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"5e2084c5d7b9403812f66de355d33a7f501e96b5","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            else:"},{"line_number":225,"context_line":"                raise"},{"line_number":226,"context_line":"        retries \u003d 6"},{"line_number":227,"context_line":"        while retries \u003e 0:"},{"line_number":228,"context_line":"            try:"},{"line_number":229,"context_line":"                pod \u003d cls.k8s_client.CoreV1Api().read_namespaced_pod("},{"line_number":230,"context_line":"                    pod_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e9ce0ed_6146bcbf","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":26},"in_reply_to":"ef24319d_86389f32","updated":"2022-03-27 07:20:39.000000000","message":"Done","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"abc130c53b93ef2f5c2a5cf202daa55ed4e7b684","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                pod \u003d cls.k8s_client.CoreV1Api().read_namespaced_pod("},{"line_number":230,"context_line":"                    pod_name,"},{"line_number":231,"context_line":"                    namespace)"},{"line_number":232,"context_line":"                time.sleep(5)"},{"line_number":233,"context_line":"            except kubernetes.client.exceptions.ApiException as e:"},{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec2d931b_5d7f20c9","line":232,"range":{"start_line":232,"start_character":0,"end_line":232,"end_character":29},"updated":"2022-03-22 10:03:06.000000000","message":"Wouldn\u0027t it be better to move this before first read?","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"5e2084c5d7b9403812f66de355d33a7f501e96b5","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                pod \u003d cls.k8s_client.CoreV1Api().read_namespaced_pod("},{"line_number":230,"context_line":"                    pod_name,"},{"line_number":231,"context_line":"                    namespace)"},{"line_number":232,"context_line":"                time.sleep(5)"},{"line_number":233,"context_line":"            except kubernetes.client.exceptions.ApiException as e:"},{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"41aa9afb_e9e9b587","line":232,"range":{"start_line":232,"start_character":0,"end_line":232,"end_character":29},"in_reply_to":"0dfc7212_8336cc49","updated":"2022-03-27 07:20:39.000000000","message":"Done","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"919a03e14fcec7e81d123235ad144bbe109c2145","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                pod \u003d cls.k8s_client.CoreV1Api().read_namespaced_pod("},{"line_number":230,"context_line":"                    pod_name,"},{"line_number":231,"context_line":"                    namespace)"},{"line_number":232,"context_line":"                time.sleep(5)"},{"line_number":233,"context_line":"            except kubernetes.client.exceptions.ApiException as e:"},{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"0dfc7212_8336cc49","line":232,"range":{"start_line":232,"start_character":0,"end_line":232,"end_character":29},"in_reply_to":"ec2d931b_5d7f20c9","updated":"2022-03-22 10:32:45.000000000","message":"I can but maybe it will be deleted even before the first read :-)","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"abc130c53b93ef2f5c2a5cf202daa55ed4e7b684","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @classmethod"},{"line_number":240,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":1,"id":"824dda1e_efdb5366","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":25},"updated":"2022-03-22 10:03:06.000000000","message":"I\u0027m not sure this should really be fatal, if the API connectivity failure happens once or twice, it shouldn\u0027t really affect the tests execution.","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"5e2084c5d7b9403812f66de355d33a7f501e96b5","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @classmethod"},{"line_number":240,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":1,"id":"d015dc44_6958d5f4","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":25},"in_reply_to":"4bed8b6e_1d26db2e","updated":"2022-03-27 07:20:39.000000000","message":"Done","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"919a03e14fcec7e81d123235ad144bbe109c2145","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @classmethod"},{"line_number":240,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fb817192_c28665b0","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":25},"in_reply_to":"824dda1e_efdb5366","updated":"2022-03-22 10:32:45.000000000","message":"yes, my bad.","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"c4f27b7133c794f181f9c4f6d2d2a507c07ccbe0","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @classmethod"},{"line_number":240,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":1,"id":"4bed8b6e_1d26db2e","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":25},"in_reply_to":"cb7d630d_93b66f43","updated":"2022-03-23 10:35:54.000000000","message":"+1","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"397c9eda1db8f065361b371ef1f61c88c2730d1a","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                if e.status \u003d\u003d 404:"},{"line_number":235,"context_line":"                    break"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @classmethod"},{"line_number":240,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":1,"id":"cb7d630d_93b66f43","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":25},"in_reply_to":"fb817192_c28665b0","updated":"2022-03-23 08:29:18.000000000","message":"It\u0027s still fatal, right?","commit_id":"84638701006643e35e9f5e506f185dc6995d6ea1"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"c4f27b7133c794f181f9c4f6d2d2a507c07ccbe0","unresolved":true,"context_lines":[{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":"        else:"},{"line_number":239,"context_line":"            LOG.debug(f\"Timeout - Pod {pod_name} was not deleted found.\")"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @classmethod"},{"line_number":242,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":2,"id":"e9c32124_45c79558","line":239,"range":{"start_line":239,"start_character":57,"end_line":239,"end_character":71},"updated":"2022-03-23 10:35:54.000000000","message":"you mean: deleted *or* not found?","commit_id":"67e65f207a206621c072c298cbc66df5da8d7046"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"5e2084c5d7b9403812f66de355d33a7f501e96b5","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    raise"},{"line_number":238,"context_line":"        else:"},{"line_number":239,"context_line":"            LOG.debug(f\"Timeout - Pod {pod_name} was not deleted found.\")"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @classmethod"},{"line_number":242,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":2,"id":"aaacb5a6_2c941f98","line":239,"range":{"start_line":239,"start_character":57,"end_line":239,"end_character":71},"in_reply_to":"e9c32124_45c79558","updated":"2022-03-27 07:20:39.000000000","message":"I changed the message","commit_id":"67e65f207a206621c072c298cbc66df5da8d7046"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"09f7a537ee201164fadc767f2c02f9b5dc2b1a89","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        except kubernetes.client.exceptions.ApiException as e:"},{"line_number":222,"context_line":"            if e.status !\u003d 404:"},{"line_number":223,"context_line":"                raise"},{"line_number":224,"context_line":"            LOG.debug(f\"Pod {pod_name} was not found.\")"},{"line_number":225,"context_line":"        retries \u003d 6"},{"line_number":226,"context_line":"        while retries \u003e 0:"},{"line_number":227,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"c7343c0c_39fce88b","line":224,"updated":"2022-03-28 10:09:18.000000000","message":"nit: fstring shouldn\u0027t be used with logger functions, since they looks basically like this:\n\n  def info(msg, *args):\n      if isEnabledFor(INFO):\n          print(msg % args)\n\nso the msg string will be interpolated with values only when needed, depending on the log level.","commit_id":"7107dd01a27d4853934057d95b413de6da8ba02c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"09f7a537ee201164fadc767f2c02f9b5dc2b1a89","unresolved":true,"context_lines":[{"line_number":231,"context_line":"                time.sleep(5)"},{"line_number":232,"context_line":"            except kubernetes.client.exceptions.ApiException as e:"},{"line_number":233,"context_line":"                if e.status !\u003d 404:"},{"line_number":234,"context_line":"                    LOG.warning(f\"An exception occured: {e}\")"},{"line_number":235,"context_line":"                break"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            LOG.debug(f\"Timeout - Pod {pod_name} has not been deleted yet.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"b023f539_4d9303f8","line":234,"updated":"2022-03-28 10:09:18.000000000","message":"ditto.","commit_id":"7107dd01a27d4853934057d95b413de6da8ba02c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"09f7a537ee201164fadc767f2c02f9b5dc2b1a89","unresolved":true,"context_lines":[{"line_number":234,"context_line":"                    LOG.warning(f\"An exception occured: {e}\")"},{"line_number":235,"context_line":"                break"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            LOG.debug(f\"Timeout - Pod {pod_name} has not been deleted yet.\")"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @classmethod"},{"line_number":240,"context_line":"    def wait_for_pod_status(cls, pod_name, namespace\u003d\"default\","}],"source_content_type":"text/x-python","patch_set":4,"id":"d95531db_4ad4d2bc","line":237,"updated":"2022-03-28 10:09:18.000000000","message":"ditto.","commit_id":"7107dd01a27d4853934057d95b413de6da8ba02c"}]}