)]}'
{"kuryr/binding.py":[{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"89bbaba71fa1a384a9734b200fcc5c5e98bef0c1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    # don\u0027t import it in the module scope but here."},{"line_number":130,"context_line":"    import pyroute2.netlink"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    unbinding_exec_path \u003d config.CONF.binding.unbinding_executable_path"},{"line_number":133,"context_line":"    port_id \u003d neutron_port[\u0027id\u0027]"},{"line_number":134,"context_line":"    stdout, stderr \u003d processutils.execute("},{"line_number":135,"context_line":"        \u0027bash\u0027, unbinding_exec_path, port_id, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa80f949_19634cb3","line":132,"updated":"2015-11-03 13:19:54.000000000","message":"same about using vif_type to find the executable. Rather than having config.CONF.binding.binding_executable_path and config.CONF.binding.unbinding_executable_path, I\u0027d much rather use:\n\n    os.path.join(config.CONF.bindir, vif_type)","commit_id":"695da59b09d1d19cbe807abc9b9d6fc3f4e3d644"}],"kuryr/tests/test_join.py":[{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"9a43e338a20ddea30948b5419696e098619f1146","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return fake_binding_response"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @ddt.data(exceptions.VethCreationFailure,"},{"line_number":68,"context_line":"              processutils.ProcessExecutionError)"},{"line_number":69,"context_line":"    def test_join_veth_failures(self, GivenException):"},{"line_number":70,"context_line":"        fake_docker_network_id \u003d hashlib.sha256("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_6d5b3488","line":67,"updated":"2015-10-15 08:33:35.000000000","message":"This should happen in the patch for Join.","commit_id":"a413175cbfea2a5d9ba75ec5849b081468205342"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"7b135af3afbef1cef61eebdbfc8abf679edf3a80","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return fake_binding_response"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @ddt.data(exceptions.VethCreationFailure,"},{"line_number":68,"context_line":"              processutils.ProcessExecutionError)"},{"line_number":69,"context_line":"    def test_join_veth_failures(self, GivenException):"},{"line_number":70,"context_line":"        fake_docker_network_id \u003d hashlib.sha256("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_a3bb9de4","line":67,"in_reply_to":"5a2ca52d_6d5b3488","updated":"2015-10-15 09:16:13.000000000","message":"Done","commit_id":"a413175cbfea2a5d9ba75ec5849b081468205342"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"9a43e338a20ddea30948b5419696e098619f1146","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            fake_neutron_subnets_response)"},{"line_number":98,"context_line":"        fake_neutron_port \u003d fake_neutron_ports_response[\u0027ports\u0027][0]"},{"line_number":99,"context_line":"        fake_neutron_subnets \u003d fake_neutron_subnets_response[\u0027subnets\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        fake_message \u003d \"fake message\""},{"line_number":102,"context_line":"        fake_exception \u003d GivenException(fake_message)"},{"line_number":103,"context_line":"        self._port_bind_with_exeption("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_ed4f44bb","line":100,"updated":"2015-10-15 08:33:35.000000000","message":"Unnecessary change.","commit_id":"a413175cbfea2a5d9ba75ec5849b081468205342"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"7b135af3afbef1cef61eebdbfc8abf679edf3a80","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            fake_neutron_subnets_response)"},{"line_number":98,"context_line":"        fake_neutron_port \u003d fake_neutron_ports_response[\u0027ports\u0027][0]"},{"line_number":99,"context_line":"        fake_neutron_subnets \u003d fake_neutron_subnets_response[\u0027subnets\u0027]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        fake_message \u003d \"fake message\""},{"line_number":102,"context_line":"        fake_exception \u003d GivenException(fake_message)"},{"line_number":103,"context_line":"        self._port_bind_with_exeption("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_c3bed9d3","line":100,"in_reply_to":"5a2ca52d_ed4f44bb","updated":"2015-10-15 09:16:13.000000000","message":"Done","commit_id":"a413175cbfea2a5d9ba75ec5849b081468205342"}],"usr/libexec/kuryr/binding/midonet_unbinding.sh":[{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"9a43e338a20ddea30948b5419696e098619f1146","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"echo \"Unbinding Neutron port $1...\""},{"line_number":15,"context_line":"mm-ctl --unbind-port $1"},{"line_number":16,"context_line":"echo \"Done.\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a2ca52d_cd7da8e8","line":16,"updated":"2015-10-15 08:33:35.000000000","message":"This should be:\n\nmm-ctl --unbind-port $1 \u0026\u0026 echo \"Done.\"","commit_id":"a413175cbfea2a5d9ba75ec5849b081468205342"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"7b135af3afbef1cef61eebdbfc8abf679edf3a80","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"echo \"Unbinding Neutron port $1...\""},{"line_number":15,"context_line":"mm-ctl --unbind-port $1"},{"line_number":16,"context_line":"echo \"Done.\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a2ca52d_63b585ec","line":16,"in_reply_to":"5a2ca52d_cd7da8e8","updated":"2015-10-15 09:16:13.000000000","message":"Done","commit_id":"a413175cbfea2a5d9ba75ec5849b081468205342"}]}