)]}'
{"kuryr/controllers.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b1167b63043160d2d53d0e56039fd28318ddf8e2","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    subnets \u003d _get_subnets_by_attrs("},{"line_number":446,"context_line":"        network_id\u003dnetwork[\u0027network\u0027][\u0027id\u0027], cidr\u003dsubnet_cidr)"},{"line_number":447,"context_line":"    if not subnets:"},{"line_number":448,"context_line":"        if gateway_ip:"},{"line_number":449,"context_line":"            new_subnets \u003d [{"},{"line_number":450,"context_line":"                \u0027name\u0027: pool_cidr,"},{"line_number":451,"context_line":"                \u0027network_id\u0027: network[\u0027network\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_5697cc39","line":448,"updated":"2016-01-14 07:44:01.000000000","message":"There is no need to duplicate the whole block. Just add gw_ip in case it is defined after the rest of the fields are set.\nnew_subnet \u003d [{\n...\n}]\nif gateway_ip:\n    new_subnet[0][\u0027gateway_ip\u0027] \u003d gateway_ip","commit_id":"2e034aca1ee71b4988152153571c2e9d409db0a6"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"76a1ae94b7e0c1c2c3c17aea2a21767ff13e70ac","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    pool_cidr \u003d json_data[\u0027IPv4Data\u0027][0][\u0027Pool\u0027]"},{"line_number":429,"context_line":"    gateway_ip \u003d \u0027\u0027"},{"line_number":430,"context_line":"    if \u0027Gateway\u0027 in json_data[\u0027IPv4Data\u0027][0]:"},{"line_number":431,"context_line":"        gateway_cidr \u003d json_data[\u0027IPv4Data\u0027][0][\u0027Gateway\u0027]"},{"line_number":432,"context_line":"        gateway_ip \u003d gateway_cidr.split(\u0027/\u0027)[0]"},{"line_number":433,"context_line":"        app.logger.debug(\"gateway_cidr {0}, gateway_ip {1}\""},{"line_number":434,"context_line":"            .format(gateway_cidr, gateway_ip))"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_d76571e1","line":432,"range":{"start_line":431,"start_character":7,"end_line":432,"end_character":47},"updated":"2016-01-19 03:35:03.000000000","message":"Isn\u0027t the input supposed to be an IP address and not a CIDR for the gateway?","commit_id":"ac4f3223468546ad0656bc3b2e04e575dd70d8a4"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"87165c35060093cd3cb1cfa68b14b0105c30c0a3","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    pool_cidr \u003d json_data[\u0027IPv4Data\u0027][0][\u0027Pool\u0027]"},{"line_number":429,"context_line":"    gateway_ip \u003d \u0027\u0027"},{"line_number":430,"context_line":"    if \u0027Gateway\u0027 in json_data[\u0027IPv4Data\u0027][0]:"},{"line_number":431,"context_line":"        gateway_cidr \u003d json_data[\u0027IPv4Data\u0027][0][\u0027Gateway\u0027]"},{"line_number":432,"context_line":"        gateway_ip \u003d gateway_cidr.split(\u0027/\u0027)[0]"},{"line_number":433,"context_line":"        app.logger.debug(\"gateway_cidr {0}, gateway_ip {1}\""},{"line_number":434,"context_line":"            .format(gateway_cidr, gateway_ip))"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_f73af5e6","line":432,"range":{"start_line":431,"start_character":7,"end_line":432,"end_character":47},"in_reply_to":"ba63e191_d76571e1","updated":"2016-01-19 03:55:17.000000000","message":"Docker command takes gateway as IP but passes here to libnetwork as cidr. For example if  --gateway\u003d104.11.0.8 is used in docker cmd, this will gw in cidr format in json.","commit_id":"ac4f3223468546ad0656bc3b2e04e575dd70d8a4"}]}
