)]}'
{"id":"openstack%2Flarge-scale~855508","triplet_id":"openstack%2Flarge-scale~master~Iee95287911097274c96c630fa912e7f994339b6a","project":"openstack/large-scale","branch":"master","topic":"rabbitmq_scheduling","attention_set":{},"removed_from_attention_set":{"29074":{"account":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"last_update":"2022-12-14 12:30:29.000000000","reason":"Removed by \u003cGERRIT_ACCOUNT_29074\u003e by clicking the attention icon","reason_account":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"}}},"hashtags":[],"change_id":"Iee95287911097274c96c630fa912e7f994339b6a","subject":"rabbitmq: add erlang scheduler recommendation","status":"MERGED","created":"2022-09-01 12:54:55.000000000","updated":"2022-12-14 12:30:29.000000000","submitted":"2022-09-09 07:19:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"855508-rabbitmq_scheduling","meta_rev_id":"1988330fb002593e4c15c04515835d8cfc2a4ba5","_number":855508,"virtual_id_number":855508,"owner":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-09-09 07:19:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"all":[{"value":2,"date":"2022-09-08 07:42:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-09-09 07:07:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-09-09 07:07:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-01 13:02:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-08 07:42:25.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2022-09-09 07:07:16.000000000","updated_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"reviewer":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"state":"REVIEWER"},{"updated":"2022-09-09 07:40:29.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"CC"},{"updated":"2022-09-09 08:56:58.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"CC"}],"messages":[{"id":"e46bb1f7aa77702a7b36f17bfe3158550e9509ab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2022-09-01 12:54:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"72f6a6f04b242f8fe6ec2b9a12ad27d222bf595b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2022-09-01 12:56:58.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"94774303bf3f1f28881e8d1d4444dcbf9218f290","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-01 13:02:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/86beac5b1be7405c864335b70d50bcd2\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/19be066dbe224495a2a9ab242513e442 : SUCCESS in 3m 48s","accounts_in_message":[],"_revision_number":2},{"id":"b483063a68b87dfa624a1cc1091c30a032dd141b","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2022-09-08 07:42:25.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ad5476250852e74fd35e46a34eeaef5abc32602f","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2022-09-09 07:07:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"288f4385bc11ccfcad8dc407d8bcb75f6f40c857","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-09 07:07:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c441b89790ee25fb7e8c3b07e8863097bdddcf26","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-09 07:19:57.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f4815e50c18841689ed4da6061b20d6e\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3bd11266108c42bca37612d527e9d103 : SUCCESS in 4m 21s","accounts_in_message":[],"_revision_number":2},{"id":"dd2d027cbcbd48804fbd41ee220435ad6d03eac3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-09 07:19:57.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"5223c622a0d6250fef8bfc705f52fa24d666b9a7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-09 07:20:59.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6e541a8d055e4a739c606fe57bb868cc\n\n- promote-openstack-tox-docs-direct https://zuul.opendev.org/t/openstack/build/2f2ef0dac4fb4c71ac66e3dba00f87d7 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":2},{"id":"ada0f628d778d8498cd228b68640e2b60410780f","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2022-09-09 07:40:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"10265b8531da7f65291233a01fae4867fbcfeb30","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2022-09-09 07:56:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"884a0987a76971bc1a23ff3da9c8d6c7d74cf949","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2022-09-09 08:56:58.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"280ed67c35b390a7aad78026f6875df05fa52dbc","revisions":{"b4188b6575a34fbffb91ab4defd5a1c619e5a346":{"kind":"REWORK","_number":1,"created":"2022-09-01 12:54:55.000000000","uploader":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"ref":"refs/changes/08/855508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/large-scale","ref":"refs/changes/08/855508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/large-scale refs/changes/08/855508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/large-scale refs/changes/08/855508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/large-scale refs/changes/08/855508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/large-scale refs/changes/08/855508/1"}}},"commit":{"parents":[{"commit":"bdf1c7102ceaebf62f5b568e6ab984563432a02e","subject":"Reformat \"how to contribute\" page","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/large-scale/commit/bdf1c7102ceaebf62f5b568e6ab984563432a02e"}]}],"author":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2022-09-01 12:02:50.000000000","tz":120},"committer":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2022-09-01 12:54:48.000000000","tz":120},"subject":"rabbitmq: add erlang scheduler recommendation","message":"rabbitmq: add erlang scheduler recommendation\n\nThe official rabbitmq  dockerimage sets `+stbt db` as a launch option of\nerlang. This option defines how the erlang scheduler threads (the\nthreads actually running the erlang code) are distributed over the phyiscal\ncpu cores. Per default erlang spawns one scheduler thread per logical core\n(so hyperthread or phyiscal core depending on if you have hyperthreading\nenabled).\n\nThe setting `db` translates to the setting `thread_no_node_processor_spread`\nwhich basically means that each scheduler thread is pinned to one specific\nlogical core in a predetermined order. There are some more details to this\nspecific setting, but they are not relevant for this issue\n(if interested please see https://www.erlang.org/doc/man/erl.html#+sbt).\n\nWhen possible the erlang runtime tries to run processes on the lowest possible\nscheduler id. As the scheduler id consistently mapping to a logical core this\nmeans that if possible all rabbitmq processes on a given host try to run code\non the same logical core.\n\nThe erlang documentation already metions that this can cause performance issues:\n\u003e If the Erlang runtime system is the only operating system process that binds\n  threads to logical processors, this improves the performance of the runtime\n  system. However, if other operating system processes (for example another\n  Erlang runtime system) also bind threads to logical processors, there can\n  be a performance penalty instead. This performance penalty can sometimes be\n  severe. If so, you are advised not to bind the schedulers.\n\nAs this recommendation is quite hidden we add it to our config\nrecommendations as well.\n\nThe above is a summary of https://www.erlang.org/doc/man/erl.html#+sbt.\n\nChange-Id: Iee95287911097274c96c630fa912e7f994339b6a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/large-scale/commit/b4188b6575a34fbffb91ab4defd5a1c619e5a346"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/large-scale/commit/b4188b6575a34fbffb91ab4defd5a1c619e5a346"}]},"branch":"refs/heads/master"},"280ed67c35b390a7aad78026f6875df05fa52dbc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-09-01 12:56:58.000000000","uploader":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"ref":"refs/changes/08/855508/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/large-scale","ref":"refs/changes/08/855508/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/large-scale refs/changes/08/855508/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/large-scale refs/changes/08/855508/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/large-scale refs/changes/08/855508/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/large-scale refs/changes/08/855508/2"}}},"commit":{"parents":[{"commit":"bdf1c7102ceaebf62f5b568e6ab984563432a02e","subject":"Reformat \"how to contribute\" page","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/large-scale/commit/bdf1c7102ceaebf62f5b568e6ab984563432a02e"}]}],"author":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2022-09-01 12:02:50.000000000","tz":120},"committer":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2022-09-01 12:55:12.000000000","tz":120},"subject":"rabbitmq: add erlang scheduler recommendation","message":"rabbitmq: add erlang scheduler recommendation\n\nThe official rabbitmq  dockerimage sets `+stbt db` as a launch option\nof erlang. This option defines how the erlang scheduler threads (the\nthreads actually running the erlang code) are distributed over the\nphyiscal cpu cores. Per default erlang spawns one scheduler thread per\nlogical core (so hyperthread or phyiscal core depending on if you have\nhyperthreading enabled).\n\nThe setting `db` translates to the setting\n`thread_no_node_processor_spread` which basically means that each\nscheduler thread is pinned to one specific logical core in a\npredetermined order. There are some more details to this specific\nsetting, but they are not relevant for this issue (if interested please\nsee https://www.erlang.org/doc/man/erl.html#+sbt).\n\nWhen possible the erlang runtime tries to run processes on the lowest\npossible scheduler id. As the scheduler id consistently mapping to a\nlogical core this means that if possible all rabbitmq processes on a\ngiven host try to run code on the same logical core.\n\nThe erlang documentation already metions that this can cause\nperformance issues:\n\u003e If the Erlang runtime system is the only operating system process\n  that binds threads to logical processors, this improves the\n  performance of the runtime system. However, if other operating\n  system processes (for example another Erlang runtime system) also\n  bind threads to logical processors, there can be a performance\n  penalty instead. This performance penalty can sometimes be severe.\n  If so, you are advised not to bind the schedulers.\n\nAs this recommendation is quite hidden we add it to our config\nrecommendations as well.\n\nThe above is a summary of https://www.erlang.org/doc/man/erl.html#+sbt.\n\nChange-Id: Iee95287911097274c96c630fa912e7f994339b6a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/large-scale/commit/280ed67c35b390a7aad78026f6875df05fa52dbc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/large-scale/commit/280ed67c35b390a7aad78026f6875df05fa52dbc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[]}