)]}'
{"ldappool/__init__.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9e3aec3662e6cf9e52941765c12a11f31dc7f14c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        # each one in turn in case of connection failures (server down,"},{"line_number":250,"context_line":"        # timeout, etc.).  URIs can be delimited by either commas or"},{"line_number":251,"context_line":"        # whitespace."},{"line_number":252,"context_line":"        for server in re.split(\u0027[\\s,]+\u0027, self.uri):"},{"line_number":253,"context_line":"            tries \u003d 0"},{"line_number":254,"context_line":"            exc \u003d None"},{"line_number":255,"context_line":"            conn \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bbd2925e","line":252,"range":{"start_line":252,"start_character":22,"end_line":252,"end_character":39},"updated":"2018-11-01 21:54:54.000000000","message":"Historically we\u0027ve supported both \u0027,\u0027 and \u0027\\s\u0027 delimiters? That is unfortunate. I much prefer forcing the use of a single delimiter.\n\nNo need to re-spin this patch for this comment.","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"1b5d67ac14ce04319a83b6357971b2ebb52c0953","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        # each one in turn in case of connection failures (server down,"},{"line_number":250,"context_line":"        # timeout, etc.).  URIs can be delimited by either commas or"},{"line_number":251,"context_line":"        # whitespace."},{"line_number":252,"context_line":"        for server in re.split(\u0027[\\s,]+\u0027, self.uri):"},{"line_number":253,"context_line":"            tries \u003d 0"},{"line_number":254,"context_line":"            exc \u003d None"},{"line_number":255,"context_line":"            conn \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7ba2ba99","line":252,"range":{"start_line":252,"start_character":22,"end_line":252,"end_character":39},"in_reply_to":"3f79a3b5_bbd2925e","updated":"2018-11-01 22:09:29.000000000","message":"It wasn\u0027t really our choice, as it is the underlying behavior of python-ldap:\n\n  https://www.python-ldap.org/en/latest/reference/ldap.html#ldap.initialize","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9e3aec3662e6cf9e52941765c12a11f31dc7f14c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            # We successfully connected to one of the servers, so"},{"line_number":291,"context_line":"            # we can just return the connection and stop processing"},{"line_number":292,"context_line":"            # any additional URIs."},{"line_number":293,"context_line":"            if connected:"},{"line_number":294,"context_line":"                return conn"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # We failed to connect to any of the servers,"},{"line_number":297,"context_line":"        # so raise an appropriate exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9bf1d6e2","line":294,"range":{"start_line":293,"start_character":0,"end_line":294,"end_character":27},"updated":"2018-11-01 21:54:54.000000000","message":"As a note, in the future, I suggest keeping the code flow mostly the same with the same exit points instead of the early exit like this, just easier to review.","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"1b5d67ac14ce04319a83b6357971b2ebb52c0953","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            # We successfully connected to one of the servers, so"},{"line_number":291,"context_line":"            # we can just return the connection and stop processing"},{"line_number":292,"context_line":"            # any additional URIs."},{"line_number":293,"context_line":"            if connected:"},{"line_number":294,"context_line":"                return conn"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # We failed to connect to any of the servers,"},{"line_number":297,"context_line":"        # so raise an appropriate exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3bb682dd","line":294,"range":{"start_line":293,"start_character":0,"end_line":294,"end_character":27},"in_reply_to":"3f79a3b5_9bf1d6e2","updated":"2018-11-01 22:09:29.000000000","message":"Noted.","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9e3aec3662e6cf9e52941765c12a11f31dc7f14c","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # We failed to connect to any of the servers,"},{"line_number":297,"context_line":"        # so raise an appropriate exception."},{"line_number":298,"context_line":"        if not connected:"},{"line_number":299,"context_line":"            if isinstance(exc, (ldap.NO_SUCH_OBJECT,"},{"line_number":300,"context_line":"                                ldap.SERVER_DOWN,"},{"line_number":301,"context_line":"                                ldap.TIMEOUT)):"},{"line_number":302,"context_line":"                raise exc"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # that\u0027s something else"},{"line_number":305,"context_line":"        raise BackendError(str(exc), backend\u003dconn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_db074ec8","line":302,"range":{"start_line":298,"start_character":0,"end_line":302,"end_character":25},"updated":"2018-11-01 21:54:54.000000000","message":"This seems odd. We raise the most recent error, depending on how the connections fail. Is NO_SUCH_OBJECT in fact correct behavior here? It may not be.","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"faaa151e3dd5396492cdd39c2d836b16fb5ada98","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # We failed to connect to any of the servers,"},{"line_number":297,"context_line":"        # so raise an appropriate exception."},{"line_number":298,"context_line":"        if not connected:"},{"line_number":299,"context_line":"            if isinstance(exc, (ldap.NO_SUCH_OBJECT,"},{"line_number":300,"context_line":"                                ldap.SERVER_DOWN,"},{"line_number":301,"context_line":"                                ldap.TIMEOUT)):"},{"line_number":302,"context_line":"                raise exc"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # that\u0027s something else"},{"line_number":305,"context_line":"        raise BackendError(str(exc), backend\u003dconn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_56beb3af","line":302,"range":{"start_line":298,"start_character":0,"end_line":302,"end_character":25},"in_reply_to":"3f79a3b5_bbeff2b0","updated":"2018-11-01 23:12:54.000000000","message":"Yep, I just don\u0027t have a good feeling of what else should be raised here. This all feels very inconsistent, but with no better option we can just keep going with what we have.","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"1b5d67ac14ce04319a83b6357971b2ebb52c0953","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # We failed to connect to any of the servers,"},{"line_number":297,"context_line":"        # so raise an appropriate exception."},{"line_number":298,"context_line":"        if not connected:"},{"line_number":299,"context_line":"            if isinstance(exc, (ldap.NO_SUCH_OBJECT,"},{"line_number":300,"context_line":"                                ldap.SERVER_DOWN,"},{"line_number":301,"context_line":"                                ldap.TIMEOUT)):"},{"line_number":302,"context_line":"                raise exc"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        # that\u0027s something else"},{"line_number":305,"context_line":"        raise BackendError(str(exc), backend\u003dconn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bbeff2b0","line":302,"range":{"start_line":298,"start_character":0,"end_line":302,"end_character":25},"in_reply_to":"3f79a3b5_db074ec8","updated":"2018-11-01 22:09:29.000000000","message":"Yes, I also wasn\u0027t really sure what the best error is to report.  We could return a generic exception of our own, but it seemed best to at least provide the last LDAP exception we encountered.  I\u0027m open to other suggestions if you have an idea for something better.\n\nNO_SUCH_OBJECT was here before my patch, but I suspect it was added as an expected exception in case someone made a typo for the bind DN in the configuration.  If you make a mistake in the bind DN, the server will return NO_SUCH_OBJECT when you attempt to bind using a DN that doesn\u0027t exist.","commit_id":"3f0ea8533a9144b95c7ea24a940a0ccea211108b"}],"ldappool/tests/test_ldapconnection.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5e3c48e31c9d766127500da78318ad60b818b248","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    raise ldap.LDAPError(\u0027LDAP connection invalid\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def _bind_fails2(self, who\u003d\u0027\u0027, cred\u003d\u0027\u0027, **kw):"},{"line_number":55,"context_line":"    raise ldap.SERVER_DOWN(\u0027LDAP connection invalid\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f25c9df0","side":"PARENT","line":54,"updated":"2018-11-02 13:11:17.000000000","message":"Thanks for fixing this :D","commit_id":"a74cf70ff4ab2d99e63a4050f08a01ddbaf5bf79"}]}