)]}'
{"id":"openstack%2Fliberasurecode~324083","triplet_id":"openstack%2Fliberasurecode~master~I72eddf78b25b3ff9bedbd596095f04be855c3817","project":"openstack/liberasurecode","branch":"master","topic":"bug/1587954","hashtags":[],"change_id":"I72eddf78b25b3ff9bedbd596095f04be855c3817","subject":"Fix clang compile time error","status":"MERGED","created":"2016-06-01 20:03:34.000000000","updated":"2016-11-07 05:27:21.000000000","submitted":"2016-11-07 05:27:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b8ef63c25fd83a62ef0a8c4e53467328a7c84b45","_number":324083,"virtual_id_number":324083,"owner":{"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2016-11-07 05:27:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"all":[{"value":2,"date":"2016-11-07 05:17:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-31 20:14:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":1,"date":"2016-10-31 19:59:51.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"all":[{"value":1,"date":"2016-11-07 05:23:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-31 19:59:51.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-10-31 20:14:53.000000000","updated_by":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"reviewer":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"state":"REVIEWER"},{"updated":"2016-11-07 05:23:51.000000000","updated_by":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"reviewer":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"state":"REVIEWER"},{"updated":"2016-11-07 05:27:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"05bc5817c7a3343a1d9291670488c45bd0c93c22","author":{"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},"date":"2016-06-01 20:03:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9bbcd916ab9ae48a1289133a85b0d9f4b991499","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2016-06-01 20:03:42.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"2c06c5b747c35907c85ed739345752cb3cbd161b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-01 20:06:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- noop http://logs.openstack.org/83/324083/1/check/noop/96381cc/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"aac5cf6af214f1219b4b0865ba0502db96d13702","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-10-31 19:59:51.000000000","message":"Patch Set 1: Code-Review+1\n\nConfirmed that clang will bomb out with something like\n\n erasurecode.c:1090:17: error: comparison of unsigned expression \u003c 0 is always false\n       [-Werror,-Wtautological-compare]\n     if (md-\u003eidx \u003c 0 || (md-\u003eidx \u003e (k + m))) {\n         ~~~~~~~ ^ ~\n\nWith this change, I can successfully build \u0026 test on OS X.","accounts_in_message":[],"_revision_number":1},{"id":"4f42ab4b1a142778e57c16d14b63b3d2e4c0470e","author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"date":"2016-10-31 20:14:53.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good","accounts_in_message":[],"_revision_number":1},{"id":"c3d76642106d13bd2c03455dc6c1d9cca09e695d","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-07 05:15:56.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"ddb848681ac8327bc89ac48754e6c79e67f17b73","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-07 05:17:47.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good to me and I confirmed that exactly happens in the Mac environment.\n\nHowever, the jenkins job for this is still noop right now. The newer gate job will run as unit testing so add recheck in the previous comment, and then, will add +A if it passed.","accounts_in_message":[],"_revision_number":1},{"id":"11e83f9b6234ede7c446757ce6491cc2a6556533","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 05:20:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/83/324083/1/check/gate-liberasurecode-unit/2598bcb/ : SUCCESS in 3m 34s","accounts_in_message":[],"_revision_number":1},{"id":"86b4ff3f17d7463551577399e0daebca53f1d8d9","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-07 05:23:51.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8e889ba7d9188f26ba7ed393daece2f09ee47041","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 05:24:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"fcd31ca6bf8ae560aac4cf765f811926352a3717","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-07 05:27:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/83/324083/1/gate/gate-liberasurecode-unit/bd2e95b/ : SUCCESS in 3m 18s","accounts_in_message":[],"_revision_number":1},{"id":"4625fa55a61239cd0ec2388ae150e47f96c7f0bd","date":"2016-11-07 05:27:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f60dcfcc16a0c7b06c6c44c1bf7470456a7441c5","revisions":{"f60dcfcc16a0c7b06c6c44c1bf7470456a7441c5":{"kind":"REWORK","_number":1,"created":"2016-06-01 20:03:34.000000000","uploader":{"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},"ref":"refs/changes/83/324083/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/83/324083/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/83/324083/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/83/324083/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/83/324083/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/83/324083/1"}}},"commit":{"parents":[{"commit":"3b8ee7d108a2bd3a854f90f75b2986fc6d7b386e","subject":"Add NEWS and README back","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/3b8ee7d108a2bd3a854f90f75b2986fc6d7b386e"}]}],"author":{"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","date":"2016-06-01 16:21:25.000000000","tz":-420},"committer":{"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","date":"2016-06-01 16:21:25.000000000","tz":-420},"subject":"Fix clang compile time error","message":"Fix clang compile time error\n\nRemoved unnecessary check that metadata index was not negative.\nCheck is unneeded because type is unsigned and as such can not be\nnegative.\n\nChange-Id: I72eddf78b25b3ff9bedbd596095f04be855c3817\nCloses-Bug: 1587954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/f60dcfcc16a0c7b06c6c44c1bf7470456a7441c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/f60dcfcc16a0c7b06c6c44c1bf7470456a7441c5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}