)]}'
{"id":"openstack%2Fliberasurecode~341016","triplet_id":"openstack%2Fliberasurecode~master~I489f8b5d049610863b5e0b477b6ff70ead245b55","project":"openstack/liberasurecode","branch":"master","topic":"get_fragment_size","hashtags":[],"change_id":"I489f8b5d049610863b5e0b477b6ff70ead245b55","subject":"Add get_by_desc ret val handling to get_fragment_size","status":"MERGED","created":"2016-07-12 15:45:25.000000000","updated":"2016-09-08 03:37:20.000000000","submitted":"2016-09-08 03:37:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a5a990e7d691912a6a47f42fecee62e0dd54ad71","_number":341016,"virtual_id_number":341016,"owner":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2016-09-08 03:37:20.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-08 03:30:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-08 03:30:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-08 03:30:17.000000000","updated_by":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"reviewer":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"state":"REVIEWER"},{"updated":"2016-09-08 03:37:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c4f1284d10e73426cf294f70ff636b90ef975811","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-07-12 15:45:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4f50e12ee7e4da905e714c8d3299f05d0c8c209","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-07-12 15:56:36.000000000","message":"Patch Set 1: Workflow-1\n\nThis might cause memory leak (i got definitely lost with valgrind so that set workflow -1 until figure out how it\u0027s broken.","accounts_in_message":[],"_revision_number":1},{"id":"759e2229a01454e7660302d19b743ea3f0be56fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-12 16:17:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/16/341016/1/check/gate-liberasurecode-unit/167294a/ : SUCCESS in 1m 52s","accounts_in_message":[],"_revision_number":1},{"id":"db4b37af012fce5807cd7fef210676fcd03660b3","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-07-12 16:19:59.000000000","message":"Patch Set 1: -Workflow\n\nAh...the definitely lost happens also at the master. so plug my workflow -1 right now.","accounts_in_message":[],"_revision_number":1},{"id":"2dca19449b89f11109cc0359e2d31820cabf4c44","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-07-13 16:23:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"61c8d1f32bff9e7726921ab447e91ca8459f47c2","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-07-13 16:24:29.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"37f999c246e473050bc9bd9f25b725398e861a24","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-07-13 16:26:39.000000000","message":"Patch Set 3:\n\nOn my second thought, the API change affects significant upgrade impact for users (e.g. OpenStack Swift)\n\nFortunately, liberasurecode_get_fragment should return non-negative int for design so we can return negative int as an error code to make it catch-able.","accounts_in_message":[],"_revision_number":3},{"id":"b93863e4b0c9cf76e07608800aa3c303a5ddfcdd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-13 16:41:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/16/341016/3/check/gate-liberasurecode-unit/b5f4be0/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":3},{"id":"367d403db54e50237d54f42c2d8328345c5fad43","author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"date":"2016-09-07 05:57:48.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d0c14ec07d3e0d93880d263e937737c14f1888c1","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-09-07 06:58:06.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7c86a6d267986cc2a8862792c07cb63857eea2b0","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-09-08 03:23:01.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4511ccdd528bbc7dc3865e2c058eb380d1605a35","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-09-08 03:24:16.000000000","message":"Patch Set 4:\n\nRemove unnecessary changes. Does it ok for you, Tushar?","accounts_in_message":[],"_revision_number":4},{"id":"604d3c006da5860b56d5288034a8215f73e2cf30","author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"date":"2016-09-08 03:25:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"23f55f5d5c22922da6868a8e8167edecea952b6b","author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"date":"2016-09-08 03:30:17.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"176240ecd519ba2cce6139fb01f73d33ca32bd6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-08 03:31:36.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/16/341016/4/check/gate-liberasurecode-unit/aa53c29/ : SUCCESS in 4m 45s","accounts_in_message":[],"_revision_number":4},{"id":"0492a5fb2a02f5867629e03679bec879a657c277","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-08 03:31:46.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"034c3a0af400685ed479d52e1052fab47ab2137f","date":"2016-09-08 03:37:20.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"f50f386d23f3cd8a29a868b2b2525463db14a332","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-08 03:37:20.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/16/341016/4/gate/gate-liberasurecode-unit/decf10c/ : SUCCESS in 5m 19s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"cb0daba975dfb3b7bffe402d7aa73fac19180f73","revisions":{"bc1856d748608da9a5f2d37bfe03279c9aa94200":{"kind":"REWORK","_number":1,"created":"2016-07-12 15:45:25.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/16/341016/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/16/341016/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/1"}}},"commit":{"parents":[{"commit":"bdc8503bb2e24d7f70f13503dc440d8f9276268e","subject":"Fix posix_memalign handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bdc8503bb2e24d7f70f13503dc440d8f9276268e"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-12 15:37:00.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-12 15:44:31.000000000","tz":-420},"subject":"Add get_by_desc ret val handling to get_fragment_size","message":"Add get_by_desc ret val handling to get_fragment_size\n\nAs well as any other callers, libersurecode_get_fragment_size should\nhandle the return value of liberasurecode_get_backend_instance_by_desc.\n\nOtherwise, get_by_desc can return NULL and it causes an invalid memory\naccess in librerasurecode_get_fragment_size.\n\nNote that this change impacted to PyECLib due to API change so we need\nalso PyECLib updates.\n\nDocImpact\nUpgradeImpact\n\nChange-Id: I489f8b5d049610863b5e0b477b6ff70ead245b55\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bc1856d748608da9a5f2d37bfe03279c9aa94200"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bc1856d748608da9a5f2d37bfe03279c9aa94200"}]},"branch":"refs/heads/master"},"23a966526cf653bf40f5603e7194562a33760fa2":{"kind":"REWORK","_number":2,"created":"2016-07-13 16:23:01.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/16/341016/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/16/341016/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/2"}}},"commit":{"parents":[{"commit":"bdc8503bb2e24d7f70f13503dc440d8f9276268e","subject":"Fix posix_memalign handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bdc8503bb2e24d7f70f13503dc440d8f9276268e"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-12 15:37:00.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-13 16:14:20.000000000","tz":-420},"subject":"Add get_by_desc ret val handling to get_fragment_size","message":"Add get_by_desc ret val handling to get_fragment_size\n\nAs well as any other callers, libersurecode_get_fragment_size should\nhandle the return value of liberasurecode_get_backend_instance_by_desc.\n\nOtherwise, get_by_desc can return NULL and it causes an invalid memory\naccess in librerasurecode_get_fragment_size.\n\nNote that this change impacted to PyECLib due to API change so we need\nalso PyECLib updates.\n\nChange-Id: I489f8b5d049610863b5e0b477b6ff70ead245b55\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/23a966526cf653bf40f5603e7194562a33760fa2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/23a966526cf653bf40f5603e7194562a33760fa2"}]},"branch":"refs/heads/master"},"bf1f60ddd754e2da3c01862de8c416c58982798a":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-07-13 16:24:29.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/16/341016/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/16/341016/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/3"}}},"commit":{"parents":[{"commit":"bdc8503bb2e24d7f70f13503dc440d8f9276268e","subject":"Fix posix_memalign handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bdc8503bb2e24d7f70f13503dc440d8f9276268e"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-12 15:37:00.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-13 16:23:53.000000000","tz":-420},"subject":"Add get_by_desc ret val handling to get_fragment_size","message":"Add get_by_desc ret val handling to get_fragment_size\n\nAs well as any other callers, libersurecode_get_fragment_size should\nhandle the return value of liberasurecode_get_backend_instance_by_desc.\n\nOtherwise, get_by_desc can return NULL and it causes an invalid memory\naccess in librerasurecode_get_fragment_size.\n\nChange-Id: I489f8b5d049610863b5e0b477b6ff70ead245b55\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bf1f60ddd754e2da3c01862de8c416c58982798a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/bf1f60ddd754e2da3c01862de8c416c58982798a"}]},"branch":"refs/heads/master"},"cb0daba975dfb3b7bffe402d7aa73fac19180f73":{"kind":"REWORK","_number":4,"created":"2016-09-08 03:23:01.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/16/341016/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/16/341016/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/16/341016/4"}}},"commit":{"parents":[{"commit":"89807c5aac829453d855c1adb6830bd3a12876b5","subject":"Merge \"Move other-requirements.txt to bindep.txt\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/89807c5aac829453d855c1adb6830bd3a12876b5"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-07-12 15:37:00.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-09-08 03:22:47.000000000","tz":-420},"subject":"Add get_by_desc ret val handling to get_fragment_size","message":"Add get_by_desc ret val handling to get_fragment_size\n\nAs well as any other callers, libersurecode_get_fragment_size should\nhandle the return value of liberasurecode_get_backend_instance_by_desc.\n\nOtherwise, get_by_desc can return NULL and it causes an invalid memory\naccess in librerasurecode_get_fragment_size.\n\nChange-Id: I489f8b5d049610863b5e0b477b6ff70ead245b55\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/cb0daba975dfb3b7bffe402d7aa73fac19180f73"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/cb0daba975dfb3b7bffe402d7aa73fac19180f73"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}