)]}'
{"src/erasurecode.c":[{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"32d592033a65755f13e606830d53b939a2f3362c","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"{"},{"line_number":1073,"context_line":"    uint32_t *stored_csum \u003d NULL, csum \u003d 0;"},{"line_number":1074,"context_line":"    assert (NULL !\u003d header);"},{"line_number":1075,"context_line":"    if (header-\u003elibec_version \u003c\u003d 0){"},{"line_number":1076,"context_line":"        /* libec_version must be equal or bigger than 0 */"},{"line_number":1077,"context_line":"        return 1;"},{"line_number":1078,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_ec54a8cb","line":1075,"updated":"2016-10-18 12:31:32.000000000","message":"Minor nit - space before the opening brace","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9aa0f99e68509b658f12e138eca6f3211aac14f1","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"{"},{"line_number":1073,"context_line":"    uint32_t *stored_csum \u003d NULL, csum \u003d 0;"},{"line_number":1074,"context_line":"    assert (NULL !\u003d header);"},{"line_number":1075,"context_line":"    if (header-\u003elibec_version \u003c\u003d 0){"},{"line_number":1076,"context_line":"        /* libec_version must be equal or bigger than 0 */"},{"line_number":1077,"context_line":"        return 1;"},{"line_number":1078,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_a97286e1","line":1075,"in_reply_to":"fa6399be_0789b2ca","updated":"2016-10-19 02:23:25.000000000","message":"Ah, ok. Good call. Thanks for pointing out. Done.","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"14d7e6c80eac9f46e6df30231dfb7a0dd911b7a6","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"{"},{"line_number":1073,"context_line":"    uint32_t *stored_csum \u003d NULL, csum \u003d 0;"},{"line_number":1074,"context_line":"    assert (NULL !\u003d header);"},{"line_number":1075,"context_line":"    if (header-\u003elibec_version \u003c\u003d 0){"},{"line_number":1076,"context_line":"        /* libec_version must be equal or bigger than 0 */"},{"line_number":1077,"context_line":"        return 1;"},{"line_number":1078,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_0789b2ca","line":1075,"in_reply_to":"fa6399be_ec54a8cb","updated":"2016-10-18 14:09:54.000000000","message":"I usually try to respect the existing style in such cases. Clearly the original author liked to omit braces in small ifs.","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"281361020b8efea0c2c40a7af63ac058232faace","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    uint32_t *stored_csum \u003d NULL, csum \u003d 0;"},{"line_number":1074,"context_line":"    assert (NULL !\u003d header);"},{"line_number":1075,"context_line":"    if (header-\u003elibec_version \u003c\u003d 0)"},{"line_number":1076,"context_line":"        /* libec_version must be equal or bigger than 0 */"},{"line_number":1077,"context_line":"        return 1;"},{"line_number":1078,"context_line":"    if (header-\u003elibec_version \u003c _VERSION(1,2,0))"},{"line_number":1079,"context_line":"        /* no metadata checksum support */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba5da102_e8037440","line":1076,"range":{"start_line":1076,"start_character":30,"end_line":1076,"end_character":38},"updated":"2016-10-31 20:45:03.000000000","message":"This would seem to disallow libec_version \u003d\u003d 0, no?\n\nAnd checking for \u003c 0 is unnecessary; fragment_header_t defines lib_ecversion as unsigned.","commit_id":"1cd0b05bd8f9b71d18e374985284c495cbcb2f86"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"6da50d0f07f967529555af1c1efd7029c6c3d64d","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    uint32_t *stored_csum \u003d NULL, csum \u003d 0;"},{"line_number":1074,"context_line":"    assert (NULL !\u003d header);"},{"line_number":1075,"context_line":"    if (header-\u003elibec_version \u003c\u003d 0)"},{"line_number":1076,"context_line":"        /* libec_version must be equal or bigger than 0 */"},{"line_number":1077,"context_line":"        return 1;"},{"line_number":1078,"context_line":"    if (header-\u003elibec_version \u003c _VERSION(1,2,0))"},{"line_number":1079,"context_line":"        /* no metadata checksum support */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba5da102_4d693925","line":1076,"range":{"start_line":1076,"start_character":30,"end_line":1076,"end_character":38},"in_reply_to":"ba5da102_e8037440","updated":"2016-11-04 09:55:03.000000000","message":"good catch. I forgot the type for the version, will fix.","commit_id":"1cd0b05bd8f9b71d18e374985284c495cbcb2f86"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8aac6d465a9b25ac6b17d07fd1aa0494fdd10ca6","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"    assert (NULL !\u003d header);"},{"line_number":1075,"context_line":"    if (header-\u003elibec_version \u003d\u003d 0)"},{"line_number":1076,"context_line":"        /* libec_version must be bigger than 0 */"},{"line_number":1077,"context_line":"        return 1;"},{"line_number":1078,"context_line":"    if (header-\u003elibec_version \u003c _VERSION(1,2,0))"},{"line_number":1079,"context_line":"        /* no metadata checksum support */"},{"line_number":1080,"context_line":"        return 0;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"9a629dbe_dcfacf74","line":1077,"updated":"2016-11-09 22:53:29.000000000","message":"this is just a drive-by right?  not really related to the commit message?","commit_id":"e8b5a64d8d68c6f379fcd8aa69d934682b9e1a25"}],"test/liberasurecode_test.c":[{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"32d592033a65755f13e606830d53b939a2f3362c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"    rc \u003d liberasurecode_decode(desc, avail_frags, num_avail_frags,"},{"line_number":642,"context_line":"                               strlen(fake_data), 1,"},{"line_number":643,"context_line":"                               \u0026decoded_data, \u0026decoded_data_len);"},{"line_number":644,"context_line":"    // force_metadata_checks results in EINSUFFFRAGS"},{"line_number":645,"context_line":"    assert(rc \u003d\u003d -EBADHEADER);"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    rc \u003d liberasurecode_decode(desc, avail_frags, num_avail_frags,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_4c62f4ae","line":644,"updated":"2016-10-18 12:31:32.000000000","message":"Thanks for taking care of this Kota.  Please also fix the error name in the comment in the process","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9aa0f99e68509b658f12e138eca6f3211aac14f1","unresolved":false,"context_lines":[{"line_number":641,"context_line":"    rc \u003d liberasurecode_decode(desc, avail_frags, num_avail_frags,"},{"line_number":642,"context_line":"                               strlen(fake_data), 1,"},{"line_number":643,"context_line":"                               \u0026decoded_data, \u0026decoded_data_len);"},{"line_number":644,"context_line":"    // force_metadata_checks results in EINSUFFFRAGS"},{"line_number":645,"context_line":"    assert(rc \u003d\u003d -EBADHEADER);"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    rc \u003d liberasurecode_decode(desc, avail_frags, num_avail_frags,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_6c0cfc3b","line":644,"in_reply_to":"fa6399be_4c62f4ae","updated":"2016-10-19 02:23:25.000000000","message":"Done","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"14d7e6c80eac9f46e6df30231dfb7a0dd911b7a6","unresolved":false,"context_lines":[{"line_number":2018,"context_line":"                            (testname) ? testname : \"\", i);"},{"line_number":2019,"context_line":"                    continue;"},{"line_number":2020,"context_line":"                }"},{"line_number":2021,"context_line":"                struct ec_args *args \u003d create_ec_args(testcases[ii].be_id, testcases[ii].ct, i);"},{"line_number":2022,"context_line":"            if (testcases[ii].be_id \u003d\u003d EC_BACKENDS_MAX) {"},{"line_number":2023,"context_line":"                    /* no be_id \u003d\u003d NULL means EC_BACKEND_MAX basically"},{"line_number":2024,"context_line":"                     * designed for invalid args tests */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_4a901196","line":2021,"updated":"2016-10-18 14:09:54.000000000","message":"please move the call to create_ec_args beyond the new special-case, down to the NULL!\u003dargs. The \"continue\" keyword is your friend here.","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9aa0f99e68509b658f12e138eca6f3211aac14f1","unresolved":false,"context_lines":[{"line_number":2018,"context_line":"                            (testname) ? testname : \"\", i);"},{"line_number":2019,"context_line":"                    continue;"},{"line_number":2020,"context_line":"                }"},{"line_number":2021,"context_line":"                struct ec_args *args \u003d create_ec_args(testcases[ii].be_id, testcases[ii].ct, i);"},{"line_number":2022,"context_line":"            if (testcases[ii].be_id \u003d\u003d EC_BACKENDS_MAX) {"},{"line_number":2023,"context_line":"                    /* no be_id \u003d\u003d NULL means EC_BACKEND_MAX basically"},{"line_number":2024,"context_line":"                     * designed for invalid args tests */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa6399be_ec500cd7","line":2021,"in_reply_to":"fa6399be_4a901196","updated":"2016-10-19 02:23:25.000000000","message":"Oh yeah. Good catch. Thanks.\n\nI\u0027ll try it but the new version may be still redundant, so please feel free to let me know how to make great c code to me ;-)","commit_id":"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"281361020b8efea0c2c40a7af63ac058232faace","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"                        (testname) ? testname : \"\", i);"},{"line_number":2029,"context_line":"                fflush(stdout);"},{"line_number":2030,"context_line":"                num_cases++;"},{"line_number":2031,"context_line":"\t\tcontinue;"},{"line_number":2032,"context_line":"\t    }"},{"line_number":2033,"context_line":"            struct ec_args *args \u003d create_ec_args(testcases[ii].be_id, testcases[ii].ct, i);"},{"line_number":2034,"context_line":"            if (NULL !\u003d args) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba5da102_0886e8b8","line":2031,"updated":"2016-10-31 20:45:03.000000000","message":"Is the convention to use tabs or spaces?","commit_id":"1cd0b05bd8f9b71d18e374985284c495cbcb2f86"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"6da50d0f07f967529555af1c1efd7029c6c3d64d","unresolved":false,"context_lines":[{"line_number":2028,"context_line":"                        (testname) ? testname : \"\", i);"},{"line_number":2029,"context_line":"                fflush(stdout);"},{"line_number":2030,"context_line":"                num_cases++;"},{"line_number":2031,"context_line":"\t\tcontinue;"},{"line_number":2032,"context_line":"\t    }"},{"line_number":2033,"context_line":"            struct ec_args *args \u003d create_ec_args(testcases[ii].be_id, testcases[ii].ct, i);"},{"line_number":2034,"context_line":"            if (NULL !\u003d args) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba5da102_ed584d8d","line":2031,"in_reply_to":"ba5da102_0886e8b8","updated":"2016-11-04 09:55:03.000000000","message":"will convert to spaces. Thx.","commit_id":"1cd0b05bd8f9b71d18e374985284c495cbcb2f86"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b9a7bba6d605c18dc9388696a2072c8fd9c75705","unresolved":false,"context_lines":[{"line_number":2021,"context_line":"            }"},{"line_number":2022,"context_line":"            if (testcases[ii].be_id \u003d\u003d EC_BACKENDS_MAX) {"},{"line_number":2023,"context_line":"                /* EC_BACKEND_MAX basically designed for invalid args tests"},{"line_number":2024,"context_line":"\t\t * and not takes the args so call the function w/o args here */"},{"line_number":2025,"context_line":"                testcases[ii].function();"},{"line_number":2026,"context_line":"                fprintf(stdout, \"ok %d - %s: %s (idx\u003d%d)\\n\", num_cases,"},{"line_number":2027,"context_line":"                        testcases[ii].description,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ba5da102_74e153fe","line":2024,"range":{"start_line":2024,"start_character":0,"end_line":2024,"end_character":2},"updated":"2016-11-04 17:05:45.000000000","message":"More tabs","commit_id":"b0c3a60a44004206fa609dc600684a4c6b0fbb6e"}]}