)]}'
{"id":"openstack%2Fliberasurecode~387879","triplet_id":"openstack%2Fliberasurecode~master~Ib99a8aa6032f02d0c7d1ab94b8da1ebfd9047d74","project":"openstack/liberasurecode","branch":"master","topic":"bug/1634403","hashtags":[],"change_id":"Ib99a8aa6032f02d0c7d1ab94b8da1ebfd9047d74","subject":"Fix liberasurecode skipping a bunch of invalid_args tests","status":"MERGED","created":"2016-10-18 09:18:14.000000000","updated":"2016-11-09 23:08:32.000000000","submitted":"2016-11-09 23:08:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0c17c72502f6f3acd896800ae1d897096cedcd9d","_number":387879,"virtual_id_number":387879,"owner":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2016-11-09 23:08:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-04 18:46:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},{"value":2,"date":"2016-11-09 22:53:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},{"value":1,"date":"2016-11-09 23:05:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-18 12:31:32.000000000","updated_by":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"reviewer":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"state":"REVIEWER"},{"updated":"2016-10-18 15:24:04.000000000","updated_by":{"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},"reviewer":{"_account_id":11608,"name":"Eric Lambert","email":"eric.d.lambert@gmail.com","username":"elambert"},"state":"REVIEWER"},{"updated":"2016-11-04 17:05:45.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-11-04 18:46:06.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2016-11-09 23:05:10.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2016-11-09 23:08:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0589ddb9dc284185b70cc73b7e1f3c8beb4a321a","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-10-18 09:18:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea88c5651b0d24c1089857a10aca58cd893018be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 09:22:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/79/387879/1/check/gate-liberasurecode-unit/0fdc71d/ : SUCCESS in 3m 25s","accounts_in_message":[],"_revision_number":1},{"id":"32d592033a65755f13e606830d53b939a2f3362c","author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"date":"2016-10-18 12:31:32.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"14d7e6c80eac9f46e6df30231dfb7a0dd911b7a6","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2016-10-18 14:09:54.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nSorry I found something not to like, see inline. Hopefuly you and Tushar agree!","accounts_in_message":[],"_revision_number":1},{"id":"9aa0f99e68509b658f12e138eca6f3211aac14f1","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-10-19 02:23:25.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nThanks Tushar and Pete so quick response. The new version will be coming soon.","accounts_in_message":[],"_revision_number":1},{"id":"f722e499ef59bdee247b9b9c8ae9b430998c1562","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-10-19 02:23:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"02ede5e02eb2a0a910e3a92f0ee4b546fb4e84ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-19 02:27:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/79/387879/2/check/gate-liberasurecode-unit/d6103cf/ : SUCCESS in 3m 23s","accounts_in_message":[],"_revision_number":2},{"id":"281361020b8efea0c2c40a7af63ac058232faace","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-10-31 20:45:03.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nNice test cleanup, but I think there\u0027s a contradiction between code \u0026 comment in the src/erasurecode.c change.","accounts_in_message":[],"_revision_number":2},{"id":"6da50d0f07f967529555af1c1efd7029c6c3d64d","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-04 09:55:03.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a8f9042d836a1797a0d824e4acc46d932d160ec7","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-04 10:01:51.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4ebce9d4efdcfb69db7dbfaa3e9a166656fa58d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-04 10:05:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/79/387879/3/check/gate-liberasurecode-unit/c25d5ee/ : SUCCESS in 3m 04s","accounts_in_message":[],"_revision_number":3},{"id":"b9a7bba6d605c18dc9388696a2072c8fd9c75705","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-11-04 17:05:45.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nMore tabs, but code \u0026 comment make sense now.","accounts_in_message":[],"_revision_number":3},{"id":"2b35e82667539bf0d1fb17bb30aedf92f863500a","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2016-11-04 18:42:37.000000000","message":"Patch Set 4: Published edit on patch set 3","accounts_in_message":[],"_revision_number":4},{"id":"93ffebbfa2d58ad68e9723d77b9173daa4601dad","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2016-11-04 18:46:06.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"e52323a458e92c3b8f276b0471efec82380e183c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-04 18:46:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/79/387879/4/check/gate-liberasurecode-unit/79d9a97/ : SUCCESS in 3m 34s","accounts_in_message":[],"_revision_number":4},{"id":"8aac6d465a9b25ac6b17d07fd1aa0494fdd10ca6","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-11-09 22:53:29.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)\n\nok, so I a higher test count with this change compared to master (276 \u003d\u003e 324)\n\nAnd we were definitely skipping some of these tests - they were broken w/o these fixes but `make test` still completed successfully.  With the test runner changes, they\u0027re defiantly running because w/o those fixes they would fail!  Indeed with *this* change the test_backend_available_invalid_args test seems to run for *every* backend!?  Is that what we need/want?\n\nBut I\u0027m not quite sure I understand enough about the test infrastructure to say why *this* change is better than just adding the EC_BACKENDS_MAX id tests to the argument factory so they get valid null_test_args lists instead of falling through to the default case:\n\n  diff --git a/test/liberasurecode_test.c b/test/liberasurecode_test.c\n  index 874d706..6df1722 100644\n  --- a/test/liberasurecode_test.c\n  +++ b/test/liberasurecode_test.c\n  @@ -298,6 +298,9 @@ struct ec_args *create_ec_args(ec_backend_id_t be, ec_checksum_type_t ct, int ba\n       int i \u003d 0;\n   \n       switch(be) {\n  +        case EC_BACKENDS_MAX:\n  +            backend_args_array \u003d null_test_args;\n  +            break;\n           case EC_BACKEND_NULL:\n               backend_args_array \u003d null_test_args;\n               break;\n\nOTOH maybe it would be best to update those tests and define them as using EC_BACKEND_NULL and drop this EC_BACKENDS_MAX thing - idk, seems like that total_number_of_backups + 1 value is useful in some tests contexts - so maybe the argument factory *is* the best place for the fix.  Or maybe the default case should be an error (missing test arguments?)\n\nOr this?  Like I said - really don\u0027t know.","accounts_in_message":[],"_revision_number":4},{"id":"d570cb3a48436bdfbfb7afb786c3c7f3a2c0241c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-11-09 23:05:10.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"6981ca279c9946d6ac9720e2eefcd50fdbfd2895","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-09 23:05:20.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"244c4d36d7a9bc88b1b3d65994a83ce9e8e8cb2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-09 23:08:31.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/79/387879/4/gate/gate-liberasurecode-unit/5aa8dc0/ : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":4},{"id":"16af343300179862c094198bd61f25321e578ee4","date":"2016-11-09 23:08:32.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e8b5a64d8d68c6f379fcd8aa69d934682b9e1a25","revisions":{"ea8d292fe1191aa9467e63363b4fe21fbe1b7fda":{"kind":"REWORK","_number":1,"created":"2016-10-18 09:18:14.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/79/387879/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/79/387879/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/1"}}},"commit":{"parents":[{"commit":"cb0daba975dfb3b7bffe402d7aa73fac19180f73","subject":"Add get_by_desc ret val handling to get_fragment_size","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/cb0daba975dfb3b7bffe402d7aa73fac19180f73"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-10-18 09:10:01.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-10-18 09:15:19.000000000","tz":-420},"subject":"Fix liberasurecode skipping a bunch of invalid_args tests","message":"Fix liberasurecode skipping a bunch of invalid_args tests\n\nSince the commit a01b1818c874a65d1d1fb8f11ea441e9d3e18771,\nwe have been to able to test some parameters for each tests.\nHowever, instead the NULL which means the end of the test parameters\ncauses skipping a bunch of unit tests which doesn\u0027t take args (e.g.\ntest_create_backend_invalid_args). That is the worse because we have not\ntested anymore for the tests since the commit.\n\nThis patch fixes to make it tested and more, fix a minor bug for a\ncase that corrupted header incomming to get_metadata.\n\nCloses-Bug: #1634403\n\nChange-Id: Ib99a8aa6032f02d0c7d1ab94b8da1ebfd9047d74\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/ea8d292fe1191aa9467e63363b4fe21fbe1b7fda"}]},"branch":"refs/heads/master"},"1cd0b05bd8f9b71d18e374985284c495cbcb2f86":{"kind":"REWORK","_number":2,"created":"2016-10-19 02:23:50.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/79/387879/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/79/387879/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/2"}}},"commit":{"parents":[{"commit":"cb0daba975dfb3b7bffe402d7aa73fac19180f73","subject":"Add get_by_desc ret val handling to get_fragment_size","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/cb0daba975dfb3b7bffe402d7aa73fac19180f73"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-10-18 09:10:01.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-10-19 02:19:53.000000000","tz":-420},"subject":"Fix liberasurecode skipping a bunch of invalid_args tests","message":"Fix liberasurecode skipping a bunch of invalid_args tests\n\nSince the commit a01b1818c874a65d1d1fb8f11ea441e9d3e18771,\nwe have been to able to test some parameters for each tests.\nHowever, instead, the NULL which means the end of the test parameters\ncauses skipping a bunch of unit tests which doesn\u0027t take args (e.g.\ntest_create_backend_invalid_args). That is the worse because we have not\ntested anymore for the tests since the commit.\n\nThis patch fixes to make it tested and more, fix a minor bug for a\ncase that corrupted header incomming to get_metadata.\n\nCloses-Bug: #1634403\n\nChange-Id: Ib99a8aa6032f02d0c7d1ab94b8da1ebfd9047d74\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/1cd0b05bd8f9b71d18e374985284c495cbcb2f86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/1cd0b05bd8f9b71d18e374985284c495cbcb2f86"}]},"branch":"refs/heads/master"},"b0c3a60a44004206fa609dc600684a4c6b0fbb6e":{"kind":"REWORK","_number":3,"created":"2016-11-04 10:01:51.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/79/387879/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/79/387879/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/3"}}},"commit":{"parents":[{"commit":"cb0daba975dfb3b7bffe402d7aa73fac19180f73","subject":"Add get_by_desc ret val handling to get_fragment_size","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/cb0daba975dfb3b7bffe402d7aa73fac19180f73"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-10-18 09:10:01.000000000","tz":-420},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-11-04 10:01:39.000000000","tz":-420},"subject":"Fix liberasurecode skipping a bunch of invalid_args tests","message":"Fix liberasurecode skipping a bunch of invalid_args tests\n\nSince the commit a01b1818c874a65d1d1fb8f11ea441e9d3e18771,\nwe have been to able to test some parameters for each tests.\nHowever, instead, the NULL which means the end of the test parameters\ncauses skipping a bunch of unit tests which doesn\u0027t take args (e.g.\ntest_create_backend_invalid_args). That is the worse because we have not\ntested anymore for the tests since the commit.\n\nThis patch fixes to make it tested and more, fix a minor bug for a\ncase that corrupted header incomming to get_metadata.\n\nCloses-Bug: #1634403\n\nChange-Id: Ib99a8aa6032f02d0c7d1ab94b8da1ebfd9047d74\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b0c3a60a44004206fa609dc600684a4c6b0fbb6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b0c3a60a44004206fa609dc600684a4c6b0fbb6e"}]},"branch":"refs/heads/master"},"e8b5a64d8d68c6f379fcd8aa69d934682b9e1a25":{"kind":"REWORK","_number":4,"created":"2016-11-04 18:42:37.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/79/387879/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/79/387879/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/79/387879/4"}}},"commit":{"parents":[{"commit":"cb0daba975dfb3b7bffe402d7aa73fac19180f73","subject":"Add get_by_desc ret val handling to get_fragment_size","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/cb0daba975dfb3b7bffe402d7aa73fac19180f73"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-10-18 09:10:01.000000000","tz":-420},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2016-11-04 18:42:11.000000000","tz":0},"subject":"Fix liberasurecode skipping a bunch of invalid_args tests","message":"Fix liberasurecode skipping a bunch of invalid_args tests\n\nSince the commit a01b1818c874a65d1d1fb8f11ea441e9d3e18771,\nwe have been to able to test some parameters for each tests.\nHowever, instead, the NULL which means the end of the test parameters\ncauses skipping a bunch of unit tests which doesn\u0027t take args (e.g.\ntest_create_backend_invalid_args). That is the worse because we have not\ntested anymore for the tests since the commit.\n\nThis patch fixes to make it tested and more, fix a minor bug for a\ncase that corrupted header incomming to get_metadata.\n\nCloses-Bug: #1634403\nChange-Id: Ib99a8aa6032f02d0c7d1ab94b8da1ebfd9047d74\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/e8b5a64d8d68c6f379fcd8aa69d934682b9e1a25"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/e8b5a64d8d68c6f379fcd8aa69d934682b9e1a25"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}