)]}'
{"include/isa_l/isa_l_common.h":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"69e45cfede9e463195e614ade6914c73d0a43fe7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    int k;"},{"line_number":56,"context_line":"    int m;"},{"line_number":57,"context_line":"    int w;"},{"line_number":58,"context_line":"} isa_l_descriptor;"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"int isa_l_encode(void *desc, char **data, char **parity, int blocksize);"},{"line_number":61,"context_line":"int isa_l_decode(void *desc, char **data, char **parity, int *missing_idxs,"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3a71b18c_dff6f35b","line":58,"updated":"2016-12-07 00:45:02.000000000","message":"anonymous typedef is new to me, but I think i\u0027m outdated - looks legit\n\n1. https://gcc.gnu.org/onlinedocs/gcc/Unnamed-Fields.html","commit_id":"88c101de1167cd7ab52e18be83741f4783c3c3ef"}],"src/backends/isa-l/isa_l_common.c":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bf6f3fec669d862265be35802130455fb63cd591","unresolved":false,"context_lines":[{"line_number":446,"context_line":"{"},{"line_number":447,"context_line":"    struct isa_l_rs_vand_descriptor *isa_l_desc \u003d NULL;"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    isa_l_desc \u003d (struct isa_l_rs_vand_descriptor*) desc;"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    free(isa_l_desc);"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"3a71b18c_a1014bb1","line":449,"updated":"2016-12-06 03:17:10.000000000","message":"Are these type contortions actually necessary? I thought free() took void* ...?","commit_id":"cb738b9b98188bb993881278035244db1f41e7a1"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5d63b82fdb9778c97d6a448da5bd5a62b5a758ec","unresolved":false,"context_lines":[{"line_number":446,"context_line":"{"},{"line_number":447,"context_line":"    struct isa_l_rs_vand_descriptor *isa_l_desc \u003d NULL;"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    isa_l_desc \u003d (struct isa_l_rs_vand_descriptor*) desc;"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    free(isa_l_desc);"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"3a71b18c_ba7c10b6","line":449,"in_reply_to":"3a71b18c_a1014bb1","updated":"2016-12-06 05:55:57.000000000","message":"Oops, that is my mistake, good catch. will fix.\n\nThe fix will include a change the isa_l_descritor from just a struct to type and then will remove all \u0027struct\u0027 word from this file to prevent similar mis-spelling problem.","commit_id":"cb738b9b98188bb993881278035244db1f41e7a1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bf6f3fec669d862265be35802130455fb63cd591","unresolved":false,"context_lines":[{"line_number":454,"context_line":"}"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"void * isa_l_common_init(struct ec_backend_args *args, void *backend_sohandle,"},{"line_number":458,"context_line":"        const char* gen_matrix_func_name)"},{"line_number":459,"context_line":"{"},{"line_number":460,"context_line":"    struct isa_l_descriptor *desc \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"3a71b18c_01d75f4b","line":457,"range":{"start_line":457,"start_character":0,"end_line":457,"end_character":6},"updated":"2016-12-06 03:17:10.000000000","message":"We can\u0027t return\n\n isa_l_descriptor *\n\n? Eh, I suppose now\u0027s not the time to try to fix it...","commit_id":"cb738b9b98188bb993881278035244db1f41e7a1"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5d63b82fdb9778c97d6a448da5bd5a62b5a758ec","unresolved":false,"context_lines":[{"line_number":454,"context_line":"}"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"void * isa_l_common_init(struct ec_backend_args *args, void *backend_sohandle,"},{"line_number":458,"context_line":"        const char* gen_matrix_func_name)"},{"line_number":459,"context_line":"{"},{"line_number":460,"context_line":"    struct isa_l_descriptor *desc \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"3a71b18c_15c875a7","line":457,"range":{"start_line":457,"start_character":0,"end_line":457,"end_character":6},"in_reply_to":"3a71b18c_01d75f4b","updated":"2016-12-06 05:55:57.000000000","message":"If we want to handle something in the each backend init functions, it could be useful to set isa_l_descriptor pointer from this function. However, currently we are nothing to do in the backend (please see isa-l-rs-vand and isa-l-cauchy init func) and it will return the private descriptor to the caller directly. In the caller side, the descriptor will be handled as void to be abstracted for all backends so I think we should keep this as it is for now (maybe until we need to change that)","commit_id":"cb738b9b98188bb993881278035244db1f41e7a1"},{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"fc816eaec0f82a3009f9a42ad539b3a8101be20b","unresolved":false,"context_lines":[{"line_number":532,"context_line":"    /**"},{"line_number":533,"context_line":"     * Generate ISA-L encoding matrix"},{"line_number":534,"context_line":"     */"},{"line_number":535,"context_line":"    desc-\u003egf_gen_rs_matrix(desc-\u003ematrix, desc-\u003ek + desc-\u003em, desc-\u003ek);"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    return desc;"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3a71b18c_6dcff655","line":535,"updated":"2016-12-07 00:50:20.000000000","message":"Hey Kota, we do need to get rid of this, don\u0027t we?  :-)","commit_id":"88c101de1167cd7ab52e18be83741f4783c3c3ef"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"5e909090e5e90e4cbdd79918acc476cb6f3ce99e","unresolved":false,"context_lines":[{"line_number":532,"context_line":"    /**"},{"line_number":533,"context_line":"     * Generate ISA-L encoding matrix"},{"line_number":534,"context_line":"     */"},{"line_number":535,"context_line":"    desc-\u003egf_gen_rs_matrix(desc-\u003ematrix, desc-\u003ek + desc-\u003em, desc-\u003ek);"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    return desc;"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3a71b18c_4d7a3abe","line":535,"in_reply_to":"3a71b18c_6d00d634","updated":"2016-12-07 01:01:00.000000000","message":"Ok Tushar, we don\u0027t need to get rid of this but you want to rename the name to clarify it as an abstraction of encoding matrix (either rs_vand or rs_cauchy). Will do soon.","commit_id":"88c101de1167cd7ab52e18be83741f4783c3c3ef"},{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"13569bbb2f921f6dc8ed19f651efdce80a69c77a","unresolved":false,"context_lines":[{"line_number":532,"context_line":"    /**"},{"line_number":533,"context_line":"     * Generate ISA-L encoding matrix"},{"line_number":534,"context_line":"     */"},{"line_number":535,"context_line":"    desc-\u003egf_gen_rs_matrix(desc-\u003ematrix, desc-\u003ek + desc-\u003em, desc-\u003ek);"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    return desc;"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3a71b18c_6d00d634","line":535,"in_reply_to":"3a71b18c_6dcff655","updated":"2016-12-07 00:56:17.000000000","message":"Never mind - on a second read, can we rename this to \"gf_gen_encoding_matrix()\"?","commit_id":"88c101de1167cd7ab52e18be83741f4783c3c3ef"},{"author":{"_account_id":8433,"name":"Kevin Greenan","email":"kmgreen2@gmail.com","username":"kmg"},"change_message_id":"f6c774b20f7aa13b60b4ddfeb37d783a78691769","unresolved":false,"context_lines":[{"line_number":532,"context_line":"    /**"},{"line_number":533,"context_line":"     * Generate ISA-L encoding matrix"},{"line_number":534,"context_line":"     */"},{"line_number":535,"context_line":"    desc-\u003egf_gen_rs_matrix(desc-\u003ematrix, desc-\u003ek + desc-\u003em, desc-\u003ek);"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    return desc;"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"3a71b18c_2d5c1e7c","line":535,"in_reply_to":"3a71b18c_6dcff655","updated":"2016-12-07 00:55:50.000000000","message":"Or replace with whatever gen_matrix_func_name resolves to?","commit_id":"88c101de1167cd7ab52e18be83741f4783c3c3ef"}],"src/backends/isa-l/isa_l_rs_cauchy.c":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bf6f3fec669d862265be35802130455fb63cd591","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#define ISA_L_RS_CAUCHY_LIB_MAJOR 2"},{"line_number":36,"context_line":"#define ISA_L_RS_CAUCHY_LIB_MINOR 14"},{"line_number":37,"context_line":"#define ISA_L_RS_CAUCHY_LIB_REV   1"},{"line_number":38,"context_line":"#define ISA_L_RS_CAUCHY_LIB_VER_STR \"2.14\""},{"line_number":39,"context_line":"#define ISA_L_RS_CAUCHY_LIB_NAME \"isa_l_rs_cauchy\""},{"line_number":40,"context_line":"#if defined(__MACOS__) || defined(__MACOSX__) || defined(__OSX__) || defined(__APPLE__)"},{"line_number":41,"context_line":"#define ISA_L_RS_CAUCHY_SO_NAME \"libisal.dylib\""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"3a71b18c_21553bf9","line":38,"updated":"2016-12-06 03:17:10.000000000","message":"The *_REV defs don\u0027t get rolled into the *_VER_STR defs? I guess not...","commit_id":"cb738b9b98188bb993881278035244db1f41e7a1"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bf6f3fec669d862265be35802130455fb63cd591","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#define ISA_L_RS_CAUCHY_LIB_VER_STR \"2.14\""},{"line_number":39,"context_line":"#define ISA_L_RS_CAUCHY_LIB_NAME \"isa_l_rs_cauchy\""},{"line_number":40,"context_line":"#if defined(__MACOS__) || defined(__MACOSX__) || defined(__OSX__) || defined(__APPLE__)"},{"line_number":41,"context_line":"#define ISA_L_RS_CAUCHY_SO_NAME \"libisal.dylib\""},{"line_number":42,"context_line":"#else"},{"line_number":43,"context_line":"#define ISA_L_RS_CAUCHY_SO_NAME \"libisal.so.2\""},{"line_number":44,"context_line":"#endif"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"3a71b18c_81128f55","line":41,"updated":"2016-12-06 03:17:10.000000000","message":"It seems curious that we have these in the per-ec_type source files rather than in common.h","commit_id":"cb738b9b98188bb993881278035244db1f41e7a1"}]}