)]}'
{"id":"openstack%2Fliberasurecode~403996","triplet_id":"openstack%2Fliberasurecode~master~I453d99a9866f54f20dac72cf76666d39fb2e7e87","project":"openstack/liberasurecode","branch":"master","topic":"isa-l-cauchy-support","hashtags":[],"change_id":"I453d99a9866f54f20dac72cf76666d39fb2e7e87","subject":"Gather up common isa_l function to isa_l_common.c file","status":"ABANDONED","created":"2016-11-29 03:05:25.000000000","updated":"2016-11-30 05:22:05.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"36c6f60f7a7c92ad2bdb50e05ca55f512ba66ef9","_number":403996,"virtual_id_number":403996,"owner":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":1,"date":"2016-11-29 04:12:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-29 18:56:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-29 03:32:16.000000000","updated_by":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"reviewer":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"state":"REVIEWER"},{"updated":"2016-11-29 04:12:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-11-29 18:56:44.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"436eb5842ec014e000d71547f62c6a6050eaa68d","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-29 03:05:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"259e68de886a80770609e7ab5235508d86bd369d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-29 03:08:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/96/403996/1/check/gate-liberasurecode-unit/33d9ed6/ : SUCCESS in 3m 05s","accounts_in_message":[],"_revision_number":1},{"id":"fd6f41831aeeb02cd3c81680cfdf3ccdcd4e2c07","author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"date":"2016-11-29 03:32:16.000000000","message":"Patch Set 1:\n\nThanks Kota.  Perhaps name the new file \"isa_l_common.c\"?","accounts_in_message":[],"_revision_number":1},{"id":"e9ab8836a0cd7758b4f2da04da437fac3bc9bfd3","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-29 03:59:17.000000000","message":"Patch Set 1:\n\nSure Tushar, will do soon, thanks.","accounts_in_message":[],"_revision_number":1},{"id":"43542cace689efe673e37f1b6487cfbb68eafde9","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-29 04:00:19.000000000","message":"Patch Set 1:\n\nAnd if you like this cleanup, can i squash this into https://review.openstack.org/#/c/393263 ?","accounts_in_message":[],"_revision_number":1},{"id":"5c0dbd7842e8aabd7948e06b1e2616b88b9b9863","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-29 04:07:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"392e777a792b95112090889aeda9fc8552f34f28","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-29 04:12:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/96/403996/2/check/gate-liberasurecode-unit/753f2be/ : SUCCESS in 4m 37s","accounts_in_message":[],"_revision_number":2},{"id":"b62366d180ded29daff8b04f4166a297684b02bb","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2016-11-29 18:56:44.000000000","message":"Patch Set 2: Code-Review+2\n\nthis is great; definitely should squash it into the other!\n\nbut why not go further and pull the init method into common as well?\n\nsomething like:\n\nhttps://gist.github.com/clayg/302a7e24d235c86e069c5e389cd99b35","accounts_in_message":[],"_revision_number":2},{"id":"aa96f86e9afa267d45ca4616bde3bea5d7d7c3d5","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-11-30 05:22:05.000000000","message":"Abandoned\n\nThis patch has been squashed up to https://review.openstack.org/#/c/393263","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"51d4b1e87c749a21a02de879b6a4a8d042114d62","revisions":{"5dc6aa7bf354b4fb6f6b697266a15f2a207b187a":{"kind":"REWORK","_number":1,"created":"2016-11-29 03:05:25.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/96/403996/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/96/403996/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/1"}}},"commit":{"parents":[{"commit":"8ede8810d7939a68f04af4d47ad30de68588cdc7","subject":"ISA-L Cauchy support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8ede8810d7939a68f04af4d47ad30de68588cdc7"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-11-29 02:41:43.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-11-29 03:03:49.000000000","tz":-480},"subject":"Gather up common isa_l function to isa_l.c file","message":"Gather up common isa_l function to isa_l.c file\n\nAfter copy/pasting almost code from isa_l_rs_vand.c to isa_l_rs_cauchy.c,\nI\u0027m realizing to wonder why I didn\u0027t make the common functions as the base\nfuncitonalities.\n\nThis is my current answer, we can make isa_l.c file for common fucntions\nlike encode/decode/reconstruct. That is because the difference between\nisa_l_rs_vand and isa_l_cauchy is just a function entry point for\nmatrix generation and it will be loaded by dlsym from .so file. Hence,\nwhat we need is just *init* to define what function from isa_l library used\nin the backend and attach it to the descriptor in the init function for\neach backend.\n\nChange-Id: I453d99a9866f54f20dac72cf76666d39fb2e7e87\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/5dc6aa7bf354b4fb6f6b697266a15f2a207b187a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/5dc6aa7bf354b4fb6f6b697266a15f2a207b187a"}]},"branch":"refs/heads/master"},"51d4b1e87c749a21a02de879b6a4a8d042114d62":{"kind":"REWORK","_number":2,"created":"2016-11-29 04:07:17.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/96/403996/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/96/403996/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/96/403996/2"}}},"commit":{"parents":[{"commit":"8ede8810d7939a68f04af4d47ad30de68588cdc7","subject":"ISA-L Cauchy support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8ede8810d7939a68f04af4d47ad30de68588cdc7"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-11-29 02:41:43.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-11-29 04:06:57.000000000","tz":-480},"subject":"Gather up common isa_l function to isa_l_common.c file","message":"Gather up common isa_l function to isa_l_common.c file\n\nAfter copy/pasting almost code from isa_l_rs_vand.c to isa_l_rs_cauchy.c,\nI\u0027m realizing to wonder why I didn\u0027t make the common functions as the base\nfuncitonalities.\n\nThis is my current answer, we can make isa_l_common.c file for common\nfucntions like encode/decode/reconstruct. That is because the difference\nbetween isa_l_rs_vand and isa_l_cauchy is just a function entry point for\nmatrix generation and it will be loaded by dlsym from .so file. Hence,\nwhat we need is just *init* to define what function from isa_l library used\nin the backend and attach it to the descriptor in the init function for\neach backend.\n\nChange-Id: I453d99a9866f54f20dac72cf76666d39fb2e7e87\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/51d4b1e87c749a21a02de879b6a4a8d042114d62"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/51d4b1e87c749a21a02de879b6a4a8d042114d62"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
