)]}'
{"id":"openstack%2Fliberasurecode~405926","triplet_id":"openstack%2Fliberasurecode~master~I8161ea7da3b069e83c93e11cb41ce12fa60c6f32","project":"openstack/liberasurecode","branch":"master","topic":"getlibec-version","hashtags":[],"change_id":"I8161ea7da3b069e83c93e11cb41ce12fa60c6f32","subject":"Add get_version functionality to liberasurecode lib","status":"MERGED","created":"2016-12-02 05:38:24.000000000","updated":"2016-12-08 19:54:37.000000000","submitted":"2016-12-08 19:54:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8b8a901f56787b2400ac24661a21ba2a79758020","_number":405926,"virtual_id_number":405926,"owner":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2016-12-08 19:54:37.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-12-08 19:48:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":2,"date":"2016-12-05 20:07:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-08 19:48:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"date":"2016-12-05 05:08:58.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-05 05:08:58.000000000","updated_by":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"reviewer":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"state":"REVIEWER"},{"updated":"2016-12-05 20:07:43.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2016-12-08 19:48:51.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2016-12-08 19:54:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"62eb31bb88fea0bc301ad325901468508e1f8c8b","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-12-02 05:38:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8f979439be813bfa2953f732acba1c4333ac6974","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-02 05:41:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/26/405926/1/check/gate-liberasurecode-unit/dfd8102/ : SUCCESS in 3m 08s","accounts_in_message":[],"_revision_number":1},{"id":"b956a74a6baa5f2fb17bbdf35248f89fd31e522f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-12-02 20:17:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nLove the idea! I think we might need to be a little more careful about types, though.","accounts_in_message":[],"_revision_number":1},{"id":"2b9e2688d649815ce3316aa779506ae1597d0bd9","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-12-05 04:52:27.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nGood catch Time. I\u0027ll address the type definition for this but the other topic you wrote in testcases is a bit skeptical to me. Please feel free to call me if you have better idea for that, thanks.","accounts_in_message":[],"_revision_number":1},{"id":"18f135b0d1a98e7db1a7ae498d527ac118ec481c","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2016-12-05 04:56:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0e8746751b23d5984fd1234017960309d1a8fda4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-05 04:59:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/26/405926/2/check/gate-liberasurecode-unit/8e57344/ : SUCCESS in 3m 05s","accounts_in_message":[],"_revision_number":2},{"id":"25a486b7988bd600478497d1c80127234c8f04e8","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-12-05 20:06:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d36bf4bbd4feb0de1fe50d8bcccfd83aba910ad2","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-12-05 20:07:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"851454aec0e3ab9a3c0008e7b78503ebc15847e9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2016-12-08 00:27:46.000000000","message":"Patch Set 2:\n\nNote for other reviewers: To test this I wrote a little wrapper http://paste.openstack.org/show/591738/\n\n* Save it off as test.c or whatever.\n* Get a user install of liberasurecode with something like\n\n  git review -d 405926\n  ./autogen.sh\n  ./configure --prefix\u003d$(pwd)/tmp\n  make \u0026\u0026 make install\n\n* Compile the test code like\n\n  gcc test.c -L tmp/lib -I tmp/include -l erasurecode -l dl -Xlinker -rpath -Xlinker $(pwd)/tmp/lib\n\n* Run ./a.out as a sanity check.\n* Twiddle _MAJOR/_MINOR/_REV in erasurecode_version.h\n* Check that the tester reports different versions like\n\n  make \u0026\u0026 make install \u0026\u0026 ./a.out\n\n* Roll back to HEAD^ and recheck.\n* Blow away all of tmp/lib and recheck.","accounts_in_message":[],"_revision_number":2},{"id":"db108504bf7ed2f2d07ede7695d93aaf88785d6e","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2016-12-08 19:48:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"494933b0203d53b63b36de2b0ba2433f33367fd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-08 19:49:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"24d9067e38b61d860e7277b80ea96779cca8929b","date":"2016-12-08 19:54:37.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"5e8662d82af927fea052527546ef994359d42108","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-08 19:54:37.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/26/405926/2/gate/gate-liberasurecode-unit/e63764c/ : SUCCESS in 5m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"09d8bbf361955b986fbcbf172dfbef2ed78d5f24","revisions":{"d9b7a559a174ca7fe2a761fe873363ef180379f2":{"kind":"REWORK","_number":1,"created":"2016-12-02 05:38:24.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/26/405926/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/26/405926/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/1"}}},"commit":{"parents":[{"commit":"0a2c06b8b446cbe4fda89c18c20b069728c70323","subject":"Version bump to 1.3.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0a2c06b8b446cbe4fda89c18c20b069728c70323"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-12-02 05:35:31.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-12-02 05:35:31.000000000","tz":-480},"subject":"Add get_version functionality to liberasurecode lib","message":"Add get_version functionality to liberasurecode lib\n\nCurrently, we have liberasurecode version info in the header and pyeclib\nis using the info to detect the version. However it\u0027s a bit painful\nbecause it requires to rebuild pyeclib c code for you to see the actual\ninstalled version.\n\nThis addition for liberasurecode_get_version enables caller to get the\nversion integer from compiled shared library file (.so) and it will\nrescure to re-compiled operation from pyeclib.\n\nChange-Id: I8161ea7da3b069e83c93e11cb41ce12fa60c6f32\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/d9b7a559a174ca7fe2a761fe873363ef180379f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/d9b7a559a174ca7fe2a761fe873363ef180379f2"}]},"branch":"refs/heads/master"},"09d8bbf361955b986fbcbf172dfbef2ed78d5f24":{"kind":"REWORK","_number":2,"created":"2016-12-05 04:56:36.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/26/405926/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/26/405926/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/26/405926/2"}}},"commit":{"parents":[{"commit":"0a2c06b8b446cbe4fda89c18c20b069728c70323","subject":"Version bump to 1.3.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0a2c06b8b446cbe4fda89c18c20b069728c70323"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-12-02 05:35:31.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2016-12-05 04:56:24.000000000","tz":-480},"subject":"Add get_version functionality to liberasurecode lib","message":"Add get_version functionality to liberasurecode lib\n\nCurrently, we have liberasurecode version info in the header and pyeclib\nis using the info to detect the version. However it\u0027s a bit painful\nbecause it requires to rebuild pyeclib c code for you to see the actual\ninstalled version.\n\nThis addition for liberasurecode_get_version enables caller to get the\nversion integer from compiled shared library file (.so) and it will\nrescure to re-compiled operation from pyeclib.\n\nChange-Id: I8161ea7da3b069e83c93e11cb41ce12fa60c6f32\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/09d8bbf361955b986fbcbf172dfbef2ed78d5f24"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/09d8bbf361955b986fbcbf172dfbef2ed78d5f24"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}