)]}'
{"src/backends/jerasure/jerasure_rs_cauchy.c":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9782572553ca2d4c9a83be991978762c32518eec","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        long long max_symbols;"},{"line_number":261,"context_line":"        max_symbols \u003d 1LL \u003c\u003c w;"},{"line_number":262,"context_line":"        if ((k + m) \u003e max_symbols) {"},{"line_number":263,"context_line":"            goto error;"},{"line_number":264,"context_line":"        }"},{"line_number":265,"context_line":"    }"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da36d5c6_dc73ffaf","line":263,"updated":"2017-02-20 21:10:31.000000000","message":"OK, this can jump to free_cauchy_desc and...","commit_id":"c7639ed55015e6c7bfba8dfda865bf0feb9df60a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9782572553ca2d4c9a83be991978762c32518eec","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        return;"},{"line_number":386,"context_line":"    }"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    if (jerasure_desc-\u003ematrix !\u003d NULL) {"},{"line_number":389,"context_line":"        free(jerasure_desc-\u003ematrix);"},{"line_number":390,"context_line":"    }"},{"line_number":391,"context_line":"    if (jerasure_desc-\u003ebitmatrix !\u003d NULL) {"},{"line_number":392,"context_line":"        free(jerasure_desc-\u003ebitmatrix);"},{"line_number":393,"context_line":"    }"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    // NOTE, based on an inspection of the jerasure code used to build the"},{"line_number":396,"context_line":"    // the schedule array, it appears that the sentinal used to signal the end"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da36d5c6_3cba5b24","line":393,"range":{"start_line":388,"start_character":0,"end_line":393,"end_character":5},"updated":"2017-02-20 21:10:31.000000000","message":"Those matrix could be NULL if it was before initialized, make sense.","commit_id":"c7639ed55015e6c7bfba8dfda865bf0feb9df60a"},{"author":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"change_message_id":"76a60b00e036c44886955078a6db0cae188e8db5","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    }"},{"line_number":358,"context_line":"    desc-\u003ebitmatrix \u003d desc-\u003ejerasure_matrix_to_bitmatrix(k, m, w, desc-\u003ematrix);"},{"line_number":359,"context_line":"    if (NULL \u003d\u003d desc-\u003ebitmatrix) {"},{"line_number":360,"context_line":"        goto error;"},{"line_number":361,"context_line":"    }"},{"line_number":362,"context_line":"    desc-\u003eschedule \u003d desc-\u003ejerasure_smart_bitmatrix_to_schedule(k, m, w, desc-\u003ebitmatrix);"},{"line_number":363,"context_line":"    if (NULL \u003d\u003d desc-\u003eschedule) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"da36d5c6_c1eaaa73","line":360,"updated":"2017-02-24 05:53:02.000000000","message":"I think at this point you should use a set of different error clauses. See e.g. https://review.openstack.org/#/c/431850/3/src/backends/isa-l/isa_l_common.c\n\nThen you don\u0027t need to make the free function deal with both fully and partial init, and you don\u0027t need the slower alloc_zeroed earlier in the file.","commit_id":"a2254c2a085579f59da25079ce1f4279aed21448"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f84202bcdf4dea6d898da69dfd545bb111475f94","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    }"},{"line_number":358,"context_line":"    desc-\u003ebitmatrix \u003d desc-\u003ejerasure_matrix_to_bitmatrix(k, m, w, desc-\u003ematrix);"},{"line_number":359,"context_line":"    if (NULL \u003d\u003d desc-\u003ebitmatrix) {"},{"line_number":360,"context_line":"        goto error;"},{"line_number":361,"context_line":"    }"},{"line_number":362,"context_line":"    desc-\u003eschedule \u003d desc-\u003ejerasure_smart_bitmatrix_to_schedule(k, m, w, desc-\u003ebitmatrix);"},{"line_number":363,"context_line":"    if (NULL \u003d\u003d desc-\u003eschedule) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1a1ced50_f2ce56b3","line":360,"in_reply_to":"da36d5c6_c1eaaa73","updated":"2017-03-16 17:56:04.000000000","message":"Done","commit_id":"a2254c2a085579f59da25079ce1f4279aed21448"}],"test/liberasurecode_test.c":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9782572553ca2d4c9a83be991978762c32518eec","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"    }"},{"line_number":1371,"context_line":"}"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"static void test_isa_l_rs_vand_decode_reconstruct_specific_error_case()"},{"line_number":1374,"context_line":"{"},{"line_number":1375,"context_line":"    struct ec_args specific_1010_args \u003d {"},{"line_number":1376,"context_line":"        .k \u003d 10,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da36d5c6_d9a4f158","line":1373,"updated":"2017-02-20 21:10:31.000000000","message":"good catch, this is only for the isa_l_rs_vand backend.","commit_id":"c7639ed55015e6c7bfba8dfda865bf0feb9df60a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9782572553ca2d4c9a83be991978762c32518eec","unresolved":false,"context_lines":[{"line_number":1472,"context_line":"        .m \u003d 10,"},{"line_number":1473,"context_line":"        .w \u003d 4,"},{"line_number":1474,"context_line":"    };"},{"line_number":1475,"context_line":"    // NB: (k + m) \u003e (1 \u003c\u003c w) \u003d\u003e too many frags!"},{"line_number":1476,"context_line":""},{"line_number":1477,"context_line":"    int desc \u003d -1;"},{"line_number":1478,"context_line":"    desc \u003d liberasurecode_instance_create("}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da36d5c6_5c1b8f72","line":1475,"updated":"2017-02-20 21:10:31.000000000","message":"Ok, 1 \u003c\u003c 4 -\u003e 16 \u003c 20 so this should fail.","commit_id":"c7639ed55015e6c7bfba8dfda865bf0feb9df60a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9782572553ca2d4c9a83be991978762c32518eec","unresolved":false,"context_lines":[{"line_number":1738,"context_line":""},{"line_number":1739,"context_line":"    // Jerasure RS Cauchy backend tests"},{"line_number":1740,"context_line":"    TEST_SUITE(EC_BACKEND_JERASURE_RS_CAUCHY),"},{"line_number":1741,"context_line":"    TEST(test_jerasure_rs_cauchy_init_failure,          EC_BACKENDS_MAX, 0),"},{"line_number":1742,"context_line":""},{"line_number":1743,"context_line":"    // ISA-L rs_vand tests"},{"line_number":1744,"context_line":"    TEST_SUITE(EC_BACKEND_ISA_L_RS_VAND),"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da36d5c6_1ccf5757","line":1741,"range":{"start_line":1741,"start_character":55,"end_line":1741,"end_character":76},"updated":"2017-02-20 21:10:31.000000000","message":"Ok, this is aligned to the vertical line above.","commit_id":"c7639ed55015e6c7bfba8dfda865bf0feb9df60a"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"9782572553ca2d4c9a83be991978762c32518eec","unresolved":false,"context_lines":[{"line_number":1743,"context_line":"    // ISA-L rs_vand tests"},{"line_number":1744,"context_line":"    TEST_SUITE(EC_BACKEND_ISA_L_RS_VAND),"},{"line_number":1745,"context_line":"    // note this test is hard-coded to use ISA-L"},{"line_number":1746,"context_line":"    TEST(test_isa_l_rs_vand_decode_reconstruct_specific_error_case, EC_BACKENDS_MAX, 0),"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"    // ISA-L rs cauchy tests"},{"line_number":1749,"context_line":"    TEST_SUITE(EC_BACKEND_ISA_L_RS_CAUCHY),"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"da36d5c6_9c098798","line":1746,"range":{"start_line":1746,"start_character":67,"end_line":1746,"end_character":83},"updated":"2017-02-20 21:10:31.000000000","message":"Only this line is not aligned though :P","commit_id":"c7639ed55015e6c7bfba8dfda865bf0feb9df60a"}]}