)]}'
{"test/liberasurecode_test.c":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e3998ecf807589aa6b913fe933d2182879f27426","unresolved":false,"context_lines":[{"line_number":1667,"context_line":""},{"line_number":1668,"context_line":"/* An individual test, useful to ensure the reported name"},{"line_number":1669,"context_line":"   reflects thefunction name */"},{"line_number":1670,"context_line":"#define TEST(test, backend, checksum) {#test, test, backend, checksum, .skip \u003d false}"},{"line_number":1671,"context_line":"/* Block of common tests for the \"real\" backends */"},{"line_number":1672,"context_line":"#define TEST_SUITE(backend) \\"},{"line_number":1673,"context_line":"    TEST(test_create_and_destroy_backend,               backend, CHKSUM_NONE), \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_d193134e","line":1670,"updated":"2017-02-10 01:25:29.000000000","message":"It doesn\u0027t look like we are currently using the skip thing?  Would we want to do that?","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e3998ecf807589aa6b913fe933d2182879f27426","unresolved":false,"context_lines":[{"line_number":1669,"context_line":"   reflects thefunction name */"},{"line_number":1670,"context_line":"#define TEST(test, backend, checksum) {#test, test, backend, checksum, .skip \u003d false}"},{"line_number":1671,"context_line":"/* Block of common tests for the \"real\" backends */"},{"line_number":1672,"context_line":"#define TEST_SUITE(backend) \\"},{"line_number":1673,"context_line":"    TEST(test_create_and_destroy_backend,               backend, CHKSUM_NONE), \\"},{"line_number":1674,"context_line":"    TEST(test_simple_encode_decode,                     backend, CHKSUM_NONE), \\"},{"line_number":1675,"context_line":"    TEST(test_decode_with_missing_data,                 backend, CHKSUM_NONE), \\"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_5192c358","line":1672,"updated":"2017-02-10 01:25:29.000000000","message":"*this* seems like a pretty big win","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1a6897e745bdfb61013dcb3990f4c26c45e3ec24","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"    TEST(test_verify_stripe_metadata_frag_idx_invalid,  backend, CHKSUM_CRC32), \\"},{"line_number":1690,"context_line":"    TEST(test_simple_encode_decode_over32,              backend, CHKSUM_CRC32)"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"struct testcase testcases[] \u003d {"},{"line_number":1693,"context_line":"    TEST(test_backend_available,                        EC_BACKEND_NULL, 0),"},{"line_number":1694,"context_line":"    TEST(test_backend_available_invalid_args,           EC_BACKENDS_MAX, 0),"},{"line_number":1695,"context_line":"    TEST(test_create_backend_invalid_args,              EC_BACKENDS_MAX, CHKSUM_TYPES_MAX),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da36d5c6_58885b71","line":1692,"range":{"start_line":1692,"start_character":16,"end_line":1692,"end_character":25},"updated":"2017-02-24 18:27:13.000000000","message":"nits) I\u0027d like to add an inline comment here that those tests are not related to a specific backend but general test cases in liberasurecode (L1693-L1707, i mean)","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1a6897e745bdfb61013dcb3990f4c26c45e3ec24","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    TEST(test_create_and_destroy_backend,               EC_BACKEND_NULL, CHKSUM_NONE),"},{"line_number":1710,"context_line":"    TEST(test_simple_encode_decode,                     EC_BACKEND_NULL, CHKSUM_NONE),"},{"line_number":1711,"context_line":"    TEST(test_get_fragment_metadata,                    EC_BACKEND_NULL, CHKSUM_NONE),"},{"line_number":1712,"context_line":"    TEST(test_decode_with_missing_parity,               EC_BACKEND_NULL, CHKSUM_NONE),"},{"line_number":1713,"context_line":"    TEST(test_decode_with_missing_multi_parity,         EC_BACKEND_NULL, CHKSUM_NONE),"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"    // Flat XOR backend tests"},{"line_number":1716,"context_line":"    TEST_SUITE(EC_BACKEND_FLAT_XOR_HD),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da36d5c6_b8fcf7b8","line":1713,"range":{"start_line":1712,"start_character":0,"end_line":1713,"end_character":86},"updated":"2017-02-24 18:27:13.000000000","message":"Those 2 look new tests. FWIW, I\u0027m not sure null backend works the both cases, IIRC, null backend won\u0027t do anything, it needs to check.","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e3998ecf807589aa6b913fe933d2182879f27426","unresolved":false,"context_lines":[{"line_number":1713,"context_line":"    TEST(test_decode_with_missing_multi_parity,         EC_BACKEND_NULL, CHKSUM_NONE),"},{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"    // Flat XOR backend tests"},{"line_number":1716,"context_line":"    TEST_SUITE(EC_BACKEND_FLAT_XOR_HD),"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"    // Jerasure RS Vand backend tests"},{"line_number":1719,"context_line":"    TEST_SUITE(EC_BACKEND_JERASURE_RS_VAND),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_d18cf337","line":1716,"updated":"2017-02-10 01:25:29.000000000","message":"nice.","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1a6897e745bdfb61013dcb3990f4c26c45e3ec24","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"    // ISA-L rs_vand tests"},{"line_number":1725,"context_line":"    TEST_SUITE(EC_BACKEND_ISA_L_RS_VAND),"},{"line_number":1726,"context_line":"    // note this test is hard-coded to use ISA-L"},{"line_number":1727,"context_line":"    TEST(test_decode_reconstruct_specific_error_case,   EC_BACKENDS_MAX, 0),"},{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"    // ISA-L rs cauchy tests"},{"line_number":1730,"context_line":"    TEST_SUITE(EC_BACKEND_ISA_L_RS_CAUCHY),"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da36d5c6_b88cf7da","line":1727,"updated":"2017-02-24 18:27:13.000000000","message":"Yup.","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1a6897e745bdfb61013dcb3990f4c26c45e3ec24","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"                        testcases[ii].description, i);"},{"line_number":1774,"context_line":"                fflush(stdout);"},{"line_number":1775,"context_line":"                testcases[ii].function();"},{"line_number":1776,"context_line":"                fprintf(stdout, \"ok\\n\");"},{"line_number":1777,"context_line":"                num_cases++;"},{"line_number":1778,"context_line":"                continue;"},{"line_number":1779,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da36d5c6_c338dcd5","line":1776,"updated":"2017-02-24 18:27:13.000000000","message":"fflush(stdout); here again?","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1a6897e745bdfb61013dcb3990f4c26c45e3ec24","unresolved":false,"context_lines":[{"line_number":1780,"context_line":"            const char *backend \u003d get_name_from_backend_id(testcases[ii].be_id);"},{"line_number":1781,"context_line":"            const char *chksum \u003d get_name_from_checksum_id(testcases[ii].ct);"},{"line_number":1782,"context_line":"            if (testcases[ii].skip) {"},{"line_number":1783,"context_line":"                fprintf(stdout, \"%3d - %s: %s (idx\u003d%d)... SKIP\\n\", num_cases,"},{"line_number":1784,"context_line":"                        testcases[ii].description,"},{"line_number":1785,"context_line":"                        backend, i);"},{"line_number":1786,"context_line":"                continue;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da36d5c6_a3b2084a","line":1783,"range":{"start_line":1783,"start_character":46,"end_line":1783,"end_character":54},"updated":"2017-02-24 18:27:13.000000000","message":"ct info should be here?","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e3998ecf807589aa6b913fe933d2182879f27426","unresolved":false,"context_lines":[{"line_number":1782,"context_line":"            if (testcases[ii].skip) {"},{"line_number":1783,"context_line":"                fprintf(stdout, \"%3d - %s: %s (idx\u003d%d)... SKIP\\n\", num_cases,"},{"line_number":1784,"context_line":"                        testcases[ii].description,"},{"line_number":1785,"context_line":"                        backend, i);"},{"line_number":1786,"context_line":"                continue;"},{"line_number":1787,"context_line":"            }"},{"line_number":1788,"context_line":"            struct ec_args *args \u003d create_ec_args(testcases[ii].be_id, testcases[ii].ct, i);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_31caaf50","line":1785,"updated":"2017-02-10 01:25:29.000000000","message":"hrm...","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"},{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"1a6897e745bdfb61013dcb3990f4c26c45e3ec24","unresolved":false,"context_lines":[{"line_number":1792,"context_line":"                        backend, chksum, i);"},{"line_number":1793,"context_line":"                fflush(stdout);"},{"line_number":1794,"context_line":"                testcases[ii].function(testcases[ii].be_id, args);"},{"line_number":1795,"context_line":"                fprintf(stdout, \"ok\\n\");"},{"line_number":1796,"context_line":"                free(args);"},{"line_number":1797,"context_line":"                num_cases++;"},{"line_number":1798,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da36d5c6_83598437","line":1795,"updated":"2017-02-24 18:27:13.000000000","message":"ditto.","commit_id":"8bad5c2fd717bcf50111d6c9f8143a02f4a110ff"}]}