)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ad55d122a2032475f70dcac3edc3eb1f18c6c2bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Calculate the tables only once, on init."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This trades off a little bit of per-context memory and creation"},{"line_number":16,"context_line":"time for measurably faster encodes when using the same context."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"On powerpc64le, when repeatedly encoding a 4kB file with pyeclib,"},{"line_number":19,"context_line":"this increases the measured speed by over 10%."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_1c12feb4","line":16,"updated":"2017-02-10 17:44:28.000000000","message":"Totally worth it!","commit_id":"fb0999768e8db66cf7642feade243f6024ae7496"}],"include/isa_l/isa_l_common.h":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ad55d122a2032475f70dcac3edc3eb1f18c6c2bc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    int k;"},{"line_number":57,"context_line":"    int m;"},{"line_number":58,"context_line":"    int w;"},{"line_number":59,"context_line":"} isa_l_descriptor;"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"int isa_l_encode(void *desc, char **data, char **parity, int blocksize);"},{"line_number":62,"context_line":"int isa_l_decode(void *desc, char **data, char **parity, int *missing_idxs,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_1cee7e8b","line":59,"updated":"2017-02-10 17:44:28.000000000","message":"Cool -- this seems to be used entirely internally, so changing the size of the struct shouldn\u0027t affect downstream consumers.\n\nI almost wonder if we should (later, not now) move it into the .c file to make that more explicit...","commit_id":"fb0999768e8db66cf7642feade243f6024ae7496"}],"src/backends/isa-l/isa_l_common.c":[{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"0501b9c65cf82ab31a6b36664d97f686b6f5f513","unresolved":false,"context_lines":[{"line_number":533,"context_line":"     * Generate the tables for encoding"},{"line_number":534,"context_line":"     */"},{"line_number":535,"context_line":"    desc-\u003eencode_tables \u003d malloc(sizeof(unsigned char) *"},{"line_number":536,"context_line":"\t\t\t\t (desc-\u003ek * desc-\u003em * 32));"},{"line_number":537,"context_line":"    if (NULL \u003d\u003d desc-\u003eencode_tables) {"},{"line_number":538,"context_line":"        goto error;"},{"line_number":539,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_c1c5f65b","line":536,"updated":"2017-02-10 07:17:21.000000000","message":"total nitpick: whitespace is usually spaces rather than tabs, but not sure how much this project cares","commit_id":"fb0999768e8db66cf7642feade243f6024ae7496"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ad55d122a2032475f70dcac3edc3eb1f18c6c2bc","unresolved":false,"context_lines":[{"line_number":545,"context_line":"    return desc;"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"error:"},{"line_number":548,"context_line":"    free(desc);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    return NULL;"},{"line_number":551,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_f7b6233c","line":548,"updated":"2017-02-10 17:44:28.000000000","message":"This should now also free desc-\u003ematrix, if it was allocated.","commit_id":"fb0999768e8db66cf7642feade243f6024ae7496"},{"author":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"change_message_id":"2d6d850bf7a81548ce1716d3ff828eb1186e5f44","unresolved":false,"context_lines":[{"line_number":545,"context_line":"    return desc;"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"error:"},{"line_number":548,"context_line":"    free(desc);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    return NULL;"},{"line_number":551,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa31d9ce_09947389","line":548,"in_reply_to":"fa31d9ce_f7b6233c","updated":"2017-02-10 21:24:44.000000000","message":"Good catch - I will respin the patch when I get back to work on Monday.","commit_id":"fb0999768e8db66cf7642feade243f6024ae7496"}]}