)]}'
{"id":"openstack%2Fliberasurecode~434162","triplet_id":"openstack%2Fliberasurecode~master~I96f124e4e536bbd7544208acc084de1cda5c19b2","project":"openstack/liberasurecode","branch":"master","topic":"bug/1665242","hashtags":[],"change_id":"I96f124e4e536bbd7544208acc084de1cda5c19b2","subject":"Fix valgrind-check and memory leak","status":"MERGED","created":"2017-02-15 09:19:37.000000000","updated":"2017-02-20 16:14:09.000000000","submitted":"2017-02-20 16:14:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"395d58c03d2cbdf8ae0da3bd6078eb22730c26cd","_number":434162,"virtual_id_number":434162,"owner":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2017-02-20 16:14:09.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"all":[{"value":2,"date":"2017-02-20 16:06:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},{"value":2,"date":"2017-02-20 15:51:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"all":[{"value":1,"date":"2017-02-20 16:06:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-17 07:39:01.000000000","updated_by":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"reviewer":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"state":"REVIEWER"},{"updated":"2017-02-20 15:51:17.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-02-20 16:14:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4ea7f0be804f71c594ba9aedb58b10812b440dc4","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-15 09:19:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"739e451fa30436c4adcdebb30bd111c54d912907","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 09:21:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/1/check/gate-liberasurecode-unit/26c79ea/ : FAILURE in 53s","accounts_in_message":[],"_revision_number":1},{"id":"d8a1660ef8f3715daf5011c424ddc9413e487ad5","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-15 10:20:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"36650c0384e2f5849a186ca6cccf2ef30054e33e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 10:26:19.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/2/check/gate-liberasurecode-unit/e748dd7/ : FAILURE in 2m 54s","accounts_in_message":[],"_revision_number":2},{"id":"e0d89dc9e43cd50b90d09dc52997ed163822d416","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-15 10:33:13.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"7406221cbf621cbecb49e03cd81535ef9ed6dc1f","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-15 10:34:57.000000000","message":"Patch Set 3: Workflow-1\n\nOk, it looks the leak blocks are less than my env. Maybe it seems that I referred older code (w/o ISA-L exit fix) so we can start at the gate result but it still reports the leak more than 1500 blocks on definitely lost X(","accounts_in_message":[],"_revision_number":3},{"id":"ddfe4366d59d820db5107843c89b90cdb145660a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-15 10:37:48.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/3/check/gate-liberasurecode-unit/0adf5a1/ : FAILURE in 2m 43s","accounts_in_message":[],"_revision_number":3},{"id":"44b277d8142cdb03bd5f60975b01fe7c5f2c1b15","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-15 10:43:46.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nadd small comments for why we need this fix as inlines.","accounts_in_message":[],"_revision_number":3},{"id":"a5a097a2af04434973e1216bef8cf65faf9e6d92","author":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"date":"2017-02-16 00:48:21.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"732d370193268c5070c5720ba1fd98f6c9385581","author":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"date":"2017-02-16 01:08:14.000000000","message":"Patch Set 3:\n\nI think we also need to add the sources for the other plugins, to catch leaks (and bugs) in them, right?","accounts_in_message":[],"_revision_number":3},{"id":"d0858f3bad90e1e83f1a872fc7683d2d7bb5aca0","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-16 07:20:14.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f59b361b7c29de76923ecb22ea9430c9e1e0973f","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-16 07:21:47.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"5f810f794b9fdd122c644a81d4cd1198d17dc6ad","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-16 07:22:51.000000000","message":"Patch Set 5:\n\nSquash Tim\u0027s fix up and change Makefile.am according to Daniel\u0027s comment.","accounts_in_message":[],"_revision_number":5},{"id":"e75e95254606ae51a8849b626128bb6d5fff538e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-16 07:30:36.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/5/check/gate-liberasurecode-unit/185dc51/ : SUCCESS in 7m 43s","accounts_in_message":[],"_revision_number":5},{"id":"794a3c6a0b7bb22165ba22fb9972dd014154e60c","author":{"_account_id":25109,"name":"Daniel Axtens","email":"dja@axtens.net","username":"dja"},"date":"2017-02-17 07:39:01.000000000","message":"Patch Set 5:\n\n\u003e Squash Tim\u0027s fix up and change Makefile.am according to Daniel\u0027s\n \u003e comment.\n\nI probably wasn\u0027t very clear: I think --trace-children should be enough that you don\u0027t need any other changes to the makefile. Have you tried that?","accounts_in_message":[],"_revision_number":5},{"id":"5d9ab05c770ca7c9e6f476fc67fda17ffbe9becc","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-17 08:11:00.000000000","message":"Patch Set 5:\n\n@Daniel\n\nI didn\u0027t try to remove other change but the setting for the library path is in `test` command in the Makefile.am too. And IIRC, the setting was added for testing the local built binaries (see the commit[1]) so that I added the setting to `valgrind-test` to be consistent.\n\nFWIW, if we remove that, the test binaries references the default shared object library path? Not entirely sure. \n\n1: https://github.com/openstack/liberasurecode/commit/93446db9414f311bd9fc7dc047eb4dbbeb3e6feb","accounts_in_message":[],"_revision_number":5},{"id":"54f78d92128ed96f0172ee308651f4e74025f445","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-02-17 18:18:16.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"4e671a74f468283162a3c8c9c699622598984dff","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-02-20 06:41:54.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"99e3b03bc70e1279154a6311a5d61f7e57b7e15c","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-20 15:17:23.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"bba4e067838e250236987a91927a02b964ed7b29","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-20 15:21:10.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"30e342e646f8732d00c16dac35b4a3179241e93d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 15:26:51.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/6/check/gate-liberasurecode-unit/960fec7/ : FAILURE in 3m 44s","accounts_in_message":[],"_revision_number":6},{"id":"c61eb930532a1bb667936ca8514e2e380101ea39","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-20 15:46:02.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"8138aa71876eb6f4cb4b43642a0936f81e282193","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-02-20 15:51:17.000000000","message":"Patch Set 7: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"94f49b9e8291de9dcc8f2a2fba305f77c5951b1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 15:57:44.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/7/check/gate-liberasurecode-unit/e0360eb/ : SUCCESS in 9m 19s","accounts_in_message":[],"_revision_number":7},{"id":"22913e7932e0ba9e7e9c1608c40d0cf964ec707d","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-20 16:06:39.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nOk, Tim add his +2 and I\u0027m sure we need this asap to ensure that we don\u0027t have the memory leak at the gate job, so +2 +A though I\u0027m the author of this patch.","accounts_in_message":[],"_revision_number":7},{"id":"3b80ae61f01571b79a669da563b462a75f6bebc6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 16:06:49.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"9005485ab0209a11b3d21b906d3a06be1874d6fa","date":"2017-02-20 16:14:09.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":7},{"id":"d9776d5f24dbb669e7d181256ae2c0dea7ddcf8d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 16:14:09.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/62/434162/7/gate/gate-liberasurecode-unit/65fa78d/ : SUCCESS in 7m 14s","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"c9136a62b6e7cc8701cd7206ef0367520a20b8b9","revisions":{"13211a10f443e602f70e30be7d97a52bc8cd7a6c":{"kind":"REWORK","_number":1,"created":"2017-02-15 09:19:37.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/1"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:19:01.000000000","tz":-480},"subject":"WIP: Fix valgrind-check to use actual binary","message":"WIP: Fix valgrind-check to use actual binary\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\n\nNow this patch enable to run the valgrind against to the binaries but\nat least in my environment, it reports\n\n\u003d\u003d24165\u003d\u003d LEAK SUMMARY:\n\u003d\u003d24165\u003d\u003d    definitely lost: 63,008,880 bytes in 4,119 blocks\n\u003d\u003d24165\u003d\u003d    indirectly lost: 52,094,184 bytes in 485 blocks\n\u003d\u003d24165\u003d\u003d      possibly lost: 6,029,440 bytes in 9 blocks\n\u003d\u003d24165\u003d\u003d    still reachable: 7,042,451 bytes in 99,523 blocks\n\u003d\u003d24165\u003d\u003d         suppressed: 0 bytes in 0 blocks\n\nwith liberasurecode_test binary so that we need to fix at least\ndefinitely lost of them with this patch. It is why I set this as WIP.\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/13211a10f443e602f70e30be7d97a52bc8cd7a6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/13211a10f443e602f70e30be7d97a52bc8cd7a6c"}]},"branch":"refs/heads/master"},"8edd5c0e3f989facac40e497d878d899945e31c0":{"kind":"REWORK","_number":2,"created":"2017-02-15 10:20:32.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/2"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 10:20:10.000000000","tz":-480},"subject":"WIP: Fix valgrind-check to use actual binary","message":"WIP: Fix valgrind-check to use actual binary\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\n\nNow this patch enable to run the valgrind against to the binaries but\nat least in my environment, it reports\n\n\u003d\u003d24165\u003d\u003d LEAK SUMMARY:\n\u003d\u003d24165\u003d\u003d    definitely lost: 63,008,880 bytes in 4,119 blocks\n\u003d\u003d24165\u003d\u003d    indirectly lost: 52,094,184 bytes in 485 blocks\n\u003d\u003d24165\u003d\u003d      possibly lost: 6,029,440 bytes in 9 blocks\n\u003d\u003d24165\u003d\u003d    still reachable: 7,042,451 bytes in 99,523 blocks\n\u003d\u003d24165\u003d\u003d         suppressed: 0 bytes in 0 blocks\n\nwith liberasurecode_test binary so that we need to fix at least\ndefinitely lost of them with this patch. It is why I set this as WIP.\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8edd5c0e3f989facac40e497d878d899945e31c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8edd5c0e3f989facac40e497d878d899945e31c0"}]},"branch":"refs/heads/master"},"fbfcd0625b02cb9f0971caa1f26a3a9f05392753":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-02-15 10:33:13.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/3"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 10:33:03.000000000","tz":0},"subject":"WIP: Fix valgrind-check to use actual binary","message":"WIP: Fix valgrind-check to use actual binary\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\n\nNow this patch enable to run the valgrind against to the binaries but\nat least in the gate, it reports\n\n\u003d\u003d6526\u003d\u003d LEAK SUMMARY:\n\u003d\u003d6526\u003d\u003d    definitely lost: 86,202,988 bytes in 1,501 blocks\n\u003d\u003d6526\u003d\u003d    indirectly lost: 20,327,180 bytes in 214 blocks\n\u003d\u003d6526\u003d\u003d      possibly lost: 2,228,304 bytes in 4 blocks\n\u003d\u003d6526\u003d\u003d    still reachable: 1,149,039 bytes in 407 blocks\n\u003d\u003d6526\u003d\u003d         suppressed: 0 bytes in 0 blocks\n\nwith liberasurecode_test binary so that we need to fix at least\ndefinitely lost of them with this patch. It is why I set this as WIP.\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/fbfcd0625b02cb9f0971caa1f26a3a9f05392753"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/fbfcd0625b02cb9f0971caa1f26a3a9f05392753"}]},"branch":"refs/heads/master"},"8b381226e45e6de34c4bb6cc6e029633aaa9913d":{"kind":"REWORK","_number":4,"created":"2017-02-16 07:20:14.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/4"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-16 07:19:46.000000000","tz":-480},"subject":"Fix valgrind-check and memory-leak found at","message":"Fix valgrind-check and memory-leak found at\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\nNow this patch enable to run the valgrind against to the binaries.\n\nWith this fix, we found various memory leak at liberasurecode_test as\nfollows and this patch also fixes them:\n\n- If we create fake fragments, we\u0027re responsible for freeing all of the\n  frags as well as the array holding the pointers to the frags.\n- If we allocate any space, we\u0027re responsible for freeing it.\n- If we create an EC descriptor, we\u0027re responsible for destroying it.\n- If we create a fragment or skip array, we\u0027re responsible for freeing it.\n- If that happens inside a loop, we\u0027re responsible for doing it *inside\n  that same loop*.\n\nIn addition to the test fix, this patch fixes following memory leaks at\nthe code which is affected to other users (pyeclib, OpenStack Swift)\n\n* Refuse to decode fragments that aren\u0027t even long enough to include\n  fragment headers.\n* Fix a small memory leak in the builtin rs_vand implementation.\n\nCloses-Bug: #1665242\n\nCo-Authored-By: Tim Burke \u003ctim@swiftstack.com\u003e\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8b381226e45e6de34c4bb6cc6e029633aaa9913d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8b381226e45e6de34c4bb6cc6e029633aaa9913d"}]},"branch":"refs/heads/master"},"f560f32fe77ee05229ae6197dd40bd1406d96b78":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2017-02-16 07:21:47.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/5"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-16 07:20:59.000000000","tz":-480},"subject":"Fix valgrind-check and memory leak","message":"Fix valgrind-check and memory leak\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\nNow this patch enable to run the valgrind against to the binaries.\n\nWith this fix, we found various memory leak at liberasurecode_test as\nfollows and this patch also fixes them:\n\n- If we create fake fragments, we\u0027re responsible for freeing all of the\n  frags as well as the array holding the pointers to the frags.\n- If we allocate any space, we\u0027re responsible for freeing it.\n- If we create an EC descriptor, we\u0027re responsible for destroying it.\n- If we create a fragment or skip array, we\u0027re responsible for freeing it.\n- If that happens inside a loop, we\u0027re responsible for doing it *inside\n  that same loop*.\n\nIn addition to the test fix, this patch fixes following memory leaks at\nthe code which is affected to other users (pyeclib, OpenStack Swift)\n\n* Refuse to decode fragments that aren\u0027t even long enough to include\n  fragment headers.\n* Fix a small memory leak in the builtin rs_vand implementation.\n\nCloses-Bug: #1665242\n\nCo-Authored-By: Tim Burke \u003ctim@swiftstack.com\u003e\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/f560f32fe77ee05229ae6197dd40bd1406d96b78"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/f560f32fe77ee05229ae6197dd40bd1406d96b78"}]},"branch":"refs/heads/master"},"ba3ed7c479bba43368e76f5e231a306f52d501a7":{"kind":"REWORK","_number":6,"created":"2017-02-20 15:21:10.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/6"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-20 15:21:00.000000000","tz":-480},"subject":"Fix valgrind-check and memory leak","message":"Fix valgrind-check and memory leak\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\nNow this patch enable to run the valgrind against to the binaries.\n\nWith this fix, we found various memory leak at liberasurecode_test as\nfollows and this patch also fixes them:\n\n- If we create fake fragments, we\u0027re responsible for freeing all of the\n  frags as well as the array holding the pointers to the frags.\n- If we allocate any space, we\u0027re responsible for freeing it.\n- If we create an EC descriptor, we\u0027re responsible for destroying it.\n- If we create a fragment or skip array, we\u0027re responsible for freeing it.\n- If that happens inside a loop, we\u0027re responsible for doing it *inside\n  that same loop*.\n\nIn addition to the test fix, this patch fixes following memory leaks at\nthe code which is affected to other users (pyeclib, OpenStack Swift)\n\n* Refuse to decode fragments that aren\u0027t even long enough to include\n  fragment headers.\n* Fix a small memory leak in the builtin rs_vand implementation.\n\nCloses-Bug: #1665242\n\nCo-Authored-By: Tim Burke \u003ctim@swiftstack.com\u003e\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/ba3ed7c479bba43368e76f5e231a306f52d501a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/ba3ed7c479bba43368e76f5e231a306f52d501a7"}]},"branch":"refs/heads/master"},"c9136a62b6e7cc8701cd7206ef0367520a20b8b9":{"kind":"REWORK","_number":7,"created":"2017-02-20 15:46:02.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/62/434162/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/62/434162/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/62/434162/7"}}},"commit":{"parents":[{"commit":"10e096fe097a489eec41bad120f5b5e52fa4b61c","subject":"ISA-L: free matrix on exit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/10e096fe097a489eec41bad120f5b5e52fa4b61c"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-15 09:08:25.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-20 15:45:55.000000000","tz":-480},"subject":"Fix valgrind-check and memory leak","message":"Fix valgrind-check and memory leak\n\nCan you believe that we ware testing the memory leak with valgrind\nto just *bash scripts* instead of actual binaries on liberasurecode_test\nand libec_slap?\n\nThat is why we cannot find such an easy memory leak[1] at the gate.\nNow this patch enable to run the valgrind against to the binaries.\n\nWith this fix, we found various memory leak at liberasurecode_test as\nfollows and this patch also fixes them:\n\n- If we create fake fragments, we\u0027re responsible for freeing all of the\n  frags as well as the array holding the pointers to the frags.\n- If we allocate any space, we\u0027re responsible for freeing it.\n- If we create an EC descriptor, we\u0027re responsible for destroying it.\n- If we create a fragment or skip array, we\u0027re responsible for freeing it.\n- If that happens inside a loop, we\u0027re responsible for doing it *inside\n  that same loop*.\n\nIn addition to the test fix, this patch fixes following memory leaks at\nthe code which is affected to other users (pyeclib, OpenStack Swift)\n\n* Refuse to decode fragments that aren\u0027t even long enough to include\n  fragment headers.\n* Fix a small memory leak in the builtin rs_vand implementation.\n\nCloses-Bug: #1665242\n\nCo-Authored-By: Tim Burke \u003ctim@swiftstack.com\u003e\n\n1: https://review.openstack.org/#/c/431812\n\nChange-Id: I96f124e4e536bbd7544208acc084de1cda5c19b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/c9136a62b6e7cc8701cd7206ef0367520a20b8b9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/c9136a62b6e7cc8701cd7206ef0367520a20b8b9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}