)]}'
{"id":"openstack%2Fliberasurecode~436233","triplet_id":"openstack%2Fliberasurecode~master~I0e79bed7755a1f286b746a70fcf56fdc972bfd5d","project":"openstack/liberasurecode","branch":"master","topic":"testing-tool","hashtags":[],"change_id":"I0e79bed7755a1f286b746a70fcf56fdc972bfd5d","subject":"Fix warning on automake tool","status":"MERGED","created":"2017-02-20 22:26:54.000000000","updated":"2017-05-10 15:35:41.000000000","submitted":"2017-05-10 15:35:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"812ae3661a06e4b23e318cb4dfe6beba0e4df1bb","_number":436233,"virtual_id_number":436233,"owner":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-05-10 15:35:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-05-03 23:34:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":2,"date":"2017-02-21 15:55:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":1,"date":"2017-05-10 15:24:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-03 23:34:14.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2017-05-10 15:24:52.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-05-10 15:35:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4a0e09e666202458c1df63e01275bc12d93c7b51","author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"date":"2017-02-20 22:26:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d08d07bc05638d391a7029b632e49f85a1c56e9f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 22:38:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit http://logs.openstack.org/33/436233/1/check/gate-liberasurecode-unit/0e53164/ : SUCCESS in 9m 23s","accounts_in_message":[],"_revision_number":1},{"id":"73b94a2914a179964e01e27d83fba1abc3d0b7f3","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-02-21 15:55:18.000000000","message":"Patch Set 1: Code-Review+2\n\nNice! autogen.sh output is much better [1], and regressing a memory leak [2] has make return non-zero just fine. I find it a little weird/annoying that sed seems to be leaking memory and polluting results, but it doesn\u0027t seem to affect the final exit code, so I guess it\u0027s fine.\n\n[1] http://paste.openstack.org/show/599857/\n[2] https://review.openstack.org/#/c/434162/7/src/builtin/rs_vand/liberasurecode_rs_vand.c\n[3] http://logs.openstack.org/33/436233/1/check/gate-liberasurecode-unit/0e53164/console.html#_2017-02-20_22_30_15_695718","accounts_in_message":[],"_revision_number":1},{"id":"44a0a7e67336c5226031be0e06576174bc41a25f","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2017-05-03 23:34:14.000000000","message":"Patch Set 1: Code-Review+2\n\nI don\u0027t get it - what\u0027s the difference between `test/.lib/libec_slap` and `test/libec_slap` besides the size and contents?\n\n    (swift) clayg:~/Workspace/vagrant-swift-all-in-one/liberasurecode$ md5sum test/libec_slap test/.libs/libec_slap \n    027fcf864f5107fba600de96288422a8  test/libec_slap\n    4cc3dd2921b3fa24a5a48678a0e9659b  test/.libs/libec_slap\n    (swift) clayg:~/Workspace/vagrant-swift-all-in-one/liberasurecode$ ls -alhF test/libec_slap test/.libs/libec_slap\n    -rwxr-xr-x  1 clayg  staff   410K May  3 16:30 test/.libs/libec_slap*\n    -rwxr-xr-x  1 clayg  staff   7.6K May  3 16:30 test/libec_slap*\n\nWhen I run them they both seem to do the same thing - why do we need both?  why is the bigger one better?\n\nWhy doesn\u0027t our .gitignore know about these generated files?\n\n    (swift) clayg:~/Workspace/vagrant-swift-all-in-one/liberasurecode$ git status\n    On branch review/kota_tsuyuzaki/testing-tool\n    Your branch is ahead of \u0027gerrit/master\u0027 by 3 commits.\n      (use \"git push\" to publish your local commits)\n    Untracked files:\n      (use \"git add \u003cfile\u003e...\" to include in what will be committed)\n\n        INSTALL\n        depcomp\n        missing\n        test/alg_sig_test\n        test/libec_slap\n        test/liberasurecode_rs_vand_test\n        test/liberasurecode_test\n        test/rs_galois_test\n        test/test_xor_hd_code\n\n    nothing added to commit but untracked files present (use \"git add\" to track)\n\nFWIW as best I can tell `make valgrind-test` still seems to do something related to memory leaks; but that\u0027s about as far as I understand it.","accounts_in_message":[],"_revision_number":1},{"id":"445085cfaf368a7d99a8dc941072acb6eacd5414","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-05-10 15:24:52.000000000","message":"Patch Set 1: Workflow+1\n\nSo my understanding is that the shell scripts (like test/libec_slap) use some libtool magic to have the real executable (like test/.libs/libec_slap) load the just-compiled library without needing to install it.\n\nBefore we added --trace-children\u003dyes (in https://review.openstack.org/#/c/434162/7/Makefile.am) our valgrind-test target *only traced bash* as it was invoking the script. As I recall, that review started out with us just running the test executable, then we realized that there was this other option that would get us the coverage we want *with* the libtool magic, but we forgot to switch back to the shell scripts.","accounts_in_message":[],"_revision_number":1},{"id":"2f176223acd64642e2ce97d4c1a0baca57f8999a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-10 15:25:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"385f9ac18c5f2ba73d17a7258d3340a998689030","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-10 15:35:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/33/436233/1/gate/gate-liberasurecode-unit-ubuntu-xenial/acf9a65/ : SUCCESS in 10m 21s","accounts_in_message":[],"_revision_number":1},{"id":"c75c5d816f1a5eed777a2465e6b38ee90a45cc9e","date":"2017-05-10 15:35:41.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"19442df2cd9a5bc8ec4deded7046ea7aca1d50a2","revisions":{"19442df2cd9a5bc8ec4deded7046ea7aca1d50a2":{"kind":"REWORK","_number":1,"created":"2017-02-20 22:26:54.000000000","uploader":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"ref":"refs/changes/33/436233/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/33/436233/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/33/436233/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/33/436233/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/33/436233/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/33/436233/1"}}},"commit":{"parents":[{"commit":"c9136a62b6e7cc8701cd7206ef0367520a20b8b9","subject":"Fix valgrind-check and memory leak","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/c9136a62b6e7cc8701cd7206ef0367520a20b8b9"}]}],"author":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-20 22:12:43.000000000","tz":-480},"committer":{"name":"Kota Tsuyuzaki","email":"tsuyuzaki.kota@lab.ntt.co.jp","date":"2017-02-20 22:23:16.000000000","tz":-480},"subject":"Fix warning on automake tool","message":"Fix warning on automake tool\n\nThis patch fixes automake tools warnings as follows (and a my fault\nin previous patch [1]):\n\n- Change INCLUDES variable to APP_CPP_FLAGS and APP_C_FLAGS according to\n  the warning message\n\n- Remove non-POSIX variable to suppress that warnings\n\nNote that the latter change may be affected to the testing so please\nbe careful on your review what\u0027s going on your testing environment.\nIn the past change [2], they ware designed to use the shared\nobject binaries in the build path. However, Daniel had pointed out the good\nthing at [1] if we runs the test/liberasruecode_test (it\u0027s shell with linker)\nin the dir, we can touch the expected binaries.\n\nMy fault in the previous patch is that I didn\u0027t replace\n./test/.libs/liberasurecode_test to ./test/liberasurecode_test even\nwe use --trace-children\u003dyes option for the valgrind.\n\nNow, all tests run via ./test/\u003ctest name\u003e syntax and IMO no matters\nexist even if we remove the non-POSIX variable for test settings.\n\n1: https://review.openstack.org/#/c/434162\n2: 93446db9414f311bd9fc7dc047eb4dbbeb3e6feb\n\nChange-Id: I0e79bed7755a1f286b746a70fcf56fdc972bfd5d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/19442df2cd9a5bc8ec4deded7046ea7aca1d50a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/19442df2cd9a5bc8ec4deded7046ea7aca1d50a2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}