)]}'
{"id":"openstack%2Fliberasurecode~458987","triplet_id":"openstack%2Fliberasurecode~master~I39fb137b1a3b6b2beda1d0b28faef3132229ec3b","project":"openstack/liberasurecode","branch":"master","topic":"458987","hashtags":[],"change_id":"I39fb137b1a3b6b2beda1d0b28faef3132229ec3b","subject":"Add dl to pkg-config metadata","status":"MERGED","created":"2017-04-21 22:39:52.000000000","updated":"2017-09-13 20:23:43.000000000","submitted":"2017-09-13 20:23:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b3e95559789217c5e4a1c4b39b131921e8d23087","_number":458987,"virtual_id_number":458987,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":2,"date":"2017-09-13 20:23:43.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"all":[{"value":2,"date":"2017-09-13 20:13:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"all":[{"value":1,"date":"2017-09-13 20:13:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-13 20:13:24.000000000","updated_by":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"reviewer":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"state":"REVIEWER"},{"updated":"2017-09-13 20:23:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7dd2bc4adf9bf561a164723a74609b2a996626ed","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-21 22:39:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"abc0a06c7289e211a2c9fe1ea71290b3453f8829","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-21 22:41:16.000000000","message":"Patch Set 1:\n\nI think this is a good idea? That or we ought to try getting rid of\n\n #include \u003cdlfcn.h\u003e\n\nfrom include/erasurecode/erasurecode_stdinc.h and instead only include it in the .c files where we do our loading.","accounts_in_message":[],"_revision_number":1},{"id":"3eba06e926cf93aa57a5689dfd6a41e390f08b85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-21 22:46:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/87/458987/1/check/gate-liberasurecode-unit-ubuntu-xenial/0d0073d/ : SUCCESS in 6m 32s","accounts_in_message":[],"_revision_number":1},{"id":"407f36e2c3e2fcffe938935fce7212b95fa24583","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 19:29:22.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"9e61d8a4ce21fa21f4ad3c301bf0845583aac392","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-07-13 21:05:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7cf09a89587eb528b0366e5bb7e190fbc31e5ac3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 21:14:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/87/458987/2/check/gate-liberasurecode-unit-ubuntu-xenial/70ad6e2/ : SUCCESS in 9m 16s","accounts_in_message":[],"_revision_number":2},{"id":"9d2299acc4aed5acace1969df8045d993d61d929","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-09-13 20:13:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b747c1f796002413e6fad605015bb8381bc085e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-13 20:13:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8926419d7f8d4a4de9eb5582175c94f291596707","date":"2017-09-13 20:23:43.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"918c8bfca093bd8c949627c856c29b32c8d25f4e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-13 20:23:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/87/458987/2/gate/gate-liberasurecode-unit-ubuntu-xenial/5c59e5e/ : SUCCESS in 9m 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b5ad3290c244a9b124fdb86974616ffd681bec6c","revisions":{"47d004bf9417d4ab0c5f0dd4654eb3d1623c25eb":{"kind":"REWORK","_number":1,"created":"2017-04-21 22:39:52.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/87/458987/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/87/458987/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/1"}}},"commit":{"parents":[{"commit":"7c4ef60c9d9e69dd23e43ec59d6c03e139a32723","subject":"Merge \"ISA-L: Only calculate gf tables on init, not every encode\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/7c4ef60c9d9e69dd23e43ec59d6c03e139a32723"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-21 22:17:20.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-21 22:17:20.000000000","tz":-420},"subject":"Add dl to pkg-config metadata","message":"Add dl to pkg-config metadata\n\nThis simplifies compiling by allowing users to include\n\n   CFLAGS +\u003d `pkg-config --cflags erasurecode-1`\n   LDFLAGS +\u003d `pkg-config --libs erasurecode-1`\n\nin makefiles. Otherwise, trying to use pkg-config results in errors like\n\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlopen\u0027\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlclose\u0027\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlerror\u0027\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlsym\u0027\n   collect2: error: ld returned 1 exit status\n\nChange-Id: I39fb137b1a3b6b2beda1d0b28faef3132229ec3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/47d004bf9417d4ab0c5f0dd4654eb3d1623c25eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/47d004bf9417d4ab0c5f0dd4654eb3d1623c25eb"}]},"branch":"refs/heads/master"},"b5ad3290c244a9b124fdb86974616ffd681bec6c":{"kind":"REWORK","_number":2,"created":"2017-07-13 21:05:17.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/87/458987/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/87/458987/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/87/458987/2"}}},"commit":{"parents":[{"commit":"a9b20ae6a38073afe91ae2b7d789ddfb7dabade8","subject":"Use zlib for CRC-32","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/a9b20ae6a38073afe91ae2b7d789ddfb7dabade8"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-21 22:17:20.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-07-13 20:26:00.000000000","tz":-420},"subject":"Add dl to pkg-config metadata","message":"Add dl to pkg-config metadata\n\nThis simplifies compiling by allowing users to include\n\n   CFLAGS +\u003d `pkg-config --cflags erasurecode-1`\n   LDFLAGS +\u003d `pkg-config --libs erasurecode-1`\n\nin makefiles. Otherwise, trying to use pkg-config results in errors like\n\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlopen\u0027\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlclose\u0027\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlerror\u0027\n   /usr/local/lib/liberasurecode.so: undefined reference to `dlsym\u0027\n   collect2: error: ld returned 1 exit status\n\nChange-Id: I39fb137b1a3b6b2beda1d0b28faef3132229ec3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b5ad3290c244a9b124fdb86974616ffd681bec6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b5ad3290c244a9b124fdb86974616ffd681bec6c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}