)]}'
{"id":"openstack%2Fliberasurecode~459028","triplet_id":"openstack%2Fliberasurecode~master~I8a5e42312948a75f5dd8b23b6f5ccfa7bd22eb1d","project":"openstack/liberasurecode","branch":"master","topic":"(detached","hashtags":[],"change_id":"I8a5e42312948a75f5dd8b23b6f5ccfa7bd22eb1d","subject":"Un-inline get/set_metatdata_chksum","status":"MERGED","created":"2017-04-22 01:36:28.000000000","updated":"2017-07-13 20:48:51.000000000","submitted":"2017-07-13 20:48:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5b9d76e2770573d65b6d30e9054cfa1707ce9710","_number":459028,"virtual_id_number":459028,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-13 20:48:51.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-06 18:58:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2017-07-13 20:39:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2017-07-13 20:39:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-06 18:58:19.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2017-07-13 20:39:48.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2017-07-13 20:48:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"544c5c7335dec9cdd6d1924fed499703d1f1efaf","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-22 01:36:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f9a135117af9b674bc8c484ac09ad5ae8c3ad07a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-04-22 01:38:31.000000000","message":"Patch Set 1:\n\nApparently I managed to compile it on OS X at least once [1] since we added metadata checksums [2], so I guess it was a clang version bump that did it?\n\nFWIW, looks like I\u0027m currently on\n\n Apple LLVM version 8.1.0 (clang-802.0.38)\n\n[1] https://review.openstack.org/#/c/324083/\n[2] https://github.com/openstack/liberasurecode/commit/a6a8d20","accounts_in_message":[],"_revision_number":1},{"id":"c16a27ebea8692c4a6ffe5733e965f7adf132e66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-22 01:44:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/28/459028/1/check/gate-liberasurecode-unit-ubuntu-xenial/8988c7a/ : SUCCESS in 7m 22s","accounts_in_message":[],"_revision_number":1},{"id":"0816d9cb088cb39d403e73a72efb70d905dfdfa2","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-06-08 01:58:06.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nClang is correct.\n\nOverall it\u0027s just another reminder that packed structures are usually a wrong decision. That said, on most OSes it\u0027s harmless. Linux will intercept the trap and load the right value using an instruction emulator on architectures where it matters (such as ARM). Although perhaps OSX aborts the app, I dunno.","accounts_in_message":[],"_revision_number":1},{"id":"4d46c13360862fb44da8d96626fa2de42de816e6","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-07-06 18:01:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dd7dd5ac52646b89e882f4e480f988b9e8727098","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-07-06 18:01:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a3234a0b50e68f5acdbfa4971ee08bd0a6e8eacf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-06 18:15:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/28/459028/2/check/gate-liberasurecode-unit-ubuntu-xenial/95c8e11/ : SUCCESS in 7m 47s","accounts_in_message":[],"_revision_number":2},{"id":"1d84050811f5ed8c61d9608d80bbf9e011825a68","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-07-06 18:58:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"be1763066cb1f2cd4a53679465aa281cd7259955","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-07-13 20:13:05.000000000","message":"Patch Set 1:\n\ncheck experimental","accounts_in_message":[],"_revision_number":1},{"id":"9c7d378920920b32e95680aadc459d81e238424f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 20:13:17.000000000","message":"Patch Set 1:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"5e6a8322fb8b13ee9f88662be753b7bfc0c78b37","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-07-13 20:39:48.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9597d89038909f9eddf9da4ac646efb6e7f1e2b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 20:40:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0df7ea845766d1784b5680eb06817621fde897d5","date":"2017-07-13 20:48:51.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"4208fa0ad38fb7fd2341176ac6e8a0aa0de18854","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-13 20:48:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/28/459028/2/gate/gate-liberasurecode-unit-ubuntu-xenial/9dbccd2/ : SUCCESS in 7m 22s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e426aee95b616778e4a8e484c3a56c691a2b9c52","revisions":{"8007c0fd55be2c42ddfb17f66088042b8d118e4b":{"kind":"REWORK","_number":1,"created":"2017-04-22 01:36:28.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/28/459028/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/28/459028/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/1"}}},"commit":{"parents":[{"commit":"6a74aa66f16ab20b28a98e49bf79ef448df5532a","subject":"Consistently use zlib for crc32","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/6a74aa66f16ab20b28a98e49bf79ef448df5532a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-22 01:32:02.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-22 01:36:03.000000000","tz":-420},"subject":"Un-inline get/set_metatdata_chksum","message":"Un-inline get/set_metatdata_chksum\n\nEach was only really used in one place, they had some strange return types,\nand recent versions of clang on OS X would refuse to compile with\n\nerasurecode_helpers.c:531:26: error: taking address of packed member \u0027metadata_chksum\u0027 of\n      class or structure \u0027fragment_header_s\u0027 may result in an unaligned pointer value\n      [-Werror,-Waddress-of-packed-member]\n    return (uint32_t *) \u0026header-\u003emetadata_chksum;\n                         ^~~~~~~~~~~~~~~~~~~~~~~\n\nWe don\u0027t really *care* about the pointer; we just want the value!\n\nChange-Id: I8a5e42312948a75f5dd8b23b6f5ccfa7bd22eb1d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8007c0fd55be2c42ddfb17f66088042b8d118e4b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/8007c0fd55be2c42ddfb17f66088042b8d118e4b"}]},"branch":"refs/heads/master"},"e426aee95b616778e4a8e484c3a56c691a2b9c52":{"kind":"REWORK","_number":2,"created":"2017-07-06 18:01:40.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/28/459028/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/28/459028/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/28/459028/2"}}},"commit":{"parents":[{"commit":"a9b20ae6a38073afe91ae2b7d789ddfb7dabade8","subject":"Use zlib for CRC-32","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/a9b20ae6a38073afe91ae2b7d789ddfb7dabade8"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-04-22 01:32:02.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-07-06 18:02:02.000000000","tz":0},"subject":"Un-inline get/set_metatdata_chksum","message":"Un-inline get/set_metatdata_chksum\n\nEach was only really used in one place, they had some strange return types,\nand recent versions of clang on OS X would refuse to compile with\n\nerasurecode_helpers.c:531:26: error: taking address of packed member \u0027metadata_chksum\u0027 of\n      class or structure \u0027fragment_header_s\u0027 may result in an unaligned pointer value\n      [-Werror,-Waddress-of-packed-member]\n    return (uint32_t *) \u0026header-\u003emetadata_chksum;\n                         ^~~~~~~~~~~~~~~~~~~~~~~\n\nWe don\u0027t really *care* about the pointer; we just want the value!\n\nChange-Id: I8a5e42312948a75f5dd8b23b6f5ccfa7bd22eb1d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/e426aee95b616778e4a8e484c3a56c691a2b9c52"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/e426aee95b616778e4a8e484c3a56c691a2b9c52"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}