)]}'
{"id":"openstack%2Fliberasurecode~467418","triplet_id":"openstack%2Fliberasurecode~master~Ib297f6df304abf5ca8c27d3392b1107a525e0be0","project":"openstack/liberasurecode","branch":"master","topic":"bug/1454543","hashtags":[],"change_id":"Ib297f6df304abf5ca8c27d3392b1107a525e0be0","subject":"Stop using ceill() to compute padded data size","status":"MERGED","created":"2017-05-23 23:57:50.000000000","updated":"2017-06-06 19:17:12.000000000","submitted":"2017-06-06 19:17:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"da9e67498239b006f6cda89f9a9a4d56dd2f69d0","_number":467418,"virtual_id_number":467418,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":2,"date":"2017-06-06 19:17:12.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2017-06-06 18:55:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":2,"date":"2017-06-06 18:57:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":1,"date":"2017-06-06 18:57:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-06 08:45:23.000000000","updated_by":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"reviewer":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"state":"REVIEWER"},{"updated":"2017-06-06 18:55:01.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2017-06-06 18:57:49.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-06-06 19:17:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"827c3382a84a4835be66a708766a03393aace5b7","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-05-23 23:57:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e0519006026a551715ff2767ef357a09dd9588a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 00:21:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/18/467418/1/check/gate-liberasurecode-unit-ubuntu-xenial/6d92311/ : SUCCESS in 10m 04s","accounts_in_message":[],"_revision_number":1},{"id":"9bfa91572229308113059878fcc530d98f4f5a53","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-05-24 00:30:23.000000000","message":"Patch Set 1: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ba623fd5df9e13d0963ea775d11d19f72ca27e59","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-06-06 16:50:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9cf48c9509df97770f9c102a99b08ee6db93fc82","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-06-06 18:43:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c0f1cdd9356ca8bc510e49f4a4a52d9d92784ad2","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-06-06 18:53:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b75087c50627beb92d76e1db4a529470da626cd4","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-06-06 18:55:01.000000000","message":"Patch Set 3: Code-Review+2\n\npatch set 2 and 3 was just to fix the tab issue, math looks good","accounts_in_message":[],"_revision_number":3},{"id":"5efbf92bc8f7383e2a24a118cd987d50de511422","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-06-06 18:55:15.000000000","message":"Patch Set 3:\n\ncheck experimental","accounts_in_message":[],"_revision_number":3},{"id":"385f1d34664fa42079c79fda3ba184069ee6c621","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-06 18:57:49.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"bbad86728e6ada427a1680557638c135eb8becbf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-06 19:04:42.000000000","message":"Patch Set 3:\n\nBuild succeeded (experimental pipeline).\n\n- gate-liberasurecode-unit-centos-7 http://logs.openstack.org/18/467418/3/experimental/gate-liberasurecode-unit-centos-7/44474ce/ : SUCCESS in 7m 15s","accounts_in_message":[],"_revision_number":3},{"id":"e7c8dc01e5c86c237e4b7b70d20a8d551348728c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-06 19:09:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/18/467418/3/check/gate-liberasurecode-unit-ubuntu-xenial/d7bcb25/ : SUCCESS in 7m 13s","accounts_in_message":[],"_revision_number":3},{"id":"22d9e5028d6414a43cf08bb0dc5a186ad9b7dc26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-06 19:09:25.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"78aa2c4e961f8a55c92562313218f5953bd2b3bd","date":"2017-06-06 19:17:12.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"ac72339d8082fb1be524969839128938f2fca6de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-06 19:17:12.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/18/467418/3/gate/gate-liberasurecode-unit-ubuntu-xenial/62fd522/ : SUCCESS in 7m 23s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"960cdd09dcabe5e125d8ee1c54fcc1f908e8ef11","revisions":{"b9d62b6f08cab1e8c2032649843073fedfee9e00":{"kind":"REWORK","_number":1,"created":"2017-05-23 23:57:50.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/18/467418/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/18/467418/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/1"}}},"commit":{"parents":[{"commit":"de984f59e7a6cca8c1f3cf1d93b87ff144a2b974","subject":"Merge \"Stop running targeted tests repeatedly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/de984f59e7a6cca8c1f3cf1d93b87ff144a2b974"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2017-05-23 23:45:43.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2017-05-23 23:45:43.000000000","tz":-360},"subject":"Stop using ceill() to compute padded data size","message":"Stop using ceill() to compute padded data size\n\nThe well-known idiom to compute a required number of data blocks\nof size B to contain data of length d is:\n\n     (d + (B-1))/B\n\nThe code we use, with ceill(), computes the same value, but does\nit in an unorthodox way. This makes a reviewer to doubt himself\nand even run tests to make sure we\u0027re really computing the\nobvious thing.\n\nApropos the reviewer confusion, the code in Phazr.IO looks weird.\nIt uses (word_size - hamming_distance) to compute the necessary\nnumber of blocks... but then returns the amount of memory needed\nto store blocks of a different size (word_size). We left all of it\nalone and return exactly the same values that the old computation\nreturned.\n\nAll these computations were the only thing in the code that used\n-lm, so drop that too.\n\nCoincidentially, this patch solves the crash of distro-built\npackages of liberasurecode (see Red Hat bug #1454543). But it\u0027s\na side effect. Expect a proper patch soon.\n\nChange-Id: Ib297f6df304abf5ca8c27d3392b1107a525e0be0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b9d62b6f08cab1e8c2032649843073fedfee9e00"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b9d62b6f08cab1e8c2032649843073fedfee9e00"}]},"branch":"refs/heads/master"},"3078eb7e63994ad7fe0cd9cf5db5ce1d0b230c8e":{"kind":"REWORK","_number":2,"created":"2017-06-06 18:43:31.000000000","uploader":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"ref":"refs/changes/18/467418/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/18/467418/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/2"}}},"commit":{"parents":[{"commit":"de984f59e7a6cca8c1f3cf1d93b87ff144a2b974","subject":"Merge \"Stop running targeted tests repeatedly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/de984f59e7a6cca8c1f3cf1d93b87ff144a2b974"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2017-05-23 23:45:43.000000000","tz":-360},"committer":{"name":"Thiago da Silva","email":"thiago@redhat.com","date":"2017-06-06 18:43:02.000000000","tz":-240},"subject":"Stop using ceill() to compute padded data size","message":"Stop using ceill() to compute padded data size\n\nThe well-known idiom to compute a required number of data blocks\nof size B to contain data of length d is:\n\n     (d + (B-1))/B\n\nThe code we use, with ceill(), computes the same value, but does\nit in an unorthodox way. This makes a reviewer to doubt himself\nand even run tests to make sure we\u0027re really computing the\nobvious thing.\n\nApropos the reviewer confusion, the code in Phazr.IO looks weird.\nIt uses (word_size - hamming_distance) to compute the necessary\nnumber of blocks... but then returns the amount of memory needed\nto store blocks of a different size (word_size). We left all of it\nalone and return exactly the same values that the old computation\nreturned.\n\nAll these computations were the only thing in the code that used\n-lm, so drop that too.\n\nCoincidentially, this patch solves the crash of distro-built\npackages of liberasurecode (see Red Hat bug #1454543). But it\u0027s\na side effect. Expect a proper patch soon.\n\nChange-Id: Ib297f6df304abf5ca8c27d3392b1107a525e0be0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/3078eb7e63994ad7fe0cd9cf5db5ce1d0b230c8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/3078eb7e63994ad7fe0cd9cf5db5ce1d0b230c8e"}]},"branch":"refs/heads/master"},"960cdd09dcabe5e125d8ee1c54fcc1f908e8ef11":{"kind":"REWORK","_number":3,"created":"2017-06-06 18:53:58.000000000","uploader":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"ref":"refs/changes/18/467418/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/18/467418/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/18/467418/3"}}},"commit":{"parents":[{"commit":"de984f59e7a6cca8c1f3cf1d93b87ff144a2b974","subject":"Merge \"Stop running targeted tests repeatedly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/de984f59e7a6cca8c1f3cf1d93b87ff144a2b974"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2017-05-23 23:45:43.000000000","tz":-360},"committer":{"name":"Thiago da Silva","email":"thiago@redhat.com","date":"2017-06-06 18:53:45.000000000","tz":-240},"subject":"Stop using ceill() to compute padded data size","message":"Stop using ceill() to compute padded data size\n\nThe well-known idiom to compute a required number of data blocks\nof size B to contain data of length d is:\n\n     (d + (B-1))/B\n\nThe code we use, with ceill(), computes the same value, but does\nit in an unorthodox way. This makes a reviewer to doubt himself\nand even run tests to make sure we\u0027re really computing the\nobvious thing.\n\nApropos the reviewer confusion, the code in Phazr.IO looks weird.\nIt uses (word_size - hamming_distance) to compute the necessary\nnumber of blocks... but then returns the amount of memory needed\nto store blocks of a different size (word_size). We left all of it\nalone and return exactly the same values that the old computation\nreturned.\n\nAll these computations were the only thing in the code that used\n-lm, so drop that too.\n\nCoincidentially, this patch solves the crash of distro-built\npackages of liberasurecode (see Red Hat bug #1454543). But it\u0027s\na side effect. Expect a proper patch soon.\n\nChange-Id: Ib297f6df304abf5ca8c27d3392b1107a525e0be0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/960cdd09dcabe5e125d8ee1c54fcc1f908e8ef11"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/960cdd09dcabe5e125d8ee1c54fcc1f908e8ef11"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}