)]}'
{"id":"openstack%2Fliberasurecode~467761","triplet_id":"openstack%2Fliberasurecode~master~I09603b97ceeb833ba582cf3217e0be51c019d645","project":"openstack/liberasurecode","branch":"master","hashtags":[],"change_id":"I09603b97ceeb833ba582cf3217e0be51c019d645","subject":"Allow to disable optimizations for portability","status":"MERGED","created":"2017-05-24 20:42:47.000000000","updated":"2017-05-25 18:28:23.000000000","submitted":"2017-05-25 18:28:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"72d327b5eec6231af055d7be3900847fd0bc38b1","_number":467761,"virtual_id_number":467761,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-05-25 18:28:23.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-05-25 18:18:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":2,"date":"2017-05-24 21:05:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-05-25 18:18:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-24 21:05:49.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2017-05-25 18:18:16.000000000","updated_by":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"reviewer":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"state":"REVIEWER"},{"updated":"2017-05-25 18:28:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"aba9ff39b5e7fee5b5266290a0f76858e6099821","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2017-05-24 20:42:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e25793c8a29061dafdf84d02b19392037bdd0bea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-24 20:54:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/61/467761/1/check/gate-liberasurecode-unit-ubuntu-xenial/183dccc/ : SUCCESS in 8m 46s","accounts_in_message":[],"_revision_number":1},{"id":"2755609165bf44b339023b02894a2c684284d11c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-05-24 21:05:49.000000000","message":"Patch Set 1: Code-Review+2\n\nI started looking at how distros handle other projects (like OpenSSL) that may make use of AVX or other extensions, found myself looking at perl code generating asm, and soon gave up.\n\nFWIW, I\u0027d be partial toward *always* (or at least, by default) disabling optimizations -- we\u0027re already an order of magnitude slower than isa-l or jerasure as I recall.","accounts_in_message":[],"_revision_number":1},{"id":"dfd535a8eb11ab122081c5f57316e81052d90ed0","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-05-25 13:51:08.000000000","message":"Patch Set 1:\n\ncheck experimental","accounts_in_message":[],"_revision_number":1},{"id":"da895aa20d1b4cbd4f875a6190bc33041b7d717a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 14:02:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (experimental pipeline).\n\n- gate-liberasurecode-unit-centos-7 http://logs.openstack.org/61/467761/1/experimental/gate-liberasurecode-unit-centos-7/a3a8c54/ : SUCCESS in 10m 21s","accounts_in_message":[],"_revision_number":1},{"id":"3199e2d695c4585e858b872fce7daa5b22e955bd","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-05-25 18:17:46.000000000","message":"Patch Set 1:\n\nlgtm, I tested this bug disabling the mmi flag, building and testing pyeclib","accounts_in_message":[],"_revision_number":1},{"id":"1a5f801d8e6c8c9cfebfb973ab80c692cb58255a","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-05-25 18:17:50.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3b437c7a95fced219e083ade0b1369d5fd48647a","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-05-25 18:17:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b3a1a5cfbfc959043b4026bf78a6c4a660310e72","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-05-25 18:18:06.000000000","message":"Patch Set 1: -Code-Review -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"7b49df904f7b0660037fcca1d335af508eba242b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 18:18:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0794694c8376aeecd7d27562439b58753767dc3f","author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"date":"2017-05-25 18:18:16.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3e324077912d5b08b448e376c193f5c13e440c22","date":"2017-05-25 18:28:23.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"72d327b5eec6231af055d7be3900847fd0bc38b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 18:28:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/61/467761/1/gate/gate-liberasurecode-unit-ubuntu-xenial/c230ac4/ : SUCCESS in 9m 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0962144c51421a39be921876328bcecb912c7674","revisions":{"0962144c51421a39be921876328bcecb912c7674":{"kind":"REWORK","_number":1,"created":"2017-05-24 20:42:47.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/61/467761/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/61/467761/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/61/467761/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/61/467761/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/61/467761/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/61/467761/1"}}},"commit":{"parents":[{"commit":"de984f59e7a6cca8c1f3cf1d93b87ff144a2b974","subject":"Merge \"Stop running targeted tests repeatedly\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/de984f59e7a6cca8c1f3cf1d93b87ff144a2b974"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2017-05-24 20:35:15.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2017-05-24 20:42:36.000000000","tz":-360},"subject":"Allow to disable optimizations for portability","message":"Allow to disable optimizations for portability\n\nWe\u0027re having trouble on Fedora when the build system runs\non Intel CPUs. The ./configure detects AVX instructions and\nbuilds liberasurecode with them. The resulting library crashes\nwith SIGILL when users run it on ADM CPUs without AVX.\n\nSee the details here:\n https://bugzilla.redhat.com/show_bug.cgi?id\u003d1454543\n\nThe patch allows to disable the optimizations, so that\ndistro packaging then can invoke this options and build\nportable libraries.\n\nFor the record, \"make test\" runs about 16% slower on an Intel\nCPU if optimizations are disabled. So, there\u0027s a measurable\nperformance impact. However, operators intersted in outright\nperformance might want to consider Erasure Coding implementations\nother than the one  built-in into liberasurecode. The library\nsupports other back-ends that are significantly faster than\neven optimized built-in code.\n\nChange-Id: I09603b97ceeb833ba582cf3217e0be51c019d645\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0962144c51421a39be921876328bcecb912c7674"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0962144c51421a39be921876328bcecb912c7674"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
