)]}'
{"id":"openstack%2Fliberasurecode~472394","triplet_id":"openstack%2Fliberasurecode~master~Id6c70cdb2d86580280ededc3ec6ec648c6cb7d57","project":"openstack/liberasurecode","branch":"master","topic":"472394","hashtags":[],"change_id":"Id6c70cdb2d86580280ededc3ec6ec648c6cb7d57","subject":"Negative data or parity args are invalid","status":"MERGED","created":"2017-06-08 19:51:25.000000000","updated":"2017-09-13 21:24:27.000000000","submitted":"2017-09-13 21:24:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8b1e88f1408cf865bd955da45f7c16a49e456451","_number":472394,"virtual_id_number":472394,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-09-13 21:24:27.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-09-13 21:09:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-09-13 21:09:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-13 21:09:57.000000000","updated_by":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"reviewer":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"state":"REVIEWER"},{"updated":"2017-09-13 21:24:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"61ca920257c8ffd578c7bdaf4d0399c6cbc483dc","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-06-08 19:51:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f8c492cf8165cd8a345c1852bfe44dfb659aa05","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-08 20:03:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/94/472394/1/check/gate-liberasurecode-unit-ubuntu-xenial/7a43da7/ : SUCCESS in 9m 25s","accounts_in_message":[],"_revision_number":1},{"id":"a2254fc511cfe85b48a389ae6596452758618ca1","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-08-01 19:54:24.000000000","message":"Patch Set 1: Code-Review+2\n\nIn retrospect we probably should have used `unsigned int`s in `struct ec_args` from the start so we could have our type system enforce this automatically, but\n\n* you clearly can\u0027t have a negative number of fragments and\n* I don\u0027t think we should break existing consumers over it\n\nso this seems like a reasonable approach that will save us from trying to free invalid pointers when deinit\u0027ing descriptors that were successfully init\u0027ed with negative args.","accounts_in_message":[],"_revision_number":1},{"id":"01ade82268638b01bc05e9e3f39bcf884ddb998f","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-09-13 20:16:54.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a9f980fd5ac381bc240fcb88a7e86885fa6d05ed","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-09-13 21:03:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e165c142db051d96bfff2076a53ca3677d5b3c76","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2017-09-13 21:03:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5a64df3adea6fd3f3a7f0ff211c1feb10b145711","author":{"_account_id":17363,"name":"Timur Alperovich","email":"timur@timuralp.com","username":"timuralp"},"date":"2017-09-13 21:09:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"86d51016d90bf829717f443dc07137e490461aae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-13 21:15:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/94/472394/2/check/gate-liberasurecode-unit-ubuntu-xenial/d26511e/ : SUCCESS in 9m 18s","accounts_in_message":[],"_revision_number":2},{"id":"6efe850678e2ed6c585d558fdcded1e8abe85743","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-13 21:15:16.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f2e138265de84d36aba07eebd48ff3a2ce6d1874","date":"2017-09-13 21:24:27.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"e4b34795a1cc4f4ac1aa3dc1606b11c0f4b7a04f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-13 21:24:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-liberasurecode-unit-ubuntu-xenial http://logs.openstack.org/94/472394/2/gate/gate-liberasurecode-unit-ubuntu-xenial/ba33a69/ : SUCCESS in 9m 03s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"082e4799d81149a9f0ca4e9d8afc65e64118fec0","revisions":{"35c58de68438e53d8a201a90bea8df106937fcd4":{"kind":"REWORK","_number":1,"created":"2017-06-08 19:51:25.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/94/472394/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/94/472394/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/1"}}},"commit":{"parents":[{"commit":"dd31ac647bdfbac0f95025329d96580d5f52fd76","subject":"Merge \"Stop using ceill() to compute padded data size\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/dd31ac647bdfbac0f95025329d96580d5f52fd76"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-06-08 19:46:25.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-06-08 19:55:53.000000000","tz":0},"subject":"Negative data or parity args are invalid","message":"Negative data or parity args are invalid\n\nWhile we\u0027re at it, tighten up some test_create_backend_invalid_args\nassertions.\n\nChange-Id: Id6c70cdb2d86580280ededc3ec6ec648c6cb7d57\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/35c58de68438e53d8a201a90bea8df106937fcd4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/35c58de68438e53d8a201a90bea8df106937fcd4"}]},"branch":"refs/heads/master"},"082e4799d81149a9f0ca4e9d8afc65e64118fec0":{"kind":"REWORK","_number":2,"created":"2017-09-13 21:03:59.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/94/472394/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/94/472394/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/94/472394/2"}}},"commit":{"parents":[{"commit":"dd31ac647bdfbac0f95025329d96580d5f52fd76","subject":"Merge \"Stop using ceill() to compute padded data size\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/dd31ac647bdfbac0f95025329d96580d5f52fd76"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-06-08 19:46:25.000000000","tz":0},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2017-09-13 20:52:30.000000000","tz":0},"subject":"Negative data or parity args are invalid","message":"Negative data or parity args are invalid\n\nWhile we\u0027re at it, tighten up some test_create_backend_invalid_args\nassertions.\n\nChange-Id: Id6c70cdb2d86580280ededc3ec6ec648c6cb7d57\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/082e4799d81149a9f0ca4e9d8afc65e64118fec0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/082e4799d81149a9f0ca4e9d8afc65e64118fec0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}