)]}'
{"id":"openstack%2Fliberasurecode~636556","triplet_id":"openstack%2Fliberasurecode~master~Ibd5e4e6c02be00540a9648cc7e0f8efda275bf3f","project":"openstack/liberasurecode","branch":"master","topic":"s390x/crc32alt","hashtags":[],"change_id":"Ibd5e4e6c02be00540a9648cc7e0f8efda275bf3f","subject":"Make our alt crc32 more portable","status":"MERGED","created":"2019-02-13 06:45:30.000000000","updated":"2019-02-13 22:04:04.000000000","submitted":"2019-02-13 22:04:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"636556-1550095444154-32aab42b","meta_rev_id":"05b23bad02b21b4d92b9301d4f452fb001a63546","_number":636556,"virtual_id_number":636556,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-02-13 22:04:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-02-13 21:25:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-02-13 21:25:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-13 21:25:56.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2019-02-13 22:04:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"db7364d5f500f8baf1103bbac80c485103aedec1","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2019-02-13 06:45:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2efb3445f9c8893a92aa732debe3d0d46bbc8f4a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-13 07:11:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- liberasurecode-unittests http://logs.openstack.org/56/636556/1/check/liberasurecode-unittests/4fa4f03/ : SUCCESS in 20m 30s","accounts_in_message":[],"_revision_number":1},{"id":"97302ffa613824bd3f711d8b87d1a14792931684","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-02-13 21:25:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a861eadc29b593a6536d2fc4e25424bd4287353a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-02-13 21:25:35.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"de6500e9a4685232de60d6b93af1796a3672f628","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2019-02-13 21:25:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nYeah, I think those bit manipulations make sense...","accounts_in_message":[],"_revision_number":2},{"id":"1fa4e52c6d9786cb211ab562eddefc7425c3d47d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-13 21:47:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- liberasurecode-unittests http://logs.openstack.org/56/636556/2/check/liberasurecode-unittests/60e4b4f/ : SUCCESS in 20m 57s","accounts_in_message":[],"_revision_number":2},{"id":"f1308a614aa8099c4614b44f7406d0e31fc6b0c3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-13 21:47:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"93d8fc3cf1162933d0ef1e487c2d7c52ef1c6a91","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-13 22:04:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- liberasurecode-unittests http://logs.openstack.org/56/636556/2/gate/liberasurecode-unittests/8e526e5/ : SUCCESS in 16m 27s","accounts_in_message":[],"_revision_number":2},{"id":"7a14e84bdeb35ffbe32e20b8ada78b4426c21dda","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-13 22:04:04.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7e97b2f808e1115425eef527899b27528f05af3a","revisions":{"4bfb4ff7c370357db0fc03daa30837f3da812719":{"kind":"REWORK","_number":1,"created":"2019-02-13 06:45:30.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/56/636556/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/56/636556/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/1"}}},"commit":{"parents":[{"commit":"405775cba1d1ac06b86b2fab64e8f9d03ab2fd0e","subject":"Merge \"Install Jerasure and ISA-L libs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/405775cba1d1ac06b86b2fab64e8f9d03ab2fd0e"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2019-02-13 04:08:26.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2019-02-13 06:42:12.000000000","tz":-360},"subject":"Make our alt crc32 more portable","message":"Make our alt crc32 more portable\n\nApparently the author of our old crc32 assumed that shifting an int\nto the right sign-extends, which is not always the case. Result is,\nbuilding and running make test on s390x fails. The fix is to force\na sign-extension using the \"xor 0x80; sub 0x80\" trick.\n\nN.B. This does not cause a compatibility problem, because by a\nmiracle the \"broken\" crc32_alt was actually computing a stock\ncrc32, same that zlib has. Therefore, if someone, somewhere,\nran a Swift cluster on s390x with erasure coding policy,\nthe data in it is already stored with zlib checksums, as we\ndo it now anyway. This fix only permits the tests pass, which\nused the bad data sample from x86.\n\nChange-Id: Ibd5e4e6c02be00540a9648cc7e0f8efda275bf3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/4bfb4ff7c370357db0fc03daa30837f3da812719"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/4bfb4ff7c370357db0fc03daa30837f3da812719"}]},"branch":"refs/heads/master"},"7e97b2f808e1115425eef527899b27528f05af3a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-02-13 21:25:35.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/56/636556/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/56/636556/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/56/636556/2"}}},"commit":{"parents":[{"commit":"405775cba1d1ac06b86b2fab64e8f9d03ab2fd0e","subject":"Merge \"Install Jerasure and ISA-L libs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/405775cba1d1ac06b86b2fab64e8f9d03ab2fd0e"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2019-02-13 04:08:26.000000000","tz":-360},"committer":{"name":"Tim Burke","email":"tim@swiftstack.com","date":"2019-02-13 21:25:33.000000000","tz":0},"subject":"Make our alt crc32 more portable","message":"Make our alt crc32 more portable\n\nApparently the author of our old crc32 assumed that shifting an int\nto the right sign-extends, which is not always the case. Result is,\nbuilding and running make test on s390x fails. The fix is to force\na sign-extension using the \"xor 0x80; sub 0x80\" trick.\n\nN.B. This does not cause a compatibility problem, because by a\nmiracle the \"broken\" crc32_alt was actually computing a stock\ncrc32, same that zlib has. Therefore, if someone, somewhere,\nran a Swift cluster on s390x with erasure coding policy,\nthe data in it is already stored with zlib checksums, as we\ndo it now anyway. This fix only permits the tests pass, which\nused the bad data sample from x86.\n\nChange-Id: Ibd5e4e6c02be00540a9648cc7e0f8efda275bf3f\nRelated-Change: Ib5ea2a830c7c23d66bf2ca404a3eb84ad00c5bc5\nRelated-Bug: 1666320\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/7e97b2f808e1115425eef527899b27528f05af3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/7e97b2f808e1115425eef527899b27528f05af3a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}