)]}'
{"id":"openstack%2Fliberasurecode~702530","triplet_id":"openstack%2Fliberasurecode~master~I50cd7922dfa377ea27f3c9558a8a7268120ec733","project":"openstack/liberasurecode","branch":"master","topic":"bug/1859710","hashtags":[],"change_id":"I50cd7922dfa377ea27f3c9558a8a7268120ec733","subject":"Fix create_fake_frags_no_meta to use memset to fill frags","status":"MERGED","created":"2020-01-14 20:58:20.000000000","updated":"2020-01-29 18:36:43.000000000","submitted":"2020-01-29 18:36:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"702530-1580323003251-bbef5f2b","meta_rev_id":"138ea2ca30ad2be71c6b4fefea75657df6d5cb4d","_number":702530,"virtual_id_number":702530,"owner":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-29 18:36:43.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"recommended":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"all":[{"value":1,"date":"2020-01-29 07:55:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":2,"date":"2020-01-29 18:06:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":1,"date":"2020-01-29 18:06:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-29 07:55:44.000000000","updated_by":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"reviewer":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"state":"REVIEWER"},{"updated":"2020-01-29 18:06:33.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2020-01-29 18:36:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6ce2b7c8704b81602eb8419caed9d5444cb89b1d","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-01-14 20:58:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6389c8bd29d15f8c4a4012a74a78d7dff5fdb0de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-14 21:23:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/51840196a17b46c19924adde1b66249c : SUCCESS in 20m 51s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/a1ce02b4142a430089a774c34f583a5b : SUCCESS in 19m 47s","accounts_in_message":[],"_revision_number":1},{"id":"3ddb5f9315bf4cc6fc37785d151503052444ea4c","author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"date":"2020-01-14 21:28:42.000000000","message":"Patch Set 1:\n\nI see two solutions here:\n\nAll strings passed to \"create_fake_frags_no_meta\" should be null terminated. So \"data\" param should be \u003cstring\u003e\u003cNULL\u003e and data_len should be len(\u003cstring\u003e) + 1.\n\nTo be consistent I think create_buffer function should create NULL terminated strings too, which is not true now.\n\n--- OR ---\n\ncreate_fake_frags_no_meta should not use strncpy, but memcpy and handle \"data\" as char arrays with length.","accounts_in_message":[],"_revision_number":1},{"id":"0404f5e81dacc97fe758e5341812e0c8d62d8c6a","author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"date":"2020-01-14 21:32:15.000000000","message":"Patch Set 1:\n\n\"chars array\" of course","accounts_in_message":[],"_revision_number":1},{"id":"ec6e3e336f07e2d563033ba9a3777b022b40280b","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-01-15 14:20:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"16a5acc309c128466bebcbdad6bc7ce55a96db40","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-01-15 14:24:39.000000000","message":"Patch Set 2:\n\nOndrej, thanks for the comments. Let me know what you think about v2.","accounts_in_message":[],"_revision_number":2},{"id":"436faf7274b0a068d8e472095d26f15982149364","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-15 14:44:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/c9d2eda9011d4e9da7ae698f8b59a721 : SUCCESS in 19m 34s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/de1e474119b744f49de37061bd77196c : SUCCESS in 18m 46s","accounts_in_message":[],"_revision_number":2},{"id":"ede44e174cf5777b4db3f1ba3013d6e366fae297","author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"date":"2020-01-15 15:14:49.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"408b6a0e3c761137d1a48bec8e77d407669d853d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-01-29 00:35:03.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"bae603a1662092fa1ab5bc813da1d81e491731a5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 00:58:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/dc6dc12121f8424f9f52d9a0031034d3 : SUCCESS in 17m 52s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/77de900306c148e3960f60b60e595d35 : SUCCESS in 17m 41s","accounts_in_message":[],"_revision_number":3},{"id":"60fd863368c1e385ce0a66a84f1be7658ebbd306","author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"date":"2020-01-29 07:55:44.000000000","message":"Patch Set 3: Code-Review+1\n\nright, better :)","accounts_in_message":[],"_revision_number":3},{"id":"2eecee556332515da1f26e349174f089eaeb0e69","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-01-29 18:06:33.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"cb7cb06472132f2c4e78592afb13df9fecd23369","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 18:06:47.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"26ba83641d4b87fda6660666152f7dfd01fe6da9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 18:36:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"7dd3d52ba8e1a09d4aa3ad064eec470a1328e009","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-29 18:36:43.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/9fadcb4d133f45d69a80d2c3e7fa0e03 : SUCCESS in 22m 19s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/83d850e2cb9b4cacabf0514b52c04035 : SUCCESS in 22m 52s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0eb6cd321e312e32b3ad12c34089466eae60cd88","revisions":{"c11ff0aa58e79d96100bc92f69b76e25b6668031":{"kind":"REWORK","_number":1,"created":"2020-01-14 20:58:20.000000000","uploader":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"ref":"refs/changes/30/702530/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/30/702530/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/1"}}},"commit":{"parents":[{"commit":"135c3a272fccd983174cbfe10ef2b01e142dc4ee","subject":"Update test to build on FreeBSD 12","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/135c3a272fccd983174cbfe10ef2b01e142dc4ee"}]}],"author":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2020-01-14 20:47:44.000000000","tz":-300},"committer":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2020-01-14 20:58:20.000000000","tz":-300},"subject":"Fix strncpy to prevent truncation of source","message":"Fix strncpy to prevent truncation of source\n\nFix data_len argument in call to create_fake_frags_no_meta to\nensure strncpy copies the string plus the null terminator rather\nthan the string without the null terminator.\n\nChange-Id: I50cd7922dfa377ea27f3c9558a8a7268120ec733\nCloses-Bug: #1859710\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/c11ff0aa58e79d96100bc92f69b76e25b6668031"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/c11ff0aa58e79d96100bc92f69b76e25b6668031"}]},"branch":"refs/heads/master"},"2fb87db0be9c4d2ef926053debdc9075048896ed":{"kind":"REWORK","_number":2,"created":"2020-01-15 14:20:16.000000000","uploader":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"ref":"refs/changes/30/702530/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/30/702530/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/2"}}},"commit":{"parents":[{"commit":"135c3a272fccd983174cbfe10ef2b01e142dc4ee","subject":"Update test to build on FreeBSD 12","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/135c3a272fccd983174cbfe10ef2b01e142dc4ee"}]}],"author":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2020-01-14 20:47:44.000000000","tz":-300},"committer":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2020-01-15 14:20:16.000000000","tz":-300},"subject":"Fix strncpy to prevent truncation of source","message":"Fix strncpy to prevent truncation of source\n\nEnsure data_len argument to create_fake_frags_no_meta includes\nstring\u0027s null terminator. This ensures strncpy copies the string\nplus the null terminator.\n\nAlso ensure create_buffer null terminates the string it creates.\n\nChange-Id: I50cd7922dfa377ea27f3c9558a8a7268120ec733\nCloses-Bug: #1859710\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/2fb87db0be9c4d2ef926053debdc9075048896ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/2fb87db0be9c4d2ef926053debdc9075048896ed"}]},"branch":"refs/heads/master"},"0eb6cd321e312e32b3ad12c34089466eae60cd88":{"kind":"REWORK","_number":3,"created":"2020-01-29 00:35:03.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/30/702530/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/30/702530/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/30/702530/3"}}},"commit":{"parents":[{"commit":"135c3a272fccd983174cbfe10ef2b01e142dc4ee","subject":"Update test to build on FreeBSD 12","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/135c3a272fccd983174cbfe10ef2b01e142dc4ee"}]}],"author":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2020-01-14 20:47:44.000000000","tz":-300},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-01-29 00:33:01.000000000","tz":-480},"subject":"Fix create_fake_frags_no_meta to use memset to fill frags","message":"Fix create_fake_frags_no_meta to use memset to fill frags\n\nThese aren\u0027t C strings; we shouldn\u0027t be using strncpy and friends.\n\nChange-Id: I50cd7922dfa377ea27f3c9558a8a7268120ec733\nCloses-Bug: #1859710\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0eb6cd321e312e32b3ad12c34089466eae60cd88"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0eb6cd321e312e32b3ad12c34089466eae60cd88"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}