)]}'
{"id":"openstack%2Fliberasurecode~706180","triplet_id":"openstack%2Fliberasurecode~master~I54db0172a36419206d00b22608523a08818f41f6","project":"openstack/liberasurecode","branch":"master","topic":"warning/frags","hashtags":[],"change_id":"I54db0172a36419206d00b22608523a08818f41f6","subject":"Do not discard a technical return value in tests","status":"MERGED","created":"2020-02-06 05:29:17.000000000","updated":"2020-02-11 00:22:56.000000000","submitted":"2020-02-11 00:22:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"706180-1581380576940-4edda447","meta_rev_id":"aed4ac96fc438f8c58c97fe3c57dc518cfc076b7","_number":706180,"virtual_id_number":706180,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-11 00:22:56.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-10 23:56:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-02-10 23:56:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-10 23:56:24.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2020-02-11 00:22:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"925f7b69e7b6ec80a8f78968f13594fa5999d5c2","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-02-06 05:29:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8184564dc1f5c73073b8e611196f3e36834a217c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 05:53:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/183c57d5953e4daba3a5f286f707742c : SUCCESS in 19m 09s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/8a9710c38e0e420abc49cebd828a6b6d : SUCCESS in 20m 00s","accounts_in_message":[],"_revision_number":1},{"id":"2b626cdc81d6ffaaf2babd1e5d4b0a11911c2c67","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-02-10 23:56:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nMakes me glad it\u0027s just in test code!\n\n...right? Now I\u0027m a little worried about https://github.com/openstack/pyeclib/blob/master/src/c/pyeclib_c/pyeclib_c.c#L536 and https://github.com/openstack/pyeclib/blob/master/src/c/pyeclib_c/pyeclib_c.c#L901 ...","accounts_in_message":[],"_revision_number":1},{"id":"9b3afeb10be01f59917dc76dc31b1912a367ca30","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 23:56:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"60ee9407aae62f3b38ad4cdefcdc78f24c26042a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-11 00:22:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fa0a20a8045ccba9054dd92db85a17b268f98ed0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-11 00:22:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/ea0dd17eb57f482a95d0ba33bfcce842 : SUCCESS in 20m 14s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/5cc08f2e005a409c9a1dd009bdee1e17 : SUCCESS in 20m 38s\n- liberasurecode-unittests-centos-8 https://zuul.opendev.org/t/openstack/build/c55de7ee9f5941838143d40ef8954096 : SUCCESS in 23m 08s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4568188d77815697419c8d0b2c55bcbba7f65929","revisions":{"4568188d77815697419c8d0b2c55bcbba7f65929":{"kind":"REWORK","_number":1,"created":"2020-02-06 05:29:17.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/80/706180/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/80/706180/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/80/706180/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/80/706180/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/80/706180/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/80/706180/1"}}},"commit":{"parents":[{"commit":"0eb6cd321e312e32b3ad12c34089466eae60cd88","subject":"Fix create_fake_frags_no_meta to use memset to fill frags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/0eb6cd321e312e32b3ad12c34089466eae60cd88"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2020-02-06 05:26:31.000000000","tz":-360},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2020-02-06 05:26:31.000000000","tz":-360},"subject":"Do not discard a technical return value in tests","message":"Do not discard a technical return value in tests\n\nCompilers are getting smarter, and we started getting this:\n\nlibec_slap.c: In function \u0027test_hd_code\u0027:\nlibec_slap.c:285:14: error: \u0027frags.array\u0027 may be used uninitialized\n in this function [-Werror\u003dmaybe-uninitialized]\n\nThe fix is to consume the error code in such a way that the\ntest proceeds further only when frags are indeed initialized.\n\nChange-Id: I54db0172a36419206d00b22608523a08818f41f6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/4568188d77815697419c8d0b2c55bcbba7f65929"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/4568188d77815697419c8d0b2c55bcbba7f65929"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}