)]}'
{"id":"openstack%2Fliberasurecode~907156","triplet_id":"openstack%2Fliberasurecode~master~I38ee6d19d12cf8702ef394f3ee40f353f749b2c6","project":"openstack/liberasurecode","branch":"master","attention_set":{},"removed_from_attention_set":{"36752":{"account":{"_account_id":36752,"name":"Eli Schwartz","display_name":"Eli Schwartz","email":"eschwartz93@gmail.com","username":"eschwartz"},"last_update":"2024-01-30 05:14:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I38ee6d19d12cf8702ef394f3ee40f353f749b2c6","subject":"configure: fix basic syntax errors in the shell script programming language","status":"MERGED","created":"2024-01-29 23:51:23.000000000","updated":"2024-01-30 05:14:20.000000000","submitted":"2024-01-30 05:14:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"907156","meta_rev_id":"072e3ed6128eba33c92fedf330d55ba63517ccb2","_number":907156,"virtual_id_number":907156,"owner":{"_account_id":36752,"name":"Eli Schwartz","display_name":"Eli Schwartz","email":"eschwartz93@gmail.com","username":"eschwartz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-01-30 05:14:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"recommended":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":1,"date":"2024-01-30 00:13:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-01-30 04:29:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-01-30 04:29:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-30 00:11:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-01-30 00:13:29.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2024-01-30 00:48:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-30 04:29:38.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"815e8186e54234d3703b773f229c6a76322dcae2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36752,"name":"Eli Schwartz","display_name":"Eli Schwartz","email":"eschwartz93@gmail.com","username":"eschwartz"},"date":"2024-01-29 23:51:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa62408a2583c701966cde767410ba39a1f20165","author":{"_account_id":36752,"name":"Eli Schwartz","display_name":"Eli Schwartz","email":"eschwartz93@gmail.com","username":"eschwartz"},"date":"2024-01-29 23:56:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"35509dc7eccab67022b81aec1ccb3741f83f4eac","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-30 00:11:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5c3bb7f5349f49e18c34f5e558bf8ef6\n\n- liberasurecode-unittests-arm64 https://zuul.opendev.org/t/openstack/build/7daffc4f93c3421ca4991d096d319392 : SUCCESS in 16m 56s\n- liberasurecode-unittests-centos-8-stream-arm64 https://zuul.opendev.org/t/openstack/build/db4b2820618a4ef584544b35ed745884 : SUCCESS in 14m 30s","accounts_in_message":[],"_revision_number":1},{"id":"48325fa0ab50aa18d16d0f7f33bfbb8a46fb585b","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-01-30 00:13:29.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f07a712e6cdd58ec30eef07762a2e68f65eaf811","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-30 00:48:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a27bb65b93b9458fb2ec06ba40a4defd\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/560a89a2057c4534b0014adb7abca6cd : SUCCESS in 16m 32s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/1660e4f5d7f443e3a9e1ac3287ba074f : SUCCESS in 15m 07s\n- liberasurecode-unittests-centos-8-stream https://zuul.opendev.org/t/openstack/build/00002fcef50647c8a888cdc97b5ac4cb : SUCCESS in 18m 15s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/4ea5c9cb7cc04201b6b8168efc55c000 : SUCCESS in 17m 05s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/a5487835a19e4c4e9709e6868ae56149 : SUCCESS in 17m 28s","accounts_in_message":[],"_revision_number":1},{"id":"ea4da1f68631000de49b0a4116aa325c6f78fc6f","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2024-01-30 04:29:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"79a9711a59cb60c3ec075c9b110ab47a6bad7110","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-30 04:30:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e0de6a75a2c35942568d19956e943f51e1048a11","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-30 05:14:19.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5a7ec2b3315a41c3b5052e51b0fe3608\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/d24309913d634aaf9a97b168e9aac811 : SUCCESS in 12m 29s\n- liberasurecode-unittests-centos-7 https://zuul.opendev.org/t/openstack/build/6c92e14cf53344608d0e4a5d7cf00a8a : SUCCESS in 14m 25s\n- liberasurecode-unittests-centos-8-stream https://zuul.opendev.org/t/openstack/build/f2d714d07620481280de66c2aafcd094 : SUCCESS in 13m 47s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/89fc494830874dada64b6b6096817bb9 : SUCCESS in 17m 44s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/99e75d5f4b7b4dbea8a39e9b9cf10fc8 : SUCCESS in 14m 08s","accounts_in_message":[],"_revision_number":1},{"id":"072e3ed6128eba33c92fedf330d55ba63517ccb2","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-30 05:14:20.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b9a8a5b0b8249ca63a785f092bdbb0e0402119fb","revisions":{"b9a8a5b0b8249ca63a785f092bdbb0e0402119fb":{"kind":"REWORK","_number":1,"created":"2024-01-29 23:51:23.000000000","uploader":{"_account_id":36752,"name":"Eli Schwartz","display_name":"Eli Schwartz","email":"eschwartz93@gmail.com","username":"eschwartz"},"ref":"refs/changes/56/907156/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/56/907156/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/907156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/907156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/56/907156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/56/907156/1"}}},"commit":{"parents":[{"commit":"ca2caab1ad5afe772695fc71c663a746d81594d6","subject":"Use spaces for code indent, instead of tabs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/ca2caab1ad5afe772695fc71c663a746d81594d6"}]}],"author":{"name":"Eli Schwartz","email":"eschwartz93@gmail.com","date":"2024-01-29 22:57:06.000000000","tz":-300},"committer":{"name":"Eli Schwartz","email":"eschwartz93@gmail.com","date":"2024-01-29 23:40:16.000000000","tz":-300},"subject":"configure: fix basic syntax errors in the shell script programming language","message":"configure: fix basic syntax errors in the shell script programming language\n\nFixes regression in commit f3a99e81e997cf0d8db47056b36ca2c2e3beee8f\nwhich prevented successfully running on non-bash shells.\n\nBash provides the standard `test XXX \u003d YYY` or `[ XXX \u003d YYY ]`\nutilities. It also provides the ability to spell the equals sign as a\ndouble equals. This does nothing whatsoever -- it adds no new\nfunctionality to bash, it forbids nothing, it is *literally* an exact\nalias.\n\nIt should never be used under any circumstances. All developers must\nimmediately forget that it exists. Using it is non-portable and does not\nwork in /bin/sh scripts such as configure scripts, and it results in\ndangerous muscle memory when used in bash scripts because it makes\npeople unthinkingly use the double equals even in /bin/sh scripts. To\nadd insult to injury, it makes scripts take up more disk space (by a\nwhole byte! and sometimes even a few bytes...)\n\nDelete this accidental bashism, and restore the ability to get correct\n./configure behavior on systems where /bin/sh is something other than a\nsymlink to GNU bash.\n\nChange-Id: I38ee6d19d12cf8702ef394f3ee40f353f749b2c6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b9a8a5b0b8249ca63a785f092bdbb0e0402119fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/b9a8a5b0b8249ca63a785f092bdbb0e0402119fb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}