)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fc4f2e74444022394516e9f24e0339c47eb82398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"47900105_ce8b32ed","updated":"2026-01-09 20:58:02.000000000","message":"It\u0027s been more than a year to for anyone to raise objections -- let\u0027s merge it.","commit_id":"7ee6e6c2bb4a2ccade6f2ef4b0b231a29c1f89cf"}],"src/erasurecode.c":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"124d683b77382dd6c5ff645b1b828f52c87257a5","unresolved":true,"context_lines":[{"line_number":268,"context_line":"        }"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        /* Register instance and return a descriptor/instance id */"},{"line_number":271,"context_line":"        SLIST_INSERT_HEAD(\u0026active_instances, instance, link);"},{"line_number":272,"context_line":"        desc \u003d liberasurecode_backend_alloc_desc();"},{"line_number":273,"context_line":"        if (desc \u003c\u003d 0)"},{"line_number":274,"context_line":"            goto register_out;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"dec4d8d5_3b1a176f","line":271,"updated":"2024-10-11 15:57:48.000000000","message":"This is how it worked before in `liberasurecode_backend_instance_register`, but surely the list insertion should happen *after* we\u0027re done populating all the `instance` fields. Plus, then we can safely `free(instance)` if `liberasurecode_backend_alloc_desc` fails.","commit_id":"0af7915356f8920978ebba3dccc1d82e22540b3a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"beb49293feffadd92ec37df4fc549e1e4e33de23","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        }"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        /* Register instance and return a descriptor/instance id */"},{"line_number":271,"context_line":"        SLIST_INSERT_HEAD(\u0026active_instances, instance, link);"},{"line_number":272,"context_line":"        desc \u003d liberasurecode_backend_alloc_desc();"},{"line_number":273,"context_line":"        if (desc \u003c\u003d 0)"},{"line_number":274,"context_line":"            goto register_out;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cd70e35a_b922ae39","line":271,"in_reply_to":"dec4d8d5_3b1a176f","updated":"2024-10-15 21:01:25.000000000","message":"Done -- there was also more clean-up needed.","commit_id":"0af7915356f8920978ebba3dccc1d82e22540b3a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"124d683b77382dd6c5ff645b1b828f52c87257a5","unresolved":true,"context_lines":[{"line_number":274,"context_line":"            goto register_out;"},{"line_number":275,"context_line":"        instance-\u003eidesc \u003d desc;"},{"line_number":276,"context_line":"    } else {"},{"line_number":277,"context_line":"        goto exit;"},{"line_number":278,"context_line":"    }"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"register_out:"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c8dab86a_930538cf","line":277,"updated":"2024-10-11 15:57:48.000000000","message":"This needs a `free(instance)` before jumping.","commit_id":"0af7915356f8920978ebba3dccc1d82e22540b3a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"beb49293feffadd92ec37df4fc549e1e4e33de23","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            goto register_out;"},{"line_number":275,"context_line":"        instance-\u003eidesc \u003d desc;"},{"line_number":276,"context_line":"    } else {"},{"line_number":277,"context_line":"        goto exit;"},{"line_number":278,"context_line":"    }"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"register_out:"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"237575b0_c2768972","line":277,"in_reply_to":"c8dab86a_930538cf","updated":"2024-10-15 21:01:25.000000000","message":"Done","commit_id":"0af7915356f8920978ebba3dccc1d82e22540b3a"}]}