)]}'
{"id":"openstack%2Fliberasurecode~956214","triplet_id":"openstack%2Fliberasurecode~master~Ib4c29fa56821ebd3b9472c5d379f449d31b5e104","project":"openstack/liberasurecode","branch":"master","topic":"maybe-uninitialized","attention_set":{},"removed_from_attention_set":{"15343":{"account":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"last_update":"2025-08-06 01:58:35.000000000","reason":"Change was submitted"},"7233":{"account":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"last_update":"2025-08-06 01:32:35.000000000","reason":"\u003cGERRIT_ACCOUNT_7233\u003e replied on the change","reason_account":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}}},"hashtags":[],"change_id":"Ib4c29fa56821ebd3b9472c5d379f449d31b5e104","subject":"Make sure alg_sig_handle-\u003etbl1_l is defined","status":"MERGED","created":"2025-07-31 06:53:41.000000000","updated":"2025-08-06 01:58:35.000000000","submitted":"2025-08-06 01:58:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":13,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"956214-maybe-uninitialized","meta_rev_id":"c0b648a2ed22c74d0400d301fadf7697591ab7fd","_number":956214,"virtual_id_number":956214,"owner":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-08-06 01:58:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-08-05 07:32:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":1,"date":"2025-08-06 01:32:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-31 07:11:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-07-31 09:27:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-31 19:21:08.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"472c9caa024b1c3ede661b8ee53062325af1603d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2025-07-31 06:53:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5beadd0676024f82d80992968b43f6e0584d714a","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-31 07:11:42.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c21b60192a9347e2a5867083d0e24762\n\n- liberasurecode-unittests-arm64 https://zuul.opendev.org/t/openstack/build/6e86a461b73042558aef2f6736311276 : SUCCESS in 15m 24s","accounts_in_message":[],"_revision_number":1},{"id":"261261abb5ed69d195ef3cf55b207eaaba8fed22","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-31 09:27:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b9c28f5b2f8a477ba9517a012e51dddc\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/4603569a83824acfa229357fcc61a77e : SUCCESS in 7m 33s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/e833f211c1ed44368b5dd4931e43b31f : SUCCESS in 8m 23s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/fe7313a0e5b24fb1b06196f3fc95846a : SUCCESS in 20m 00s","accounts_in_message":[],"_revision_number":1},{"id":"f8ab93d0aa9e212b37ce0c1ce162eda9fb6baeea","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2025-07-31 19:21:08.000000000","message":"Patch Set 1: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"911dc01e716a1b4afb60edf6e6bc635c15bb4af6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2025-08-01 05:19:21.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"9353704e31fad255e299e412549d29e8e99b42fd","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-01 05:34:41.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/55e81cbb3c534d718b4e2e9aef472161\n\n- liberasurecode-unittests-arm64 https://zuul.opendev.org/t/openstack/build/82fbf7b1cc1b415c96617667d2b58a5a : SUCCESS in 13m 24s","accounts_in_message":[],"_revision_number":2},{"id":"10d6015d0776b0b6f498c9384bfdff530fa10c19","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-01 05:36:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a113fc2d74334d039e2e2dc4c537e846\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/d2cb51e4862643baa0ab909fe4ec9288 : SUCCESS in 15m 51s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/0873b9dca1014ad2becdcabc75b17350 : SUCCESS in 8m 05s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/f25f76c81e3d468a91c330d2737d362a : SUCCESS in 9m 11s","accounts_in_message":[],"_revision_number":2},{"id":"3ef6589e82552d414b5e44d487d5118657936646","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2025-08-01 06:04:59.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1b9215260327124fc4af5204b788cfa55bb265ca","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2025-08-05 06:38:45.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7ea2a2454b5278916c8ea561fdc828213492a18d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2025-08-05 06:39:00.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"61ee561f16b3fa7db8a218e9f6145531087b974c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-05 07:17:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c6d665de094f4d3686b8f4e740a311f5\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/2a0790afc4204d33a9ce864d251278a3 : SUCCESS in 16m 39s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/734c5d6d0a034272a6db551c073385b4 : SUCCESS in 16m 51s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/429c37b8db1e462abf9f4bfabe93fcf2 : SUCCESS in 19m 39s","accounts_in_message":[],"_revision_number":3},{"id":"60e5c7b74a141a1c25efc8e986231f1166f5f716","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2025-08-05 07:30:48.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":4},{"id":"d3a6c35beee3b15cb4fd46da54c97db84f947a07","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2025-08-05 07:32:02.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"132fa417339584fe6a563a651c3acb3ae8768c18","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-05 07:50:27.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fa8361ea0c0d40d29358cfb1de833a46\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/f89259eef5c343d1a7298569379b1278 : SUCCESS in 14m 19s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/3b467815227246da8b1552c2becf8a21 : SUCCESS in 8m 56s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/bc4776de0f1042239c0adde2207fe991 : SUCCESS in 18m 28s","accounts_in_message":[],"_revision_number":4},{"id":"f4781094541bec218d39164b6f37bafb5ff28826","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-05 08:01:32.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/141168821e99407aa54bb80e9c680960\n\n- liberasurecode-unittests-arm64 https://zuul.opendev.org/t/openstack/build/a7f20ff6aabd4355b4623a8bda15351d : SUCCESS in 12m 27s","accounts_in_message":[],"_revision_number":4},{"id":"8e343e4ad05d020ad1a549ea87cac9ff2708c2f7","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2025-08-06 01:32:35.000000000","message":"Patch Set 4: Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9e48da42250e0e39ddc17fd5d95cd7bd5dc87da7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-06 01:32:42.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"604443de13789f5e0c3382742a1c509e47e47017","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-06 01:58:34.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f4dda1be4174474580f6bc6f9c8e0d91\n\n- liberasurecode-unittests https://zuul.opendev.org/t/openstack/build/a35fa809387b4650ba051ade87407503 : SUCCESS in 17m 22s\n- liberasurecode-unittests-centos-9-stream https://zuul.opendev.org/t/openstack/build/adf5a69a8b5d4174a5b3391d9b2afecd : SUCCESS in 9m 43s\n- liberasurecode-unittests-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/0ba6cf0a51ea45d9b8b5e466fbce56b4 : SUCCESS in 11m 15s","accounts_in_message":[],"_revision_number":4},{"id":"c0b648a2ed22c74d0400d301fadf7697591ab7fd","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-08-06 01:58:35.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"548847e77e37be6339314840bbad7f7e9a3e4ffa","revisions":{"480f0fab5e41ff7d773078e0902bd5efda826e36":{"kind":"REWORK","_number":1,"created":"2025-07-31 06:53:41.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/14/956214/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/14/956214/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/1"}}},"commit":{"parents":[{"commit":"303e1466cf29659f8898bc8de3c7a7ea9deb6c43","subject":"Merge \"Mark a bunch of things internal\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/303e1466cf29659f8898bc8de3c7a7ea9deb6c43"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-07-31 06:44:51.000000000","tz":600},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-07-31 06:53:26.000000000","tz":600},"subject":"Make sure alg_sig_handle-\u003etbl1_l is defined","message":"Make sure alg_sig_handle-\u003etbl1_l is defined\n\nOn a newer GCC that runs with `-Werror\u003dmaybe-uninitialized`\nliberasurecode can not be built because there isn\u0027t a guard around the\nintialisation of table 1 (tbl1_l) in alg_sig_handle which causes:\n\n  In function \u0027init_alg_sig_w16\u0027,\n       inlined from \u0027init_alg_sig\u0027 at utils/chksum/alg_sig.c:242:12:\n   utils/chksum/alg_sig.c:201:21: error: \u0027*alg_sig_handle.tbl1_l\u0027 may be used uninitialized [-Werror\u003dmaybe-uninitialized]\n    201 |       alg_sig_handle-\u003etbl1_l[i] \u003d alg_sig_handle-\u003emult_routines.galois_single_multiply((unsigned short) (i \u003c\u003c 8), alpha, w);\n        |       ~~~~~~~~~~~~~~^~~~~~~~\n    cc1: all warnings being treated as errors\n    make[2]: *** [Makefile:734: utils/chksum/liberasurecode_la-alg_sig.lo]\n    Error 1\n\nThis patch wraps wraps the missing if statement guard around it, so it\u0027s only\never initialised when used.\n\nChange-Id: Ib4c29fa56821ebd3b9472c5d379f449d31b5e104\nSigned-off-by: Matthew Oliver \u003cmatt@oliver.net.au\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/480f0fab5e41ff7d773078e0902bd5efda826e36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/480f0fab5e41ff7d773078e0902bd5efda826e36"}]},"branch":"refs/heads/master"},"e111a5e7837436fcb1984341c0b3cf53998df38a":{"kind":"REWORK","_number":2,"created":"2025-08-01 05:19:21.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/14/956214/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/14/956214/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/2"}}},"commit":{"parents":[{"commit":"303e1466cf29659f8898bc8de3c7a7ea9deb6c43","subject":"Merge \"Mark a bunch of things internal\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/303e1466cf29659f8898bc8de3c7a7ea9deb6c43"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-07-31 06:44:51.000000000","tz":600},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-08-01 05:18:26.000000000","tz":600},"subject":"Make sure alg_sig_handle-\u003etbl1_l is defined","message":"Make sure alg_sig_handle-\u003etbl1_l is defined\n\nOn a newer GCC that runs with `-Werror\u003dmaybe-uninitialized`\nliberasurecode can not be built because there isn\u0027t a guard around the\nintialisation of table 1 (tbl1_l) in alg_sig_handle which causes:\n\n  In function \u0027init_alg_sig_w16\u0027,\n       inlined from \u0027init_alg_sig\u0027 at utils/chksum/alg_sig.c:242:12:\n   utils/chksum/alg_sig.c:201:21: error: \u0027*alg_sig_handle.tbl1_l\u0027 may be used uninitialized [-Werror\u003dmaybe-uninitialized]\n    201 |       alg_sig_handle-\u003etbl1_l[i] \u003d alg_sig_handle-\u003emult_routines.galois_single_multiply((unsigned short) (i \u003c\u003c 8), alpha, w);\n        |       ~~~~~~~~~~~~~~^~~~~~~~\n    cc1: all warnings being treated as errors\n    make[2]: *** [Makefile:734: utils/chksum/liberasurecode_la-alg_sig.lo]\n    Error 1\n\nThis patch wraps wraps the missing if statement guard around it, so it\u0027s only\never initialised when used.\n\nDrive by check that initialization with malloc was actually successful.\n\nChange-Id: Ib4c29fa56821ebd3b9472c5d379f449d31b5e104\nSigned-off-by: Matthew Oliver \u003cmatt@oliver.net.au\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/e111a5e7837436fcb1984341c0b3cf53998df38a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/e111a5e7837436fcb1984341c0b3cf53998df38a"}]},"branch":"refs/heads/master"},"a2836c3c59cfea4710109231724a7a7b5db85f3b":{"kind":"REWORK","_number":3,"created":"2025-08-05 06:39:00.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/14/956214/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/14/956214/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/3"}}},"commit":{"parents":[{"commit":"303e1466cf29659f8898bc8de3c7a7ea9deb6c43","subject":"Merge \"Mark a bunch of things internal\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/303e1466cf29659f8898bc8de3c7a7ea9deb6c43"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-07-31 06:44:51.000000000","tz":600},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-08-05 06:36:54.000000000","tz":600},"subject":"Make sure alg_sig_handle-\u003etbl1_l is defined","message":"Make sure alg_sig_handle-\u003etbl1_l is defined\n\nOn a newer GCC that runs with `-Werror\u003dmaybe-uninitialized`\nliberasurecode can not be built because there isn\u0027t a guard around the\nintialisation of table 1 (tbl1_l) in alg_sig_handle which causes:\n\n  In function \u0027init_alg_sig_w16\u0027,\n       inlined from \u0027init_alg_sig\u0027 at utils/chksum/alg_sig.c:242:12:\n   utils/chksum/alg_sig.c:201:21: error: \u0027*alg_sig_handle.tbl1_l\u0027 may be used uninitialized [-Werror\u003dmaybe-uninitialized]\n    201 |       alg_sig_handle-\u003etbl1_l[i] \u003d alg_sig_handle-\u003emult_routines.galois_single_multiply((unsigned short) (i \u003c\u003c 8), alpha, w);\n        |       ~~~~~~~~~~~~~~^~~~~~~~\n    cc1: all warnings being treated as errors\n    make[2]: *** [Makefile:734: utils/chksum/liberasurecode_la-alg_sig.lo]\n    Error 1\n\nThis patch wraps wraps the missing if statement guard around it, so it\u0027s only\never initialised when used.\n\nDrive by check that initialization with malloc was actually successful.\n\nChange-Id: Ib4c29fa56821ebd3b9472c5d379f449d31b5e104\nSigned-off-by: Matthew Oliver \u003cmatt@oliver.net.au\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/a2836c3c59cfea4710109231724a7a7b5db85f3b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/a2836c3c59cfea4710109231724a7a7b5db85f3b"}]},"branch":"refs/heads/master"},"548847e77e37be6339314840bbad7f7e9a3e4ffa":{"kind":"REWORK","_number":4,"created":"2025-08-05 07:30:48.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/14/956214/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/liberasurecode","ref":"refs/changes/14/956214/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/liberasurecode refs/changes/14/956214/4"}}},"commit":{"parents":[{"commit":"303e1466cf29659f8898bc8de3c7a7ea9deb6c43","subject":"Merge \"Mark a bunch of things internal\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/303e1466cf29659f8898bc8de3c7a7ea9deb6c43"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2025-07-31 06:44:51.000000000","tz":600},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2025-08-05 07:30:46.000000000","tz":-420},"subject":"Make sure alg_sig_handle-\u003etbl1_l is defined","message":"Make sure alg_sig_handle-\u003etbl1_l is defined\n\nOn a newer GCC that runs with `-Werror\u003dmaybe-uninitialized`\nliberasurecode can not be built because there isn\u0027t a guard around the\nintialisation of table 1 (tbl1_l) in alg_sig_handle which causes:\n\n  In function \u0027init_alg_sig_w16\u0027,\n       inlined from \u0027init_alg_sig\u0027 at utils/chksum/alg_sig.c:242:12:\n   utils/chksum/alg_sig.c:201:21: error: \u0027*alg_sig_handle.tbl1_l\u0027 may be used uninitialized [-Werror\u003dmaybe-uninitialized]\n    201 |       alg_sig_handle-\u003etbl1_l[i] \u003d alg_sig_handle-\u003emult_routines.galois_single_multiply((unsigned short) (i \u003c\u003c 8), alpha, w);\n        |       ~~~~~~~~~~~~~~^~~~~~~~\n    cc1: all warnings being treated as errors\n    make[2]: *** [Makefile:734: utils/chksum/liberasurecode_la-alg_sig.lo]\n    Error 1\n\nThis patch wraps wraps the missing if statement guard around it, so it\u0027s only\never initialised when used.\n\nDrive by check that initialization with malloc was actually successful.\n\nChange-Id: Ib4c29fa56821ebd3b9472c5d379f449d31b5e104\nSigned-off-by: Matthew Oliver \u003cmatt@oliver.net.au\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/548847e77e37be6339314840bbad7f7e9a3e4ffa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/liberasurecode/commit/548847e77e37be6339314840bbad7f7e9a3e4ffa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}