)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"78fe5d21cd2626b84e9fcb9170db387089bc1efd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8d0f21a_8413158e","updated":"2025-10-21 16:08:13.000000000","message":"I think there may be more than one bug in this test. But it\u0027s definitely a step in the right direction!","commit_id":"f9fb7579f53ca13e6e89bd87413be5d608eb7bc6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"2bd8045f4a1b68426646e89a86ef0f5f80b8ecd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7cbc674c_c0a0363c","updated":"2025-10-26 02:20:20.000000000","message":"Thanks!","commit_id":"27d856ae7178731ea6a957b007b7aaaf0c36182e"}],"test/liberasurecode_test.c":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"78fe5d21cd2626b84e9fcb9170db387089bc1efd","unresolved":true,"context_lines":[{"line_number":1458,"context_line":"                                            struct ec_args *args)"},{"line_number":1459,"context_line":"{"},{"line_number":1460,"context_line":"    int i;"},{"line_number":1461,"context_line":"    int *skip \u003d create_skips_array(args,args-\u003ek);"},{"line_number":1462,"context_line":"    assert(skip !\u003d NULL);"},{"line_number":1463,"context_line":"    for (i \u003d args-\u003ek; i \u003c args-\u003ek + args-\u003em; i++)"},{"line_number":1464,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"58db135d_84e10acb","line":1461,"range":{"start_line":1461,"start_character":40,"end_line":1461,"end_character":47},"updated":"2025-10-21 16:08:13.000000000","message":"I wonder if we really meant to pass `args-\u003ek` here, or if it should have been `-1` like in `test_decode_with_missing_data`...","commit_id":"f9fb7579f53ca13e6e89bd87413be5d608eb7bc6"},{"author":{"_account_id":38169,"name":"Lhoussain AIT ASSOU","display_name":"aitassou","email":"lhoussain.ait-assou@ovhcloud.com","username":"aitassou"},"change_message_id":"d63e05328ebe68331dfa056b321dc78b43d216fb","unresolved":true,"context_lines":[{"line_number":1458,"context_line":"                                            struct ec_args *args)"},{"line_number":1459,"context_line":"{"},{"line_number":1460,"context_line":"    int i;"},{"line_number":1461,"context_line":"    int *skip \u003d create_skips_array(args,args-\u003ek);"},{"line_number":1462,"context_line":"    assert(skip !\u003d NULL);"},{"line_number":1463,"context_line":"    for (i \u003d args-\u003ek; i \u003c args-\u003ek + args-\u003em; i++)"},{"line_number":1464,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2109281f_3409deec","line":1461,"range":{"start_line":1461,"start_character":40,"end_line":1461,"end_character":47},"in_reply_to":"58db135d_84e10acb","updated":"2025-10-22 08:10:41.000000000","message":"sounds good,I will modify that also.","commit_id":"f9fb7579f53ca13e6e89bd87413be5d608eb7bc6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"78fe5d21cd2626b84e9fcb9170db387089bc1efd","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"    int i;"},{"line_number":1461,"context_line":"    int *skip \u003d create_skips_array(args,args-\u003ek);"},{"line_number":1462,"context_line":"    assert(skip !\u003d NULL);"},{"line_number":1463,"context_line":"    for (i \u003d args-\u003ek; i \u003c args-\u003ek + args-\u003em; i++)"},{"line_number":1464,"context_line":"    {"},{"line_number":1465,"context_line":"        skip[i] \u003d 1;"},{"line_number":1466,"context_line":"        encode_decode_test_impl(be_id, args, skip);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8d91969b_b4974777","line":1463,"updated":"2025-10-21 16:08:13.000000000","message":"Whoops! Yeah, I think there were only a handful of cases (with `4+8` schemes) where this loop would do *anything*, and it definitely didn\u0027t test *all* the parities. Good catch!","commit_id":"f9fb7579f53ca13e6e89bd87413be5d608eb7bc6"}]}
