)]}'
{"src/backends/isa-l/isa_l_rs_lrc.c":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b7ff9968e81f78c76dd8d9552213c189aedf3b5a","unresolved":true,"context_lines":[{"line_number":351,"context_line":"     * Unavailable: multiply corresponding coefficient with"},{"line_number":352,"context_line":"     * the row that corresponds to the missing data in inverse_rows"},{"line_number":353,"context_line":"     * and XOR the resulting row with this row."},{"line_number":354,"context_line":"     */"},{"line_number":355,"context_line":"    for (i \u003d k; i \u003c n; i++) {"},{"line_number":356,"context_line":"        // Parity is missing"},{"line_number":357,"context_line":"        if ((1 \u003c\u003c i) \u0026 (missing_bm)) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4418eac8_7f6b186f","line":354,"updated":"2026-02-20 18:47:54.000000000","message":"Man, I wish I had a better understanding of what\u0027s going on in here...","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":38169,"name":"Lhoussain AIT ASSOU","display_name":"aitassou","email":"lhoussain.ait-assou@ovhcloud.com","username":"aitassou"},"change_message_id":"7b508895be9c4dd3ec165a574e7a680d64acb8d1","unresolved":true,"context_lines":[{"line_number":351,"context_line":"     * Unavailable: multiply corresponding coefficient with"},{"line_number":352,"context_line":"     * the row that corresponds to the missing data in inverse_rows"},{"line_number":353,"context_line":"     * and XOR the resulting row with this row."},{"line_number":354,"context_line":"     */"},{"line_number":355,"context_line":"    for (i \u003d k; i \u003c n; i++) {"},{"line_number":356,"context_line":"        // Parity is missing"},{"line_number":357,"context_line":"        if ((1 \u003c\u003c i) \u0026 (missing_bm)) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cf28ff08_8e8378ff","line":354,"in_reply_to":"4418eac8_7f6b186f","updated":"2026-02-23 10:56:12.000000000","message":"I worked as expected this great!\nI just added a condition to combine parities in case of g+1 errors ( and no local parity missing).\nAnd this worked for some failing teste before  combing parities !!!\n\n(gdb) run\nStarting program: /home/laitasso/code/erasure/liberasurecode/test/.libs/liberasurecode_rs_isal_stress_test 10 15 5 3 2000\n\n\ntotal decoding errors 0\n[Inferior 1 (process 3379442)\n\nStarting program: /home/laitasso/code/erasure/liberasurecode/test/.libs/liberasurecode_rs_isal_stress_test 10 15 6 3 2000\ntotal decoding errors 0","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e3b85aaf27300974a13f25485027c0bcc32c9150","unresolved":true,"context_lines":[{"line_number":419,"context_line":"        for (int v \u003d 0; v \u003c local_parity; v++) {"},{"line_number":420,"context_line":"            int group_size \u003d local_group_size(k, local_parity, v);"},{"line_number":421,"context_line":"            for (int u \u003d group_offset; u \u003c group_offset + group_size; u++) {"},{"line_number":422,"context_line":"                decode_matrix[(i * k) + u] \u003d encode_matrix[(locate * k) + u];"},{"line_number":423,"context_line":"            }"},{"line_number":424,"context_line":"            group_offset +\u003d group_size;"},{"line_number":425,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f043245f_c822ef4f","line":422,"range":{"start_line":422,"start_character":60,"end_line":422,"end_character":66},"updated":"2026-02-20 21:41:43.000000000","message":"`locate + v`!","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b7ff9968e81f78c76dd8d9552213c189aedf3b5a","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        goto out;"},{"line_number":497,"context_line":"    }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    inverse_rows \u003d get_lrc_inverse_rows(k, m, 0, k, 0, decode_inverse, isa_l_desc-\u003ematrix, missing_bm, isa_l_desc-\u003egf_mul);"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    decoded_elements \u003d (unsigned char**)malloc(sizeof(unsigned char*)*num_missing_elements);"},{"line_number":502,"context_line":"    if (NULL \u003d\u003d decoded_elements) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"774a6f33_1202d791","line":499,"updated":"2026-02-20 18:47:54.000000000","message":"OK, I *think* this is the trouble? I went and inserted our combined global parity in `decode_inverse`, so it no longer lines up with `isa_l_desc-\u003ematrix` in `get_lrc_inverse_rows`...","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e3b85aaf27300974a13f25485027c0bcc32c9150","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        goto out;"},{"line_number":497,"context_line":"    }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    inverse_rows \u003d get_lrc_inverse_rows(k, m, 0, k, 0, decode_inverse, isa_l_desc-\u003ematrix, missing_bm, isa_l_desc-\u003egf_mul);"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    decoded_elements \u003d (unsigned char**)malloc(sizeof(unsigned char*)*num_missing_elements);"},{"line_number":502,"context_line":"    if (NULL \u003d\u003d decoded_elements) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d2d96286_aa971f8e","line":499,"in_reply_to":"774a6f33_1202d791","updated":"2026-02-20 21:41:43.000000000","message":"No, wait -- `get_lrc_inverse_rows` only futzes with parities if they\u0027re missing, and we only insert the combined parity if none of the remaining parities are missing...","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":38169,"name":"Lhoussain AIT ASSOU","display_name":"aitassou","email":"lhoussain.ait-assou@ovhcloud.com","username":"aitassou"},"change_message_id":"7b508895be9c4dd3ec165a574e7a680d64acb8d1","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        goto out;"},{"line_number":497,"context_line":"    }"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    inverse_rows \u003d get_lrc_inverse_rows(k, m, 0, k, 0, decode_inverse, isa_l_desc-\u003ematrix, missing_bm, isa_l_desc-\u003egf_mul);"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    decoded_elements \u003d (unsigned char**)malloc(sizeof(unsigned char*)*num_missing_elements);"},{"line_number":502,"context_line":"    if (NULL \u003d\u003d decoded_elements) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8c921584_59d500d2","line":499,"in_reply_to":"d2d96286_aa971f8e","updated":"2026-02-23 10:56:12.000000000","message":"Rgiht","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e3b85aaf27300974a13f25485027c0bcc32c9150","unresolved":true,"context_lines":[{"line_number":533,"context_line":"            goto out;"},{"line_number":534,"context_line":"        }"},{"line_number":535,"context_line":"        for (i \u003d n - local_parity; i \u003c n; i++) {"},{"line_number":536,"context_line":"            for (int x \u003d 0; x \u003c k; x++) {"},{"line_number":537,"context_line":"                combined_local_parities[x] ^\u003d parity[i - k][x];"},{"line_number":538,"context_line":"            }"},{"line_number":539,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"47a2b4df_5849e2cc","line":536,"range":{"start_line":536,"start_character":32,"end_line":536,"end_character":33},"updated":"2026-02-20 21:41:43.000000000","message":"`blocksize`!","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b7ff9968e81f78c76dd8d9552213c189aedf3b5a","unresolved":true,"context_lines":[{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    ret \u003d 0;"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"out:"},{"line_number":572,"context_line":"    free(g_tbls);"},{"line_number":573,"context_line":"    free(decode_matrix);"},{"line_number":574,"context_line":"    free(decode_inverse);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4b807e6b_a3f61a78","line":571,"updated":"2026-02-20 18:47:54.000000000","message":"Oh, right: missing a `free(combined_local_parities);` down in here.","commit_id":"5de769b2c6e324cfdbf718777a01afb765cea269"}]}